mongoose 6.3.1 → 6.3.4

package/lib/connection.js

@@ -1357,7 +1357,8 @@ Connection.prototype.optionsProvideAuthenticationData = function(options) {
  * that this connection uses to talk to MongoDB.
  *
  * #### Example:
- *     const conn = await mongoose.createConnection('mongodb://localhost:27017/test');
+ *     const conn = await mongoose.createConnection('mongodb://localhost:27017/test').
+ *       asPromise();
  *
  *     conn.getClient(); // MongoClient { ... }
  *

package/lib/document.js

@@ -53,6 +53,7 @@ const populateModelSymbol = require('./helpers/symbols').populateModelSymbol;
 const scopeSymbol = require('./helpers/symbols').scopeSymbol;
 const schemaMixedSymbol = require('./schema/symbols').schemaMixedSymbol;
 const parentPaths = require('./helpers/path/parentPaths');
+
 let DocumentArray;
 let MongooseArray;
 let Embedded;
@@ -1322,6 +1323,10 @@ Document.prototype.$set = function $set(path, val, type, options) {
 
   if (!schema) {
     this.$__set(pathToMark, path, options, constructing, parts, schema, val, priorVal);
+
+    if (pathType === 'nested' && val == null) {
+      cleanModifiedSubpaths(this, path);
+    }
     return this;
   }
 
@@ -1455,14 +1460,18 @@ Document.prototype.$set = function $set(path, val, type, options) {
   }
 
   if (shouldSet) {
-    const doc = this.$isSubdocument ? this.ownerDocument() : this;
-    const savedState = doc.$__.savedState;
-    const savedStatePath = this.$isSubdocument ? this.$__.fullPath + '.' + path : path;
-    if (savedState != null) {
-      const firstDot = savedStatePath.indexOf('.');
-      const topLevelPath = firstDot === -1 ? savedStatePath : savedStatePath.slice(0, firstDot);
-      if (!savedState.hasOwnProperty(topLevelPath)) {
-        savedState[topLevelPath] = utils.clone(doc.$__getValue(topLevelPath));
+    let savedState = null;
+    let savedStatePath = null;
+    if (!constructing) {
+      const doc = this.$isSubdocument ? this.ownerDocument() : this;
+      savedState = doc.$__.savedState;
+      savedStatePath = this.$isSubdocument ? this.$__.fullPath + '.' + path : path;
+      if (savedState != null) {
+        const firstDot = savedStatePath.indexOf('.');
+        const topLevelPath = firstDot === -1 ? savedStatePath : savedStatePath.slice(0, firstDot);
+        if (!savedState.hasOwnProperty(topLevelPath)) {
+          savedState[topLevelPath] = utils.clone(doc.$__getValue(topLevelPath));
+        }
       }
     }
 
@@ -1619,7 +1628,6 @@ Document.prototype.$__set = function(pathToMark, path, options, constructing, pa
 
   const shouldModify = this.$__shouldModify(pathToMark, path, options, constructing, parts,
     schema, val, priorVal);
-  const _this = this;
 
   if (shouldModify) {
     this.markModified(pathToMark);
@@ -1635,14 +1643,6 @@ Document.prototype.$__set = function(pathToMark, path, options, constructing, pa
           item && item.__parentArray && (item.__parentArray = val);
         });
       }
-
-      // Small hack for gh-1638: if we're overwriting the entire array, ignore
-      // paths that were modified before the array overwrite
-      this.$__.activePaths.forEach(function(modifiedPath) {
-        if (modifiedPath.startsWith(path + '.')) {
-          _this.$__.activePaths.ignore(modifiedPath);
-        }
-      });
     }
   } else if (Array.isArray(val) && Array.isArray(priorVal) && utils.isMongooseArray(val) && utils.isMongooseArray(priorVal)) {
     val[arrayAtomicsSymbol] = priorVal[arrayAtomicsSymbol];
@@ -1833,7 +1833,6 @@ Document.prototype.$__path = function(path) {
  */
 
 Document.prototype.markModified = function(path, scope) {
-  // console.log('MarkModified', path, new Error().stack);
   this.$__.activePaths.modify(path);
   if (scope != null && !this.$isSubdocument) {
     this.$__.pathsToScopes = this.$__pathsToScopes || {};
@@ -2525,9 +2524,11 @@ function _getPathsToValidate(doc) {
   // the children as well
   for (const path of paths) {
     const _pathType = doc.$__schema.path(path);
+    if (!_pathType) {
+      continue;
+    }
 
-    if (!_pathType ||
-        !_pathType.$isMongooseArray ||
+    if (!_pathType.$isMongooseArray ||
         // To avoid potential performance issues, skip doc arrays whose children
         // are not required. `getPositionalPathType()` may be slow, so avoid
         // it unless we have a case of #6364
@@ -2539,8 +2540,7 @@ function _getPathsToValidate(doc) {
 
     // gh-11380: optimization. If the array isn't a document array and there's no validators
     // on the array type, there's no need to run validation on the individual array elements.
-    if (_pathType &&
-        _pathType.$isMongooseArray &&
+    if (_pathType.$isMongooseArray &&
         !_pathType.$isMongooseDocumentArray && // Skip document arrays...
         !_pathType.$embeddedSchemaType.$isMongooseArray && // and arrays of arrays
         _pathType.$embeddedSchemaType.validators.length === 0) {
@@ -3132,48 +3132,48 @@ Document.prototype.$isValid = function(path) {
 
 Document.prototype.$__reset = function reset() {
   let _this = this;
-  DocumentArray || (DocumentArray = require('./types/DocumentArray'));
 
-  this.$__.activePaths
-    .map('init', 'modify', function(i) {
-      return _this.$__getValue(i);
-    })
-    .filter(function(val) {
-      return val && Array.isArray(val) && utils.isMongooseDocumentArray(val) && val.length;
-    })
-    .forEach(function(array) {
-      let i = array.length;
-      while (i--) {
-        const doc = array[i];
-        if (!doc) {
-          continue;
+  // Skip for subdocuments
+  const subdocs = this.$parent() === this ? this.$getAllSubdocs() : [];
+  const resetArrays = new Set();
+  for (const subdoc of subdocs) {
+    const fullPathWithIndexes = subdoc.$__fullPathWithIndexes();
+    if (this.isModified(fullPathWithIndexes) || isParentInit(fullPathWithIndexes)) {
+      subdoc.$__reset();
+      if (subdoc.$isDocumentArrayElement) {
+        if (!resetArrays.has(subdoc.parentArray())) {
+          const array = subdoc.parentArray();
+          // Mark path to array as init for gh-6818
+          this.$__.activePaths.init(fullPathWithIndexes.replace(/\.\d+$/, '').slice(-subdoc.$basePath - 1));
+          array[arrayAtomicsBackupSymbol] = array[arrayAtomicsSymbol];
+          array[arrayAtomicsSymbol] = {};
+
+          resetArrays.add(array);
+        }
+      } else {
+        if (subdoc.$parent() === this) {
+          this.$__.activePaths.init(subdoc.$basePath);
+        } else if (subdoc.$parent() != null && subdoc.$parent().$isSubdocument) {
+          // If map path underneath subdocument, may end up with a case where
+          // map path is modified but parent still needs to be reset. See gh-10295
+          subdoc.$parent().$__reset();
         }
-        doc.$__reset();
       }
+    }
+  }
 
-      _this.$__.activePaths.init(array.$path());
-
-      array[arrayAtomicsBackupSymbol] = array[arrayAtomicsSymbol];
-      array[arrayAtomicsSymbol] = {};
-    });
-
-  this.$__.activePaths.
-    map('init', 'modify', function(i) {
-      return _this.$__getValue(i);
-    }).
-    filter(function(val) {
-      return val && !Array.isArray(val) && val.$isSingleNested;
-    }).
-    forEach(function(doc) {
-      doc.$__reset();
-      if (doc.$parent() === _this) {
-        _this.$__.activePaths.init(doc.$basePath);
-      } else if (doc.$parent() != null && doc.$parent().$isSubdocument) {
-        // If map path underneath subdocument, may end up with a case where
-        // map path is modified but parent still needs to be reset. See gh-10295
-        doc.$parent().$__reset();
+  function isParentInit(path) {
+    path = path.indexOf('.') === -1 ? [path] : path.split('.');
+    let cur = '';
+    for (let i = 0; i < path.length; ++i) {
+      cur += (cur.length ? '.' : '') + path[i];
+      if (_this.$__.activePaths[cur] === 'init') {
+        return true;
       }
-    });
+    }
+
+    return false;
+  }
 
   // clear atomics
   this.$__dirty().forEach(function(dirt) {

package/lib/error/cast.js

@@ -142,7 +142,8 @@ function formatMessage(model, kind, stringValue, path, messageFormat, valueType,
     }
     if (reason != null &&
         typeof reason.constructor === 'function' &&
-        reason.constructor.name !== 'AssertionError') {
+        reason.constructor.name !== 'AssertionError' &&
+        reason.constructor.name !== 'Error') {
       ret += ' because of "' + reason.constructor.name + '"';
     }
     return ret;

package/lib/helpers/clone.js

@@ -118,6 +118,7 @@ module.exports = clone;
 
 function cloneObject(obj, options, isArrayChild) {
   const minimize = options && options.minimize;
+  const omitUndefined = options && options.omitUndefined;
   const ret = {};
   let hasKeys;
 
@@ -138,7 +139,7 @@ function cloneObject(obj, options, isArrayChild) {
     // Don't pass `isArrayChild` down
     const val = clone(obj[key], options, false);
 
-    if (minimize === false && typeof val === 'undefined') {
+    if ((minimize === false || omitUndefined) && typeof val === 'undefined') {
       delete ret[key];
     } else if (minimize !== true || (typeof val !== 'undefined')) {
       hasKeys || (hasKeys = true);

package/lib/helpers/common.js

@@ -80,14 +80,6 @@ function modifiedPaths(update, path, result) {
 
     const _path = path + key;
     result[_path] = true;
-    if (_path.indexOf('.') !== -1) {
-      const sp = _path.split('.');
-      let cur = sp[0];
-      for (let i = 1; i < sp.length; ++i) {
-        result[cur] = true;
-        cur += '.' + sp[i];
-      }
-    }
     if (!Buffer.isBuffer(val) && isMongooseObject(val)) {
       val = val.toObject({ transform: false, virtuals: false });
     }

package/lib/helpers/immediate.js

@@ -7,7 +7,9 @@
 
 'use strict';
 
-const nextTick = process.nextTick.bind(process);
+const nextTick = typeof process !== 'undefined' && typeof process.nextTick === 'function' ?
+  process.nextTick.bind(process) :
+  cb => setTimeout(cb, 0); // Fallback for browser build
 
 module.exports = function immediate(cb) {
   return nextTick(cb);

package/lib/helpers/isAsyncFunction.js

@@ -1,10 +1,22 @@
 'use strict';
 
-const asyncFunctionPrototype = Object.getPrototypeOf(async function() {});
+let asyncFunctionPrototype = null;
+// try/catch for Babel compatibility, because Babel preset-env requires
+// regenerator-runtime for async/await and we don't want to include that
+// for a simple check.
+try {
+  asyncFunctionPrototype = Object.getPrototypeOf(async function() {});
+} catch (err) {}
 
-module.exports = function isAsyncFunction(v) {
-  return (
-    typeof v === 'function' &&
-    Object.getPrototypeOf(v) === asyncFunctionPrototype
-  );
-};
+if (asyncFunctionPrototype == null) {
+  module.exports = function isAsyncFunction() {
+    return false;
+  };
+} else {
+  module.exports = function isAsyncFunction(v) {
+    return (
+      typeof v === 'function' &&
+      Object.getPrototypeOf(v) === asyncFunctionPrototype
+    );
+  };
+}

package/lib/helpers/model/castBulkWrite.js

@@ -27,6 +27,12 @@ module.exports = function castBulkWrite(originalModel, op, options) {
         doc.$session(options.session);
       }
       op['insertOne']['document'] = doc;
+
+      if (options.skipValidation || op['insertOne'].skipValidation) {
+        callback(null);
+        return;
+      }
+
       op['insertOne']['document'].$validate({ __noPromise: true }, function(error) {
         if (error) {
           return callback(error, null);
@@ -154,6 +160,12 @@ module.exports = function castBulkWrite(originalModel, op, options) {
       }
       op['replaceOne']['replacement'] = doc;
 
+      if (options.skipValidation || op['replaceOne'].skipValidation) {
+        op['replaceOne']['replacement'] = op['replaceOne']['replacement'].toBSON();
+        callback(null);
+        return;
+      }
+
       op['replaceOne']['replacement'].$validate({ __noPromise: true }, function(error) {
         if (error) {
           return callback(error, null);

package/lib/helpers/query/cast$expr.js

@@ -4,7 +4,7 @@ const CastError = require('../../error/cast');
 const StrictModeError = require('../../error/strict');
 const castNumber = require('../../cast/number');
 
-const booleanComparison = new Set(['$and', '$or', '$not']);
+const booleanComparison = new Set(['$and', '$or']);
 const comparisonOperator = new Set(['$cmp', '$eq', '$lt', '$lte', '$gt', '$gte']);
 const arithmeticOperatorArray = new Set([
   // avoid casting '$add' or '$subtract', because expressions can be either number or date,
@@ -66,6 +66,7 @@ const dateOperators = new Set([
   '$isoWeek',
   '$millisecond'
 ]);
+const expressionOperator = new Set(['$not']);
 
 module.exports = function cast$expr(val, schema, strictQuery) {
   if (typeof val !== 'object' || val === null) {
@@ -106,6 +107,8 @@ function _castExpression(val, schema, strictQuery) {
       val[key] = castArithmetic(val[key], schema, strictQuery);
     } else if (arithmeticOperatorNumber.has(key)) {
       val[key] = castNumberOperator(val[key], schema, strictQuery);
+    } else if (expressionOperator.has(key)) {
+      val[key] = _castExpression(val[key], schema, strictQuery);
     }
   }
 

package/lib/index.js

@@ -267,7 +267,7 @@ Mongoose.prototype.get = Mongoose.prototype.set;
  * @param {Number} [options.connectTimeoutMS=30000] How long the MongoDB driver will wait before killing a socket due to inactivity _during initial connection_. Defaults to 30000. This option is passed transparently to [Node.js' `socket#setTimeout()` function](https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback).
  * @param {Number} [options.socketTimeoutMS=30000] How long the MongoDB driver will wait before killing a socket due to inactivity _after initial connection_. A socket may be inactive because of either no activity or a long-running operation. This is set to `30000` by default, you should set this to 2-3x your longest running operation if you expect some of your database operations to run longer than 20 seconds. This option is passed to [Node.js `socket#setTimeout()` function](https://nodejs.org/api/net.html#net_socket_settimeout_timeout_callback) after the MongoDB driver successfully completes.
  * @param {Number} [options.family=0] Passed transparently to [Node.js' `dns.lookup()`](https://nodejs.org/api/dns.html#dns_dns_lookup_hostname_options_callback) function. May be either `0`, `4`, or `6`. `4` means use IPv4 only, `6` means use IPv6 only, `0` means try both.
- * @return {Connection} the created Connection object. Connections are not thenable, so you can not `await mongoose.createConnection()`. To await use mongoose.createConnection(uri).asPromise() instead.
+ * @return {Connection} the created Connection object. Connections are not thenable, so you can't do `await mongoose.createConnection()`. To await use mongoose.createConnection(uri).asPromise() instead.
  * @api public
  */
 

package/lib/internal.js

@@ -11,7 +11,6 @@ module.exports = exports = InternalCache;
 
 function InternalCache() {
   this.activePaths = new ActiveRoster();
-  this.strictMode = undefined;
 }
 
 InternalCache.prototype.fullPath = undefined;

package/lib/model.js

@@ -768,6 +768,7 @@ Model.prototype.$__delta = function() {
         transform: false,
         virtuals: false,
         getters: false,
+        omitUndefined: true,
         _isNested: true
       });
       operand(this, where, delta, data, value);
@@ -1067,7 +1068,9 @@ Model.prototype.$__deleteOne = Model.prototype.$__remove;
  *     doc.model('User').findById(id, callback);
  *
  * @param {String} name model name
+ * @method model
  * @api public
+ * @return {Model}
  */
 
 Model.prototype.model = function model(name) {
@@ -1083,7 +1086,9 @@ Model.prototype.model = function model(name) {
  *     doc.model('User').findById(id, callback);
  *
  * @param {String} name model name
+ * @method $model
  * @api public
+ * @return {Model}
  */
 
 Model.prototype.$model = function $model(name) {
@@ -1484,61 +1489,68 @@ Model.syncIndexes = function syncIndexes(options, callback) {
  * the result of this function would be the result of
  * Model.syncIndexes().
  *
- * @param {Object} options not used at all.
+ * @param {Object} [options]
  * @param {Function} callback optional callback
- * @returns {Promise} which containts an object, {toDrop, toCreate}, which
- * are indexes that would be dropped in mongodb and indexes that would be created in mongodb.
+ * @returns {Promise} which contains an object, {toDrop, toCreate}, which
+ * are indexes that would be dropped in MongoDB and indexes that would be created in MongoDB.
  */
 
 Model.diffIndexes = function diffIndexes(options, callback) {
+  if (typeof options === 'function') {
+    callback = options;
+    options = null;
+  }
   const toDrop = [];
   const toCreate = [];
   callback = this.$handleCallbackError(callback);
   return this.db.base._promiseOrCallback(callback, cb => {
     cb = this.$wrapCallback(cb);
-    this.listIndexes((err, indexes) => {
-      if (indexes === undefined) {
-        indexes = [];
+    this.listIndexes((err, dbIndexes) => {
+      if (dbIndexes === undefined) {
+        dbIndexes = [];
       }
-      const schemaIndexes = this.schema.indexes();
-      // Iterate through the indexes created in mongodb and
-      // compare against the indexes in the schema.
-      for (const index of indexes) {
+      dbIndexes = getRelatedDBIndexes(this, dbIndexes);
+      const schemaIndexes = getRelatedSchemaIndexes(this, this.schema.indexes());
+
+      for (const dbIndex of dbIndexes) {
         let found = false;
         // Never try to drop `_id` index, MongoDB server doesn't allow it
-        if (isDefaultIdIndex(index)) {
+        if (isDefaultIdIndex(dbIndex)) {
           continue;
         }
 
-        for (const schemaIndex of schemaIndexes) {
-          const key = schemaIndex[0];
-          const options = decorateDiscriminatorIndexOptions(this.schema, utils.clone(schemaIndex[1]));
-          if (isIndexEqual(key, options, index)) {
+        for (const [schemaIndexKeysObject, schemaIndexOptions] of schemaIndexes) {
+          const options = decorateDiscriminatorIndexOptions(this.schema, utils.clone(schemaIndexOptions));
+          applySchemaCollation(schemaIndexKeysObject, options, this.schema.options);
+
+          if (isIndexEqual(schemaIndexKeysObject, options, dbIndex)) {
             found = true;
           }
         }
 
         if (!found) {
-          toDrop.push(index.name);
+          toDrop.push(dbIndex.name);
         }
       }
       // Iterate through the indexes created on the schema and
       // compare against the indexes in mongodb.
-      for (const schemaIndex of schemaIndexes) {
-        let found = false;
-        const key = schemaIndex[0];
-        const options = decorateDiscriminatorIndexOptions(this.schema, utils.clone(schemaIndex[1]));
-        for (const index of indexes) {
-          if (isDefaultIdIndex(index)) {
-            continue;
+      if (!options || options.toCreate !== false) {
+        for (const schemaIndex of schemaIndexes) {
+          let found = false;
+          const key = schemaIndex[0];
+          const options = decorateDiscriminatorIndexOptions(this.schema, utils.clone(schemaIndex[1]));
+          for (const index of dbIndexes) {
+            if (isDefaultIdIndex(index)) {
+              continue;
+            }
+            if (isIndexEqual(key, options, index)) {
+              found = true;
+            }
           }
-          if (isIndexEqual(key, options, index)) {
-            found = true;
+          if (!found) {
+            toCreate.push(key);
           }
         }
-        if (!found) {
-          toCreate.push(key);
-        }
       }
       cb(null, { toDrop, toCreate });
     });
@@ -1564,36 +1576,12 @@ Model.cleanIndexes = function cleanIndexes(callback) {
   return this.db.base._promiseOrCallback(callback, cb => {
     const collection = this.$__collection;
 
-    this.listIndexes((err, dbIndexes) => {
+    this.diffIndexes({ toCreate: false }, (err, res) => {
       if (err != null) {
         return cb(err);
       }
 
-      dbIndexes = getRelatedDBIndexes(this, dbIndexes);
-      const schemaIndexes = getRelatedSchemaIndexes(this, this.schema.indexes());
-
-      const toDrop = [];
-
-      for (const dbIndex of dbIndexes) {
-        let found = false;
-        // Never try to drop `_id` index, MongoDB server doesn't allow it
-        if (isDefaultIdIndex(dbIndex)) {
-          continue;
-        }
-
-        for (const [schemaIndexKeysObject, schemaIndexOptions] of schemaIndexes) {
-          const options = decorateDiscriminatorIndexOptions(this.schema, utils.clone(schemaIndexOptions));
-          applySchemaCollation(schemaIndexKeysObject, options, this.schema.options);
-
-          if (isIndexEqual(schemaIndexKeysObject, options, dbIndex)) {
-            found = true;
-          }
-        }
-
-        if (!found) {
-          toDrop.push(dbIndex.name);
-        }
-      }
+      const toDrop = res.toDrop;
 
       if (toDrop.length === 0) {
         return cb(null, []);
@@ -3496,6 +3484,7 @@ function _setIsNew(doc, val) {
   const subdocs = doc.$getAllSubdocs();
   for (const subdoc of subdocs) {
     subdoc.$isNew = val;
+    subdoc.$emit('isNew', val);
   }
 }
 
@@ -3576,6 +3565,7 @@ function _setIsNew(doc, val) {
  * @param {String|number} [options.w=1] The [write concern](https://docs.mongodb.com/manual/reference/write-concern/). See [`Query#w()`](/docs/api.html#query_Query-w) for more information.
  * @param {number} [options.wtimeout=null] The [write concern timeout](https://docs.mongodb.com/manual/reference/write-concern/#wtimeout).
  * @param {Boolean} [options.j=true] If false, disable [journal acknowledgement](https://docs.mongodb.com/manual/reference/write-concern/#j-option)
+ * @param {Boolean} [options.skipValidation=false] Set to true to skip Mongoose schema validation on bulk write operations. Mongoose currently runs validation on `insertOne` and `replaceOne` operations by default.
  * @param {Boolean} [options.bypassDocumentValidation=false] If true, disable [MongoDB server-side schema validation](https://docs.mongodb.com/manual/core/schema-validation/) for all writes in this bulk.
  * @param {Boolean} [options.strict=null] Overwrites the [`strict` option](/docs/guide.html#strict) on schema. If false, allows filtering and writing fields not defined in the schema for all writes in this bulk.
  * @param {Function} [callback] callback `function(error, bulkWriteOpResult) {}`
@@ -4254,7 +4244,7 @@ Model.aggregate = function aggregate(pipeline, options, callback) {
  *     }
  *
  * @param {Object} obj
- * @param {Array} pathsToValidate
+ * @param {Array|String} pathsToValidate
  * @param {Object} [context]
  * @param {Function} [callback]
  * @return {Promise|undefined}
@@ -4273,7 +4263,7 @@ Model.validate = function validate(obj, pathsToValidate, context, callback) {
     let paths = Object.keys(schema.paths);
 
     if (pathsToValidate != null) {
-      const _pathsToValidate = new Set(pathsToValidate);
+      const _pathsToValidate = typeof pathsToValidate === 'string' ? new Set(pathsToValidate.split(' ')) : new Set(pathsToValidate);
       paths = paths.filter(p => {
         const pieces = p.split('.');
         let cur = pieces[0];
@@ -4569,9 +4559,9 @@ function populate(model, docs, options, callback) {
     }
     // If no models to populate but we have a nested populate,
     // keep trying, re: gh-8946
-    if (options.populate != null) {
-      const opts = utils.populate(options.populate).map(pop => Object.assign({}, pop, {
-        path: options.path + '.' + pop.path
+    if (populateOptions.populate != null) {
+      const opts = utils.populate(populateOptions.populate).map(pop => Object.assign({}, pop, {
+        path: populateOptions.path + '.' + pop.path
       }));
       return model.populate(docs, opts, callback);
     }

package/lib/query.js

@@ -53,6 +53,7 @@ const queryOptionMethods = new Set([
   'maxScan',
   'maxTimeMS',
   'maxscan',
+  'populate',
   'projection',
   'read',
   'select',
@@ -4609,7 +4610,10 @@ Query.prototype.transform = function(fn) {
  *     // Throws if no doc returned
  *     await Model.findOne({ foo: 'bar' }).orFail();
  *
- *     // Throws if no document was updated
+ *     // Throws if no document was updated. Note that `orFail()` will still
+ *     // throw if the only document that matches is `{ foo: 'bar', name: 'test' }`,
+ *     // because `orFail()` will throw if no document was _updated_, not
+ *     // if no document was _found_.
  *     await Model.updateOne({ foo: 'bar' }, { name: 'test' }).orFail();
  *
  *     // Throws "No docs found!" error if no docs match `{ foo: 'bar' }`
@@ -4976,7 +4980,7 @@ function castQuery(query) {
  * a response for each query has also been returned, the results are passed to
  * the callback.
  *
- * @param {Object|String} path either the path to populate or an object specifying all parameters
+ * @param {Object|String|Array<String>} path either the path(s) to populate or an object specifying all parameters
  * @param {Object|String} [select] Field selection for the population query
  * @param {Model} [model] The model you wish to use for population. If not specified, populate will look up the model by the name in the Schema's `ref` field.
  * @param {Object} [match] Conditions for the population query
@@ -5757,4 +5761,4 @@ Query.prototype.model;
  * Export
  */
 
-module.exports = Query;
+module.exports = Query;

package/lib/queryhelpers.js

@@ -226,7 +226,9 @@ exports.applyPaths = function applyPaths(fields, schema) {
     const addedPaths = [];
     schema.eachPath(function(path, type) {
       if (prefix) path = prefix + '.' + path;
-
+      if (type.$isSchemaMap || path.endsWith('.$*')) {
+        return;
+      }
       let addedPath = analyzePath(path, type);
       // arrays
       if (addedPath == null && !Array.isArray(type) && type.$isMongooseArray && !type.$isMongooseDocumentArray) {
@@ -248,7 +250,6 @@ exports.applyPaths = function applyPaths(fields, schema) {
         }
       }
     });
-
     stack.pop();
     return addedPaths;
   }

package/lib/schema/SubdocumentPath.js

@@ -60,25 +60,13 @@ function _createConstructor(schema, baseClass) {
   Subdocument || (Subdocument = require('../types/subdocument'));
 
   const _embedded = function SingleNested(value, path, parent) {
-    const _this = this;
-
     this.$__parent = parent;
     Subdocument.apply(this, arguments);
 
-    this.$session(this.ownerDocument().$session());
-
-    if (parent) {
-      parent.$on('save', function() {
-        _this.emit('save', _this);
-        _this.constructor.emit('save', _this);
-      });
-
-      parent.$on('isNew', function(val) {
-        _this.isNew = val;
-        _this.emit('isNew', val);
-        _this.constructor.emit('isNew', val);
-      });
+    if (parent == null) {
+      return;
     }
+    this.$session(parent.$session());
   };
 
   schema._preCompile();