mongoose 6.2.11 → 6.3.2

package/lib/model.js

@@ -1067,13 +1067,33 @@ Model.prototype.$__deleteOne = Model.prototype.$__remove;
  *     doc.model('User').findById(id, callback);
  *
  * @param {String} name model name
+ * @method model
  * @api public
+ * @return {Model}
  */
 
 Model.prototype.model = function model(name) {
   return this[modelDbSymbol].model(name);
 };
 
+/**
+ * Returns another Model instance.
+ *
+ * #### Example:
+ *
+ *     const doc = new Tank;
+ *     doc.model('User').findById(id, callback);
+ *
+ * @param {String} name model name
+ * @method $model
+ * @api public
+ * @return {Model}
+ */
+
+Model.prototype.$model = function $model(name) {
+  return this[modelDbSymbol].model(name);
+};
+
 /**
  * Returns a document with `_id` only if at least one document exists in the database that matches
  * the given `filter`, and `null` otherwise.
@@ -1362,23 +1382,27 @@ Model.createCollection = function createCollection(options, callback) {
   }
 
   const schemaCollation = this &&
-  this.schema &&
-  this.schema.options &&
-  this.schema.options.collation || null;
+    this.schema &&
+    this.schema.options &&
+    this.schema.options.collation;
   if (schemaCollation != null) {
     options = Object.assign({ collation: schemaCollation }, options);
   }
   const capped = this &&
-  this.schema &&
-  this.schema.options &&
-   this.schema.options.capped;
-  if (capped) {
-    options = Object.assign({ capped: true }, capped, options);
+    this.schema &&
+    this.schema.options &&
+    this.schema.options.capped;
+  if (capped != null) {
+    if (typeof capped === 'number') {
+      options = Object.assign({ capped: true, size: capped }, options);
+    } else if (typeof capped === 'object') {
+      options = Object.assign({ capped: true }, capped, options);
+    }
   }
   const timeseries = this &&
-  this.schema &&
-  this.schema.options &&
-  this.schema.options.timeseries;
+    this.schema &&
+    this.schema.options &&
+    this.schema.options.timeseries;
   if (timeseries != null) {
     options = Object.assign({ timeseries }, options);
     if (options.expireAfterSeconds != null) {
@@ -2148,14 +2172,7 @@ Model.find = function find(conditions, projection, options, callback) {
 
   const mq = new this.Query({}, {}, this, this.$__collection);
   mq.select(projection);
-
   mq.setOptions(options);
-  if (this.schema.discriminatorMapping &&
-      this.schema.discriminatorMapping.isRoot &&
-      mq.selectedInclusively()) {
-    // Need to select discriminator key because original schema doesn't have it
-    mq.select(this.schema.options.discriminatorKey);
-  }
 
   callback = this.$handleCallbackError(callback);
 
@@ -2261,11 +2278,6 @@ Model.findOne = function findOne(conditions, projection, options, callback) {
   const mq = new this.Query({}, {}, this, this.$__collection);
   mq.select(projection);
   mq.setOptions(options);
-  if (this.schema.discriminatorMapping &&
-      this.schema.discriminatorMapping.isRoot &&
-      mq.selectedInclusively()) {
-    mq.select(this.schema.options.discriminatorKey);
-  }
 
   callback = this.$handleCallbackError(callback);
   return mq.findOne(conditions, callback);
@@ -3488,6 +3500,7 @@ function _setIsNew(doc, val) {
   const subdocs = doc.$getAllSubdocs();
   for (const subdoc of subdocs) {
     subdoc.$isNew = val;
+    subdoc.$emit('isNew', val);
   }
 }
 
@@ -4212,7 +4225,6 @@ Model.aggregate = function aggregate(pipeline, options, callback) {
 
   const aggregate = new Aggregate(pipeline || []);
   aggregate.model(this);
-
   if (options != null) {
     aggregate.option(options);
   }
@@ -4247,7 +4259,7 @@ Model.aggregate = function aggregate(pipeline, options, callback) {
  *     }
  *
  * @param {Object} obj
- * @param {Array} pathsToValidate
+ * @param {Array|String} pathsToValidate
  * @param {Object} [context]
  * @param {Function} [callback]
  * @return {Promise|undefined}
@@ -4266,7 +4278,7 @@ Model.validate = function validate(obj, pathsToValidate, context, callback) {
     let paths = Object.keys(schema.paths);
 
     if (pathsToValidate != null) {
-      const _pathsToValidate = new Set(pathsToValidate);
+      const _pathsToValidate = typeof pathsToValidate === 'string' ? new Set(pathsToValidate.split(' ')) : new Set(pathsToValidate);
       paths = paths.filter(p => {
         const pieces = p.split('.');
         let cur = pieces[0];
@@ -4809,7 +4821,6 @@ Model.compile = function compile(name, schema, collectionName, connection, base)
     o[schema.options.versionKey] = Number;
     schema.add(o);
   }
-
   let model;
   if (typeof name === 'function' && name.prototype instanceof Model) {
     model = name;
@@ -4853,6 +4864,7 @@ Model.compile = function compile(name, schema, collectionName, connection, base)
   model.model = function model(name) {
     return this.db.model(name);
   };
+
   model.db = connection;
   model.prototype.db = connection;
   model.prototype[modelDbSymbol] = connection;

package/lib/query.js

@@ -12,7 +12,7 @@ const ObjectParameterError = require('./error/objectParameter');
 const QueryCursor = require('./cursor/QueryCursor');
 const ReadPreference = require('./driver').get().ReadPreference;
 const ValidationError = require('./error/validation');
-const applyGlobalMaxTimeMS = require('./helpers/query/applyGlobalMaxTimeMS');
+const { applyGlobalMaxTimeMS, applyGlobalDiskUse } = require('./helpers/query/applyGlobalOption');
 const applyWriteConcern = require('./helpers/schema/applyWriteConcern');
 const cast = require('./cast');
 const castArrayFilters = require('./helpers/update/castArrayFilters');
@@ -53,6 +53,7 @@ const queryOptionMethods = new Set([
   'maxScan',
   'maxTimeMS',
   'maxscan',
+  'populate',
   'projection',
   'read',
   'select',
@@ -2192,6 +2193,7 @@ function _castArrayFilters(query) {
  * @api private
  */
 Query.prototype._find = wrapThunk(function(callback) {
+
   this._castConditions();
 
   if (this.error() != null) {
@@ -2210,6 +2212,7 @@ Query.prototype._find = wrapThunk(function(callback) {
   const userProvidedFields = _this._userProvidedFields || {};
 
   applyGlobalMaxTimeMS(this.options, this.model);
+  applyGlobalDiskUse(this.options, this.model);
 
   // Separate options to pass down to `completeMany()` in case we need to
   // set a session on the document
@@ -2228,8 +2231,15 @@ Query.prototype._find = wrapThunk(function(callback) {
     if (this.options.explain) {
       return callback(null, docs);
     }
-
     if (!mongooseOptions.populate) {
+      const versionKey = _this.schema.options.versionKey;
+      if (mongooseOptions.lean && mongooseOptions.lean.versionKey === false && versionKey) {
+        docs.forEach((doc) => {
+          if (versionKey in doc) {
+            delete doc[versionKey];
+          }
+        });
+      }
       return mongooseOptions.lean ?
         callback(null, docs) :
         completeMany(_this.model, docs, fields, userProvidedFields, completeManyOptions, callback);
@@ -2411,6 +2421,12 @@ Query.prototype._completeOne = function(doc, res, callback) {
   }
 
   if (!mongooseOptions.populate) {
+    const versionKey = this.schema.options.versionKey;
+    if (mongooseOptions.lean && mongooseOptions.lean.versionKey === false && versionKey) {
+      if (versionKey in doc) {
+        delete doc[versionKey];
+      }
+    }
     return mongooseOptions.lean ?
       _completeOneLean(doc, res, options, callback) :
       completeOne(model, doc, res, options, projection, userProvidedFields,
@@ -2453,8 +2469,8 @@ Query.prototype._findOne = wrapThunk(function(callback) {
 
   this._applyPaths();
   this._fields = this._castFields(this._fields);
-
   applyGlobalMaxTimeMS(this.options, this.model);
+  applyGlobalDiskUse(this.options, this.model);
 
   // don't pass in the conditions because we already merged them in
   Query.base.findOne.call(this, {}, (err, doc) => {
@@ -2567,6 +2583,7 @@ Query.prototype._count = wrapThunk(function(callback) {
   }
 
   applyGlobalMaxTimeMS(this.options, this.model);
+  applyGlobalDiskUse(this.options, this.model);
 
   const conds = this._conditions;
   const options = this._optionsForExec();
@@ -2594,6 +2611,7 @@ Query.prototype._countDocuments = wrapThunk(function(callback) {
   }
 
   applyGlobalMaxTimeMS(this.options, this.model);
+  applyGlobalDiskUse(this.options, this.model);
 
   const conds = this._conditions;
   const options = this._optionsForExec();
@@ -2814,6 +2832,7 @@ Query.prototype.__distinct = wrapThunk(function __distinct(callback) {
   }
 
   applyGlobalMaxTimeMS(this.options, this.model);
+  applyGlobalDiskUse(this.options, this.model);
 
   const options = this._optionsForExec();
 
@@ -5739,4 +5758,4 @@ Query.prototype.model;
  * Export
  */
 
-module.exports = Query;
+module.exports = Query;

package/lib/queryhelpers.js

@@ -261,7 +261,17 @@ exports.applyPaths = function applyPaths(fields, schema) {
       delete fields[plusPath];
     }
 
-    if (typeof type.selected !== 'boolean') return;
+    if (typeof type.selected !== 'boolean') {
+      return;
+    }
+
+    // If set to 0, we're explicitly excluding the discriminator key. Can't do this for all fields,
+    // because we have tests that assert that using `-path` to exclude schema-level `select: true`
+    // fields counts as an exclusive projection. See gh-11546
+    if (exclude && type.selected && path === schema.options.discriminatorKey && fields[path] != null && !fields[path]) {
+      delete fields[path];
+      return;
+    }
 
     if (hasPlusPath) {
       // forced inclusion

package/lib/schema/SubdocumentPath.js

@@ -60,25 +60,13 @@ function _createConstructor(schema, baseClass) {
   Subdocument || (Subdocument = require('../types/subdocument'));
 
   const _embedded = function SingleNested(value, path, parent) {
-    const _this = this;
-
     this.$__parent = parent;
     Subdocument.apply(this, arguments);
 
-    this.$session(this.ownerDocument().$session());
-
-    if (parent) {
-      parent.$on('save', function() {
-        _this.emit('save', _this);
-        _this.constructor.emit('save', _this);
-      });
-
-      parent.$on('isNew', function(val) {
-        _this.isNew = val;
-        _this.emit('isNew', val);
-        _this.constructor.emit('isNew', val);
-      });
+    if (parent == null) {
+      return;
     }
+    this.$session(parent.$session());
   };
 
   schema._preCompile();

package/lib/schema/documentarray.js

@@ -13,7 +13,6 @@ const SchemaType = require('../schematype');
 const discriminator = require('../helpers/model/discriminator');
 const handleIdOption = require('../helpers/schema/handleIdOption');
 const handleSpreadDoc = require('../helpers/document/handleSpreadDoc');
-const util = require('util');
 const utils = require('../utils');
 const getConstructor = require('../helpers/discriminator/getConstructor');
 
@@ -114,10 +113,12 @@ function _createConstructor(schema, options, baseClass) {
   Subdocument || (Subdocument = require('../types/ArraySubdocument'));
 
   // compile an embedded document for this schema
-  function EmbeddedDocument() {
+  function EmbeddedDocument(_value, parentArray) {
     Subdocument.apply(this, arguments);
-
-    this.$session(this.ownerDocument().$session());
+    if (parentArray == null || parentArray.getArrayParent() == null) {
+      return;
+    }
+    this.$session(parentArray.getArrayParent().$session());
   }
 
   schema._preCompile();
@@ -394,7 +395,7 @@ DocumentArrayPath.prototype.cast = function(value, doc, init, prev, options) {
 
   if (!Array.isArray(value)) {
     if (!init && !DocumentArrayPath.options.castNonArrays) {
-      throw new CastError('DocumentArray', util.inspect(value), this.path, null, this);
+      throw new CastError('DocumentArray', value, this.path, null, this);
     }
     // gh-2442 mark whole array as modified if we're initializing a doc from
     // the db and the path isn't an array in the document
@@ -486,8 +487,7 @@ DocumentArrayPath.prototype.cast = function(value, doc, init, prev, options) {
             // see gh-746
             rawArray[i] = subdoc;
           } catch (error) {
-            const valueInErrorMessage = util.inspect(rawArray[i]);
-            throw new CastError('embedded', valueInErrorMessage,
+            throw new CastError('embedded', rawArray[i],
               value[arrayPathSymbol], error, this);
           }
         }

package/lib/schema/number.js

@@ -353,11 +353,7 @@ SchemaNumber.prototype.enum = function(values, message) {
  */
 
 SchemaNumber.prototype.cast = function(value, doc, init) {
-  if (SchemaType._isRef(this, value, doc, init)) {
-    if (typeof value === 'number') {
-      return value;
-    }
-
+  if (typeof value !== 'number' && SchemaType._isRef(this, value, doc, init)) {
     if (value == null || utils.isNonBuiltinObject(value)) {
       return this._castRef(value, doc, init);
     }

package/lib/schema/objectid.js

@@ -221,11 +221,9 @@ ObjectId.prototype.checkRequired = function checkRequired(value, doc) {
  */
 
 ObjectId.prototype.cast = function(value, doc, init) {
-  if (SchemaType._isRef(this, value, doc, init)) {
+  if (!(value instanceof oid) && SchemaType._isRef(this, value, doc, init)) {
     // wait! we may need to cast this to a document
-    if (value instanceof oid) {
-      return value;
-    } else if ((getConstructorName(value) || '').toLowerCase() === 'objectid') {
+    if ((getConstructorName(value) || '').toLowerCase() === 'objectid') {
       return new oid(value.toHexString());
     }
 

package/lib/schema/string.js

@@ -580,11 +580,7 @@ SchemaString.prototype.checkRequired = function checkRequired(value, doc) {
  */
 
 SchemaString.prototype.cast = function(value, doc, init) {
-  if (SchemaType._isRef(this, value, doc, init)) {
-    if (typeof value === 'string') {
-      return value;
-    }
-
+  if (typeof value !== 'string' && SchemaType._isRef(this, value, doc, init)) {
     return this._castRef(value, doc, init);
   }
 

package/lib/schema.js

@@ -22,6 +22,7 @@ const readPref = require('./driver').get().ReadPreference;
 const setupTimestamps = require('./helpers/timestamps/setupTimestamps');
 const utils = require('./utils');
 const validateRef = require('./helpers/populate/validateRef');
+const util = require('util');
 
 let MongooseTypes;
 
@@ -53,7 +54,7 @@ let id = 0;
  * - [autoCreate](/docs/guide.html#autoCreate): bool - defaults to null (which means use the connection's autoCreate option)
  * - [bufferCommands](/docs/guide.html#bufferCommands): bool - defaults to true
  * - [bufferTimeoutMS](/docs/guide.html#bufferTimeoutMS): number - defaults to 10000 (10 seconds). If `bufferCommands` is enabled, the amount of time Mongoose will wait for connectivity to be restablished before erroring out.
- * - [capped](/docs/guide.html#capped): bool - defaults to false
+ * - [capped](/docs/guide.html#capped): bool | number | object - defaults to false
  * - [collection](/docs/guide.html#collection): string - no default
  * - [discriminatorKey](/docs/guide.html#discriminatorKey): string - defaults to `__t`
  * - [id](/docs/guide.html#id): bool - defaults to true
@@ -370,6 +371,9 @@ Schema.prototype._clone = function _clone(Constructor) {
   if (this.discriminators != null) {
     s.discriminators = Object.assign({}, this.discriminators);
   }
+  if (this._applyDiscriminators != null) {
+    s._applyDiscriminators = Object.assign({}, this._applyDiscriminators);
+  }
 
   s.aliases = Object.assign({}, this.aliases);
 
@@ -469,6 +473,11 @@ Schema.prototype.defaultOptions = function(options) {
   return options;
 };
 
+Schema.prototype.discriminator = function(name, schema) {
+  this._applyDiscriminators = {};
+  this._applyDiscriminators[name] = schema;
+};
+
 /**
  * Adds key path / schema type pairs to this schema.
  *
@@ -510,7 +519,6 @@ Schema.prototype.add = function add(obj, prefix) {
 
   const keys = Object.keys(obj);
   const typeKey = this.options.typeKey;
-
   for (const key of keys) {
     const fullPath = prefix + key;
     const val = obj[key];
@@ -540,6 +548,25 @@ Schema.prototype.add = function add(obj, prefix) {
         this.nested[prefix.substring(0, prefix.length - 1)] = true;
       }
       this.path(prefix + key, val);
+      if (val[0] != null && !(val[0].instanceOfSchema) && utils.isPOJO(val[0].discriminators)) {
+        const schemaType = this.path(prefix + key);
+        for (const key in val[0].discriminators) {
+          schemaType.discriminator(key, val[0].discriminators[key]);
+        }
+      } else if (val[0] != null && val[0].instanceOfSchema && utils.isPOJO(val[0]._applyDiscriminators)) {
+        const applyDiscriminators = val[0]._applyDiscriminators || [];
+        const schemaType = this.path(prefix + key);
+        for (const disc in applyDiscriminators) {
+          schemaType.discriminator(disc, applyDiscriminators[disc]);
+        }
+      }
+      else if (val != null && val.instanceOfSchema && utils.isPOJO(val._applyDiscriminators)) {
+        const applyDiscriminators = val._applyDiscriminators || [];
+        const schemaType = this.path(prefix + key);
+        for (const disc in applyDiscriminators) {
+          schemaType.discriminator(disc, applyDiscriminators[disc]);
+        }
+      }
     } else if (Object.keys(val).length < 1) {
       // Special-case: {} always interpreted as Mixed path so leaf at this node
       if (prefix) {
@@ -569,6 +596,12 @@ Schema.prototype.add = function add(obj, prefix) {
           this.nested[prefix.substring(0, prefix.length - 1)] = true;
         }
         this.path(prefix + key, val);
+        if (val != null && !(val.instanceOfSchema) && utils.isPOJO(val.discriminators)) {
+          const schemaType = this.path(prefix + key);
+          for (const key in val.discriminators) {
+            schemaType.discriminator(key, val.discriminators[key]);
+          }
+        }
       }
     }
   }
@@ -579,6 +612,86 @@ Schema.prototype.add = function add(obj, prefix) {
   return this;
 };
 
+/**
+ * Remove an index by name or index specification.
+ *
+ * removeIndex only removes indexes from your schema object. Does **not** affect the indexes
+ * in MongoDB.
+ *
+ * ####Example:
+ *
+ *     const ToySchema = new Schema({ name: String, color: String, price: Number });
+ *
+ *     // Add a new index on { name, color }
+ *     ToySchema.index({ name: 1, color: 1 });
+ *
+ *     // Remove index on { name, color }
+ *     // Keep in mind that order matters! `removeIndex({ color: 1, name: 1 })` won't remove the index
+ *     ToySchema.removeIndex({ name: 1, color: 1 });
+ *
+ *     // Add an index with a custom name
+ *     ToySchema.index({ color: 1 }, { name: 'my custom index name' });
+ *     // Remove index by name
+ *     ToySchema.removeIndex('my custom index name');
+ *
+ * @param {Object|string} index name or index specification
+ * @return {Schema} the Schema instance
+ * @api public
+ */
+
+Schema.prototype.removeIndex = function removeIndex(index) {
+  if (arguments.length > 1) {
+    throw new Error('removeIndex() takes only 1 argument');
+  }
+
+  if (typeof index !== 'object' && typeof index !== 'string') {
+    throw new Error('removeIndex() may only take either an object or a string as an argument');
+  }
+
+  if (typeof index === 'object') {
+    for (let i = this._indexes.length - 1; i >= 0; --i) {
+      if (util.isDeepStrictEqual(this._indexes[i][0], index)) {
+        this._indexes.splice(i, 1);
+      }
+    }
+  } else {
+    for (let i = this._indexes.length - 1; i >= 0; --i) {
+      if (this._indexes[i][1] != null && this._indexes[i][1].name === index) {
+        this._indexes.splice(i, 1);
+      }
+    }
+  }
+
+  return this;
+};
+
+/**
+ * Remove all indexes from this schema.
+ *
+ * clearIndexes only removes indexes from your schema object. Does **not** affect the indexes
+ * in MongoDB.
+ *
+ * ####Example:
+ *
+ *     const ToySchema = new Schema({ name: String, color: String, price: Number });
+ *     ToySchema.index({ name: 1 });
+ *     ToySchema.index({ color: 1 });
+ *
+ *     // Remove all indexes on this schema
+ *     ToySchema.clearIndexes();
+ *
+ *     ToySchema.indexes(); // []
+ *
+ * @return {Schema} the Schema instance
+ * @api public
+ */
+
+Schema.prototype.clearIndexes = function clearIndexes() {
+  this._indexes.length = 0;
+
+  return this;
+};
+
 /**
  * Reserved document keys.
  *

package/lib/schematype.js

@@ -1148,7 +1148,7 @@ SchemaType.prototype.getDefault = function(scope, init) {
  * @api private
  */
 
-SchemaType.prototype._applySetters = function(value, scope, init, priorVal) {
+SchemaType.prototype._applySetters = function(value, scope, init, priorVal, options) {
   let v = value;
   if (init) {
     return v;
@@ -1156,7 +1156,7 @@ SchemaType.prototype._applySetters = function(value, scope, init, priorVal) {
   const setters = this.setters;
 
   for (let i = setters.length - 1; i >= 0; i--) {
-    v = setters[i].call(scope, v, priorVal, this);
+    v = setters[i].call(scope, v, priorVal, this, options);
   }
 
   return v;

package/lib/types/DocumentArray/methods/index.js

@@ -22,6 +22,14 @@ const methods = {
     return this.toObject(internalToObjectOptions);
   },
 
+  /*!
+   * ignore
+   */
+
+  getArrayParent() {
+    return this[arrayParentSymbol];
+  },
+
   /**
    * Overrides MongooseArray#cast
    *
@@ -311,8 +319,8 @@ const methods = {
       return this;
     }
     const value = methods._cast.call(this, val, i);
-    arr[i] = value;
     methods._markModified.call(this, i);
+    arr[i] = value;
     return this;
   },
 

package/lib/types/array/methods/index.js

@@ -414,9 +414,9 @@ const methods = {
       }
 
       if (!found) {
+        this._markModified();
         rawArray.push(v);
         this._registerAtomic('$addToSet', v);
-        this._markModified();
         [].push.call(added, v);
       }
     }, this);
@@ -510,9 +510,9 @@ const methods = {
 
   nonAtomicPush() {
     const values = [].map.call(arguments, this._mapCast, this);
+    this._markModified();
     const ret = [].push.apply(this, values);
     this._registerAtomic('$set', this);
-    this._markModified();
     return ret;
   },
 
@@ -530,9 +530,9 @@ const methods = {
    */
 
   pop() {
+    this._markModified();
     const ret = [].pop.call(this);
     this._registerAtomic('$set', this);
-    this._markModified();
     return ret;
   },
 
@@ -572,6 +572,7 @@ const methods = {
     const cur = this[arrayParentSymbol].get(this[arrayPathSymbol]);
     let i = cur.length;
     let mem;
+    this._markModified();
 
     while (i--) {
       mem = cur[i];
@@ -595,7 +596,6 @@ const methods = {
       this._registerAtomic('$pullAll', values);
     }
 
-    this._markModified();
 
     // Might have modified child paths and then pulled, like
     // `doc.children[1].name = 'test';` followed by
@@ -657,7 +657,7 @@ const methods = {
       undefined, { skipDocumentArrayCast: true });
     let ret;
     const atomics = this[arrayAtomicsSymbol];
-
+    this._markModified();
     if (isOverwrite) {
       atomic.$each = values;
 
@@ -684,7 +684,6 @@ const methods = {
     }
 
     this._registerAtomic('$push', atomic);
-    this._markModified();
     return ret;
   },
 
@@ -737,8 +736,8 @@ const methods = {
       return this;
     }
     const value = methods._cast.call(this, val, i);
-    arr[i] = value;
     methods._markModified.call(this, i);
+    arr[i] = value;
     return this;
   },
 
@@ -763,9 +762,9 @@ const methods = {
 
   shift() {
     const arr = utils.isMongooseArray(this) ? this.__array : this;
+    this._markModified();
     const ret = [].shift.call(arr);
     this._registerAtomic('$set', this);
-    this._markModified();
     return ret;
   },
 
@@ -890,9 +889,9 @@ const methods = {
     }
 
     const arr = utils.isMongooseArray(this) ? this.__array : this;
+    this._markModified();
     [].unshift.apply(arr, values);
     this._registerAtomic('$set', this);
-    this._markModified();
     return this.length;
   }
 };