mongoose 6.1.8 → 6.2.1

package/lib/helpers/update/applyTimestampsToChildren.js

@@ -153,7 +153,7 @@ function applyTimestampsToUpdateKey(schema, key, update, now) {
         // Single nested is easy
         update[parentPath + '.' + updatedAt] = now;
       } else if (parentSchemaType.$isMongooseDocumentArray) {
-        let childPath = key.substr(parentPath.length + 1);
+        let childPath = key.substring(parentPath.length + 1);
 
         if (/^\d+$/.test(childPath)) {
           update[parentPath + '.' + childPath][updatedAt] = now;
@@ -161,7 +161,7 @@ function applyTimestampsToUpdateKey(schema, key, update, now) {
         }
 
         const firstDot = childPath.indexOf('.');
-        childPath = firstDot !== -1 ? childPath.substr(0, firstDot) : childPath;
+        childPath = firstDot !== -1 ? childPath.substring(0, firstDot) : childPath;
 
         update[parentPath + '.' + childPath + '.' + updatedAt] = now;
       }

package/lib/helpers/update/castArrayFilters.js

@@ -51,7 +51,7 @@ function _castArrayFilters(arrayFilters, schema, strictQuery, updatedPathsByFilt
       const dot = key.indexOf('.');
       let filterPath = dot === -1 ?
         updatedPathsByFilter[key] + '.0' :
-        updatedPathsByFilter[key.substr(0, dot)] + '.0' + key.substr(dot);
+        updatedPathsByFilter[key.substring(0, dot)] + '.0' + key.substring(dot);
       if (filterPath == null) {
         throw new Error(`Filter path not found for ${key}`);
       }

package/lib/helpers/update/updatedPathsByArrayFilter.js

@@ -19,7 +19,7 @@ module.exports = function updatedPathsByArrayFilter(update) {
         throw new Error(`Path '${path}' contains the same array filter multiple times`);
       }
       cur[match.substring(2, match.length - 1)] = path.
-        substr(0, firstMatch - 1).
+        substring(0, firstMatch - 1).
         replace(/\$\[[^\]]+\]/g, '0');
     }
     return cur;

package/lib/index.js

@@ -947,55 +947,31 @@ Mongoose.prototype.ObjectId = SchemaTypes.ObjectId;
  *
  *     mongoose.isValidObjectId(new mongoose.Types.ObjectId()); // true
  *     mongoose.isValidObjectId('0123456789ab'); // true
- *     mongoose.isValidObjectId(6); // false
+ *     mongoose.isValidObjectId(6); // true
+ *     mongoose.isValidObjectId({ test: 42 }); // false
  *
  * @method isValidObjectId
+ * @param {Any} value
+ * @returns {boolean} true if it is a valid ObjectId
  * @api public
  */
 
 Mongoose.prototype.isValidObjectId = function(v) {
-  if (v == null) {
-    return true;
-  }
-  const base = this || mongoose;
-  const ObjectId = base.driver.get().ObjectId;
-  if (v instanceof ObjectId) {
-    return true;
-  }
-
-  if (v._id != null) {
-    if (v._id instanceof ObjectId) {
-      return true;
-    }
-    if (v._id.toString instanceof Function) {
-      v = v._id.toString();
-      if (typeof v === 'string' && v.length === 12) {
-        return true;
-      }
-      if (typeof v === 'string' && /^[0-9A-Fa-f]{24}$/.test(v)) {
-        return true;
-      }
-      return false;
-    }
-  }
-
-  if (v.toString instanceof Function) {
-    v = v.toString();
-  }
-
-  if (typeof v === 'string' && v.length === 12) {
-    return true;
-  }
-  if (typeof v === 'string' && /^[0-9A-Fa-f]{24}$/.test(v)) {
-    return true;
-  }
-
-  return false;
+  const _mongoose = this instanceof Mongoose ? this : mongoose;
+  return _mongoose.Types.ObjectId.isValid(v);
 };
 
-Mongoose.prototype.syncIndexes = function() {
+/**
+ *
+ * Syncs all the indexes for the models registered with this connection.
+ *
+ * @param {Object} options
+ * @param {Boolean} options.continueOnError `false` by default. If set to `true`, mongoose will not throw an error if one model syncing failed, and will return an object where the keys are the names of the models, and the values are the results/errors for each model.
+ * @returns
+ */
+Mongoose.prototype.syncIndexes = function(options) {
   const _mongoose = this instanceof Mongoose ? this : mongoose;
-  return _mongoose.connection.syncIndexes();
+  return _mongoose.connection.syncIndexes(options);
 };
 
 /**

package/lib/internal.js

@@ -10,7 +10,7 @@ const ActiveRoster = StateMachine.ctor('require', 'modify', 'init', 'default', '
 module.exports = exports = InternalCache;
 
 function InternalCache() {
-  this.activePaths = new ActiveRoster;
+  this.activePaths = new ActiveRoster();
   this.strictMode = undefined;
 }
 

package/lib/model.js

@@ -48,6 +48,7 @@ const modifiedPaths = require('./helpers/update/modifiedPaths');
 const parallelLimit = require('./helpers/parallelLimit');
 const prepareDiscriminatorPipeline = require('./helpers/aggregate/prepareDiscriminatorPipeline');
 const removeDeselectedForeignField = require('./helpers/populate/removeDeselectedForeignField');
+const setDottedPath = require('./helpers/path/setDottedPath');
 const util = require('util');
 const utils = require('./utils');
 
@@ -379,7 +380,12 @@ Model.prototype.$__save = function(options, callback) {
       });
     }
     let numAffected = 0;
-    if (get(options, 'safe.w') !== 0 && get(options, 'w') !== 0) {
+    const writeConcern = options != null ?
+      options.writeConcern != null ?
+        options.writeConcern.w :
+        options.w :
+      0;
+    if (writeConcern !== 0) {
       // Skip checking if write succeeded if writeConcern is set to
       // unacknowledged writes, because otherwise `numAffected` will always be 0
       if (result != null) {
@@ -391,8 +397,10 @@ Model.prototype.$__save = function(options, callback) {
           numAffected = result;
         }
       }
+
+      const versionBump = this.$__.version || this.$__schema.options.optimisticConcurrency;
       // was this an update that required a version bump?
-      if (this.$__.version && !this.$__.inserting) {
+      if (versionBump && !this.$__.inserting) {
         const doIncrement = VERSION_INC === (VERSION_INC & this.$__.version);
         this.$__.version = undefined;
         const key = this.$__schema.options.versionKey;
@@ -740,7 +748,7 @@ Model.prototype.$__delta = function() {
       operand(this, where, delta, data, 1, '$unset');
     } else if (value === null) {
       operand(this, where, delta, data, null);
-    } else if (value.isMongooseArray && value.$path() && value[arrayAtomicsSymbol]) {
+    } else if (utils.isMongooseArray(value) && value.$path() && value[arrayAtomicsSymbol]) {
       // arrays and other custom types (support plugins etc)
       handleAtomics(this, where, delta, data, value);
     } else if (value[MongooseBuffer.pathSymbol] && Buffer.isBuffer(value)) {
@@ -792,7 +800,7 @@ function checkDivergentArray(doc, path, array) {
     }
   }
 
-  if (!(pop && array && array.isMongooseArray)) return;
+  if (!(pop && utils.isMongooseArray(array))) return;
 
   // If the array was populated using options that prevented all
   // documents from being returned (match, skip, limit) or they
@@ -832,7 +840,8 @@ Model.prototype.$__version = function(where, delta) {
   if (where === true) {
     // this is an insert
     if (key) {
-      this.$__setValue(key, delta[key] = 0);
+      setDottedPath(delta, key, 0);
+      this.$__setValue(key, 0);
     }
     return;
   }
@@ -1059,8 +1068,8 @@ Model.prototype.model = function model(name) {
 };
 
 /**
- * Returns true if at least one document exists in the database that matches
- * the given `filter`, and false otherwise.
+ * Returns a document with `_id` only if at least one document exists in the database that matches
+ * the given `filter`, and `null` otherwise.
  *
  * Under the hood, `MyModel.exists({ answer: 42 })` is equivalent to
  * `MyModel.findOne({ answer: 42 }).select({ _id: 1 }).lean()`
@@ -1097,10 +1106,6 @@ Model.exists = function exists(filter, options, callback) {
   if (typeof callback === 'function') {
     return query.exec(callback);
   }
-  options = options || {};
-  if (!options.explain) {
-    return query.then(doc => !!doc);
-  }
 
   return query;
 };
@@ -1136,11 +1141,13 @@ Model.exists = function exists(filter, options, callback) {
  * @param {Object|String} [options] If string, same as `options.value`.
  * @param {String} [options.value] the string stored in the `discriminatorKey` property. If not specified, Mongoose uses the `name` parameter.
  * @param {Boolean} [options.clone=true] By default, `discriminator()` clones the given `schema`. Set to `false` to skip cloning.
+ * @param {Boolean} [options.overwriteModels=false] by default, Mongoose does not allow you to define a discriminator with the same name as another discriminator. Set this to allow overwriting discriminators with the same name.
  * @return {Model} The newly created discriminator model
  * @api public
  */
 
 Model.discriminator = function(name, schema, options) {
+
   let model;
   if (typeof name === 'function') {
     model = name;
@@ -1164,7 +1171,7 @@ Model.discriminator = function(name, schema, options) {
   }
 
   schema = discriminator(this, name, schema, value, true);
-  if (this.db.models[name]) {
+  if (this.db.models[name] && !schema.options.overwriteModels) {
     throw new OverwriteModelError(name);
   }
 
@@ -3374,7 +3381,7 @@ Model.$__insertMany = function(arr, options, callback) {
       return doc != null;
     });
     // Quickly escape while there aren't any valid docAttributes
-    if (docAttributes.length < 1) {
+    if (docAttributes.length === 0) {
       if (rawResult) {
         const res = {
           mongoose: {
@@ -3609,16 +3616,21 @@ Model.bulkWrite = function(ops, options, callback) {
  * `bulkSave` uses `bulkWrite` under the hood, so it's mostly useful when dealing with many documents (10K+)
  *
  * @param {[Document]} documents
+ * @param {Object} [options] options passed to the underlying `bulkWrite()`
+ * @param {ClientSession} [options.session=null] The session associated with this bulk write. See [transactions docs](/docs/transactions.html).
+ * @param {String|number} [options.w=1] The [write concern](https://docs.mongodb.com/manual/reference/write-concern/). See [`Query#w()`](/docs/api.html#query_Query-w) for more information.
+ * @param {number} [options.wtimeout=null] The [write concern timeout](https://docs.mongodb.com/manual/reference/write-concern/#wtimeout).
+ * @param {Boolean} [options.j=true] If false, disable [journal acknowledgement](https://docs.mongodb.com/manual/reference/write-concern/#j-option)
  *
  */
-Model.bulkSave = function(documents) {
+Model.bulkSave = function(documents, options) {
   const preSavePromises = documents.map(buildPreSavePromise);
 
   const writeOperations = this.buildBulkWriteOperations(documents, { skipValidation: true });
 
   let bulkWriteResultPromise;
   return Promise.all(preSavePromises)
-    .then(() => bulkWriteResultPromise = this.bulkWrite(writeOperations))
+    .then(() => bulkWriteResultPromise = this.bulkWrite(writeOperations, options))
     .then(() => documents.map(buildSuccessfulWriteHandlerPromise))
     .then(() => bulkWriteResultPromise)
     .catch((err) => {
@@ -4451,9 +4463,16 @@ const excludeIdRegGlobal = /\s?-_id\s?/g;
 
 function populate(model, docs, options, callback) {
   const populateOptions = { ...options };
-  if (model.base.options.strictPopulate != null && options.strictPopulate == null) {
-    populateOptions.strictPopulate = model.base.options.strictPopulate;
+  if (options.strictPopulate == null) {
+    if (options._localModel != null && options._localModel.schema._userProvidedOptions.strictPopulate != null) {
+      populateOptions.strictPopulate = options._localModel.schema._userProvidedOptions.strictPopulate;
+    } else if (options._localModel != null && model.base.options.strictPopulate != null) {
+      populateOptions.strictPopulate = model.base.options.strictPopulate;
+    } else if (model.base.options.strictPopulate != null) {
+      populateOptions.strictPopulate = model.base.options.strictPopulate;
+    }
   }
+
   // normalize single / multiple docs passed
   if (!Array.isArray(docs)) {
     docs = [docs];
@@ -4524,7 +4543,7 @@ function populate(model, docs, options, callback) {
   }
   if (!hasOne) {
     // If models but no docs, skip further deep populate.
-    if (modelsMap.length > 0) {
+    if (modelsMap.length !== 0) {
       return callback();
     }
     // If no models to populate but we have a nested populate,

package/lib/plugins/trackTransaction.js

@@ -2,6 +2,7 @@
 
 const arrayAtomicsSymbol = require('../helpers/symbols').arrayAtomicsSymbol;
 const sessionNewDocuments = require('../helpers/symbols').sessionNewDocuments;
+const utils = require('../utils');
 
 module.exports = function trackTransaction(schema) {
   schema.pre('save', function() {
@@ -47,10 +48,10 @@ function _getAtomics(doc, previous) {
     const val = doc.$__getValue(path);
     if (val != null &&
         val instanceof Array &&
-        val.isMongooseDocumentArray &&
+        utils.isMongooseDocumentArray(val) &&
         val.length &&
         val[arrayAtomicsSymbol] != null &&
-        Object.keys(val[arrayAtomicsSymbol]).length > 0) {
+        Object.keys(val[arrayAtomicsSymbol]).length !== 0) {
       const existing = previous.get(path) || {};
       pathToAtomics.set(path, mergeAtomics(existing, val[arrayAtomicsSymbol]));
     }
@@ -61,7 +62,7 @@ function _getAtomics(doc, previous) {
     const path = dirt.path;
 
     const val = dirt.value;
-    if (val != null && val[arrayAtomicsSymbol] != null && Object.keys(val[arrayAtomicsSymbol]).length > 0) {
+    if (val != null && val[arrayAtomicsSymbol] != null && Object.keys(val[arrayAtomicsSymbol]).length !== 0) {
       const existing = previous.get(path) || {};
       pathToAtomics.set(path, mergeAtomics(existing, val[arrayAtomicsSymbol]));
     }

package/lib/query.js

@@ -120,7 +120,7 @@ function Query(conditions, options, model, collection) {
  * inherit mquery
  */
 
-Query.prototype = new mquery;
+Query.prototype = new mquery();
 Query.prototype.constructor = Query;
 Query.base = mquery.prototype;
 
@@ -4848,7 +4848,8 @@ Query.prototype._castUpdate = function _castUpdate(obj, overwrite) {
     overwrite: overwrite,
     strict: this._mongooseOptions.strict,
     upsert: upsert,
-    arrayFilters: this.options.arrayFilters
+    arrayFilters: this.options.arrayFilters,
+    overwriteDiscriminatorKey: this._mongooseOptions.overwriteDiscriminatorKey
   }, this, this._conditions);
 };
 
@@ -5057,18 +5058,19 @@ Query.prototype.cast = function(model, obj) {
     model = getDiscriminatorByValue(model.discriminators, obj[discriminatorKey]) || model;
   }
 
+  const opts = { upsert: this.options && this.options.upsert };
+  if (this.options) {
+    if ('strict' in this.options) {
+      opts.strict = this.options.strict;
+      opts.strictQuery = opts.strict;
+    }
+    if ('strictQuery' in this.options) {
+      opts.strictQuery = this.options.strictQuery;
+    }
+  }
+
   try {
-    return cast(model.schema, obj, {
-      upsert: this.options && this.options.upsert,
-      strict: (this.options && 'strict' in this.options) ?
-        this.options.strict :
-        get(model, 'schema.options.strict', null),
-      strictQuery: (this.options && 'strictQuery' in this.options) ?
-        this.options.strictQuery :
-        (this.options && 'strict' in this.options) ?
-          this.options.strict :
-          get(model, 'schema.options.strictQuery', null)
-    }, this);
+    return cast(model.schema, obj, opts, this);
   } catch (err) {
     // CastError, assign model
     if (typeof err.setModel === 'function') {

package/lib/queryhelpers.js

@@ -212,7 +212,7 @@ exports.applyPaths = function applyPaths(fields, schema) {
 
       let addedPath = analyzePath(path, type);
       // arrays
-      if (addedPath == null && type.$isMongooseArray && !type.$isMongooseDocumentArray) {
+      if (addedPath == null && !Array.isArray(type) && type.$isMongooseArray && !type.$isMongooseDocumentArray) {
         addedPath = analyzePath(path, type.caster);
       }
       if (addedPath != null) {

package/lib/schema/SubdocumentPath.js

@@ -168,7 +168,7 @@ SubdocumentPath.prototype.cast = function(val, doc, init, priorVal, options) {
   const path = this.path;
   const selected = Object.keys(parentSelected).reduce((obj, key) => {
     if (key.startsWith(path + '.')) {
-      obj[key.substr(path.length + 1)] = parentSelected[key];
+      obj[key.substring(path.length + 1)] = parentSelected[key];
     }
     return obj;
   }, {});

package/lib/schema/array.js

@@ -112,14 +112,12 @@ function SchemaArray(key, cast, options, schemaOptions) {
 
   if (!('defaultValue' in this) || this.defaultValue !== void 0) {
     const defaultFn = function() {
-      let arr = [];
-      if (fn) {
-        arr = defaultArr.call(this);
-      } else if (defaultArr != null) {
-        arr = arr.concat(defaultArr);
-      }
       // Leave it up to `cast()` to convert the array
-      return arr;
+      return fn
+        ? defaultArr.call(this)
+        : defaultArr != null
+          ? [].concat(defaultArr)
+          : [];
     };
     defaultFn.$runBeforeSetters = !fn;
     this.default(defaultFn);
@@ -275,7 +273,7 @@ SchemaArray.prototype.applyGetters = function(value, scope) {
 
   const ret = SchemaType.prototype.applyGetters.call(this, value, scope);
   if (Array.isArray(ret)) {
-    const rawValue = ret.isMongooseArrayProxy ? ret.__array : ret;
+    const rawValue = utils.isMongooseArray(ret) ? ret.__array : ret;
     const len = rawValue.length;
     for (let i = 0; i < len; ++i) {
       rawValue[i] = this.caster.applyGetters(rawValue[i], scope);
@@ -299,7 +297,7 @@ SchemaArray.prototype._applySetters = function(value, scope, init, priorVal) {
     }
 
     // No need to wrap empty arrays
-    if (value != null && value.length > 0) {
+    if (value != null && value.length !== 0) {
       const valueDepth = arrayDepth(value);
       if (valueDepth.min === valueDepth.max && valueDepth.max < depth && valueDepth.containsNonArrayItem) {
         for (let i = valueDepth.max; i < depth; ++i) {
@@ -344,7 +342,7 @@ SchemaArray.prototype.cast = function(value, doc, init, prev, options) {
       // Special case: if this index is on the parent of what looks like
       // GeoJSON, skip setting the default to empty array re: #1668, #3233
       const arrayGeojsonPath = this.path.endsWith('.coordinates') ?
-        this.path.substr(0, this.path.lastIndexOf('.')) : null;
+        this.path.substring(0, this.path.lastIndexOf('.')) : null;
       if (arrayGeojsonPath != null) {
         for (i = 0, l = indexes.length; i < l; ++i) {
           const pathIndex = indexes[i][0][arrayGeojsonPath];
@@ -357,7 +355,7 @@ SchemaArray.prototype.cast = function(value, doc, init, prev, options) {
 
     options = options || emptyOpts;
 
-    let rawValue = value.isMongooseArrayProxy ? value.__array : value;
+    let rawValue = utils.isMongooseArray(value) ? value.__array : value;
     value = MongooseArray(rawValue, options.path || this._arrayPath || this.path, doc, this);
     rawValue = value.__array;
 
@@ -557,12 +555,16 @@ function cast$all(val) {
   }
 
   val = val.map(function(v) {
-    if (utils.isObject(v)) {
-      const o = {};
-      o[this.path] = v;
-      return cast(this.casterConstructor.schema, o)[this.path];
+    if (!utils.isObject(v)) {
+      return v;
+    }
+    if (v.$elemMatch != null) {
+      return { $elemMatch: cast(this.casterConstructor.schema, v.$elemMatch) };
     }
-    return v;
+
+    const o = {};
+    o[this.path] = v;
+    return cast(this.casterConstructor.schema, o)[this.path];
   }, this);
 
   return this.castForQuery(val);

package/lib/schema/documentarray.js

@@ -228,7 +228,7 @@ DocumentArrayPath.prototype.doValidate = function(array, fn, scope, options) {
     if (options && options.updateValidator) {
       return fn();
     }
-    if (!array.isMongooseDocumentArray) {
+    if (!utils.isMongooseDocumentArray(array)) {
       array = new MongooseDocumentArray(array, _this.path, scope);
     }
 
@@ -398,12 +398,9 @@ DocumentArrayPath.prototype.cast = function(value, doc, init, prev, options) {
     return this.cast([value], doc, init, prev, options);
   }
 
-  if (!(value && value.isMongooseDocumentArray) &&
-      !options.skipDocumentArrayCast) {
-    value = new MongooseDocumentArray(value, this.path, doc);
-  } else if (value && value.isMongooseDocumentArray) {
-    // We need to create a new array, otherwise change tracking will
-    // update the old doc (gh-4449)
+  // We need to create a new array, otherwise change tracking will
+  // update the old doc (gh-4449)
+  if (!options.skipDocumentArrayCast || utils.isMongooseDocumentArray(value)) {
     value = new MongooseDocumentArray(value, this.path, doc);
   }
 
@@ -415,7 +412,7 @@ DocumentArrayPath.prototype.cast = function(value, doc, init, prev, options) {
     value[arrayPathSymbol] = this.path + '.' + options.arrayPathIndex;
   }
 
-  const rawArray = value.isMongooseDocumentArrayProxy ? value.__array : value;
+  const rawArray = utils.isMongooseDocumentArray(value) ? value.__array : value;
 
   const len = rawArray.length;
   const initDocumentOptions = { skipId: true, willInit: true };
@@ -546,7 +543,7 @@ function scopePaths(array, fields, init) {
         continue;
       }
       if (sub.startsWith('$.')) {
-        sub = sub.substr(2);
+        sub = sub.substring(2);
       }
       hasKeys || (hasKeys = true);
       selected[sub] = fields[key];

package/lib/schema/objectid.js

@@ -281,7 +281,7 @@ function resetId(v) {
 
   if (this instanceof Document) {
     if (v === void 0) {
-      const _v = new oid;
+      const _v = new oid();
       this.$__._id = _v;
       return _v;
     }

package/lib/schema.js

@@ -75,6 +75,7 @@ let id = 0;
  * - [selectPopulatedPaths](/docs/guide.html#selectPopulatedPaths): boolean - defaults to `true`
  * - [skipVersioning](/docs/guide.html#skipVersioning): object - paths to exclude from versioning
  * - [timestamps](/docs/guide.html#timestamps): object or boolean - defaults to `false`. If true, Mongoose adds `createdAt` and `updatedAt` properties to your schema and manages those properties for you.
+ * - [pluginTags](/docs/guide.html#pluginTags): array of strings - defaults to `undefined`. If set and plugin called with `tags` option, will only apply that plugin to schemas with a matching tag.
  *
  * ####Options for Nested Schemas:
  * - `excludeIndexes`: bool - defaults to `false`. If `true`, skip building indexes on this schema's paths.
@@ -532,13 +533,13 @@ Schema.prototype.add = function add(obj, prefix) {
       // Special-case: Non-options definitely a path so leaf at this node
       // Examples: Schema instances, SchemaType instances
       if (prefix) {
-        this.nested[prefix.substr(0, prefix.length - 1)] = true;
+        this.nested[prefix.substring(0, prefix.length - 1)] = true;
       }
       this.path(prefix + key, val);
     } else if (Object.keys(val).length < 1) {
       // Special-case: {} always interpreted as Mixed path so leaf at this node
       if (prefix) {
-        this.nested[prefix.substr(0, prefix.length - 1)] = true;
+        this.nested[prefix.substring(0, prefix.length - 1)] = true;
       }
       this.path(fullPath, val); // mixed type
     } else if (!val[typeKey] || (typeKey === 'type' && isPOJO(val.type) && val.type.type)) {
@@ -553,7 +554,7 @@ Schema.prototype.add = function add(obj, prefix) {
       if (isPOJO(_typeDef) && Object.keys(_typeDef).length > 0) {
         // If a POJO is the value of a type key, make it a subdocument
         if (prefix) {
-          this.nested[prefix.substr(0, prefix.length - 1)] = true;
+          this.nested[prefix.substring(0, prefix.length - 1)] = true;
         }
         const _schema = new Schema(_typeDef);
         const schemaWrappedPath = Object.assign({}, val, { type: _schema });
@@ -561,7 +562,7 @@ Schema.prototype.add = function add(obj, prefix) {
       } else {
         // Either the type is non-POJO or we interpret it as Mixed anyway
         if (prefix) {
-          this.nested[prefix.substr(0, prefix.length - 1)] = true;
+          this.nested[prefix.substring(0, prefix.length - 1)] = true;
         }
         this.path(prefix + key, val);
       }