mongoose 5.0.5 → 5.0.6

package/History.md

@@ -1,3 +1,12 @@
+5.0.6 / 2018-02-15
+==================
+ * refactor(query.castUpdate): avoid creating error until necessary #6137
+ * docs(api): fix missing api docs #6136 [lineus](https://github.com/lineus)
+ * fix(schema): copy virtuals when using `clone()` #6133
+ * fix(update): avoid digging into buffers with upsert and replaceOne #6124
+ * fix(schema): support `enum` on arrays of strings #6102
+ * fix(update): cast `$addToSet: [1, 2]` -> `$addToSet: { $each: [1, 2] }` #6086
+
 5.0.5 / 2018-02-13
 ==================
  * docs: make > show up correctly in API docs #6114

package/lib/schema/array.js

@@ -17,6 +17,7 @@ var Types = {
 };
 var Mixed = require('./mixed');
 var cast = require('../cast');
+var get = require('lodash.get');
 var util = require('util');
 var utils = require('../utils');
 var castToNumber = require('./operators/helpers').castToNumber;
@@ -119,6 +120,23 @@ SchemaArray.schemaName = 'Array';
 SchemaArray.prototype = Object.create(SchemaType.prototype);
 SchemaArray.prototype.constructor = SchemaArray;
 
+/**
+ * Adds an enum validator if this is an array of strings. Equivalent to
+ * `SchemaString.prototype.enum()`
+ *
+ * @param {String|Object} [args...] enumeration values
+ * @return {SchemaType} this
+ */
+
+SchemaArray.prototype.enum = function() {
+  const instance = get(this, 'caster.instance');
+  if (instance !== 'String') {
+    throw new Error('`enum` can only be set on an array of strings, not ' + instance);
+  }
+  this.caster.enum.apply(this.caster, arguments);
+  return this;
+};
+
 /**
  * Check if the given value satisfies a required validator. The given value
  * must be not null nor undefined, and have a positive length.

package/lib/schema.js

@@ -235,7 +235,6 @@ Schema.prototype.tree;
 
 Schema.prototype.clone = function() {
   var s = new Schema(this.paths, this.options);
-  // Clone the call queue
   var cloneOpts = {};
   s.callQueue = this.callQueue.map(function(f) { return f; });
   s.methods = utils.clone(this.methods, cloneOpts);
@@ -244,6 +243,7 @@ Schema.prototype.clone = function() {
   s.plugins = Array.prototype.slice.call(this.plugins);
   s._indexes = utils.clone(this._indexes, cloneOpts);
   s.s.hooks = this.s.hooks.clone();
+  s.virtuals = utils.clone(this.virtuals, cloneOpts);
   return s;
 };
 

package/lib/services/query/castUpdate.js

@@ -66,8 +66,10 @@ module.exports = function castUpdate(schema, obj, options, context) {
     op = ops[i];
     val = ret[op];
     hasDollarKey = hasDollarKey || op.charAt(0) === '$';
+
     if (val &&
         typeof val === 'object' &&
+        !Buffer.isBuffer(val) &&
         (!overwrite || hasDollarKey)) {
       hasKeys |= walkUpdatePath(schema, val, op, options.strict, context);
     } else if (overwrite && ret && typeof ret === 'object') {
@@ -111,8 +113,7 @@ function walkUpdatePath(schema, obj, op, strict, context, pref) {
   var key;
   var val;
 
-  var hasError = false;
-  var aggregatedError = new ValidationError();
+  var aggregatedError = null;
 
   var useNestedStrict = schema.options.useNestedStrict;
 
@@ -133,8 +134,7 @@ function walkUpdatePath(schema, obj, op, strict, context, pref) {
               $each: castUpdateVal(schematype, val.$each, op, context)
             };
           } catch (error) {
-            hasError = true;
-            _handleCastError(error, context, key, aggregatedError);
+            aggregatedError = _handleCastError(error, context, key, aggregatedError);
           }
 
           if (val.$slice != null) {
@@ -152,8 +152,7 @@ function walkUpdatePath(schema, obj, op, strict, context, pref) {
           try {
             obj[key] = castUpdateVal(schematype, val, op, context);
           } catch (error) {
-            hasError = true;
-            _handleCastError(error, context, key, aggregatedError);
+            aggregatedError = _handleCastError(error, context, key, aggregatedError);
           }
         }
       } else if ((op === '$currentDate') || (op in castOps && schematype)) {
@@ -161,8 +160,7 @@ function walkUpdatePath(schema, obj, op, strict, context, pref) {
         try {
           obj[key] = castUpdateVal(schematype, val, op, context);
         } catch (error) {
-          hasError = true;
-          _handleCastError(error, context, key, aggregatedError);
+          aggregatedError = _handleCastError(error, context, key, aggregatedError);
         }
 
         hasKeys = true;
@@ -228,14 +226,17 @@ function walkUpdatePath(schema, obj, op, strict, context, pref) {
         try {
           obj[key] = castUpdateVal(schematype, val, op, key, context);
         } catch (error) {
-          hasError = true;
-          _handleCastError(error, context, key, aggregatedError);
+          aggregatedError = _handleCastError(error, context, key, aggregatedError);
+        }
+
+        if (Array.isArray(obj[key]) && (op === '$addToSet' || op === '$push') && key !== '$each') {
+          obj[key] = { $each: obj[key] };
         }
       }
     }
   }
 
-  if (hasError) {
+  if (aggregatedError != null) {
     throw aggregatedError;
   }
 
@@ -250,7 +251,9 @@ function _handleCastError(error, query, key, aggregatedError) {
   if (typeof query !== 'object' || !query.options.multipleCastError) {
     throw error;
   }
+  aggregatedError = aggregatedError || new ValidationError();
   aggregatedError.addError(key, error);
+  return aggregatedError;
 }
 
 /*!

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "mongoose",
   "description": "Mongoose MongoDB ODM",
-  "version": "5.0.5",
+  "version": "5.0.6",
   "author": "Guillermo Rauch <guillermo@learnboost.com>",
   "keywords": [
     "mongodb",