mongodb 6.5.0-dev.20240326.sha.918fe69 → 6.5.0-dev.20240403.sha.cb5903f

package/src/operations/execute_operation.ts

@@ -26,7 +26,7 @@ import {
 } from '../sdam/server_selection';
 import type { Topology } from '../sdam/topology';
 import type { ClientSession } from '../sessions';
-import { supportsRetryableWrites } from '../utils';
+import { squashError, supportsRetryableWrites } from '../utils';
 import { AbstractOperation, Aspect } from './operation';
 
 const MMAPv1_RETRY_WRITES_ERROR_CODE = MONGODB_ERROR_CODES.IllegalOperation;
@@ -146,7 +146,7 @@ export async function executeOperation<
 
   if (session == null) {
     // No session also means it is not retryable, early exit
-    return operation.execute(server, undefined);
+    return await operation.execute(server, undefined);
   }
 
   if (!operation.hasAspect(Aspect.RETRYABLE)) {
@@ -155,7 +155,11 @@ export async function executeOperation<
       return await operation.execute(server, session);
     } finally {
       if (session?.owner != null && session.owner === owner) {
-        await session.endSession().catch(() => null);
+        try {
+          await session.endSession();
+        } catch (error) {
+          squashError(error);
+        }
       }
     }
   }
@@ -191,7 +195,11 @@ export async function executeOperation<
     throw operationError;
   } finally {
     if (session?.owner != null && session.owner === owner) {
-      await session.endSession().catch(() => null);
+      try {
+        await session.endSession();
+      } catch (error) {
+        squashError(error);
+      }
     }
   }
 }

package/src/operations/find.ts

@@ -111,7 +111,7 @@ export class FindOperation extends CommandOperation<Document> {
       findCommand = decorateWithExplain(findCommand, this.explain);
     }
 
-    return server.command(this.ns, findCommand, {
+    return await server.command(this.ns, findCommand, {
       ...this.options,
       ...this.bsonOptions,
       documentsReturnedIn: 'firstBatch',

package/src/operations/get_more.ts

@@ -96,7 +96,7 @@ export class GetMoreOperation extends AbstractOperation {
       ...this.options
     };
 
-    return server.command(this.ns, getMoreCmd, commandOptions);
+    return await server.command(this.ns, getMoreCmd, commandOptions);
   }
 }
 

package/src/operations/indexes.ts

@@ -333,7 +333,7 @@ export class DropIndexOperation extends CommandOperation<Document> {
 
   override async execute(server: Server, session: ClientSession | undefined): Promise<Document> {
     const cmd = { dropIndexes: this.collection.collectionName, index: this.indexName };
-    return super.executeCommand(server, session, cmd);
+    return await super.executeCommand(server, session, cmd);
   }
 }
 
@@ -377,7 +377,7 @@ export class ListIndexesOperation extends CommandOperation<Document> {
       command.comment = this.options.comment;
     }
 
-    return super.executeCommand(server, session, command);
+    return await super.executeCommand(server, session, command);
   }
 }
 

package/src/operations/insert.ts

@@ -47,7 +47,7 @@ export class InsertOperation extends CommandOperation<Document> {
       command.comment = options.comment;
     }
 
-    return super.executeCommand(server, session, command);
+    return await super.executeCommand(server, session, command);
   }
 }
 

package/src/operations/kill_cursors.ts

@@ -2,7 +2,7 @@ import type { Long } from '../bson';
 import { MongoRuntimeError } from '../error';
 import type { Server } from '../sdam/server';
 import type { ClientSession } from '../sessions';
-import type { MongoDBNamespace } from '../utils';
+import { type MongoDBNamespace, squashError } from '../utils';
 import { AbstractOperation, Aspect, defineAspects, type OperationOptions } from './operation';
 
 /**
@@ -47,8 +47,9 @@ export class KillCursorsOperation extends AbstractOperation {
     };
     try {
       await server.command(this.ns, killCursorsCommand, { session });
-    } catch {
+    } catch (error) {
       // The driver should never emit errors from killCursors, this is spec-ed behavior
+      squashError(error);
     }
   }
 }

package/src/operations/list_collections.ts

@@ -52,7 +52,11 @@ export class ListCollectionsOperation extends CommandOperation<Document> {
   }
 
   override async execute(server: Server, session: ClientSession | undefined): Promise<Document> {
-    return super.executeCommand(server, session, this.generateCommand(maxWireVersion(server)));
+    return await super.executeCommand(
+      server,
+      session,
+      this.generateCommand(maxWireVersion(server))
+    );
   }
 
   /* This is here for the purpose of unit testing the final command that gets sent. */

package/src/operations/list_databases.ts

@@ -63,7 +63,7 @@ export class ListDatabasesOperation extends CommandOperation<ListDatabasesResult
       cmd.comment = this.options.comment;
     }
 
-    return super.executeCommand(server, session, cmd) as TODO_NODE_3286;
+    return await (super.executeCommand(server, session, cmd) as Promise<TODO_NODE_3286>);
   }
 }
 

package/src/operations/run_command.ts

@@ -28,11 +28,12 @@ export class RunCommandOperation<T = Document> extends AbstractOperation<T> {
 
   override async execute(server: Server, session: ClientSession | undefined): Promise<T> {
     this.server = server;
-    return server.command(this.ns, this.command, {
+    const res: TODO_NODE_3286 = await server.command(this.ns, this.command, {
       ...this.options,
       readPreference: this.readPreference,
       session
-    }) as TODO_NODE_3286;
+    });
+    return res;
   }
 }
 
@@ -54,10 +55,11 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
 
   override async execute(server: Server, session: ClientSession | undefined): Promise<T> {
     this.server = server;
-    return server.command(this.ns, this.command, {
+    const res: TODO_NODE_3286 = await server.command(this.ns, this.command, {
       ...this.options,
       readPreference: this.readPreference,
       session
-    }) as TODO_NODE_3286;
+    });
+    return res;
   }
 }

package/src/operations/stats.ts

@@ -30,7 +30,7 @@ export class DbStatsOperation extends CommandOperation<Document> {
       command.scale = this.options.scale;
     }
 
-    return super.executeCommand(server, session, command);
+    return await super.executeCommand(server, session, command);
   }
 }
 

package/src/operations/update.ts

@@ -122,7 +122,7 @@ export class UpdateOperation extends CommandOperation<Document> {
       }
     }
 
-    return super.executeCommand(server, session, command);
+    return await super.executeCommand(server, session, command);
   }
 }
 
@@ -144,8 +144,8 @@ export class UpdateOneOperation extends UpdateOperation {
     server: Server,
     session: ClientSession | undefined
   ): Promise<UpdateResult> {
-    const res = await super.execute(server, session);
-    if (this.explain != null) return res as TODO_NODE_3286;
+    const res: TODO_NODE_3286 = await super.execute(server, session);
+    if (this.explain != null) return res;
     if (res.code) throw new MongoServerError(res);
     if (res.writeErrors) throw new MongoServerError(res.writeErrors[0]);
 
@@ -178,8 +178,8 @@ export class UpdateManyOperation extends UpdateOperation {
     server: Server,
     session: ClientSession | undefined
   ): Promise<UpdateResult> {
-    const res = await super.execute(server, session);
-    if (this.explain != null) return res as TODO_NODE_3286;
+    const res: TODO_NODE_3286 = await super.execute(server, session);
+    if (this.explain != null) return res;
     if (res.code) throw new MongoServerError(res);
     if (res.writeErrors) throw new MongoServerError(res.writeErrors[0]);
 
@@ -231,8 +231,8 @@ export class ReplaceOneOperation extends UpdateOperation {
     server: Server,
     session: ClientSession | undefined
   ): Promise<UpdateResult> {
-    const res = await super.execute(server, session);
-    if (this.explain != null) return res as TODO_NODE_3286;
+    const res: TODO_NODE_3286 = await super.execute(server, session);
+    if (this.explain != null) return res;
     if (res.code) throw new MongoServerError(res);
     if (res.writeErrors) throw new MongoServerError(res.writeErrors[0]);
 

package/src/sdam/monitor.ts

@@ -351,6 +351,7 @@ function checkServer(monitor: Monitor, callback: Callback<Document | null>) {
     awaited = false;
     connection
       .command(ns('admin.$cmd'), cmd, options)
+      // eslint-disable-next-line github/no-then
       .then(onHeartbeatSucceeded, onHeartbeatFailed);
 
     return;
@@ -369,6 +370,7 @@ function checkServer(monitor: Monitor, callback: Callback<Document | null>) {
       connection.destroy();
       throw error;
     }
+    // eslint-disable-next-line github/no-then
   })().then(
     connection => {
       if (isInCloseState(monitor)) {
@@ -512,6 +514,7 @@ function measureRoundTripTime(rttPinger: RTTPinger, options: RTTPingerOptions) {
 
   const connection = rttPinger.connection;
   if (connection == null) {
+    // eslint-disable-next-line github/no-then
     connect(options).then(
       connection => {
         measureAndReschedule(connection);
@@ -526,6 +529,7 @@ function measureRoundTripTime(rttPinger: RTTPinger, options: RTTPingerOptions) {
 
   const commandName =
     connection.serverApi?.version || connection.helloOk ? 'hello' : LEGACY_HELLO_COMMAND;
+  // eslint-disable-next-line github/no-then
   connection.command(ns('admin.$cmd'), { [commandName]: 1 }, undefined).then(
     () => measureAndReschedule(),
     () => {

package/src/sdam/srv_polling.ts

@@ -3,7 +3,7 @@ import { clearTimeout, setTimeout } from 'timers';
 
 import { MongoRuntimeError } from '../error';
 import { TypedEventEmitter } from '../mongo_types';
-import { HostAddress, matchesParentDomain } from '../utils';
+import { HostAddress, matchesParentDomain, squashError } from '../utils';
 
 /**
  * @internal
@@ -95,7 +95,8 @@ export class SrvPoller extends TypedEventEmitter<SrvPollerEvents> {
     }
 
     this._timeout = setTimeout(() => {
-      this._poll().catch(() => null);
+      // eslint-disable-next-line github/no-then
+      this._poll().then(undefined, squashError);
     }, this.intervalMS);
   }
 

package/src/sdam/topology.ts

@@ -623,7 +623,7 @@ export class Topology extends TypedEventEmitter<TopologyEvents> {
     this[kWaitQueue].push(waitQueueMember);
     processWaitQueue(this);
 
-    return serverPromise;
+    return await serverPromise;
   }
   /**
    * Update the internal TopologyDescription with a ServerDescription

package/src/sessions.ts

@@ -1,3 +1,4 @@
+/* eslint-disable github/no-then */
 import { promisify } from 'util';
 
 import { Binary, type Document, Long, type Timestamp } from './bson';
@@ -44,6 +45,7 @@ import {
   List,
   maxWireVersion,
   now,
+  squashError,
   uuidV4
 } from './utils';
 import { WriteConcern } from './write_concern';
@@ -274,8 +276,9 @@ export class ClientSession extends TypedEventEmitter<ClientSessionEvents> {
         this.hasEnded = true;
         this.emit('ended', this);
       }
-    } catch {
+    } catch (error) {
       // spec indicates that we should ignore all errors for `endSessions`
+      squashError(error);
     } finally {
       maybeClearPinnedConnection(this, { force: true, ...options });
     }
@@ -415,14 +418,14 @@ export class ClientSession extends TypedEventEmitter<ClientSessionEvents> {
    * Commits the currently active transaction in this session.
    */
   async commitTransaction(): Promise<void> {
-    return endTransactionAsync(this, 'commitTransaction');
+    return await endTransactionAsync(this, 'commitTransaction');
   }
 
   /**
    * Aborts the currently active transaction in this session.
    */
   async abortTransaction(): Promise<void> {
-    return endTransactionAsync(this, 'abortTransaction');
+    return await endTransactionAsync(this, 'abortTransaction');
   }
 
   /**
@@ -464,7 +467,7 @@ export class ClientSession extends TypedEventEmitter<ClientSessionEvents> {
     options?: TransactionOptions
   ): Promise<T> {
     const startTime = now();
-    return attemptTransaction(this, startTime, fn, options);
+    return await attemptTransaction(this, startTime, fn, options);
   }
 }
 

package/src/utils.ts

@@ -1,6 +1,7 @@
 import * as crypto from 'crypto';
 import type { SrvRecord } from 'dns';
 import { type EventEmitter } from 'events';
+import { promises as fs } from 'fs';
 import * as http from 'http';
 import { clearTimeout, setTimeout } from 'timers';
 import * as url from 'url';
@@ -178,6 +179,7 @@ export function isPromiseLike<T = unknown>(value?: unknown): value is PromiseLik
     value != null &&
     typeof value === 'object' &&
     'then' in value &&
+    // eslint-disable-next-line github/no-then
     typeof value.then === 'function'
   );
 }
@@ -1156,7 +1158,7 @@ export async function request(
   uri: string,
   options: RequestOptions = {}
 ): Promise<string | Record<string, any>> {
-  return new Promise<string | Record<string, any>>((resolve, reject) => {
+  return await new Promise<string | Record<string, any>>((resolve, reject) => {
     const requestOptions = {
       method: 'GET',
       timeout: 10000,
@@ -1259,6 +1261,20 @@ export function promiseWithResolvers<T>(): {
   return { promise, resolve, reject } as const;
 }
 
+/**
+ * A noop function intended for use in preventing unhandled rejections.
+ *
+ * @example
+ * ```js
+ * const promise = myAsyncTask();
+ * // eslint-disable-next-line github/no-then
+ * promise.then(undefined, squashError);
+ * ```
+ */
+export function squashError(_error: unknown) {
+  return;
+}
+
 export const randomBytes = promisify(crypto.randomBytes);
 
 /**
@@ -1319,3 +1335,12 @@ export function maybeAddIdToDocuments(
   };
   return Array.isArray(docOrDocs) ? docOrDocs.map(transform) : transform(docOrDocs);
 }
+
+export async function fileIsAccessible(fileName: string, mode?: number) {
+  try {
+    await fs.access(fileName, mode);
+    return true;
+  } catch {
+    return false;
+  }
+}