mongodb-ops 0.11.1 → 0.11.2

package/lib/mongodb-ops.js

@@ -281,7 +281,7 @@ class MongoDBOps {
       }
       return Promise.resolve(result);
     }
-    catch (err) { return Promise.reject(err.errmsg || err.message || err); }
+    catch (err) { return Promise.reject(err); }
   }
 
   /**
@@ -364,7 +364,7 @@ class MongoDBOps {
       result = await db.collection(collectionName).bulkWrite(docs, { ordered: ordered });
       return Promise.resolve(result);
     }
-    catch (err) { return Promise.reject(err.result || err.errmsg || err.message); }
+    catch (err) { return Promise.reject(err); }
   }
 
   /**

package/package.json

@@ -1,15 +1,18 @@
 {
   "name": "mongodb-ops",
-  "version": "0.11.1",
+  "version": "0.11.2",
   "description": "Read and write ops for MongoDB",
   "main": "index.js",
   "scripts": {
     "test": "node --test",
-    "lint": "node --check index.js && node --check lib/mongodb-ops.js && node --check test/mongodb-ops.test.js"
+    "lint": "node --check index.js && node --check lib/mongodb-ops.js && node --check test/mongodb-ops.test.js && node --check test/mongodb-write-errors.test.js"
   },
   "dependencies": {
     "mongodb": "^6.8.0"
   },
+  "devDependencies": {
+    "mongodb-memory-server": "^11.2.0"
+  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/CompAndSave/mongodb-ops.git"

package/test/fixtures/README.md

@@ -0,0 +1,7 @@
+# Orders Validator
+
+`vendor-orders-validator.json` is an unmodified copy of vendor-api's
+`db/validators/orders.json` at commit `303a01b425246b588f027145db04abe53049882e`.
+The real schema is checked in so the integration tests do not depend on a
+separate vendor-api checkout. In particular, `invoice_date: null` must be
+rejected by the same strict validator used by that service.

package/test/fixtures/vendor-orders-validator.json

@@ -0,0 +1,224 @@
+{
+  "$jsonSchema": {
+    "bsonType": "object",
+    "required": [
+      "_id",
+      "ts",
+      "order_id",
+      "vendor",
+      "submitted_by",
+      "status",
+      "address"
+    ],
+    "additionalProperties": false,
+    "properties": {
+      "_id": {
+        "bsonType": "string",
+        "pattern": "^EDI-[A-Za-z0-9-]+$",
+        "description": "site EDI-<digits> or marketplace EDI-<SELLERCODE>-<rawOrderId>"
+      },
+      "ts": {
+        "bsonType": "date"
+      },
+      "order_id": {
+        "bsonType": "string",
+        "pattern": "^[A-Za-z0-9-]+$",
+        "description": "site numeric id or marketplace raw order id"
+      },
+      "vendor": {
+        "bsonType": "string",
+        "pattern": "^[a-z]+$"
+      },
+      "vendor_po_num": {
+        "bsonType": "string",
+        "pattern": "^EDI-[A-Za-z0-9-]+$"
+      },
+      "submitted_by": {
+        "bsonType": "string"
+      },
+      "status": {
+        "bsonType": "string",
+        "pattern": "^(?:new|shipped|completed|send_error)$"
+      },
+      "items": {
+        "bsonType": "array",
+        "minimum": 1,
+        "items": {
+          "bsonType": "object",
+          "required": [
+            "sku",
+            "vendor_sku",
+            "unit_price",
+            "qty"
+          ],
+          "additionalProperties": false,
+          "properties": {
+            "sku": {
+              "bsonType": "string"
+            },
+            "vendor_sku": {
+              "bsonType": "string"
+            },
+            "unit_price": {
+              "bsonType": [
+                "int",
+                "double"
+              ]
+            },
+            "qty": {
+              "bsonType": "int"
+            }
+          }
+        }
+      },
+      "total_before_shipping": {
+        "bsonType": [
+          "int",
+          "double"
+        ]
+      },
+      "address": {
+        "bsonType": "object",
+        "required": [
+          "company_name",
+          "name",
+          "address_line1",
+          "address_line2",
+          "city",
+          "state_province",
+          "postal_code",
+          "country_code"
+        ],
+        "additionalProperties": false,
+        "properties": {
+          "company_name": {
+            "bsonType": "string"
+          },
+          "name": {
+            "bsonType": "string"
+          },
+          "address_line1": {
+            "bsonType": "string"
+          },
+          "address_line2": {
+            "bsonType": "string"
+          },
+          "city": {
+            "bsonType": "string"
+          },
+          "state_province": {
+            "bsonType": "string"
+          },
+          "postal_code": {
+            "bsonType": "string"
+          },
+          "country_code": {
+            "bsonType": "string"
+          }
+        }
+      },
+      "invoice_date": {
+        "bsonType": "string",
+        "pattern": "^[\\d]{4}-[\\d]{2}-[\\d]{2}$"
+      },
+      "invoice_id": {
+        "bsonType": "string"
+      },
+      "invoice_total": {
+        "bsonType": [
+          "int",
+          "double"
+        ]
+      },
+      "tracking_num": {
+        "bsonType": "string"
+      },
+      "tracking_updated_at": {
+        "bsonType": "date",
+        "description": "when tracking was last populated on this PO"
+      },
+      "shipping_cost": {
+        "bsonType": [
+          "int",
+          "double"
+        ]
+      },
+      "carrier": {
+        "bsonType": "string"
+      },
+      "signature_requested": {
+        "bsonType": "bool"
+      },
+      "channel": {
+        "bsonType": "string"
+      },
+      "seller_account": {
+        "bsonType": [
+          "string",
+          "null"
+        ]
+      },
+      "seller_code": {
+        "bsonType": [
+          "string",
+          "null"
+        ]
+      },
+      "marketplace_id": {
+        "bsonType": [
+          "string",
+          "null"
+        ]
+      },
+      "raw_order_id": {
+        "bsonType": [
+          "string",
+          "null"
+        ]
+      },
+      "source_order_id": {
+        "bsonType": "string"
+      },
+      "send_error": {
+        "bsonType": "string"
+      },
+      "marketplace_writeback_status": {
+        "bsonType": "string"
+      },
+      "marketplace_writeback_attempt_at": {
+        "bsonType": "date"
+      },
+      "marketplace_writeback_channel": {
+        "bsonType": "string"
+      },
+      "marketplace_writeback_error": {
+        "bsonType": [
+          "string",
+          "null"
+        ]
+      },
+      "marketplace_writeback_confirmed_at": {
+        "bsonType": "date"
+      },
+      "marketplace_writeback_carrier": {
+        "bsonType": "string"
+      },
+      "marketplace_writeback_tracking_number": {
+        "bsonType": "string"
+      },
+      "marketplace_writeback_failed_at": {
+        "bsonType": "date"
+      },
+      "marketplace_writeback_http_status": {
+        "bsonType": [
+          "int",
+          "double",
+          "null"
+        ]
+      },
+      "marketplace_writeback_last_error_at": {
+        "bsonType": "date"
+      }
+    }
+  }
+}

package/test/mongodb-write-errors.test.js

@@ -0,0 +1,89 @@
+'use strict';
+
+const test = require('node:test');
+const assert = require('node:assert/strict');
+const { MongoMemoryServer } = require('mongodb-memory-server');
+const { MongoDBToolSet } = require('..');
+const validator = require('./fixtures/vendor-orders-validator.json');
+
+const order = (id) => ({
+  _id: id,
+  ts: new Date('2026-01-01T00:00:00.000Z'),
+  order_id: id.replace(/^EDI-/, ''),
+  vendor: 'acm',
+  submitted_by: 'test',
+  status: 'new',
+  address: {
+    company_name: '',
+    name: 'Test Recipient',
+    address_line1: '1 Main St',
+    address_line2: '',
+    city: 'Los Angeles',
+    state_province: 'CA',
+    postal_code: '90001',
+    country_code: 'US'
+  }
+});
+
+async function rejection(promise) {
+  try {
+    await promise;
+  } catch (error) {
+    return error;
+  }
+  assert.fail('Expected the real MongoDB write to reject');
+}
+
+test('real MongoDB write errors retain their diagnostic detail', async (t) => {
+  const mongod = await MongoMemoryServer.create();
+  try {
+    const connString = mongod.getUri('write_error_test');
+    const client = await MongoDBToolSet.getDbClient(connString);
+    await client.db().createCollection('orders', {
+      validator,
+      validationLevel: 'strict',
+      validationAction: 'error'
+    });
+    await MongoDBToolSet.insertOne('orders', order('EDI-1001'), connString);
+
+    const single = await rejection(MongoDBToolSet.updateOne(
+      'orders', { $set: { invoice_date: null } }, { _id: 'EDI-1001' }, connString
+    ));
+    const bulk = await rejection(MongoDBToolSet.updateBulkUnOrdered('orders', [{
+      filter: { _id: 'EDI-1001' },
+      update: { $set: { invoice_date: null } }
+    }], connString));
+    const duplicate = await rejection(MongoDBToolSet.insertOne(
+      'orders', order('EDI-1001'), connString
+    ));
+
+    await t.test('G0: single-write rejection is an Error, not a string or copied object', () => {
+      assert.ok(single instanceof Error, 'single-write rejection must be an Error');
+    });
+    await t.test('G0: bulk-write rejection is an Error, not a BulkWriteResult or copied object', () => {
+      assert.ok(bulk instanceof Error, 'bulk-write rejection must be an Error');
+    });
+    await t.test('G1: updateOne retains the real validator field diagnostic', () => {
+      const rules = single?.errInfo?.details?.schemaRulesNotSatisfied;
+      assert.ok(Array.isArray(rules), 'updateOne must retain errInfo.details.schemaRulesNotSatisfied');
+      assert.equal(single.code, 121);
+      assert.match(JSON.stringify(rules), /"propertyName":"invoice_date"/);
+    });
+    await t.test('G2: bulk rejection exposes writeErrors directly with the validator detail', () => {
+      assert.ok(Array.isArray(bulk?.writeErrors), 'bulk rejection must expose writeErrors directly');
+      assert.equal(bulk.writeErrors.length, 1);
+      assert.equal(bulk.writeErrors[0].code, 121);
+      const rules = bulk.writeErrors[0].err.errInfo.details.schemaRulesNotSatisfied;
+      assert.match(JSON.stringify(rules), /"propertyName":"invoice_date"/);
+    });
+    await t.test('G3: duplicate-key rejection retains MongoDB code 11000', () => {
+      assert.equal(duplicate?.code, 11000, 'duplicate-key rejection must retain code 11000');
+    });
+  } finally {
+    try {
+      await MongoDBToolSet.closeDBConn();
+    } finally {
+      await mongod.stop();
+    }
+  }
+});