monday-sdk-js 0.4.9 → 0.4.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "monday-sdk-js",
-  "version": "0.4.9",
+  "version": "0.4.11",
   "private": false,
   "repository": "https://github.com/mondaycom/monday-sdk-js",
   "main": "src/index.js",

package/src/constants-test.js

@@ -5,6 +5,7 @@ describe("constants", () => {
   //setup
   beforeEach(() => {
     process.env.NODE_ENV = "development";
+    process.env.MONDAY_DOMAIN = undefined;
     process.env.MONDAY_COM_PROTOCOL = undefined;
     process.env.MONDAY_COM_DOMAIN = undefined;
     process.env.MONDAY_SUBDOMAIN_API = undefined;
@@ -35,44 +36,79 @@ describe("constants", () => {
     expect(constants.MONDAY_OAUTH_TOKEN_URL).to.eq(MONDAY_OAUTH_TOKEN_URL);
   });
 
-  it("constants should be correct", () => {
-    const keys = Object.keys(constants);
-    let key;
-    let value;
-    for (let i = 0; i < keys.length; i++) {
-      key = keys[i];
-      value = constants[key];
-
-      switch (key) {
-        case "MONDAY_DOMAIN": {
-          expect(value).to.eq("monday.com");
-          break;
-        }
-
-        case "MONDAY_PROTOCOL": {
-          expect(value).to.eq("https");
-          break;
-        }
-
-        case "MONDAY_API_URL": {
-          expect(value).to.eq("https://api.monday.com/v2");
-          break;
-        }
-
-        case "MONDAY_OAUTH_URL": {
-          expect(value).to.eq("https://auth.monday.com/oauth2/authorize");
-          break;
-        }
-
-        case "MONDAY_OAUTH_TOKEN_URL": {
-          expect(value).to.eq("https://auth.monday.com/oauth2/token");
-          break;
-        }
-
-        default: {
-          throw new Error(`missing test for this constant: ${key}`);
-        }
-      }
-    }
+  describe("check that constants are correct when NODE_ENV is development", () => {
+    it("MONDAY_DOMAIN should be correct", () => {
+      expect(constants.MONDAY_DOMAIN).to.eq("monday.com");
+    });
+
+    it("MONDAY_PROTOCOL should be correct", () => {
+      expect(constants.MONDAY_PROTOCOL).to.eq("https");
+    });
+
+    it("MONDAY_API_URL should be correct", () => {
+      expect(constants.MONDAY_API_URL).to.eq("https://api.monday.com/v2");
+    });
+
+    it("MONDAY_OAUTH_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_URL).to.eq("https://auth.monday.com/oauth2/authorize");
+    });
+
+    it("MONDAY_OAUTH_TOKEN_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_TOKEN_URL).to.eq("https://auth.monday.com/oauth2/token");
+    });
+  });
+
+  describe("check that constants are correct when NODE_ENV is undefined", () => {
+    beforeEach(() => {
+      process.env.NODE_ENV = undefined;
+      process.env.MONDAY_COM_DOMAIN = "should not be used";
+    });
+
+    it("MONDAY_DOMAIN should be correct", () => {
+      expect(constants.MONDAY_DOMAIN).to.eq("monday.com");
+    });
+
+    it("MONDAY_PROTOCOL should be correct", () => {
+      expect(constants.MONDAY_PROTOCOL).to.eq("https");
+    });
+
+    it("MONDAY_API_URL should be correct", () => {
+      expect(constants.MONDAY_API_URL).to.eq("https://api.monday.com/v2");
+    });
+
+    it("MONDAY_OAUTH_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_URL).to.eq("https://auth.monday.com/oauth2/authorize");
+    });
+
+    it("MONDAY_OAUTH_TOKEN_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_TOKEN_URL).to.eq("https://auth.monday.com/oauth2/token");
+    });
+  });
+
+  describe("check that constants are correct when NODE_ENV is undefined", () => {
+    beforeEach(() => {
+      process.env.NODE_ENV = "production";
+      process.env.MONDAY_COM_DOMAIN = "should not be used";
+    });
+
+    it("MONDAY_DOMAIN should be correct", () => {
+      expect(constants.MONDAY_DOMAIN).to.eq("monday.com");
+    });
+
+    it("MONDAY_PROTOCOL should be correct", () => {
+      expect(constants.MONDAY_PROTOCOL).to.eq("https");
+    });
+
+    it("MONDAY_API_URL should be correct", () => {
+      expect(constants.MONDAY_API_URL).to.eq("https://api.monday.com/v2");
+    });
+
+    it("MONDAY_OAUTH_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_URL).to.eq("https://auth.monday.com/oauth2/authorize");
+    });
+
+    it("MONDAY_OAUTH_TOKEN_URL should be correct", () => {
+      expect(constants.MONDAY_OAUTH_TOKEN_URL).to.eq("https://auth.monday.com/oauth2/token");
+    });
   });
 });

package/src/constants.js

@@ -7,7 +7,9 @@ function isNodeDevStageEnv() {
 }
 
 const getEnvOrDefault = (key, defaultVal) => {
-  return isNodeDevStageEnv() && process.env[key] !== "undefined" ? process.env[key] : defaultVal;
+  return isNodeDevStageEnv() && process.env[key] !== "undefined" && process.env[key] !== undefined
+    ? process.env[key]
+    : defaultVal;
 };
 
 const MONDAY_PROTOCOL = () => getEnvOrDefault("MONDAY_COM_PROTOCOL", "https");

package/types/client-sdk.interface.ts

@@ -0,0 +1,5 @@
+import { ClientData } from './client-data.interface';
+import { ClientExecute } from './client-execute.interface';
+import { ClientApi } from './client-api.interface';
+
+export type MondayClientSdk = ClientData & ClientExecute & ClientApi;

package/types/index.d.ts

@@ -1,22 +1,9 @@
 // Original Definitions were contributed by: Josh Parnham <https://github.com/josh->
-import { ClientData } from './client-data.interface';
-import { ClientExecute } from './client-execute.interface';
-import { ClientApi, APIOptions } from './client-api.interface';
+import { MondayClientSdk } from './client-sdk.interface';
+import { MondayServerSdk } from './server-sdk.interface';
 
 export as namespace mondaySdk;
 
-type MondayClientSdk = ClientData & ClientExecute & ClientApi;
-
-interface MondayServerSdk {
-    setToken(token: string): void;
-
-    setApiVersion(version: string): void;
-
-    api(query: string, options?: APIOptions): Promise<any>;
-
-    oauthToken(code: string, clientId: string, clientSecret: string): Promise<any>;
-}
-
 declare function init(
     config?: Partial<{
         clientId: string;

package/types/server-sdk.interface.ts

@@ -0,0 +1,11 @@
+import { APIOptions } from './client-api.interface';
+
+export interface MondayServerSdk {
+    setToken(token: string): void;
+
+    setApiVersion(version: string): void;
+
+    api(query: string, options?: APIOptions): Promise<any>;
+
+    oauthToken(code: string, clientId: string, clientSecret: string): Promise<any>;
+}