monday-sdk-js 0.4.5 → 0.4.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "monday-sdk-js",
-  "version": "0.4.5",
+  "version": "0.4.7",
   "private": false,
   "repository": "https://github.com/mondaycom/monday-sdk-js",
   "main": "src/index.js",

package/src/constants-test.js

@@ -2,10 +2,39 @@ const { expect } = require("./tests/helpers");
 const constants = require("./constants");
 
 describe("constants", () => {
+  //setup
+  beforeEach(() => {
+    process.env.NODE_ENV = "development";
+    process.env.MONDAY_COM_PROTOCOL = undefined;
+    process.env.MONDAY_COM_DOMAIN = undefined;
+    process.env.MONDAY_SUBDOMAIN_API = undefined;
+    process.env.MONDAY_OAUTH_SUBDOMAIN = undefined;
+  });
+
   it("should have at least 3 constants", () => {
     expect(Object.keys(constants).length).to.be.at.least(3);
   });
 
+  it("check that constants changed after setting env variables", () => {
+    const MONDAY_COM_PROTOCOL = "http";
+    const MONDAY_COM_DOMAIN = "mondaystaging.com";
+    const MONDAY_SUBDOMAIN_API = "";
+    const MONDAY_OAUTH_SUBDOMAIN = "authZ.";
+    const MONDAY_API_URL = `${MONDAY_COM_PROTOCOL}://${MONDAY_SUBDOMAIN_API}${MONDAY_COM_DOMAIN}/v2`;
+    const MONDAY_OAUTH_URL = `${MONDAY_COM_PROTOCOL}://${MONDAY_OAUTH_SUBDOMAIN}${MONDAY_COM_DOMAIN}/oauth2/authorize`;
+    const MONDAY_OAUTH_TOKEN_URL = `${MONDAY_COM_PROTOCOL}://${MONDAY_OAUTH_SUBDOMAIN}${MONDAY_COM_DOMAIN}/oauth2/token`;
+    process.env.MONDAY_COM_PROTOCOL = MONDAY_COM_PROTOCOL;
+    process.env.MONDAY_COM_DOMAIN = MONDAY_COM_DOMAIN;
+    process.env.MONDAY_SUBDOMAIN_API = MONDAY_SUBDOMAIN_API;
+    process.env.MONDAY_OAUTH_SUBDOMAIN = MONDAY_OAUTH_SUBDOMAIN;
+
+    expect(constants.MONDAY_DOMAIN).to.eq(MONDAY_COM_DOMAIN);
+    expect(constants.MONDAY_PROTOCOL).to.eq(MONDAY_COM_PROTOCOL);
+    expect(constants.MONDAY_API_URL).to.eq(MONDAY_API_URL);
+    expect(constants.MONDAY_OAUTH_URL).to.eq(MONDAY_OAUTH_URL);
+    expect(constants.MONDAY_OAUTH_TOKEN_URL).to.eq(MONDAY_OAUTH_TOKEN_URL);
+  });
+
   it("constants should be correct", () => {
     const keys = Object.keys(constants);
     let key;

package/src/constants.js

@@ -1,14 +1,19 @@
-const { isBrowser } = require("./helpers");
+function isNodeEnv() {
+  return typeof process !== "undefined";
+}
+
+function isNodeDevStageEnv() {
+  return isNodeEnv() && (process.env.NODE_ENV === "development" || process.env.NODE_ENV === "staging");
+}
 
-const isNodeDevEnv = !isBrowser && process.env.NODE_ENV === "development";
 const getEnvOrDefault = (key, defaultVal) => {
-  return isNodeDevEnv && typeof process.env[key] !== "undefined" ? process.env[key] : defaultVal;
+  return isNodeDevStageEnv() && process.env[key] !== "undefined" ? process.env[key] : defaultVal;
 };
 
 const MONDAY_PROTOCOL = () => getEnvOrDefault("MONDAY_COM_PROTOCOL", "https");
 const MONDAY_DOMAIN = () => getEnvOrDefault("MONDAY_COM_DOMAIN", "monday.com");
 const MONDAY_SUBDOMAIN_API = () => getEnvOrDefault("MONDAY_SUBDOMAIN_API", "api.");
-const MONDAY_OAUTH_SUBDOMAIN = () => getEnvOrDefault(MONDAY_SUBDOMAIN_API(), "auth.");
+const MONDAY_OAUTH_SUBDOMAIN = () => getEnvOrDefault("MONDAY_OAUTH_SUBDOMAIN", "auth.");
 
 const MONDAY_API_URL = () => `${MONDAY_PROTOCOL()}://${MONDAY_SUBDOMAIN_API()}${MONDAY_DOMAIN()}/v2`;
 const MONDAY_OAUTH_URL = () => `${MONDAY_PROTOCOL()}://${MONDAY_OAUTH_SUBDOMAIN()}${MONDAY_DOMAIN()}/oauth2/authorize`;