monastery 2.2.5 → 2.2.7

package/changelog.md

@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [2.2.7](https://github.com/boycce/monastery/compare/2.2.6...2.2.7) (2024-05-01)
+
+### [2.2.6](https://github.com/boycce/monastery/compare/2.2.5...2.2.6) (2024-04-30)
+
 ### [2.2.5](https://github.com/boycce/monastery/compare/2.2.4...2.2.5) (2024-04-30)
 
 ### [2.2.4](https://github.com/boycce/monastery/compare/2.2.3...2.2.4) (2024-04-30)

package/docs/image-plugin.md

@@ -12,7 +12,7 @@ To use the default image plugin shipped with monastery, you need to use the opti
     imagePlugin: {
       awsAcl: 'public-read', // default
       awsBucket: 'your-bucket-name',
-      awsRegion: undefined, // required when using getSignedUrl (e.g. 's3-ap-southeast-2')
+      awsRegion: undefined, // e.g. 'ap-southeast-2'
       awsAccessKeyId: 'your-key-here',
       awsSecretAccessKey: 'your-key-here',
       filesize: undefined, // default (max filesize in bytes)

package/lib/index.js

@@ -64,6 +64,7 @@ module.exports = function(uri, opts, fn) {
   }
 
   // Initiate any plugins
+  manager._getSignedUrl = manager.imagePluginFile._getSignedUrl
   if (manager.imagePlugin) {
     manager.imagePluginFile.setup(manager, util.isObject(manager.imagePlugin)? manager.imagePlugin : {})
   }
@@ -91,7 +92,6 @@ let models = async function(pathname, opts) {
    * @this Manager
    */
   let out = {}
-  opts = true
   if (opts === true) {
     opts = { waitForIndexes: true } // legacy support
     console.warn('Depreciating: please use `{ waitForIndexes: true }` instead of `true` in db.models(pathname, `true`)')

package/package.json

@@ -2,7 +2,7 @@
   "name": "monastery",
   "description": "⛪ A straight forward MongoDB ODM built around Monk",
   "author": "Ricky Boyce",
-  "version": "2.2.5",
+  "version": "2.2.7",
   "license": "MIT",
   "repository": "github:boycce/monastery",
   "homepage": "https://boycce.github.io/monastery/",

package/plugins/images/index.js

@@ -38,16 +38,16 @@ let plugin = module.exports = {
     this.path = options.path || function (uid, basename, ext, file) { return `full/${uid}.${ext}` }
 
     if (!options.awsBucket || !options.awsAccessKeyId || !options.awsSecretAccessKey) {
-      manager.error('Monastery imagePlugin: awsBucket, awsAccessKeyId, or awsSecretAccessKey is not defined')
-      delete manager.imagePlugin
-      return
+      throw new Error('Monastery imagePlugin: awsRegion, awsBucket, awsAccessKeyId, or awsSecretAccessKey is not defined')
+    }
+    if (!options.awsRegion) {
+      throw new Error('Monastery imagePlugin: v3 requires awsRegion to be defined for signing urls, e.g. "ap-southeast-2"')
     }
 
     // Create s3 'service' instance (defer require since it takes 120ms to load)
     // v2: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property
     // v3: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/s3/
     // v3 examples: https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/javascript_s3_code_examples.html
-    manager._getSignedUrl = this._getSignedUrl
     this.getS3Client = () => {
       const { S3 } = require('@aws-sdk/client-s3')
       return this._s3Client || (this._s3Client = new S3({
@@ -598,8 +598,10 @@ let plugin = module.exports = {
      * @see v2: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#getSignedUrl-property
      * @see v3: https://github.com/aws/aws-sdk-js-v3/blob/main/UPGRADING.md#s3-presigned-url
      */
-    if (!plugin.awsRegion) {
-      throw 'Monastery requires config.awsRegion to be defined when using getSignedUrl\'s'
+    if (!plugin.getS3Client) {
+      throw new Error(
+        'To use db._getSignedUrl(), the imagePlugin manager option must be defined, e.g. `monastery(..., { imagePlugin })`'
+      )
     }
     const { GetObjectCommand } = require('@aws-sdk/client-s3')
     const params = { Bucket: bucket || plugin.awsBucket, Key: path }

package/test/plugin-images.js

@@ -1,4 +1,5 @@
 let util = require('../lib/util.js')
+const imagePluginFakeOpts = { awsBucket: 'fake', awsRegion: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
 
 module.exports = function(monastery, opendb) {
 
@@ -58,7 +59,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -68,7 +69,7 @@ module.exports = function(monastery, opendb) {
     }})
 
     // Initialisation success
-    expect(db.imagePlugin).toEqual({ awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' })
+    expect(db.imagePlugin).toEqual(imagePluginFakeOpts)
 
     let expected = {
       bucket: { type: 'string', isString: true },
@@ -96,7 +97,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
     let plugin = db.imagePluginFile
     db.model('user', { fields: {
@@ -147,7 +148,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -255,7 +256,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -341,7 +342,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -392,7 +393,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     db.model('user', { fields: {
@@ -470,7 +471,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -524,7 +525,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: { awsBucket: 'fake', awsAccessKeyId: 'fake', awsSecretAccessKey: 'fake' }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', { fields: {
@@ -621,11 +622,7 @@ module.exports = function(monastery, opendb) {
     let db = (await opendb(null, {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
-      imagePlugin: {
-        awsBucket: 'fake',
-        awsAccessKeyId: 'fake',
-        awsSecretAccessKey: 'fake',
-      }
+      imagePlugin: imagePluginFakeOpts
     })).db
 
     let user = db.model('user', {
@@ -717,9 +714,7 @@ module.exports = function(monastery, opendb) {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
       imagePlugin: {
-        awsBucket: 'fake',
-        awsAccessKeyId: 'fake',
-        awsSecretAccessKey: 'fake',
+        ...imagePluginFakeOpts,
         formats: ['jpg', 'jpeg', 'png', 'ico'],
         filesize: 1000 * 270,
       }
@@ -800,9 +795,7 @@ module.exports = function(monastery, opendb) {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
       imagePlugin: {
-        awsBucket: 'fake',
-        awsAccessKeyId: 'fake',
-        awsSecretAccessKey: 'fake',
+        ...imagePluginFakeOpts,
         awsRegion: 's3-ap-southeast-2',
         getSignedUrl: true,
       },
@@ -861,10 +854,8 @@ module.exports = function(monastery, opendb) {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
       imagePlugin: {
+        ...imagePluginFakeOpts,
         awsAcl: 'private',
-        awsBucket: 'fake',
-        awsAccessKeyId: 'fake',
-        awsSecretAccessKey: 'fake',
         metadata: { small: '*x300' , medium: '*x800', large: '*x1200' },
         params: { ContentLanguage: 'DE'},
         path: (uid, basename, ext, file) => `images/${basename}`,
@@ -966,9 +957,7 @@ module.exports = function(monastery, opendb) {
       timestamps: false,
       serverSelectionTimeoutMS: 2000,
       imagePlugin: {
-        awsBucket: 'fake',
-        awsAccessKeyId: 'fake',
-        awsSecretAccessKey: 'fake',
+        ...imagePluginFakeOpts,
         bucketDir: 'old',
       }
     })).db