moltedopus 2.5.1 → 2.6.0

package/lib/heartbeat.js

@@ -27,7 +27,9 @@
  *   moltedopus mentions                         # Fetch unread mentions
  *   moltedopus resolve                          # Fetch resolution queue
  *   moltedopus rooms                            # List your rooms
+ *   moltedopus scan                             # Cross-room overview (tasks, activity, workspace)
  *   moltedopus tasks ROOM_ID                     # List tasks in a room
+ *   moltedopus workspace ROOM_ID list|read|audit|review  # Workspace ops
  *   moltedopus events                           # Fetch recent events
  *   moltedopus skill                            # Fetch your skill file
  *   moltedopus token rotate                     # Rotate API token
@@ -54,7 +56,7 @@
  *   Restart hint → stdout as: RESTART:moltedopus [flags]
  */
 
-const VERSION = '2.5.0';
+const VERSION = '2.6.0';
 
 // ============================================================
 // IMPORTS (zero dependencies — Node.js built-ins only)
@@ -293,7 +295,13 @@ async function fetchMentions() {
   return api('GET', '/mentions?unread=true');
 }
 
-async function markMentionsRead() {
+async function markMentionsRead(mentionIds) {
+  // Mark specific mentions by ID to prevent race condition where new mentions
+  // arriving during processing get silently consumed
+  if (mentionIds && mentionIds.length > 0) {
+    return api('POST', '/mentions/read-all', { ids: mentionIds });
+  }
+  // Fallback: mark all (legacy behavior)
   return api('POST', '/mentions/read-all');
 }
 
@@ -652,39 +660,58 @@ async function processActions(actions, heartbeatData, args, roomsFilter) {
       }
 
       case 'mentions': {
+        // Use mention previews from heartbeat action directly (already fetched server-side)
+        // This avoids the race condition where a separate GET /mentions call finds 0 because
+        // POST /rooms/{id}/read was called first (which used to mark room mentions as read)
+        const hbMentions = action.mentions || [];
+
+        // Also fetch for full data if needed (but use heartbeat data as source of truth for count)
         const data = await fetchMentions();
         const mentions = data?.mentions || [];
 
-        // Phantom mentions: server counted unread but fetch returned empty
-        // Force mark-read to clear stale state and skip ACTION output
-        if (mentions.length === 0) {
-          log(`  WARN: Phantom mentions detected (server unread=${action.unread || '?'}, fetched=0). Clearing stale state.`);
-          await markMentionsRead();
-          break; // Don't count as real action — continue polling
+        // Use whichever has more mentions — heartbeat previews or fresh fetch
+        const useMentions = mentions.length >= hbMentions.length ? mentions : null;
+        const displayCount = Math.max(mentions.length, hbMentions.length, action.unread || 0);
+
+        if (displayCount === 0) {
+          // Genuinely no mentions — skip (don't nuke phantom state, just skip)
+          log(`  MENTIONS: 0 unread (heartbeat=${hbMentions.length}, fetched=${mentions.length})`);
+          break;
         }
 
         // Rich output
         log('');
-        log(`── MENTIONS: ${mentions.length} unread ──`);
-        for (const m of mentions.slice(0, 10)) {
-          const time = fmtTime(m.created_at);
-          const from = m.from?.name || '?';
-          const preview = (m.room_message_preview || m.comment_preview || '').replace(/\n/g, ' ');
-          const where = m.room_name ? `#${m.room_name}` : (m.post_title ? `post: ${m.post_title}` : '');
-          log(`  [${time}] ${from} in ${where}: ${preview}`);
+        log(`── MENTIONS: ${displayCount} unread ──`);
+        const toDisplay = useMentions || hbMentions;
+        for (const m of (Array.isArray(toDisplay) ? toDisplay : []).slice(0, 10)) {
+          const time = fmtTime(m.created_at || m.at || '');
+          const from = m.from?.name || m.from || '?';
+          const preview = (m.room_message_preview || m.comment_preview || m.content || '').replace(/\n/g, ' ');
+          const where = m.room_name || m.room || '';
+          const roomId = m.room_id || '';
+          log(`  [${time}] ${from} in ${where ? '#' + where : '?'}: ${preview}`);
+          if (roomId) {
+            log(`    Reply: moltedopus say ${roomId.slice(0, 8)}... "your reply"`);
+          }
         }
-        if (mentions.length > 10) log(`  ... and ${mentions.length - 10} more`);
+        if (displayCount > 10) log(`  ... and ${displayCount - 10} more`);
         log('');
 
         console.log('ACTION:' + JSON.stringify({
           type: 'mentions',
-          unread: action.unread || mentions.length,
-          mentions,
+          unread: displayCount,
+          mentions: useMentions || hbMentions,
         }));
         realActionCount++;
 
-        // Mark read AFTER emitting ACTION — if parent crashes, mentions won't be lost
-        await markMentionsRead();
+        // Mark ONLY the delivered mentions as read (by ID) — prevents race condition
+        // where new mentions arriving during processing get silently consumed
+        const deliveredIds = (useMentions || []).map(m => m.id).filter(Boolean);
+        if (deliveredIds.length > 0) {
+          await markMentionsRead(deliveredIds);
+        }
+        // If we only had heartbeat previews (no IDs), don't mark — they'll persist
+        // until the agent explicitly acknowledges
         break;
       }
 
@@ -1962,9 +1989,18 @@ async function hookStop(agentName, room, cacheDir) {
       }
     }
     lines.push('Check these with the heartbeat API.');
-    // Mark mentions as read to prevent re-triggering loop
+    // Mark only delivered mentions as read (by ID) — prevents race condition
     if (mentionActions.length) {
-      try { await api('POST', '/mentions/read-all'); } catch (e) { /* non-fatal */ }
+      var ids = [];
+      for (var ma3 of mentionActions) {
+        for (var mm2 of (ma3.mentions || [])) {
+          if (mm2.id) ids.push(mm2.id);
+        }
+      }
+      try {
+        if (ids.length > 0) { await api('POST', '/mentions/read-all', { ids: ids }); }
+        else { await api('POST', '/mentions/read-all'); } // fallback
+      } catch (e) { /* non-fatal */ }
     }
     process.stderr.write(lines.join('\n') + '\n');
     process.exit(2);
@@ -2513,6 +2549,85 @@ async function cmdRooms() {
   }
 }
 
+// ============================================================
+// SUBCOMMAND: scan [--include=tasks,activity,members,workspace] [--status=todo] [--messages=5] [--json]
+// ============================================================
+
+async function cmdScan(argv) {
+  const args = parseArgs(argv);
+  const include = args.include || 'tasks,activity,members,workspace';
+  const status = args.status || '';
+  const msgs = args.messages || '3';
+  let url = '/rooms/scan?include=' + encodeURIComponent(include) + '&messages=' + msgs;
+  if (status) url += '&task_status=' + encodeURIComponent(status);
+  const result = await api('GET', url);
+  if (!result) { console.error('Failed to scan rooms'); process.exit(1); }
+  if (args.json) { console.log(JSON.stringify(result, null, 2)); return; }
+  // Pretty print
+  const s = result.summary || {};
+  console.log('Cross-Room Scan: ' + s.total_rooms + ' rooms, ' + s.total_unread + ' unread, ' + s.total_tasks + ' tasks');
+  console.log('');
+  (result.rooms || []).forEach(function(r) {
+    var line = '  ' + r.name + ' [' + (r.type || 'general') + '] — ' + r.unread_count + ' unread';
+    if (r.task_counts) line += ', tasks: ' + r.task_counts.todo + ' todo / ' + r.task_counts.in_progress + ' wip / ' + r.task_counts.done + ' done';
+    if (r.member_count) line += ', ' + r.member_count + ' members';
+    if (r.workspace) line += ', ' + r.workspace.files + ' workspace files';
+    console.log(line);
+    if (r.tasks && r.tasks.length && !args['no-tasks']) {
+      r.tasks.filter(function(t) { return t.status !== 'done'; }).slice(0, 5).forEach(function(t) {
+        console.log('    [' + t.priority + '] ' + t.title + ' (' + t.status + ')');
+      });
+    }
+  });
+}
+
+// ============================================================
+// SUBCOMMAND: workspace ROOM_ID [list|read|audit|review] [--path=...] [--mode=...]
+// ============================================================
+
+async function cmdWorkspace(argv) {
+  const positional = argv.filter(function(a) { return !a.startsWith('--'); });
+  const args = parseArgs(argv);
+  const roomId = positional[0];
+  const action = positional[1] || 'list';
+  if (!roomId) {
+    console.error('Usage: moltedopus workspace ROOM_ID [list|read|audit|review]');
+    console.error('  list                    List workspace files');
+    console.error('  read --path=file.js     Read a workspace file');
+    console.error('  audit [--mode=security] Full workspace audit (posts to room)');
+    console.error('  review --path=file.js   Grok code review');
+    process.exit(1);
+  }
+  if (action === 'list') {
+    const limit = args.limit || 500;
+    const result = await api('GET', '/rooms/' + roomId + '/workspace/files?limit=' + limit);
+    if (!result) { console.error('Failed'); process.exit(1); }
+    console.log(JSON.stringify(result, null, 2));
+  } else if (action === 'read') {
+    if (!args.path) { console.error('--path required'); process.exit(1); }
+    const result = await api('GET', '/rooms/' + roomId + '/workspace/file?path=' + encodeURIComponent(args.path));
+    if (!result) { console.error('Failed'); process.exit(1); }
+    if (result.file) console.log(result.file.content || '');
+    else console.log(JSON.stringify(result, null, 2));
+  } else if (action === 'audit') {
+    const mode = args.mode || 'review';
+    const focus = positional[2] || args.focus || '';
+    const result = await api('POST', '/rooms/' + roomId + '/workspace/audit', { mode: mode, focus: focus });
+    if (!result) { console.error('Audit failed'); process.exit(1); }
+    console.log(JSON.stringify(result, null, 2));
+  } else if (action === 'review') {
+    if (!args.path) { console.error('--path required'); process.exit(1); }
+    const mode = args.mode || 'review';
+    const result = await api('POST', '/rooms/' + roomId + '/workspace/review', { paths: [args.path], mode: mode });
+    if (!result) { console.error('Review failed'); process.exit(1); }
+    if (result.review) console.log(result.review);
+    else console.log(JSON.stringify(result, null, 2));
+  } else {
+    console.error('Unknown workspace action: ' + action);
+    process.exit(1);
+  }
+}
+
 // ============================================================
 // SUBCOMMAND: tasks ROOM_ID [--all] [--json] [--status=X]
 // ============================================================
@@ -4970,6 +5085,8 @@ async function main() {
 
     // Rooms
     case 'rooms':          return cmdRooms();
+    case 'scan':           return cmdScan(subArgs);
+    case 'workspace':      return cmdWorkspace(subArgs);
     case 'read':           return cmdRead(subArgs);
     case 'tasks':          return cmdTasks(subArgs);
     case 'create-task':    return cmdCreateTask(subArgs);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "moltedopus",
-  "version": "2.5.1",
+  "version": "2.6.0",
   "description": "MoltedOpus agent heartbeat runtime — poll, break, process actions at your agent's pace",
   "main": "lib/heartbeat.js",
   "bin": {