moflo 4.9.17 → 4.9.18

package/.claude/helpers/gate.cjs

@@ -2,6 +2,7 @@
 'use strict';
 var fs = require('fs');
 var path = require('path');
+var cp = require('child_process');
 
 var PROJECT_DIR = (process.env.CLAUDE_PROJECT_DIR || process.cwd()).replace(/^\/([a-z])\//i, '$1:/');
 var STATE_FILE = path.join(PROJECT_DIR, '.claude', 'workflow-state.json');
@@ -93,6 +94,36 @@ var EDIT_RESET_SKIP_BOTH_RE = /\.(md|markdown|txt|rst|adoc|lock|gitignore)$|(?:^
 // but NOT the simplify gate — /simplify already reviewed the production code; touching
 // a test file or fixture doesn't expose new untested surface for code review (#908).
 var EDIT_RESET_SKIP_SIMPLIFY_ONLY_RE = /(?:^|[\\\/])(__tests__|__mocks__|tests?|spec|specs|cypress|e2e|fixtures?)[\\\/]|\.(test|spec)\.[mc]?[jt]sx?$|\.fixture\.[mc]?[jt]sx?$/i;
+// Docs-only PR exemption: text/markup/image extensions that cannot change runtime behaviour.
+// If EVERY file in the PR diff matches this, skip testing/simplify/learnings gates.
+// Anchored to end-of-path so e.g. `foo.md.js` does not match. Excludes lock files / configs
+// on purpose — those are inert for edit-reset (above) but not "documentation".
+var DOCS_ONLY_RE = /\.(md|markdown|txt|rst|adoc|html?|pdf|png|jpe?g|gif|svg|webp|ico|bmp)$/i;
+
+// Get the file list changed on the current branch vs the merge-base with origin/main
+// (falling back to local main). Returns an array of repo-relative paths, or null on
+// failure — in which case callers MUST fall through to the standard gate (fail-safe).
+function getChangedFilesVsBase() {
+  var bases = ['origin/main', 'main', 'origin/master', 'master'];
+  var base = null;
+  for (var i = 0; i < bases.length; i++) {
+    try {
+      base = cp.execFileSync('git', ['merge-base', 'HEAD', bases[i]], {
+        cwd: PROJECT_DIR, encoding: 'utf-8', timeout: 2000, windowsHide: true,
+        stdio: ['ignore', 'pipe', 'ignore']
+      }).trim();
+      if (base) break;
+    } catch (e) { /* try next */ }
+  }
+  if (!base) return null;
+  try {
+    var out = cp.execFileSync('git', ['diff', '--name-only', base + '...HEAD'], {
+      cwd: PROJECT_DIR, encoding: 'utf-8', timeout: 2000, windowsHide: true,
+      stdio: ['ignore', 'pipe', 'ignore']
+    });
+    return out.split('\n').map(function(l) { return l.trim(); }).filter(Boolean);
+  } catch (e) { return null; }
+}
 
 switch (command) {
   case 'check-before-agent': {
@@ -208,6 +239,15 @@ switch (command) {
     // optional ENV=val prefix segment catches `GH_TOKEN=x gh pr create`.
     var cmd = process.env.TOOL_INPUT_command || '';
     if (!/(?:^|&&\s*|\|\|\s*|;\s*)\s*(?:[A-Z_][A-Z0-9_]*=\S+\s+)*gh\s+pr\s+create\b/.test(cmd)) break;
+    // Docs-only exemption: if every file changed vs the merge-base is a docs/image
+    // file (no runtime-behaviour surface), skip the testing/simplify/learnings gates
+    // and surface a one-line transparency note. Falls through to the standard gate
+    // on any failure (no base, no diff, exec error) — fail-safe by design.
+    var changed = getChangedFilesVsBase();
+    if (changed && changed.length > 0 && changed.every(function(f) { return DOCS_ONLY_RE.test(f); })) {
+      process.stdout.write('Docs-only PR (' + changed.length + ' file' + (changed.length === 1 ? '' : 's') + ') — skipping testing/simplify/learnings gates.\n');
+      break;
+    }
     var s = readState();
     var missing = [];
     if (config.testing_gate && !s.testsRun) missing.push('tests have not run since the last code edit (run npm test, vitest, jest, pytest, or similar)');

package/bin/gate.cjs

@@ -2,6 +2,7 @@
 'use strict';
 var fs = require('fs');
 var path = require('path');
+var cp = require('child_process');
 
 var PROJECT_DIR = (process.env.CLAUDE_PROJECT_DIR || process.cwd()).replace(/^\/([a-z])\//i, '$1:/');
 var STATE_FILE = path.join(PROJECT_DIR, '.claude', 'workflow-state.json');
@@ -93,6 +94,36 @@ var EDIT_RESET_SKIP_BOTH_RE = /\.(md|markdown|txt|rst|adoc|lock|gitignore)$|(?:^
 // but NOT the simplify gate — /simplify already reviewed the production code; touching
 // a test file or fixture doesn't expose new untested surface for code review (#908).
 var EDIT_RESET_SKIP_SIMPLIFY_ONLY_RE = /(?:^|[\\\/])(__tests__|__mocks__|tests?|spec|specs|cypress|e2e|fixtures?)[\\\/]|\.(test|spec)\.[mc]?[jt]sx?$|\.fixture\.[mc]?[jt]sx?$/i;
+// Docs-only PR exemption: text/markup/image extensions that cannot change runtime behaviour.
+// If EVERY file in the PR diff matches this, skip testing/simplify/learnings gates.
+// Anchored to end-of-path so e.g. `foo.md.js` does not match. Excludes lock files / configs
+// on purpose — those are inert for edit-reset (above) but not "documentation".
+var DOCS_ONLY_RE = /\.(md|markdown|txt|rst|adoc|html?|pdf|png|jpe?g|gif|svg|webp|ico|bmp)$/i;
+
+// Get the file list changed on the current branch vs the merge-base with origin/main
+// (falling back to local main). Returns an array of repo-relative paths, or null on
+// failure — in which case callers MUST fall through to the standard gate (fail-safe).
+function getChangedFilesVsBase() {
+  var bases = ['origin/main', 'main', 'origin/master', 'master'];
+  var base = null;
+  for (var i = 0; i < bases.length; i++) {
+    try {
+      base = cp.execFileSync('git', ['merge-base', 'HEAD', bases[i]], {
+        cwd: PROJECT_DIR, encoding: 'utf-8', timeout: 2000, windowsHide: true,
+        stdio: ['ignore', 'pipe', 'ignore']
+      }).trim();
+      if (base) break;
+    } catch (e) { /* try next */ }
+  }
+  if (!base) return null;
+  try {
+    var out = cp.execFileSync('git', ['diff', '--name-only', base + '...HEAD'], {
+      cwd: PROJECT_DIR, encoding: 'utf-8', timeout: 2000, windowsHide: true,
+      stdio: ['ignore', 'pipe', 'ignore']
+    });
+    return out.split('\n').map(function(l) { return l.trim(); }).filter(Boolean);
+  } catch (e) { return null; }
+}
 
 switch (command) {
   case 'check-before-agent': {
@@ -208,6 +239,15 @@ switch (command) {
     // optional ENV=val prefix segment catches `GH_TOKEN=x gh pr create`.
     var cmd = process.env.TOOL_INPUT_command || '';
     if (!/(?:^|&&\s*|\|\|\s*|;\s*)\s*(?:[A-Z_][A-Z0-9_]*=\S+\s+)*gh\s+pr\s+create\b/.test(cmd)) break;
+    // Docs-only exemption: if every file changed vs the merge-base is a docs/image
+    // file (no runtime-behaviour surface), skip the testing/simplify/learnings gates
+    // and surface a one-line transparency note. Falls through to the standard gate
+    // on any failure (no base, no diff, exec error) — fail-safe by design.
+    var changed = getChangedFilesVsBase();
+    if (changed && changed.length > 0 && changed.every(function(f) { return DOCS_ONLY_RE.test(f); })) {
+      process.stdout.write('Docs-only PR (' + changed.length + ' file' + (changed.length === 1 ? '' : 's') + ') — skipping testing/simplify/learnings gates.\n');
+      break;
+    }
     var s = readState();
     var missing = [];
     if (config.testing_gate && !s.testsRun) missing.push('tests have not run since the last code edit (run npm test, vitest, jest, pytest, or similar)');

package/dist/src/cli/commands/doctor-fixes.js

@@ -23,26 +23,72 @@ async function runFixCommand(cmd) {
     }
 }
 /**
- * Fix missing hook wiring in settings.json by patching in entries for any
- * REQUIRED_HOOK_WIRING patterns that aren't present. Delegates to shared
- * repairHookWiring() to stay DRY with the upgrade path.
+ * Fix Gate Health failures: bin/.claude-helpers gate.cjs drift AND missing
+ * settings.json hook wiring. The check has three independent failure modes
+ * and the prior fix only handled hook wiring — leaving bin/helper drift
+ * unresolved while still claiming success (the "Auto-fixed 1 issue" lie that
+ * surfaced when #920 mirrored the docs-only PR exemption into only one of
+ * the two gate.cjs files).
+ *
+ * Sync direction is decided by which source file is "ahead" of its installed
+ * counterpart in `node_modules/moflo/`:
+ *   - If only source `bin/gate.cjs` differs from installed bin → mirror bin → helper.
+ *   - If only source `.claude/helpers/gate.cjs` differs from installed helper → mirror helper → bin.
+ *   - If both are ahead with different content (genuine ambiguity) → bail
+ *     and let the caller report failure; refuse to silently pick a side.
+ *   - If `node_modules/moflo/` is missing entirely (consumer never installed,
+ *     unusual layout) → bail.
  */
 async function fixGateHealthHooks() {
-    const settingsPath = join(process.cwd(), '.claude', 'settings.json');
-    if (!existsSync(settingsPath))
-        return false;
-    try {
-        const raw = readFileSync(settingsPath, 'utf8');
-        const settings = JSON.parse(raw);
-        const { repaired } = repairHookWiring(settings);
-        if (repaired.length === 0)
-            return true; // nothing to fix
-        writeFileSync(settingsPath, JSON.stringify(settings, null, 2), 'utf-8');
-        return true;
+    const cwd = process.cwd();
+    let driftFixed = true; // true means "no drift to fix or drift resolved"
+    const binGate = join(cwd, 'bin', 'gate.cjs');
+    const helperGate = join(cwd, '.claude', 'helpers', 'gate.cjs');
+    const installedBin = join(cwd, 'node_modules', 'moflo', 'bin', 'gate.cjs');
+    const installedHelper = join(cwd, 'node_modules', 'moflo', '.claude', 'helpers', 'gate.cjs');
+    if (existsSync(binGate) && existsSync(helperGate)) {
+        try {
+            const binContent = readFileSync(binGate, 'utf8');
+            const helperContent = readFileSync(helperGate, 'utf8');
+            if (binContent !== helperContent) {
+                const installedBinContent = existsSync(installedBin) ? readFileSync(installedBin, 'utf8') : null;
+                const installedHelperContent = existsSync(installedHelper) ? readFileSync(installedHelper, 'utf8') : null;
+                const binAhead = installedBinContent !== null && binContent !== installedBinContent;
+                const helperAhead = installedHelperContent !== null && helperContent !== installedHelperContent;
+                if (binAhead && !helperAhead) {
+                    writeFileSync(helperGate, binContent, 'utf-8');
+                }
+                else if (helperAhead && !binAhead) {
+                    writeFileSync(binGate, helperContent, 'utf-8');
+                }
+                else {
+                    // Both ahead with different content, OR neither ahead (no install
+                    // to anchor on). Refuse to pick a side — surface the failure.
+                    driftFixed = false;
+                }
+            }
+        }
+        catch {
+            driftFixed = false;
+        }
     }
-    catch {
-        return false;
+    // Hook-wiring repair (separate failure mode that this fixer also owns).
+    const settingsPath = join(cwd, '.claude', 'settings.json');
+    let wiringFixed = true;
+    if (existsSync(settingsPath)) {
+        try {
+            const raw = readFileSync(settingsPath, 'utf8');
+            const settings = JSON.parse(raw);
+            const { repaired } = repairHookWiring(settings);
+            if (repaired.length > 0) {
+                writeFileSync(settingsPath, JSON.stringify(settings, null, 2), 'utf-8');
+            }
+        }
+        catch {
+            wiringFixed = false;
+        }
     }
+    return driftFixed && wiringFixed;
 }
 /**
  * Execute the fix for a failed/warned health check.

package/dist/src/cli/version.js

@@ -2,5 +2,5 @@
  * Auto-generated by build. Do not edit manually.
  * Source of truth: root package.json → scripts/sync-version.mjs
  */
-export const VERSION = '4.9.17';
+export const VERSION = '4.9.18';
 //# sourceMappingURL=version.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "moflo",
-  "version": "4.9.17",
+  "version": "4.9.18",
   "description": "MoFlo — AI agent orchestration for Claude Code. A standalone, opinionated toolkit with semantic memory, learned routing, gates, spells, and the /flo issue-execution skill.",
   "main": "dist/src/cli/index.js",
   "type": "module",
@@ -81,7 +81,7 @@
     "@typescript-eslint/eslint-plugin": "^7.18.0",
     "@typescript-eslint/parser": "^7.18.0",
     "eslint": "^8.0.0",
-    "moflo": "^4.9.16",
+    "moflo": "^4.9.17",
     "tsx": "^4.21.0",
     "typescript": "^5.9.3",
     "vitest": "^4.0.0"