moflo 4.12.3 → 4.12.4-rc.2

package/dist/src/cli/commands/doctor-fixes.js

@@ -27,6 +27,41 @@ async function runFixCommand(cmd) {
         return false;
     }
 }
+/**
+ * Fix the `Config File` check by creating the project's JSON config.
+ *
+ * The return value is derived from the file being on disk afterwards, NOT from
+ * the exit code of `config init`. That distinction is the whole fix: the
+ * command used to print "Creating claude-flow.config.json..." and exit 0
+ * without a single filesystem call, so `--fix` reported `applied: true` on
+ * every run while the warning it claimed to fix never cleared. An exit code is
+ * a claim; the file is the evidence.
+ *
+ * `deps` is injectable so tests can pin both branches without spawning npx —
+ * in particular the regression case, where the command "succeeds" and leaves
+ * nothing behind.
+ */
+export async function fixConfigFile(deps = {}) {
+    try {
+        const root = deps.root ?? resolveStateRoot();
+        const run = deps.run ?? runFixCommand;
+        const { findCliConfigFile } = await import('../config/cli-config-store.js');
+        if (findCliConfigFile(root))
+            return true;
+        const cfDir = mofloDir(root);
+        if (!existsSync(cfDir))
+            mkdirSync(cfDir, { recursive: true });
+        await run('npx moflo config init');
+        return findCliConfigFile(root) !== null;
+    }
+    catch (e) {
+        // Leave a crumb rather than a bare `catch {}` — #854 is four versions of
+        // consumer-invisible breakage caused by exactly that shape in the launcher
+        // upgrade flow.
+        output.writeln(output.warning(`  Config File fix failed: ${errorDetail(e)}`));
+        return false;
+    }
+}
 /**
  * Fix Gate Health failures: bin/.claude-helpers gate.cjs drift AND missing
  * settings.json hook wiring. The check has three independent failure modes
@@ -458,17 +493,7 @@ export async function autoFixCheck(check) {
                 return runFixCommand('npx moflo memory init --force');
             }
         },
-        'Config File': async () => {
-            try {
-                const cfDir = join(resolveStateRoot(), '.moflo');
-                if (!existsSync(cfDir))
-                    mkdirSync(cfDir, { recursive: true });
-                return runFixCommand('npx moflo config init');
-            }
-            catch {
-                return false;
-            }
-        },
+        'Config File': fixConfigFile,
         // moflo.yaml auto-create. The session-start launcher already runs
         // `ensureMofloYamlExists` (see bin/session-start-launcher.mjs § 3d-yaml-create,
         // #895) but it can miss when the launcher itself was old at upgrade time —

package/dist/src/cli/commands/doctor.js

@@ -8,7 +8,7 @@
  * `doctor-registry.ts`; rendering helpers live in `doctor-render.ts`.
  * This file is orchestration only.
  *
- * Created with motailz.com
+ * Created with cielolimitada.com
  */
 import { output } from '../output.js';
 import { allChecks, componentMap, zombieScanCheck } from './doctor-registry.js';

package/dist/src/cli/commands/embeddings.js

@@ -10,8 +10,9 @@
  * - Neural substrate integration
  * - Persistent SQLite cache
  *
- * Created with ❤️ by motailz.com
+ * Created with ❤️ by cielolimitada.com
  */
+import { readFileSync } from 'node:fs';
 import { output } from '../output.js';
 import { runEmbeddingsMigrationIfNeeded } from '../services/embeddings-migration.js';
 import { memoryDbPath, MEMORY_DB_FILE, MOFLO_DIR } from '../services/moflo-paths.js';
@@ -98,8 +99,8 @@ const searchCommand = {
     options: [
         { name: 'query', short: 'q', type: 'string', description: 'Search query', required: true },
         { name: 'collection', short: 'c', type: 'string', description: 'Namespace to search', default: 'default' },
-        { name: 'limit', short: 'l', type: 'number', description: 'Max results', default: '10' },
-        { name: 'threshold', short: 't', type: 'number', description: 'Similarity threshold (0-1)', default: '0.5' },
+        { name: 'limit', short: 'l', type: 'number', description: 'Max results', default: 10 },
+        { name: 'threshold', short: 't', type: 'number', description: 'Similarity threshold (0-1)', default: 0.5 },
         { name: 'db-path', type: 'string', description: 'Database path', default: DEFAULT_DB_PATH_FLAG },
     ],
     examples: [
@@ -448,8 +449,8 @@ const indexCommand = {
     options: [
         { name: 'action', short: 'a', type: 'string', description: 'Action: build, rebuild, status, optimize', default: 'status' },
         { name: 'collection', short: 'c', type: 'string', description: 'Collection/namespace name' },
-        { name: 'ef-construction', type: 'number', description: 'HNSW ef_construction parameter', default: '200' },
-        { name: 'm', type: 'number', description: 'HNSW M parameter', default: '16' },
+        { name: 'ef-construction', type: 'number', description: 'HNSW ef_construction parameter', default: 200 },
+        { name: 'm', type: 'number', description: 'HNSW M parameter', default: 16 },
     ],
     examples: [
         { command: 'flo embeddings index', description: 'Show index status' },
@@ -579,11 +580,11 @@ export const initCommand = {
     description: 'Initialize embedding subsystem with ONNX model and hyperbolic config',
     options: [
         { name: 'model', short: 'm', type: 'string', description: 'ONNX model ID', default: 'all-MiniLM-L6-v2' },
-        { name: 'hyperbolic', type: 'boolean', description: 'Enable hyperbolic (Poincaré ball) embeddings', default: 'true' },
+        { name: 'hyperbolic', type: 'boolean', description: 'Enable hyperbolic (Poincaré ball) embeddings', default: true },
         { name: 'curvature', short: 'c', type: 'string', description: 'Poincaré ball curvature (use --curvature=-1 for negative)', default: '-1' },
-        { name: 'download', short: 'd', type: 'boolean', description: 'Download model during init', default: 'true' },
+        { name: 'download', short: 'd', type: 'boolean', description: 'Download model during init', default: true },
         { name: 'cache-size', type: 'string', description: 'LRU cache entries', default: '256' },
-        { name: 'force', short: 'f', type: 'boolean', description: 'Overwrite existing configuration', default: 'false' },
+        { name: 'force', short: 'f', type: 'boolean', description: 'Overwrite existing configuration', default: false },
     ],
     examples: [
         { command: 'flo embeddings init', description: 'Initialize with defaults' },
@@ -739,9 +740,13 @@ const chunkCommand = {
     name: 'chunk',
     description: 'Chunk text for embedding with overlap',
     options: [
-        { name: 'text', short: 't', type: 'string', description: 'Text to chunk', required: true },
-        { name: 'max-size', short: 's', type: 'number', description: 'Max chunk size in chars', default: '512' },
-        { name: 'overlap', short: 'o', type: 'number', description: 'Overlap between chunks', default: '50' },
+        // Not `required`: --file is the documented alternative ("instead of
+        // text"), and a parser-level requirement made its own example
+        // (`chunk -f doc.txt`) impossible to run. The action validates that
+        // exactly one source was given.
+        { name: 'text', short: 't', type: 'string', description: 'Text to chunk' },
+        { name: 'max-size', short: 's', type: 'number', description: 'Max chunk size in chars', default: 512 },
+        { name: 'overlap', short: 'o', type: 'number', description: 'Overlap between chunks', default: 50 },
         { name: 'strategy', type: 'string', description: 'Strategy: character, sentence, paragraph, token', default: 'sentence' },
         { name: 'file', short: 'f', type: 'string', description: 'File to chunk (instead of text)' },
     ],
@@ -750,7 +755,40 @@ const chunkCommand = {
         { command: 'flo embeddings chunk -f doc.txt --strategy paragraph', description: 'Chunk file by paragraph' },
     ],
     action: async (ctx) => {
-        const text = ctx.flags.text || '';
+        const file = ctx.flags.file;
+        // --file was declared, described as "instead of text", and given its own
+        // example — but never read here, so it chunked the empty string even once
+        // the parser let it through.
+        let text;
+        if (file) {
+            try {
+                // Read first and let ENOENT report the missing file, rather than
+                // stat-then-read: the existence check was both a second syscall and a
+                // TOCTOU window this catch already covers.
+                //
+                // Normalize CRLF → LF: `chunking.ts` splits paragraphs on /\n\n+/,
+                // which a Windows-authored file's \r\n\r\n does not match, so the same
+                // document would chunk differently depending on the platform it was
+                // written on. Normalizing here keeps `--file` platform-independent
+                // without touching the shared splitter, whose boundaries determine
+                // already-stored embeddings.
+                text = readFileSync(file, 'utf8').replace(/\r\n/g, '\n');
+            }
+            catch (err) {
+                const code = err.code;
+                output.printError(code === 'ENOENT'
+                    ? `File not found: ${file}`
+                    : `Could not read ${file}: ${err.message}`);
+                return { success: false, exitCode: 1 };
+            }
+        }
+        else {
+            text = ctx.flags.text || '';
+        }
+        if (!text) {
+            output.printError('Nothing to chunk — pass --text or --file');
+            return { success: false, exitCode: 1 };
+        }
         const maxSize = parseInt(ctx.flags.maxSize || '512', 10);
         const overlap = parseInt(ctx.flags.overlap || '50', 10);
         const strategy = ctx.flags.strategy || 'sentence';
@@ -775,7 +813,7 @@ const chunkCommand = {
         });
         output.writeln();
         output.writeln(output.dim(`Total: ${result.totalChunks} chunks from ${result.originalLength} chars`));
-        return { success: true };
+        return { success: true, data: result };
     },
 };
 // Normalize subcommand
@@ -822,7 +860,7 @@ const hyperbolicCommand = {
     description: 'Hyperbolic embedding operations (Poincaré ball)',
     options: [
         { name: 'action', short: 'a', type: 'string', description: 'Action: convert, distance, centroid', default: 'convert' },
-        { name: 'curvature', short: 'c', type: 'number', description: 'Hyperbolic curvature', default: '-1' },
+        { name: 'curvature', short: 'c', type: 'number', description: 'Hyperbolic curvature', default: -1 },
         { name: 'input', short: 'i', type: 'string', description: 'Input embedding(s) JSON' },
     ],
     examples: [
@@ -1072,7 +1110,7 @@ export const modelsCommand = {
     description: 'List and download embedding models',
     options: [
         { name: 'download', short: 'd', type: 'string', description: 'Model ID to download' },
-        { name: 'list', short: 'l', type: 'boolean', description: 'List available models', default: 'true' },
+        { name: 'list', short: 'l', type: 'boolean', description: 'List available models', default: true },
     ],
     examples: [
         { command: 'flo embeddings models', description: 'List models' },
@@ -1254,8 +1292,8 @@ const warmupCommand = {
     name: 'warmup',
     description: 'Preload embedding model for faster subsequent operations',
     options: [
-        { name: 'background', short: 'b', type: 'boolean', description: 'Run warmup in background daemon', default: 'false' },
-        { name: 'test', short: 't', type: 'boolean', description: 'Run test embedding after warmup', default: 'true' },
+        { name: 'background', short: 'b', type: 'boolean', description: 'Run warmup in background daemon', default: false },
+        { name: 'test', short: 't', type: 'boolean', description: 'Run test embedding after warmup', default: true },
     ],
     examples: [
         { command: 'flo embeddings warmup', description: 'Preload model with test' },
@@ -1327,9 +1365,9 @@ const benchmarkCommand = {
     name: 'benchmark',
     description: 'Run embedding performance benchmarks',
     options: [
-        { name: 'iterations', short: 'n', type: 'number', description: 'Number of iterations', default: '10' },
-        { name: 'batch-size', short: 'b', type: 'number', description: 'Batch size for batch test', default: '5' },
-        { name: 'full', short: 'f', type: 'boolean', description: 'Run full benchmark suite', default: 'false' },
+        { name: 'iterations', short: 'n', type: 'number', description: 'Number of iterations', default: 10 },
+        { name: 'batch-size', short: 'b', type: 'number', description: 'Batch size for batch test', default: 5 },
+        { name: 'full', short: 'f', type: 'boolean', description: 'Run full benchmark suite', default: false },
     ],
     examples: [
         { command: 'flo embeddings benchmark', description: 'Quick benchmark' },
@@ -1472,8 +1510,11 @@ const migrateCommand = {
     description: 'Re-embed existing vectors using the current neural model (runs automatically on session start if needed)',
     options: [
         { name: 'db', short: 'd', type: 'string', description: 'Path to memory DB', default: DEFAULT_DB_PATH_FLAG },
-        { name: 'batch-size', short: 'b', type: 'number', description: 'Batch size', default: '128' },
-        { name: 'verbose', short: 'v', type: 'boolean', description: 'Verbose output', default: 'false' },
+        { name: 'batch-size', short: 'b', type: 'number', description: 'Batch size', default: 128 },
+        // Boolean default, not the string 'false' — this option shadows the global
+        // --verbose, so its default is the one the parser applies, and 'false' is
+        // a truthy string that would turn verbose ON by default.
+        { name: 'verbose', short: 'v', type: 'boolean', description: 'Verbose output', default: false },
     ],
     examples: [
         { command: 'flo embeddings migrate', description: `Migrate ${DEFAULT_DB_PATH_FLAG} to current version` },
@@ -1558,7 +1599,7 @@ export const embeddingsCommand = {
             'Hyperbolic: Better hierarchical representation',
         ]);
         output.writeln();
-        output.writeln(output.dim('Created with ❤️ by motailz.com'));
+        output.writeln(output.dim('Created with ❤️ by cielolimitada.com'));
         return { success: true };
     },
 };

package/dist/src/cli/commands/github.js

@@ -4,7 +4,7 @@
  *
  * Uses `gh` CLI for GitHub API calls and project detection from moflo.yaml.
  *
- * Created with motailz.com
+ * Created with cielolimitada.com
  */
 import { output } from '../output.js';
 import { existsSync, readFileSync, writeFileSync, mkdirSync } from 'fs';

package/dist/src/cli/commands/guidance.js

@@ -12,7 +12,7 @@ const compileCommand = {
         { name: 'root', short: 'r', type: 'string', description: 'Root guidance file path', default: './CLAUDE.md' },
         { name: 'local', short: 'l', type: 'string', description: 'Local guidance overlay file path' },
         { name: 'output', short: 'o', type: 'string', description: 'Output directory for compiled bundle' },
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     examples: [
         { command: 'flo guidance compile', description: 'Compile default CLAUDE.md' },
@@ -84,9 +84,9 @@ const retrieveCommand = {
         { name: 'task', short: 't', type: 'string', description: 'Task description', required: true },
         { name: 'root', short: 'r', type: 'string', description: 'Root guidance file path', default: './CLAUDE.md' },
         { name: 'local', short: 'l', type: 'string', description: 'Local overlay file path' },
-        { name: 'max-shards', short: 'n', type: 'number', description: 'Maximum number of shards to retrieve', default: '5' },
+        { name: 'max-shards', short: 'n', type: 'number', description: 'Maximum number of shards to retrieve', default: 5 },
         { name: 'intent', short: 'i', type: 'string', description: 'Override detected intent' },
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     examples: [
         { command: 'flo guidance retrieve -t "Fix SQL injection in user search"', description: 'Retrieve guidance for a security task' },
@@ -172,7 +172,7 @@ const gatesCommand = {
         { name: 'command', short: 'c', type: 'string', description: 'Command to evaluate' },
         { name: 'content', type: 'string', description: 'Content to check for secrets' },
         { name: 'tool', short: 't', type: 'string', description: 'Tool name to check against allowlist' },
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     examples: [
         { command: 'flo guidance gates -c "rm -rf /tmp"', description: 'Check if a command is destructive' },
@@ -256,7 +256,7 @@ const statusCommand = {
     name: 'status',
     description: 'Show guidance control plane status and metrics',
     options: [
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     action: async (ctx) => {
         const jsonOutput = ctx.flags.json === true;
@@ -309,11 +309,11 @@ const optimizeCommand = {
     options: [
         { name: 'root', short: 'r', type: 'string', description: 'Root guidance file path', default: './CLAUDE.md' },
         { name: 'local', short: 'l', type: 'string', description: 'Local overlay file path' },
-        { name: 'apply', short: 'a', type: 'boolean', description: 'Apply optimizations to the file', default: 'false' },
+        { name: 'apply', short: 'a', type: 'boolean', description: 'Apply optimizations to the file', default: false },
         { name: 'context-size', short: 's', type: 'string', description: 'Target context size: compact, standard, full', default: 'standard' },
-        { name: 'target-score', type: 'number', description: 'Target composite score (0-100)', default: '90' },
-        { name: 'max-iterations', type: 'number', description: 'Maximum optimization iterations', default: '5' },
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'target-score', type: 'number', description: 'Target composite score (0-100)', default: 90 },
+        { name: 'max-iterations', type: 'number', description: 'Maximum optimization iterations', default: 5 },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     examples: [
         { command: 'flo guidance optimize', description: 'Analyze current CLAUDE.md and show suggestions' },
@@ -416,7 +416,7 @@ const abTestCommand = {
         { name: 'config-b', short: 'b', type: 'string', description: 'Path to Config B (candidate CLAUDE.md)', default: './CLAUDE.md' },
         { name: 'tasks', short: 't', type: 'string', description: 'Path to custom task JSON file (array of ABTask objects)' },
         { name: 'work-dir', short: 'w', type: 'string', description: 'Working directory for test execution' },
-        { name: 'json', type: 'boolean', description: 'Output as JSON', default: 'false' },
+        { name: 'json', type: 'boolean', description: 'Output as JSON', default: false },
     ],
     examples: [
         { command: 'flo guidance ab-test', description: 'Run default A/B test (no guidance vs ./CLAUDE.md)' },

package/dist/src/cli/commands/hive-mind.js

@@ -113,7 +113,6 @@ ${workerTypes.map(type => `• ${type}: ${workerGroups[type].length} agents`).jo
    mcp__moflo__memory_store           - Store collective knowledge
    mcp__moflo__memory_retrieve        - Access shared memory
    mcp__moflo__memory_search          - Search memory patterns
-   mcp__moflo__neural_train           - Learn from experiences
    mcp__moflo__hooks_intelligence_pattern-store - Store patterns
 
 📋 HIVE MIND EXECUTION PROTOCOL:
@@ -789,6 +788,13 @@ const taskCommand = {
                 requireConsensus,
                 timeout,
             });
+            // An uninitialized hive comes back as { error }, not as a throw. Reading
+            // result.assignedTo.join() on that shape crashed with a TypeError
+            // instead of printing the actual problem (#1349).
+            if (result.error) {
+                output.printError(result.error);
+                return { success: false, exitCode: 1 };
+            }
             if (ctx.flags.format === 'json') {
                 output.printJson(result);
                 return { success: true, data: result };
@@ -818,73 +824,6 @@ const taskCommand = {
         }
     }
 };
-// Optimize memory subcommand
-const optimizeMemoryCommand = {
-    name: 'optimize-memory',
-    description: 'Optimize hive memory and patterns',
-    options: [
-        {
-            name: 'aggressive',
-            short: 'a',
-            description: 'Aggressive optimization',
-            type: 'boolean',
-            default: false
-        },
-        {
-            name: 'threshold',
-            description: 'Quality threshold for pattern retention',
-            type: 'number',
-            default: 0.7
-        }
-    ],
-    action: async (ctx) => {
-        const aggressive = ctx.flags.aggressive;
-        const threshold = ctx.flags.threshold;
-        output.printInfo('Optimizing hive memory...');
-        const spinner = output.createSpinner({ text: 'Analyzing patterns...', spinner: 'dots' });
-        spinner.start();
-        try {
-            const result = await callMCPTool('hive-mind_optimize-memory', {
-                aggressive,
-                qualityThreshold: threshold,
-            });
-            spinner.succeed('Memory optimized');
-            if (ctx.flags.format === 'json') {
-                output.printJson(result);
-                return { success: true, data: result };
-            }
-            output.writeln();
-            output.printTable({
-                columns: [
-                    { key: 'metric', header: 'Metric', width: 20 },
-                    { key: 'before', header: 'Before', width: 15, align: 'right' },
-                    { key: 'after', header: 'After', width: 15, align: 'right' }
-                ],
-                data: [
-                    { metric: 'Patterns', before: result.before.patterns, after: result.after.patterns },
-                    { metric: 'Memory', before: result.before.memory, after: result.after.memory }
-                ]
-            });
-            output.writeln();
-            output.printList([
-                `Patterns removed: ${result.removed}`,
-                `Patterns consolidated: ${result.consolidated}`,
-                `Optimization time: ${result.timeMs}ms`
-            ]);
-            return { success: true, data: result };
-        }
-        catch (error) {
-            spinner.fail('Optimization failed');
-            if (error instanceof MCPClientError) {
-                output.printError(`Optimization error: ${error.message}`);
-            }
-            else {
-                output.printError(`Unexpected error: ${String(error)}`);
-            }
-            return { success: false, exitCode: 1 };
-        }
-    }
-};
 // Join subcommand
 const joinCommand = {
     name: 'join',
@@ -1132,7 +1071,7 @@ export const hiveMindCommand = {
     name: 'hive-mind',
     aliases: ['hive'],
     description: 'Queen-led consensus-based multi-agent coordination',
-    subcommands: [initCommand, spawnCommand, statusCommand, taskCommand, joinCommand, leaveCommand, consensusCommand, broadcastCommand, memorySubCommand, optimizeMemoryCommand, shutdownCommand],
+    subcommands: [initCommand, spawnCommand, statusCommand, taskCommand, joinCommand, leaveCommand, consensusCommand, broadcastCommand, memorySubCommand, shutdownCommand],
     options: [],
     examples: [
         { command: 'flo hive-mind init -t hierarchical-mesh', description: 'Initialize hive' },
@@ -1157,7 +1096,6 @@ export const hiveMindCommand = {
             `${output.highlight('consensus')}       - Manage consensus proposals`,
             `${output.highlight('broadcast')}       - Broadcast message to workers`,
             `${output.highlight('memory')}          - Access shared memory`,
-            `${output.highlight('optimize-memory')} - Optimize patterns and memory`,
             `${output.highlight('shutdown')}        - Shutdown the hive`
         ]);
         output.writeln();