modestbench 0.9.0 → 0.9.2

package/src/formatters/history/compare.ts

@@ -51,8 +51,8 @@ export class HistoryCompareFormatter implements HistoryFormatter<CompareResult>
       lines.push('');
 
       for (const comparison of data.tasksInBoth) {
-        const mean1 = comparison.run1!.mean / 1000000; // Convert to ms
-        const mean2 = comparison.run2!.mean / 1000000;
+        const mean1 = comparison.run1!.mean / 1_000_000; // Convert to ms
+        const mean2 = comparison.run2!.mean / 1_000_000;
         const changeSign = comparison.percentChange >= 0 ? '+' : '';
         const changeStr = `${changeSign}${comparison.percentChange.toFixed(1)}%`;
 
@@ -73,8 +73,8 @@ export class HistoryCompareFormatter implements HistoryFormatter<CompareResult>
         );
 
         // Min - highlight higher number
-        const min1 = comparison.run1!.min / 1000000;
-        const min2 = comparison.run2!.min / 1000000;
+        const min1 = comparison.run1!.min / 1_000_000;
+        const min2 = comparison.run2!.min / 1_000_000;
         const minHigher = min2 > min1;
         const min1Str = minHigher
           ? colorize('magenta', `${min1.toFixed(3)}ms`)
@@ -87,8 +87,8 @@ export class HistoryCompareFormatter implements HistoryFormatter<CompareResult>
         );
 
         // Max - highlight higher number
-        const max1 = comparison.run1!.max / 1000000;
-        const max2 = comparison.run2!.max / 1000000;
+        const max1 = comparison.run1!.max / 1_000_000;
+        const max2 = comparison.run2!.max / 1_000_000;
         const maxHigher = max2 > max1;
         const max1Str = maxHigher
           ? colorize('magenta', `${max1.toFixed(3)}ms`)

package/src/formatters/history/show.ts

@@ -148,8 +148,8 @@ const formatTime = (ns: number): string => {
   if (ns < 1000) {
     return `${ns.toFixed(2)}ns`;
   }
-  if (ns < 1000000) {
+  if (ns < 1_000_000) {
     return `${(ns / 1000).toFixed(3)}µs`;
   }
-  return `${(ns / 1000000).toFixed(3)}ms`;
+  return `${(ns / 1_000_000).toFixed(3)}ms`;
 };

package/src/formatters/history/trends.ts

@@ -24,7 +24,7 @@ const NS_PER_MS = 1_000_000;
 /**
  * Nanoseconds per microsecond conversion constant
  */
-const NS_PER_US = 1_000;
+const NS_PER_US = 1000;
 
 /**
  * Intelligently format a time range with appropriate precision Displays

package/src/reporters/human.ts

@@ -234,7 +234,7 @@ export class HumanReporter extends BaseReporter {
       );
     }
     this.printLine(
-      `${this.colorize('cyan', ansiChars.approx + ' Duration:')} ${this.colorize('brightWhite', BaseReporter.formatDuration(duration * 1000000))}`,
+      `${this.colorize('cyan', ansiChars.approx + ' Duration:')} ${this.colorize('brightWhite', BaseReporter.formatDuration(duration * 1_000_000))}`,
     );
     this.printLine();
 
@@ -463,7 +463,7 @@ export class HumanReporter extends BaseReporter {
       });
 
       const durationStr = BaseReporter.formatDuration(
-        result.duration * 1000000,
+        result.duration * 1_000_000,
       );
 
       // Display suite setup failure
@@ -487,7 +487,9 @@ export class HumanReporter extends BaseReporter {
     const passed = result.tasks.filter((t) => !t.error && !t.aborted).length;
     const failed = result.tasks.filter((t) => t.error).length;
     const aborted = result.tasks.filter((t) => t.aborted).length;
-    const durationStr = BaseReporter.formatDuration(result.duration * 1000000); // ms to ns
+    const durationStr = BaseReporter.formatDuration(
+      result.duration * 1_000_000,
+    ); // ms to ns
 
     // Build summary parts
     const parts: string[] = [];

package/src/reporters/nyan.ts

@@ -345,7 +345,7 @@ export class NyanReporter extends BaseReporter {
    */
   private printEpilogue(run: BenchmarkRun): void {
     const duration = Date.now() - this.startTime;
-    const durationStr = BaseReporter.formatDuration(duration * 1000000);
+    const durationStr = BaseReporter.formatDuration(duration * 1_000_000);
 
     console.log();
     console.log(

package/src/services/budget-evaluator.ts

@@ -37,10 +37,10 @@ export class BudgetEvaluator {
    * Format time in nanoseconds to human-readable string
    */
   private static formatTime(this: void, nanoseconds: number): string {
-    if (nanoseconds < 1_000) {
+    if (nanoseconds < 1000) {
       return `${nanoseconds.toFixed(0)}ns`;
     } else if (nanoseconds < 1_000_000) {
-      return `${(nanoseconds / 1_000).toFixed(2)}μs`;
+      return `${(nanoseconds / 1000).toFixed(2)}μs`;
     } else if (nanoseconds < 1_000_000_000) {
       return `${(nanoseconds / 1_000_000).toFixed(2)}ms`;
     } else {

package/src/services/config-manager.ts

@@ -63,7 +63,7 @@ const DEFAULT_CONFIG: ModestBenchConfig = {
   tags: [],
   thresholds: {},
   time: 1000, // 1 second minimum for tinybench to gather samples
-  timeout: 30000, // 30 seconds
+  timeout: 30_000, // 30 seconds
   verbose: false, // No verbose output by default
   warmup: 30, // Light warmup by default - enough for basic JIT optimization
 };
@@ -291,7 +291,7 @@ export class ModestBenchConfigurationManager implements ConfigurationManager {
       }
 
       // Warn about potentially long runtime
-      if (validConfig.iterations > 1000 && validConfig.time > 60000) {
+      if (validConfig.iterations > 1000 && validConfig.time > 60_000) {
         warnings.push({
           code: 'LONG_RUNTIME_WARNING',
           file: 'configuration',

package/src/services/profiler/profile-runner.ts

@@ -26,17 +26,32 @@ interface RunOptions {
   timeout?: number;
 }
 
+/**
+ * Node.js major version number
+ */
+const nodeMajorVersion = Number(process.versions.node.split('.')[0]);
+
 /**
  * Run a command with Node.js profiling enabled
  *
  * @param command - Command to run (e.g., "npm test")
  * @param options - Execution options
  * @returns Path to generated *.cpuprofile file
+ * @throws Error if running on Node.js 20 (--cpu-prof not allowed in
+ *   NODE_OPTIONS)
  */
 export const runWithProfiling = async (
   command: string,
   options: RunOptions = {},
 ): Promise<string> => {
+  // Node.js 20 blocks --cpu-prof in NODE_OPTIONS for security reasons
+  if (nodeMajorVersion === 20) {
+    throw new Error(
+      'CPU profiling requires Node.js 22 or later. ' +
+        'Node.js 20 blocks --cpu-prof in NODE_OPTIONS for security reasons.',
+    );
+  }
+
   const cwd = options.cwd || process.cwd();
 
   // Create profiles directory

package/src/services/reporter-registry.ts

@@ -39,12 +39,12 @@ export abstract class BaseReporter implements Reporter {
   protected static formatDuration(this: void, nanoseconds: number): string {
     if (nanoseconds < 1000) {
       return `${nanoseconds.toFixed(2)}ns`;
-    } else if (nanoseconds < 1000000) {
+    } else if (nanoseconds < 1_000_000) {
       return `${(nanoseconds / 1000).toFixed(2)}μs`;
-    } else if (nanoseconds < 1000000000) {
-      return `${(nanoseconds / 1000000).toFixed(2)}ms`;
+    } else if (nanoseconds < 1_000_000_000) {
+      return `${(nanoseconds / 1_000_000).toFixed(2)}ms`;
     } else {
-      return `${(nanoseconds / 1000000000).toFixed(2)}s`;
+      return `${(nanoseconds / 1_000_000_000).toFixed(2)}s`;
     }
   }
 
@@ -57,12 +57,12 @@ export abstract class BaseReporter implements Reporter {
   ): string {
     if (opsPerSecond < 1000) {
       return `${opsPerSecond.toFixed(2)} ops/sec`;
-    } else if (opsPerSecond < 1000000) {
+    } else if (opsPerSecond < 1_000_000) {
       return `${(opsPerSecond / 1000).toFixed(2)}K ops/sec`;
-    } else if (opsPerSecond < 1000000000) {
-      return `${(opsPerSecond / 1000000).toFixed(2)}M ops/sec`;
+    } else if (opsPerSecond < 1_000_000_000) {
+      return `${(opsPerSecond / 1_000_000).toFixed(2)}M ops/sec`;
     } else {
-      return `${(opsPerSecond / 1000000000).toFixed(2)}B ops/sec`;
+      return `${(opsPerSecond / 1_000_000_000).toFixed(2)}B ops/sec`;
     }
   }