mod-build 3.6.66-beta.1 → 3.6.66

package/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## 3.6.66
 
-- Updating our `grab-cdn` task to pull down `quote-jornaya.html` for modernize pages (as we will be loading these all locally now as well).
+- Adjusting the `mergeDefaultFormFieldConfig()` for the accessible configuration so it merges the values correctly.
 
 ## 3.6.65
 

package/gulp-tasks/grab-cdn.js

@@ -42,16 +42,12 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 			'/quote/resources/shared-resources/templates/modals/faq/': ['/resources/templates/modals/faq/', 'index.html']
 		})
 
+		Object.assign(externalResources, {'/quote/resources/mod-site/templates/scripts/jornaya.html': ['/templates/scripts/', 'jornaya.html']});
+
 		if (isModWhiteLabel || domainHasModernize) {
 			Object.assign(externalResources, {'/quote/resources/mod-site/templates/scripts/recaptcha.html': ['/templates/scripts/', 'recaptcha.html']});
 		}
 
-		if (domainHasModernize) {
-			Object.assign(externalResources, {'/quote/resources/mod-site/templates/scripts/quote-jornaya.html': ['/templates/scripts/', 'quote-jornaya.html']});
-		} else {
-			Object.assign(externalResources, {'/quote/resources/mod-site/templates/scripts/jornaya.html': ['/templates/scripts/', 'jornaya.html']});
-		}
-
 		// local dev files
 		const remoteFilesForLocalDev = {
 			'/quote/resources/mod-site/scripts/vendor/maxmind-geoip2.js': ['/temp/scripts/', 'maxmind-geoip2.js']

package/gulp-tasks/templates.js

@@ -167,24 +167,34 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 		}
 	];
 
-	var mergeDefaultFormFieldConfig = function(steps, defaultConfig, folder) {
+	var mergeDefaultFormFieldConfig = function(steps, defaultConfig) {
 		if (!steps.items) {
 			console.error('No items[ ] found in steps{}!');
 			return steps;
 		}
-		steps.items.forEach(item => {
-			if (item.fields) {
-				item.fields = item.fields.map(field => {
-					if (folder === 'shared-components' && field.name && defaultConfig[field.name]) {
-						field = Object.assign(defaultConfig[field.name], field);
-					}
-					if (folder === 'accessible-components' && field.attributes && field.attributes.name && defaultConfig[field.attributes.name]) {
-						field = merge(defaultConfig[field.attributes.name], field);
-					}
-					return field;
-				});
-			}
-		});
+		if (templatesData.siteData && templatesData.siteData.useAccessibleConfig) {
+			steps.items.forEach(item => {
+				if (item.stepContent.fields) {
+					item.stepContent.fields = item.stepContent.fields.map(field => {
+						if (field.attributes && field.attributes.name && defaultConfig[field.attributes.name]) {
+							field = merge(defaultConfig[field.attributes.name], field);
+						}
+						return field;
+					});
+				}
+			});
+		} else {
+			steps.items.forEach(item => {
+				if (item.fields) {
+					item.fields = item.fields.map(field => {
+						if (field.name && defaultConfig[field.name]) {
+							field = Object.assign(defaultConfig[field.name], field);
+						}
+						return field;
+					});
+				}
+			});
+		}
 
 		return steps;
 	};
@@ -201,13 +211,13 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 				const defaultConfig = await JSON.parse(response);
 
 				if (templatesData.steps) {
-					templatesData.steps = await mergeDefaultFormFieldConfig(templatesData.steps, defaultConfig, folder);
+					templatesData.steps = await mergeDefaultFormFieldConfig(templatesData.steps, defaultConfig);
 				}
 				if (templatesData.qsSteps) {
-					templatesData.qsSteps = await mergeDefaultFormFieldConfig(templatesData.qsSteps, defaultConfig, folder);
+					templatesData.qsSteps = await mergeDefaultFormFieldConfig(templatesData.qsSteps, defaultConfig);
 				}
 				if (templatesData.modSteps) {
-					templatesData.modSteps = await mergeDefaultFormFieldConfig(templatesData.modSteps, defaultConfig, folder);
+					templatesData.modSteps = await mergeDefaultFormFieldConfig(templatesData.modSteps, defaultConfig);
 				}
 
 				templatesData.defaultConfigCompleted = true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mod-build",
-  "version": "3.6.66-beta.1",
+  "version": "3.6.66",
   "description": "Share components for S3 sites.",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",