mod-build 3.6.61-beta.8 → 3.6.61

package/CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ## 3.6.61
 
-- Adding the accessible components to the `grab-shared-components` task; As well as pulling the accessible `defaultFormFieldConfig` for the new template.js configuration (& merging to the new template stucture appropriately);
+- added functionality to increase the fileInclude maxRecursion value from site level
+- fixed bug in `templates` task. Noticed that the task was not completing as expected.
 
 ## 3.6.60
 

package/gulp-tasks/grab-shared-components.js

@@ -1,33 +1,31 @@
 var request = require('request');
 var source = require('vinyl-source-stream');
 
-function streamSharedCompsToDestination(gulp, siteSettings, folder, fileName) {
-	return new Promise(resolve => {
-		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/${folder}/${fileName}`)
+function streamSharedCompsToDestination(gulp, siteSettings, fileName) {
+	return new Promise(resolve => { // eslint-disable-line no-undef
+		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/shared-components/${fileName}`)
 			.on('response', resp => {
 				if (resp.statusCode !== 200) {
 					throw new Error(`${resp.statusCode} Error while fetching ${fileName}`);
 				}
 			})
 			.pipe(source(fileName))
-			.pipe(gulp.dest(`${siteSettings.srcFolder}/${folder}/`))
+			.pipe(gulp.dest(`${siteSettings.srcFolder}/shared-components/`))
 			.on('finish', resolve);
 	});
 }
 
-function getListOfSharedComponents(gulp, gulpPlugins, siteSettings, componentFolders) {
-	return componentFolders.map(folder => {
-		return new Promise(resolve => {
-			request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/${folder}/all.json`, function(err, resp, body) {
-				if (resp.statusCode !== 200) {
-					throw new Error(`${resp.statusCode}: Error while fetching ${folder}/all.json`);
-				}
-				var listOfComponents = JSON.parse(body);
-				const componentPromises = listOfComponents.map(function(resource) {
-					return streamSharedCompsToDestination(gulp, siteSettings, folder, `${resource}`);
-				});
-				resolve(Promise.all(componentPromises));
+function getListOfSharedComponents(gulp, gulpPlugins, siteSettings) {
+	return new Promise(resolve => { // eslint-disable-line no-undef
+		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/shared-components/all.json`, function(err, resp, body) {
+			if (resp.statusCode !== 200) {
+				throw new Error(`${resp.statusCode}: Error while fetching shared-components/all.json`);
+			}
+			var listOfComponents = JSON.parse(body);
+			const componentPromises = listOfComponents.map(function(resource) {
+				return streamSharedCompsToDestination(gulp, siteSettings, `${resource}`);
 			});
+			resolve(Promise.all(componentPromises)); // eslint-disable-line no-undef
 		});
 	});
 }
@@ -39,8 +37,6 @@ module.exports = function(gulp, gulpPlugins, siteSettings) {
 			throw new Error('Missing environment variables. Did you start with gulp instead of npm run...?');
 		}
 
-		const componentFolders = ['shared-components', 'accessible-components']
-
-		return getListOfSharedComponents(gulp, gulpPlugins, siteSettings, componentFolders);
+		return getListOfSharedComponents(gulp, gulpPlugins, siteSettings); // eslint-disable-line no-undef
 	};
 };

package/gulp-tasks/templates.js

@@ -65,7 +65,7 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 			name: 'xif',
 			fn: function(expression, options) {
 				return handlebarsX(expression, this, options) ? options.fn(this) : options.inverse(this);
-			},
+			}
 		},
 		// Reverse array
 		{
@@ -167,7 +167,7 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 		}
 	];
 
-	var mergeDefaultFormFieldConfig = function(steps, defaultConfig, folder) {
+	var mergeDefaultFormFieldConfig = function(steps, defaultConfig) {
 		if (!steps.items) {
 			console.error('No items[ ] found in steps{}!');
 			return steps;
@@ -175,12 +175,9 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 		steps.items.forEach(item => {
 			if (item.fields) {
 				item.fields = item.fields.map(field => {
-					if (folder === 'shared-components' && field.name && defaultConfig[field.name]) {
+					if (field.name && defaultConfig[field.name]) {
 						field = Object.assign(defaultConfig[field.name], field);
 					}
-					if (folder === 'accessible-components' && field.attributes && field.attributes.name && defaultConfig[field.attributes.name]) {
-						field = merge(defaultConfig[field.attributes.name], field);
-					}
 					return field;
 				});
 			}
@@ -189,25 +186,25 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 		return steps;
 	};
 
-	var getDefaultFormFieldConfig = async function(folder) {
+	var getDefaultFormFieldConfig = async function() {
 		console.time('Finished fetch-default-form-config after');
 		console.log('Starting fetch-default-form-config: ');
 		await new Promise((resolve) => {
-			request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/${folder}/steps/defaultFormFieldConfig.json`, async function(err, xhr, response) {
+			request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/shared-components/steps/defaultFormFieldConfig.json`, async function(err, xhr, response) {
 				if (xhr.statusCode !== 200) {
-					throw new Error(`${xhr.statusCode}: Error while fetching ${folder}/defaultFormFieldConfig.json`);
+					throw new Error(`${xhr.statusCode}: Error while fetching shared-components/defaultFormFieldConfig.json`);
 				}
 
 				const defaultConfig = await JSON.parse(response);
 
 				if (templatesData.steps) {
-					templatesData.steps = await mergeDefaultFormFieldConfig(templatesData.steps, defaultConfig, folder);
+					templatesData.steps = await mergeDefaultFormFieldConfig(templatesData.steps, defaultConfig);
 				}
 				if (templatesData.qsSteps) {
-					templatesData.qsSteps = await mergeDefaultFormFieldConfig(templatesData.qsSteps, defaultConfig, folder);
+					templatesData.qsSteps = await mergeDefaultFormFieldConfig(templatesData.qsSteps, defaultConfig);
 				}
 				if (templatesData.modSteps) {
-					templatesData.modSteps = await mergeDefaultFormFieldConfig(templatesData.modSteps, defaultConfig, folder);
+					templatesData.modSteps = await mergeDefaultFormFieldConfig(templatesData.modSteps, defaultConfig);
 				}
 
 				templatesData.defaultConfigCompleted = true;
@@ -234,9 +231,8 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 					throw new Error(`${xhr.statusCode}: Error while fetching TCPA`);
 				}
 				const responseJson = await JSON.parse(response);
-				let finalTCPA = await (company === 'Modernize' || templatesData.useModernizeInTCPA) ? responseJson.tcpa.replace(/QuinStreet/g, 'Modernize') : responseJson.tcpa;
-				const removeInlineStyleRegex = / style="[^"]*"/g;
-				finalTCPA = finalTCPA.replace(removeInlineStyleRegex, '');
+				const finalTCPA = await (company === 'Modernize' || templatesData.useModernizeInTCPA) ? responseJson.tcpa.replace(/QuinStreet/g, 'Modernize') : responseJson.tcpa;
+
 				templatesData.tcpaText = await finalTCPA;
 
 				resolve();
@@ -248,11 +244,7 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 	return async function() {
 		if (Object.keys(siteData).length > 0) {
 			if (!templatesData.doNotUseDefaultFieldConfig && !templatesData.defaultConfigCompleted) {
-				if (templatesData.siteData.useAccessibleFormConfig) {
-					await getDefaultFormFieldConfig('accessible-components');
-				} else {
-					await getDefaultFormFieldConfig('shared-components');
-				}
+				await getDefaultFormFieldConfig();
 			}
 
 			if (!templatesData.tcpaText && templatesData.primary_trade) {
@@ -260,14 +252,19 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 			}
 		}
 
-		return gulp.src([
-			siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/**/*.html',
-			'!' + siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/_partials/**/*.html'
-		])
-			.pipe(gulpPlugins.handlebarsFileInclude(templatesData, {
-				maxRecursion: 500,
-				handlebarsHelpers: handlebarsHelpers
-			}))
-			.pipe(gulp.dest(siteSettings.tmpFolder));
+		return new Promise(function(resolve) {
+			return gulp.src([
+				siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/**/*.html',
+				'!' + siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/_partials/**/*.html'
+			])
+				.pipe(gulpPlugins.handlebarsFileInclude(templatesData, {
+					maxRecursion: siteData.fileIncludeMaxRecursion ? siteData.fileIncludeMaxRecursion : 500,
+					handlebarsHelpers: handlebarsHelpers
+				}))
+				.pipe(gulp.dest(siteSettings.tmpFolder))
+				.on('finish', function() {
+					resolve();
+				});
+		});
 	};
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mod-build",
-  "version": "3.6.61-beta.8",
+  "version": "3.6.61",
   "description": "Share components for S3 sites.",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",