mod-build 3.6.61-beta.1 → 3.6.61-beta.2

package/CHANGELOG.md

@@ -1,9 +1,8 @@
 # Changelog
 
-## 3.6.61
+## 3.6.60
 
-- added functionality to increase the fileInclude maxRecursion value from site level
-- fixed bug in `templates` task. It was not completing as expected.
+- Adding consoles allllll throughout the `grab-shared-scripts` task. It is still breaking down somewhere; and the first step to trying to force-fail our builds is figure out where the issue is
 
 ## 3.6.59
 
@@ -19,6 +18,7 @@
 - adding `!window.Modalytics.privacyPreferencesDetected` conditional to check privacy settings to not load Heap for modernize.com
 
 ## 3.6.55
+
 - Added conditional to check if `siteData` is empty — so our  `fetchTcpaFromSitegenie()` and `getDefaultFormFieldConfig()` functions won't try to run on modify.modernize.com
 
 ## 3.6.54

package/gulp-tasks/grab-shared-components.js

@@ -1,31 +1,33 @@
 var request = require('request');
 var source = require('vinyl-source-stream');
 
-function streamSharedCompsToDestination(gulp, siteSettings, fileName) {
-	return new Promise(resolve => { // eslint-disable-line no-undef
-		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/shared-components/${fileName}`)
+function streamSharedCompsToDestination(gulp, siteSettings, folder, fileName) {
+	return new Promise(resolve => {
+		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/${folder}/${fileName}`)
 			.on('response', resp => {
 				if (resp.statusCode !== 200) {
 					throw new Error(`${resp.statusCode} Error while fetching ${fileName}`);
 				}
 			})
 			.pipe(source(fileName))
-			.pipe(gulp.dest(`${siteSettings.srcFolder}/shared-components/`))
+			.pipe(gulp.dest(`${siteSettings.srcFolder}/${folder}/`))
 			.on('finish', resolve);
 	});
 }
 
-function getListOfSharedComponents(gulp, gulpPlugins, siteSettings) {
-	return new Promise(resolve => { // eslint-disable-line no-undef
-		request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/shared-components/all.json`, function(err, resp, body) {
-			if (resp.statusCode !== 200) {
-				throw new Error(`${resp.statusCode}: Error while fetching shared-components/all.json`);
-			}
-			var listOfComponents = JSON.parse(body);
-			const componentPromises = listOfComponents.map(function(resource) {
-				return streamSharedCompsToDestination(gulp, siteSettings, `${resource}`);
+function getListOfSharedComponents(gulp, gulpPlugins, siteSettings, componentFolders) {
+	return componentFolders.map(folder => {
+		return new Promise(resolve => {
+			request(`https://${siteSettings.nodeEnv}/quote/resources/mod-site/${folder}/all.json`, function(err, resp, body) {
+				if (resp.statusCode !== 200) {
+					throw new Error(`${resp.statusCode}: Error while fetching ${folder}/all.json`);
+				}
+				var listOfComponents = JSON.parse(body);
+				const componentPromises = listOfComponents.map(function(resource) {
+					return streamSharedCompsToDestination(gulp, siteSettings, folder, `${resource}`);
+				});
+				resolve(Promise.all(componentPromises));
 			});
-			resolve(Promise.all(componentPromises)); // eslint-disable-line no-undef
 		});
 	});
 }
@@ -37,6 +39,8 @@ module.exports = function(gulp, gulpPlugins, siteSettings) {
 			throw new Error('Missing environment variables. Did you start with gulp instead of npm run...?');
 		}
 
-		return getListOfSharedComponents(gulp, gulpPlugins, siteSettings); // eslint-disable-line no-undef
+		const componentFolders = ['shared-components', 'accessible-components']
+
+		return getListOfSharedComponents(gulp, gulpPlugins, siteSettings, componentFolders);
 	};
 };

package/gulp-tasks/grab-shared-scripts.js

@@ -21,26 +21,30 @@ var pathSubdirectory = '';
 
 function replaceModalyticsSrc(gulp, gulpPlugins, siteSettings, siteData) {
   const resourcePath = isQuotePageOrUseRelativePath ? `${pathSubdirectory}{{#if this.src}}{{this.src}}{{/if}}resources/scripts/mod-alytics/` : '/resources/scripts/mod-alytics/';
+  console.log(`>> VARIABLE modAlyticsFileName = ${fileNames.modAlyticsFileName}`)
   return gulp.src(siteSettings.srcFolder + '/shared-components/head/head.html')
     .pipe(replace(/".*(modalytics).*"/, `"${resourcePath}${fileNames.modAlyticsFileName}"`))
     .pipe(gulp.dest(siteSettings.srcFolder + '/shared-components/head'));
 }
 function replaceFootAssetScripts(gulp, gulpPlugins, siteSettings, siteData) {
-  console.log('>> STARTING Replacing Foot Asset Scripts');
+  console.log('>> STARTING replacing foot asset scripts');
   const resourcePath = isQuotePageOrUseRelativePath ? `${pathSubdirectory}{{#if this.nodeModulesPath}}{{this.nodeModulesPath}}{{/if}}resources/scripts` : '/resources/scripts';
   return gulp.src(siteSettings.srcFolder + '/shared-components/foot-assets/foot-assets.html')
   .pipe(replace(/"(?:(?!"|js")[\s\S])+(modutils|mod-utils.*?)js"|"(?:(?!"|")[\s\S])+(footer\/footer-component.*?)js"|"(?:(?!"|")[\s\S])+(mod-form\/form.*?)js"/g, function(match) {
       if (match.includes('mod-form/form')) {
+        console.log(`>> VARIABLE homeownerFormFileName = ${fileNames.homeownerFormFileName}`);
         return `"${resourcePath}/mod-form/form/${fileNames.homeownerFormFileName}"`;
       } else if (match.includes('modutils') || match.includes('mod-utils')) {
+        console.log(`>> VARIABLE modUtilsFileName = ${fileNames.modUtilsFileName}`)
         return `"${resourcePath}/mod-utils/${fileNames.modUtilsFileName}"`;
       } else if (match.includes('footer-component')) {
+        console.log(`>> VARIABLE footerComponentJsFileName = ${fileNames.footerComponentJsFileName}`)
         return `"${resourcePath}/footer/${fileNames.footerComponentJsFileName}"`;
       }
     }))
     .pipe(gulp.dest(siteSettings.srcFolder + '/shared-components/foot-assets'))
     .on('end', function() {
-      console.log('>> FINISHED Replacing Foot Asset Scripts');
+      console.log('>> FINISHED replacing foot asset scripts');
     });
 }
 function replaceAbandonmentJsCssSrc(gulp, gulpPlugins, siteSettings, siteData) {
@@ -52,6 +56,8 @@ function replaceAbandonmentJsCssSrc(gulp, gulpPlugins, siteSettings, siteData) {
     .pipe(gulp.dest(siteSettings.srcFolder + '/templates/abandonment'));
 }
 function replaceFooterStylesReference(gulp, gulpPlugins, siteSettings, siteData) {
+  console.log(`>> VARIABLE modFooterStylesFileName (main styles) = ${fileNames.modFooterStylesFileName}`)
+  console.log(`>> VARIABLE qsFooterStylesFileName (main styles) = ${fileNames.qsFooterStylesFileName}`)
   if (siteData.siteData && siteData.siteData.useRelativePathForResources === true) {
     return gulp.src(siteSettings.srcFolder + '/resources/scripts/footer/' + fileNames.footerComponentJsFileName)
       .pipe(replace(/concat\((?:(?!concat\(|\))[\s\S])+(components\/footer\/mod.*?)\)/, `concat("${pathSubdirectory}resources/styles/components/footer/` + fileNames.modFooterStylesFileName + '")'))
@@ -65,6 +71,8 @@ function replaceFooterStylesReference(gulp, gulpPlugins, siteSettings, siteData)
   }
 }
 function replaceFooterStylesReferenceInMap(gulp, gulpPlugins, siteSettings, siteData) {
+  console.log(`>> VARIABLE modFooterStylesFileName (map styles) = ${fileNames.modFooterStylesFileName}`)
+  console.log(`>> VARIABLE qsFooterStylesFileName (map styles) = ${fileNames.qsFooterStylesFileName}`)
   if (siteData.siteData && siteData.siteData.useRelativePathForResources === true) {
     return gulp.src(siteSettings.srcFolder + '/resources/scripts/footer/footer-component.min.js.map')
       .pipe(replace(/\`(?:(?!\`|\`)[\s\S])+(components\/footer\/mod.*?)\`/, '`' + pathSubdirectory + 'resources/styles/components/footer/' + fileNames.modFooterStylesFileName + '`'))
@@ -125,7 +133,10 @@ function getResource(url, config = {}, fn, fnArray) {
         })
         .pipe(source(file))
         .pipe(config.gulp.dest(`${config.siteSettings.srcFolder}/resources/${config.dest}`))
-        .on('finish', resolve);
+        .on('finish', function(){
+          console.log(`>> SUCCESSFULLY copied map file = ${file}`);
+          resolve();
+        });
     });
   })
   .then(() => {
@@ -242,7 +253,14 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
         });
       }
 
-      return Promise.all(getAllResources);
+      return Promise.all(getAllResources)
+      .then(() => {
+        console.log(`>> FILENAMES object = ${JSON.stringify(fileNames)}`);
+        return gulp.src(siteSettings.srcFolder + '/shared-components/foot-assets/foot-assets.html')
+        .on('data', function (file) {
+          console.log(`>> FOOT ASSETS HTML = ${file.contents.toString()}`);
+        });
+      })
     }());
   };
 };

package/gulp-tasks/templates.js

@@ -252,20 +252,14 @@ module.exports = function(gulp, gulpPlugins, siteSettings, siteData) {
 			}
 		}
 
-		return new Promise(function(resolve) {
-			return gulp.src([
-				siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/**/*.html',
-				'!' + siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/_partials/**/*.html'
-			])
-				.pipe(gulpPlugins.handlebarsFileInclude(templatesData, {
-					maxRecursion: siteData.fileIncludeMaxRecursion ? siteData.fileIncludeMaxRecursion : 500,
-					handlebarsHelpers: handlebarsHelpers
-				}))
-				.pipe(gulp.dest(siteSettings.tmpFolder))
-				.on('finish', function() {
-					resolve();
-					console.log('Templates completed')
-				});
-		});
+		return gulp.src([
+			siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/**/*.html',
+			'!' + siteSettings.srcFolder + '/' + siteSettings.templatesSubfolder + '/_partials/**/*.html'
+		])
+			.pipe(gulpPlugins.handlebarsFileInclude(templatesData, {
+				maxRecursion: 500,
+				handlebarsHelpers: handlebarsHelpers
+			}))
+			.pipe(gulp.dest(siteSettings.tmpFolder));
 	};
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mod-build",
-  "version": "3.6.61-beta.1",
+  "version": "3.6.61-beta.2",
   "description": "Share components for S3 sites.",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",