mocha 9.0.2 → 9.0.3

package/CHANGELOG.md

@@ -1,3 +1,13 @@
+# 9.0.3 / 2021-07-25
+
+## :bug: Fixes
+
+- [#4702](https://github.com/mochajs/mocha/issues/4702): Error rethrow from cwd-relative path while loading `.mocharc.js` ([**@kirill-golovan**](https://github.com/kirill-golovan))
+
+- [#4688](https://github.com/mochajs/mocha/issues/4688): Usage of custom interface in parallel mode ([**@juergba**](https://github.com/juergba))
+
+- [#4687](https://github.com/mochajs/mocha/issues/4687): ESM: don't swallow `MODULE_NOT_FOUND` errors in case of `type:module` ([**@giltayar**](https://github.com/giltayar))
+
 # 9.0.2 / 2021-07-03
 
 ## :bug: Fixes

package/lib/cli/config.js

@@ -31,7 +31,7 @@ exports.CONFIG_FILES = [
 ];
 
 const isModuleNotFoundError = err =>
-  err.code !== 'MODULE_NOT_FOUND' ||
+  err.code === 'MODULE_NOT_FOUND' ||
   err.message.indexOf('Cannot find module') !== -1;
 
 /**

package/lib/cli/run-helpers.js

@@ -195,10 +195,10 @@ exports.runMocha = async (mocha, options) => {
  * it actually exists. This must be run _after_ requires are processed (see
  * {@link handleRequires}), as it'll prevent interfaces from loading otherwise.
  * @param {Object} opts - Options object
- * @param {"reporter"|"interface"} pluginType - Type of plugin.
- * @param {Object} [map] - An object perhaps having key `key`. Used as a cache
- * of sorts; `Mocha.reporters` is one, where each key corresponds to a reporter
- * name
+ * @param {"reporter"|"ui"} pluginType - Type of plugin.
+ * @param {Object} [map] - Used as a cache of sorts;
+ * `Mocha.reporters` where each key corresponds to a reporter name,
+ * `Mocha.interfaces` where each key corresponds to an interface name.
  * @private
  */
 exports.validateLegacyPlugin = (opts, pluginType, map = {}) => {
@@ -226,12 +226,12 @@ exports.validateLegacyPlugin = (opts, pluginType, map = {}) => {
   // if this exists, then it's already loaded, so nothing more to do.
   if (!map[pluginId]) {
     try {
-      opts[pluginType] = require(pluginId);
+      map[pluginId] = require(pluginId);
     } catch (err) {
       if (err.code === 'MODULE_NOT_FOUND') {
         // Try to load reporters from a path (absolute or relative)
         try {
-          opts[pluginType] = require(path.resolve(pluginId));
+          map[pluginId] = require(path.resolve(pluginId));
         } catch (err) {
           throw createUnknownError(err);
         }

package/lib/errors.js

@@ -328,7 +328,7 @@ function createFatalError(message, value) {
 /**
  * Dynamically creates a plugin-type-specific error based on plugin type
  * @param {string} message - Error message
- * @param {"reporter"|"interface"} pluginType - Plugin type. Future: expand as needed
+ * @param {"reporter"|"ui"} pluginType - Plugin type. Future: expand as needed
  * @param {string} [pluginId] - Name/path of plugin, if any
  * @throws When `pluginType` is not known
  * @public
@@ -339,7 +339,7 @@ function createInvalidLegacyPluginError(message, pluginType, pluginId) {
   switch (pluginType) {
     case 'reporter':
       return createInvalidReporterError(message, pluginId);
-    case 'interface':
+    case 'ui':
       return createInvalidInterfaceError(message, pluginId);
     default:
       throw new Error('unknown pluginType "' + pluginType + '"');

package/lib/esm-utils.js

@@ -52,7 +52,21 @@ exports.requireOrImport = hasStableEsmImplementation
           err.code === 'ERR_UNKNOWN_FILE_EXTENSION' ||
           err.code === 'ERR_UNSUPPORTED_DIR_IMPORT'
         ) {
-          return require(file);
+          try {
+            return require(file);
+          } catch (requireErr) {
+            if (requireErr.code === 'ERR_REQUIRE_ESM') {
+              // This happens when the test file is a JS file, but via type:module is actually ESM,
+              // AND has an import to a file that doesn't exist.
+              // This throws an `ERR_MODULE_NOT_FOUND` // error above,
+              // and when we try to `require` it here, it throws an `ERR_REQUIRE_ESM`.
+              // What we want to do is throw the original error (the `ERR_MODULE_NOT_FOUND`),
+              // and not the `ERR_REQUIRE_ESM` error, which is a red herring.
+              throw err;
+            } else {
+              throw requireErr;
+            }
+          }
         } else {
           throw err;
         }

package/mocha-es2018.js

@@ -1,4 +1,4 @@
-// mocha@9.0.2 in javascript ES2018
+// mocha@9.0.3 in javascript ES2018
 (function (global, factory) {
   typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
   typeof define === 'function' && define.amd ? define(factory) :
@@ -11432,7 +11432,7 @@
   /**
    * Dynamically creates a plugin-type-specific error based on plugin type
    * @param {string} message - Error message
-   * @param {"reporter"|"interface"} pluginType - Plugin type. Future: expand as needed
+   * @param {"reporter"|"ui"} pluginType - Plugin type. Future: expand as needed
    * @param {string} [pluginId] - Name/path of plugin, if any
    * @throws When `pluginType` is not known
    * @public
@@ -11443,7 +11443,7 @@
     switch (pluginType) {
       case 'reporter':
         return createInvalidReporterError(message, pluginId);
-      case 'interface':
+      case 'ui':
         return createInvalidInterfaceError(message, pluginId);
       default:
         throw new Error('unknown pluginType "' + pluginType + '"');
@@ -17025,7 +17025,7 @@
   });
 
   var name = "mocha";
-  var version = "9.0.2";
+  var version = "9.0.3";
   var homepage = "https://mochajs.org/";
   var notifyLogo = "https://ibin.co/4QuRuGjXvl36.png";
   var _package = {

package/mocha.js

@@ -1,4 +1,4 @@
-// mocha@9.0.2 transpiled to javascript ES5
+// mocha@9.0.3 transpiled to javascript ES5
 (function (global, factory) {
 	typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
 	typeof define === 'function' && define.amd ? define(factory) :
@@ -21866,7 +21866,7 @@
 	/**
 	 * Dynamically creates a plugin-type-specific error based on plugin type
 	 * @param {string} message - Error message
-	 * @param {"reporter"|"interface"} pluginType - Plugin type. Future: expand as needed
+	 * @param {"reporter"|"ui"} pluginType - Plugin type. Future: expand as needed
 	 * @param {string} [pluginId] - Name/path of plugin, if any
 	 * @throws When `pluginType` is not known
 	 * @public
@@ -21880,7 +21880,7 @@
 	    case 'reporter':
 	      return createInvalidReporterError(message, pluginId);
 
-	    case 'interface':
+	    case 'ui':
 	      return createInvalidInterfaceError(message, pluginId);
 
 	    default:
@@ -27544,7 +27544,7 @@
 	});
 
 	var name = "mocha";
-	var version = "9.0.2";
+	var version = "9.0.3";
 	var homepage = "https://mochajs.org/";
 	var notifyLogo = "https://ibin.co/4QuRuGjXvl36.png";
 	var _package = {