mobygate 0.6.1 → 0.6.2

package/CHANGELOG.md

@@ -4,6 +4,26 @@ All notable changes to mobygate are documented here. Format loosely follows
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); version numbers are
 [Semantic Versioning](https://semver.org/).
 
+## [0.6.2] — 2026-04-24
+
+### Fixed
+
+- **Update on Windows failed with `EBUSY` after the npm-spawn fix**
+  in v0.6.1 because the running mobygate Node process holds open
+  file handles inside its own install dir
+  (`...\AppData\Roaming\npm\node_modules\mobygate`). When `npm install -g`
+  tries to atomically rename the directory, Windows refuses — POSIX
+  systems can replace open files, Windows can't.
+- **Fix:** stop the service *before* running npm install, then start
+  on the new build. Affects both `mobygate update` (CLI) and the
+  dashboard `/update/apply` endpoint. The detached update child
+  survives because we spawn it with `detached: true` +
+  `windowsHide: true`, putting it in its own console group
+  independent of the parent that gets killed.
+- POSIX systems now also stop-then-start (instead of unload-load /
+  restart), purely for symmetry and a cleaner log progression. No
+  behavior change there.
+
 ## [0.6.1] — 2026-04-24
 
 ### Fixed

package/bin/mobygate.js

@@ -581,6 +581,25 @@ async function cmdUpdate() {
   }
   print('');
 
+  // ---- Stop the service FIRST on Windows, otherwise running Node holds
+  // open file handles inside the install dir and `npm install -g` fails
+  // with EBUSY when it tries to rename the directory. On macOS/Linux we
+  // can replace open files freely, but stopping early there too is harmless
+  // and gives a cleaner restart sequence — so we do it everywhere.
+  let stoppedForUpdate = false;
+  if (IS_WIN) {
+    info('Stopping service so npm install can replace files...');
+    stopWindowsTask(WIN_LABELS.server);
+    stoppedForUpdate = true;
+  } else if (IS_MAC) {
+    const p = plistPathForLabel(SERVER_LABEL);
+    launchctlUnload(p);
+    stoppedForUpdate = true;
+  } else if (IS_LINUX) {
+    stopLinuxUnit(LINUX_UNITS.server);
+    stoppedForUpdate = true;
+  }
+
   // ---- Perform the upgrade
   if (mode === 'npm') {
     info(`Running \`npm install -g mobygate@latest\`...`);
@@ -599,19 +618,19 @@ async function cmdUpdate() {
     return die(`Install mode is "${mode}" — can't auto-update. Reinstall via npm or git.`);
   }
 
-  // ---- Restart the managed service so the new code is running
+  // ---- Bring the service back up on the new code
   section('Restart');
-  info('Restarting service so the new build is running...');
+  info('Starting service on the new build...');
   if (IS_MAC) {
     const p = plistPathForLabel(SERVER_LABEL);
-    launchctlUnload(p); launchctlLoad(p);
-    ok(`Reloaded ${SERVER_LABEL}`);
+    launchctlLoad(p);
+    ok(`Loaded ${SERVER_LABEL}`);
   } else if (IS_WIN) {
-    stopWindowsTask(WIN_LABELS.server); startWindowsTask(WIN_LABELS.server);
-    ok(`Restarted ${WIN_LABELS.server}`);
+    startWindowsTask(WIN_LABELS.server);
+    ok(`Started ${WIN_LABELS.server}`);
   } else if (IS_LINUX) {
-    stopLinuxUnit(LINUX_UNITS.server); startLinuxUnit(LINUX_UNITS.server);
-    ok(`Restarted ${LINUX_UNITS.server}`);
+    startLinuxUnit(LINUX_UNITS.server);
+    ok(`Started ${LINUX_UNITS.server}`);
   }
   print('');
   info(`Tip: if the install-layout changed (new service file, new paths), run \`mobygate init\` to re-install the service definitions.`);

package/lib/updater.js

@@ -160,6 +160,16 @@ function writeUpdateState(patch) {
  * Build the shell command that performs update + restart. Returned as a
  * single string we can hand to `sh -c` / `cmd /c`. Written as a string
  * (not an array) because we want shell redirection for log capture.
+ *
+ * Order of operations matters on Windows: the running mobygate process
+ * holds open file handles inside its own install dir (`...\node_modules\mobygate`),
+ * so `npm install -g` fails with EBUSY when it tries to rename the dir.
+ * Fix: stop the service FIRST (which kills our parent), then install,
+ * then start. The detached child survives because we spawn with
+ * `detached: true` + `windowsHide: true`, putting it in its own console
+ * group independent of the parent. POSIX systems can replace open files
+ * freely, but stopping early there too is harmless and gives a cleaner
+ * "off → install → on" sequence in the log.
  */
 function buildUpdateCommand({ mode, repoRoot, logPath }) {
   if (IS_WIN) {
@@ -167,6 +177,11 @@ function buildUpdateCommand({ mode, repoRoot, logPath }) {
     // line so failures short-circuit via `||`.
     const steps = [];
     steps.push(`echo [mobygate-update] start at %DATE% %TIME%`);
+    // Stop FIRST so npm can replace files without EBUSY. /F forces close
+    // even if the process is mid-request; the SDK session map writes are
+    // synchronous and the SIGTERM handler flushes before exit.
+    steps.push(`echo [mobygate-update] stopping service`);
+    steps.push(`schtasks /End /TN "${WIN_SERVER_TASK}"`);
     if (mode === 'npm') {
       steps.push(`npm install -g mobygate@latest`);
     } else if (mode === 'git') {
@@ -175,15 +190,22 @@ function buildUpdateCommand({ mode, repoRoot, logPath }) {
       steps.push(`npm install`);
     }
     steps.push(`echo [mobygate-update] restarting service`);
-    steps.push(`schtasks /End   /TN "${WIN_SERVER_TASK}"`);
-    steps.push(`schtasks /Run   /TN "${WIN_SERVER_TASK}"`);
+    steps.push(`schtasks /Run /TN "${WIN_SERVER_TASK}"`);
     steps.push(`echo [mobygate-update] done`);
     // Join with && so any failure stops the chain. Final redirect to log.
     const inner = steps.map((s) => `(${s})`).join(' && ');
     return { shell: 'cmd', cmd: `${inner} >> "${logPath}" 2>&1` };
   }
-  // POSIX: sh -c, bail-on-first-failure via set -e
+  // POSIX: sh -c, bail-on-first-failure via set -e. Stop service first
+  // for the same reason — symmetry, cleaner restart, no harm.
   const parts = [`set -e`, `echo "[mobygate-update] start $(date)"`];
+  parts.push(`echo "[mobygate-update] stopping service"`);
+  if (IS_MAC) {
+    const plist = join(process.env.HOME || '~', 'Library', 'LaunchAgents', `${SERVER_LABEL}.plist`);
+    parts.push(`launchctl unload "${plist}" 2>/dev/null || true`);
+  } else if (IS_LINUX) {
+    parts.push(`systemctl --user stop ${LINUX_SERVER_UNIT} 2>/dev/null || true`);
+  }
   if (mode === 'npm') {
     parts.push(`npm install -g mobygate@latest`);
   } else if (mode === 'git') {
@@ -191,14 +213,12 @@ function buildUpdateCommand({ mode, repoRoot, logPath }) {
     parts.push(`git pull --ff-only`);
     parts.push(`npm install`);
   }
-  parts.push(`echo "[mobygate-update] restarting service"`);
+  parts.push(`echo "[mobygate-update] starting service on new build"`);
   if (IS_MAC) {
     const plist = join(process.env.HOME || '~', 'Library', 'LaunchAgents', `${SERVER_LABEL}.plist`);
-    // unload may fail if not loaded — tolerate that specific case
-    parts.push(`launchctl unload "${plist}" 2>/dev/null || true`);
-    parts.push(`launchctl load   "${plist}"`);
+    parts.push(`launchctl load "${plist}"`);
   } else if (IS_LINUX) {
-    parts.push(`systemctl --user restart ${LINUX_SERVER_UNIT}`);
+    parts.push(`systemctl --user start ${LINUX_SERVER_UNIT}`);
   }
   parts.push(`echo "[mobygate-update] done"`);
   const script = parts.join('\n');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobygate",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "OpenAI-compatible local proxy for Claude Max. The Möbius-strip gateway: OpenAI shape in, Claude Max out.",
   "type": "module",
   "main": "server.js",