mobx 6.3.7 → 6.3.11

package/CHANGELOG.md

@@ -1,5 +1,33 @@
 # mobx
 
+## 6.3.11
+
+### Patch Changes
+
+-   [`bf5da6ba`](https://github.com/mobxjs/mobx/commit/bf5da6bad982dc3d955d5f27f7fea6f94b041ea7) [#3239](https://github.com/mobxjs/mobx/pull/3239) Thanks [@bernardobelchior](https://github.com/bernardobelchior)! - Improved `toJS` jsdoc
+
+## 6.3.10
+
+### Patch Changes
+
+-   [`2d70798e`](https://github.com/mobxjs/mobx/commit/2d70798eb327187d93757757ceaf410a608735b2) [#3233](https://github.com/mobxjs/mobx/pull/3233) Thanks [@anderlaw](https://github.com/anderlaw)! - `eq.ts` fix comparer logic
+
+## 6.3.9
+
+### Patch Changes
+
+-   [`87e5a037`](https://github.com/mobxjs/mobx/commit/87e5a03735dbc1930e54a15b5ce88ad684bc3dc1) [#3214](https://github.com/mobxjs/mobx/pull/3214) Thanks [@urugator](https://github.com/urugator)! - `requiresReaction` always takes precedence over global `computedRequiresReaction`
+
+*   [`9b90e25c`](https://github.com/mobxjs/mobx/commit/9b90e25c7bc0cdc0a07d1f847683604e86790f24) [#3198](https://github.com/mobxjs/mobx/pull/3198) Thanks [@urugator](https://github.com/urugator)! - fix `isPlainObject` impl (fixes #3197)
+
+## 6.3.8
+
+### Patch Changes
+
+-   [`9d5e65cb`](https://github.com/mobxjs/mobx/commit/9d5e65cbd612f262d925e57cebb559f5cf36c502) [#3193](https://github.com/mobxjs/mobx/pull/3193) Thanks [@ChocolateLoverRaj](https://github.com/ChocolateLoverRaj)! - Make `IAtom['reportObserved']` return `boolean`
+
+*   [`55508af6`](https://github.com/mobxjs/mobx/commit/55508af690fa875e6affaf30f34280b3f27b6126) [#3189](https://github.com/mobxjs/mobx/pull/3189) Thanks [@RvanderLaan](https://github.com/RvanderLaan)! - Fix for RangeError in ObservableArray.replace for large arrays
+
 ## 6.3.7
 
 ### Patch Changes

package/dist/api/tojs.d.ts

@@ -1,4 +1,7 @@
 /**
- * Basically, a deep clone, so that no reactive property will exist anymore.
+ * Recursively converts an observable to it's non-observable native counterpart.
+ * It does NOT recurse into non-observables, these are left as they are, even if they contain observables.
+ * Computed and other non-enumerable properties are completely ignored.
+ * Complex scenarios require custom solution, eg implementing `toJSON` or using `serializr` lib.
  */
 export declare function toJS<T>(source: T, options?: any): T;

package/dist/core/atom.d.ts

@@ -1,7 +1,7 @@
 import { IDerivationState_, IObservable, IDerivation, Lambda } from "../internal";
 export declare const $mobx: unique symbol;
 export interface IAtom extends IObservable {
-    reportObserved(): any;
+    reportObserved(): boolean;
     reportChanged(): any;
 }
 export declare class Atom implements IAtom {

package/dist/mobx.cjs.development.js

@@ -168,12 +168,11 @@ function isObject(value) {
   return value !== null && typeof value === "object";
 }
 function isPlainObject(value) {
-  var _proto$constructor;
-
   if (!isObject(value)) return false;
   var proto = Object.getPrototypeOf(value);
   if (proto == null) return true;
-  return ((_proto$constructor = proto.constructor) == null ? void 0 : _proto$constructor.toString()) === plainObjectString;
+  var protoConstructor = Object.hasOwnProperty.call(proto, "constructor") && proto.constructor;
+  return typeof protoConstructor === "function" && protoConstructor.toString() === plainObjectString;
 } // https://stackoverflow.com/a/37865170
 
 function isGenerator(obj) {
@@ -268,6 +267,9 @@ function _defineProperties(target, props) {
 function _createClass(Constructor, protoProps, staticProps) {
   if (protoProps) _defineProperties(Constructor.prototype, protoProps);
   if (staticProps) _defineProperties(Constructor, staticProps);
+  Object.defineProperty(Constructor, "prototype", {
+    writable: false
+  });
   return Constructor;
 }
 
@@ -292,7 +294,17 @@ function _extends() {
 function _inheritsLoose(subClass, superClass) {
   subClass.prototype = Object.create(superClass.prototype);
   subClass.prototype.constructor = subClass;
-  subClass.__proto__ = superClass;
+
+  _setPrototypeOf(subClass, superClass);
+}
+
+function _setPrototypeOf(o, p) {
+  _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) {
+    o.__proto__ = p;
+    return o;
+  };
+
+  return _setPrototypeOf(o, p);
 }
 
 function _assertThisInitialized(self) {
@@ -321,28 +333,24 @@ function _arrayLikeToArray(arr, len) {
 }
 
 function _createForOfIteratorHelperLoose(o, allowArrayLike) {
-  var it;
-
-  if (typeof Symbol === "undefined" || o[Symbol.iterator] == null) {
-    if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") {
-      if (it) o = it;
-      var i = 0;
-      return function () {
-        if (i >= o.length) return {
-          done: true
-        };
-        return {
-          done: false,
-          value: o[i++]
-        };
+  var it = typeof Symbol !== "undefined" && o[Symbol.iterator] || o["@@iterator"];
+  if (it) return (it = it.call(o)).next.bind(it);
+
+  if (Array.isArray(o) || (it = _unsupportedIterableToArray(o)) || allowArrayLike && o && typeof o.length === "number") {
+    if (it) o = it;
+    var i = 0;
+    return function () {
+      if (i >= o.length) return {
+        done: true
       };
-    }
-
-    throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method.");
+      return {
+        done: false,
+        value: o[i++]
+      };
+    };
   }
 
-  it = o[Symbol.iterator]();
-  return it.next.bind(it);
+  throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method.");
 }
 
 var storedAnnotationsSymbol = /*#__PURE__*/Symbol("mobx-stored-annotations");
@@ -626,7 +634,7 @@ function make_$1(adm, key, descriptor, source) {
   var _this$options_;
 
   // bound
-  if ((_this$options_ = this.options_) == null ? void 0 : _this$options_.bound) {
+  if ((_this$options_ = this.options_) != null && _this$options_.bound) {
     return this.extend_(adm, key, descriptor, false) === null ? 0
     /* Cancel */
     : 1
@@ -684,7 +692,7 @@ safeDescriptors) {
   assertActionDescriptor(adm, annotation, key, descriptor);
   var value = descriptor.value;
 
-  if ((_annotation$options_ = annotation.options_) == null ? void 0 : _annotation$options_.bound) {
+  if ((_annotation$options_ = annotation.options_) != null && _annotation$options_.bound) {
     var _adm$proxy_;
 
     value = value.bind((_adm$proxy_ = adm.proxy_) != null ? _adm$proxy_ : adm.target_);
@@ -692,7 +700,7 @@ safeDescriptors) {
 
   return {
     value: createAction((_annotation$options_$ = (_annotation$options_2 = annotation.options_) == null ? void 0 : _annotation$options_2.name) != null ? _annotation$options_$ : key.toString(), value, (_annotation$options_$2 = (_annotation$options_3 = annotation.options_) == null ? void 0 : _annotation$options_3.autoAction) != null ? _annotation$options_$2 : false, // https://github.com/mobxjs/mobx/discussions/3140
-    ((_annotation$options_4 = annotation.options_) == null ? void 0 : _annotation$options_4.bound) ? (_adm$proxy_2 = adm.proxy_) != null ? _adm$proxy_2 : adm.target_ : undefined),
+    (_annotation$options_4 = annotation.options_) != null && _annotation$options_4.bound ? (_adm$proxy_2 = adm.proxy_) != null ? _adm$proxy_2 : adm.target_ : undefined),
     // Non-configurable for classes
     // prevents accidental field redefinition in subclass
     configurable: safeDescriptors ? adm.isPlainObject_ : true,
@@ -727,7 +735,7 @@ function make_$2(adm, key, descriptor, source) {
   // bound - must annotate protos to support super.flow()
 
 
-  if (((_this$options_ = this.options_) == null ? void 0 : _this$options_.bound) && !isFlow(adm.target_[key])) {
+  if ((_this$options_ = this.options_) != null && _this$options_.bound && !isFlow(adm.target_[key])) {
     if (this.extend_(adm, key, descriptor, false) === null) return 0
     /* Cancel */
     ;
@@ -910,11 +918,11 @@ function make_$5(adm, key, descriptor, source) {
     if (isGenerator(descriptor.value)) {
       var _this$options_;
 
-      var flowAnnotation = ((_this$options_ = this.options_) == null ? void 0 : _this$options_.autoBind) ? flow.bound : flow;
+      var flowAnnotation = (_this$options_ = this.options_) != null && _this$options_.autoBind ? flow.bound : flow;
       return flowAnnotation.make_(adm, key, descriptor, source);
     }
 
-    var actionAnnotation = ((_this$options_2 = this.options_) == null ? void 0 : _this$options_2.autoBind) ? autoAction.bound : autoAction;
+    var actionAnnotation = (_this$options_2 = this.options_) != null && _this$options_2.autoBind ? autoAction.bound : autoAction;
     return actionAnnotation.make_(adm, key, descriptor, source);
   } // other -> observable
   // Copy props from proto as well, see test:
@@ -923,7 +931,7 @@ function make_$5(adm, key, descriptor, source) {
 
   var observableAnnotation = ((_this$options_3 = this.options_) == null ? void 0 : _this$options_3.deep) === false ? observable.ref : observable; // if function respect autoBind option
 
-  if (typeof descriptor.value === "function" && ((_this$options_4 = this.options_) == null ? void 0 : _this$options_4.autoBind)) {
+  if (typeof descriptor.value === "function" && (_this$options_4 = this.options_) != null && _this$options_4.autoBind) {
     var _adm$proxy_;
 
     descriptor.value = descriptor.value.bind((_adm$proxy_ = adm.proxy_) != null ? _adm$proxy_ : adm.target_);
@@ -951,7 +959,7 @@ function extend_$5(adm, key, descriptor, proxyTrap) {
   // if function respect autoBind option
 
 
-  if (typeof descriptor.value === "function" && ((_this$options_5 = this.options_) == null ? void 0 : _this$options_5.autoBind)) {
+  if (typeof descriptor.value === "function" && (_this$options_5 = this.options_) != null && _this$options_5.autoBind) {
     var _adm$proxy_2;
 
     descriptor.value = descriptor.value.bind((_adm$proxy_2 = adm.proxy_) != null ? _adm$proxy_2 : adm.target_);
@@ -1229,7 +1237,7 @@ function allowStateChangesEnd(prev) {
 var _Symbol$toPrimitive;
 var CREATE = "create";
 _Symbol$toPrimitive = Symbol.toPrimitive;
-var ObservableValue = /*#__PURE__*/function (_Atom) {
+var ObservableValue = /*#__PURE__*/function (_Atom, _Symbol$toPrimitive2) {
   _inheritsLoose(ObservableValue, _Atom);
 
   function ObservableValue(value, enhancer, name_, notifySpy, equals) {
@@ -1376,12 +1384,12 @@ var ObservableValue = /*#__PURE__*/function (_Atom) {
     return toPrimitive(this.get());
   };
 
-  _proto[_Symbol$toPrimitive] = function () {
+  _proto[_Symbol$toPrimitive2] = function () {
     return this.valueOf();
   };
 
   return ObservableValue;
-}(Atom);
+}(Atom, _Symbol$toPrimitive);
 var isObservableValue = /*#__PURE__*/createInstanceofPredicate("ObservableValue", ObservableValue);
 
 var _Symbol$toPrimitive$1;
@@ -1406,7 +1414,7 @@ var _Symbol$toPrimitive$1;
  */
 
 _Symbol$toPrimitive$1 = Symbol.toPrimitive;
-var ComputedValue = /*#__PURE__*/function () {
+var ComputedValue = /*#__PURE__*/function (_Symbol$toPrimitive2) {
   // nodes we are looking at. Our value depends on these nodes
   // during tracking it's an array with new observed observers
   // to check for cycles
@@ -1460,7 +1468,7 @@ var ComputedValue = /*#__PURE__*/function () {
 
     this.equals_ = options.equals || (options.compareStructural || options.struct ? comparer.structural : comparer["default"]);
     this.scope_ = options.context;
-    this.requiresReaction_ = !!options.requiresReaction;
+    this.requiresReaction_ = options.requiresReaction;
     this.keepAlive_ = !!options.keepAlive;
   }
 
@@ -1628,7 +1636,7 @@ var ComputedValue = /*#__PURE__*/function () {
       console.log("[mobx.trace] Computed value '" + this.name_ + "' is being read outside a reactive context. Doing a full recompute.");
     }
 
-    if (globalState.computedRequiresReaction || this.requiresReaction_) {
+    if (typeof this.requiresReaction_ === "boolean" ? this.requiresReaction_ : globalState.computedRequiresReaction) {
       console.warn("[mobx] Computed value '" + this.name_ + "' is being read outside a reactive context. Doing a full recompute.");
     }
   };
@@ -1641,12 +1649,12 @@ var ComputedValue = /*#__PURE__*/function () {
     return toPrimitive(this.get());
   };
 
-  _proto[_Symbol$toPrimitive$1] = function () {
+  _proto[_Symbol$toPrimitive2] = function () {
     return this.valueOf();
   };
 
   return ComputedValue;
-}();
+}(_Symbol$toPrimitive$1);
 var isComputedValue = /*#__PURE__*/createInstanceofPredicate("ComputedValue", ComputedValue);
 
 var IDerivationState_;
@@ -2187,8 +2195,8 @@ function propagateChangeConfirmed(observable) {
       }
     } else if (d.dependenciesState_ === IDerivationState_.UP_TO_DATE_ // this happens during computing of `d`, just keep lowestObserverState up to date.
     ) {
-        observable.lowestObserverState_ = IDerivationState_.UP_TO_DATE_;
-      }
+      observable.lowestObserverState_ = IDerivationState_.UP_TO_DATE_;
+    }
   }); // invariantLOS(observable, "confirmed end");
 } // Used by computed when its dependency changed, but we don't wan't to immediately recompute.
 
@@ -3216,7 +3224,10 @@ function toJSHelper(source, __alreadySeen) {
   }
 }
 /**
- * Basically, a deep clone, so that no reactive property will exist anymore.
+ * Recursively converts an observable to it's non-observable native counterpart.
+ * It does NOT recurse into non-observables, these are left as they are, even if they contain observables.
+ * Computed and other non-enumerable properties are completely ignored.
+ * Complex scenarios require custom solution, eg implementing `toJSON` or using `serializr` lib.
  */
 
 
@@ -3683,9 +3694,12 @@ var ObservableArrayAdministration = /*#__PURE__*/function () {
 
       return (_this$values_ = this.values_).splice.apply(_this$values_, [index, deleteCount].concat(newItems));
     } else {
-      var res = this.values_.slice(index, index + deleteCount);
-      var oldItems = this.values_.slice(index + deleteCount);
-      this.values_.length = index + newItems.length - deleteCount;
+      // The items removed by the splice
+      var res = this.values_.slice(index, index + deleteCount); // The items that that should remain at the end of the array
+
+      var oldItems = this.values_.slice(index + deleteCount); // New length is the previous length + addition count - deletion count
+
+      this.values_.length += newItems.length - deleteCount;
 
       for (var i = 0; i < newItems.length; i++) {
         this.values_[index + i] = newItems[i];
@@ -4002,7 +4016,7 @@ var DELETE = "delete"; // just extend Map? See also https://gist.github.com/nest
 
 _Symbol$iterator = Symbol.iterator;
 _Symbol$toStringTag = Symbol.toStringTag;
-var ObservableMap = /*#__PURE__*/function () {
+var ObservableMap = /*#__PURE__*/function (_Symbol$iterator2, _Symbol$toStringTag2) {
   // hasMap, not hashMap >-).
   function ObservableMap(initialData, enhancer_, name_) {
     if (enhancer_ === void 0) {
@@ -4108,7 +4122,8 @@ var ObservableMap = /*#__PURE__*/function () {
         name: key
       } : null;
 
-      if ( notifySpy) spyReportStart(_change);
+      if ( notifySpy) spyReportStart(_change); // TODO fix type
+
       transaction(function () {
         var _this2$hasMap_$get;
 
@@ -4146,7 +4161,8 @@ var ObservableMap = /*#__PURE__*/function () {
         name: key,
         newValue: newValue
       } : null;
-      if ( notifySpy) spyReportStart(change);
+      if ( notifySpy) spyReportStart(change); // TODO fix type
+
       observable.setNewValue_(newValue);
       if (notify) notifyListeners(this, change);
       if ( notifySpy) spyReportEnd();
@@ -4180,7 +4196,8 @@ var ObservableMap = /*#__PURE__*/function () {
       name: key,
       newValue: newValue
     } : null;
-    if ( notifySpy) spyReportStart(change);
+    if ( notifySpy) spyReportStart(change); // TODO fix type
+
     if (notify) notifyListeners(this, change);
     if ( notifySpy) spyReportEnd();
   };
@@ -4237,7 +4254,7 @@ var ObservableMap = /*#__PURE__*/function () {
     });
   };
 
-  _proto[_Symbol$iterator] = function () {
+  _proto[_Symbol$iterator2] = function () {
     return this.entries();
   };
 
@@ -4417,14 +4434,14 @@ var ObservableMap = /*#__PURE__*/function () {
       return this.data_.size;
     }
   }, {
-    key: _Symbol$toStringTag,
+    key: _Symbol$toStringTag2,
     get: function get() {
       return "Map";
     }
   }]);
 
   return ObservableMap;
-}(); // eslint-disable-next-line
+}(_Symbol$iterator, _Symbol$toStringTag); // eslint-disable-next-line
 
 var isObservableMap = /*#__PURE__*/createInstanceofPredicate("ObservableMap", ObservableMap);
 
@@ -4450,7 +4467,7 @@ var _Symbol$iterator$1, _Symbol$toStringTag$1;
 var ObservableSetMarker = {};
 _Symbol$iterator$1 = Symbol.iterator;
 _Symbol$toStringTag$1 = Symbol.toStringTag;
-var ObservableSet = /*#__PURE__*/function () {
+var ObservableSet = /*#__PURE__*/function (_Symbol$iterator2, _Symbol$toStringTag2) {
   function ObservableSet(initialData, enhancer, name_) {
     if (enhancer === void 0) {
       enhancer = deepEnhancer;
@@ -4683,7 +4700,7 @@ var ObservableSet = /*#__PURE__*/function () {
     return "[object ObservableSet]";
   };
 
-  _proto[_Symbol$iterator$1] = function () {
+  _proto[_Symbol$iterator2] = function () {
     return this.values();
   };
 
@@ -4694,14 +4711,14 @@ var ObservableSet = /*#__PURE__*/function () {
       return this.data_.size;
     }
   }, {
-    key: _Symbol$toStringTag$1,
+    key: _Symbol$toStringTag2,
     get: function get() {
       return "Set";
     }
   }]);
 
   return ObservableSet;
-}(); // eslint-disable-next-line
+}(_Symbol$iterator$1, _Symbol$toStringTag$1); // eslint-disable-next-line
 
 var isObservableSet = /*#__PURE__*/createInstanceofPredicate("ObservableSet", ObservableSet);
 
@@ -4887,7 +4904,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
       // When called from super() some props may not exist yet.
       // However we don't have to worry about missing prop,
       // because the decorator must have been applied to something.
-      if ((_this$target_$storedA = this.target_[storedAnnotationsSymbol]) == null ? void 0 : _this$target_$storedA[key]) {
+      if ((_this$target_$storedA = this.target_[storedAnnotationsSymbol]) != null && _this$target_$storedA[key]) {
         return; // will be annotated by subclass constructor
       } else {
         die(1, annotation.annotationType_, this.name_ + "." + key.toString());
@@ -5391,7 +5408,7 @@ inherit(StubArray, Array.prototype); // Weex proto freeze protection was here,
 // but it is unclear why the hack is need as MobX never changed the prototype
 // anyway, so removed it in V6
 
-var LegacyObservableArray = /*#__PURE__*/function (_StubArray) {
+var LegacyObservableArray = /*#__PURE__*/function (_StubArray, _Symbol$toStringTag, _Symbol$iterator) {
   _inheritsLoose(LegacyObservableArray, _StubArray);
 
   function LegacyObservableArray(initialValues, enhancer, name, owned) {
@@ -5436,7 +5453,7 @@ var LegacyObservableArray = /*#__PURE__*/function (_StubArray) {
     }));
   };
 
-  _proto[Symbol.iterator] = function () {
+  _proto[_Symbol$iterator] = function () {
     var self = this;
     var nextIndex = 0;
     return makeIterable({
@@ -5462,14 +5479,14 @@ var LegacyObservableArray = /*#__PURE__*/function (_StubArray) {
       this[$mobx].setArrayLength_(newLength);
     }
   }, {
-    key: Symbol.toStringTag,
+    key: _Symbol$toStringTag,
     get: function get() {
       return "Array";
     }
   }]);
 
   return LegacyObservableArray;
-}(StubArray);
+}(StubArray, Symbol.toStringTag, Symbol.iterator);
 
 Object.entries(arrayExtensions).forEach(function (_ref) {
   var prop = _ref[0],
@@ -5592,7 +5609,7 @@ function eq(a, b, depth, aStack, bStack) {
   if (a !== a) return b !== b; // Exhaust primitive checks
 
   var type = typeof a;
-  if (!isFunction(type) && type !== "object" && typeof b != "object") return false; // Compare `[[Class]]` names.
+  if (type !== "function" && type !== "object" && typeof b != "object") return false; // Compare `[[Class]]` names.
 
   var className = toString.call(a);
   if (className !== toString.call(b)) return false;