mobx 6.3.4 → 6.3.8

package/dist/mobx.umd.development.js

@@ -1541,22 +1541,21 @@
         /* see #1208 */
         this.dependenciesState_ === IDerivationState_.NOT_TRACKING_;
         var newValue = this.computeValue_(true);
-
-        if ( isSpyEnabled()) {
-          spyReport({
-            observableKind: "computed",
-            debugObjectName: this.name_,
-            object: this.scope_,
-            type: "update",
-            oldValue: this.value_,
-            newValue: newValue
-          });
-        }
-
         var changed = wasSuspended || isCaughtException(oldValue) || isCaughtException(newValue) || !this.equals_(oldValue, newValue);
 
         if (changed) {
           this.value_ = newValue;
+
+          if ( isSpyEnabled()) {
+            spyReport({
+              observableKind: "computed",
+              debugObjectName: this.name_,
+              object: this.scope_,
+              type: "update",
+              oldValue: oldValue,
+              newValue: newValue
+            });
+          }
         }
 
         return changed;
@@ -2655,8 +2654,7 @@
       var firstTime = true;
       var isScheduled = false;
       var value;
-      var oldValue = undefined; // only an issue with fireImmediately
-
+      var oldValue;
       var equals = opts.compareStructural ? comparer.structural : opts.equals || comparer["default"];
       var r = new Reaction(name, function () {
         if (firstTime || runSync) {
@@ -3329,7 +3327,7 @@
 
         cancel = function cancel() {
           disposer();
-          reject("WHEN_CANCELLED");
+          reject(new Error("WHEN_CANCELLED"));
         };
       });
       res.cancel = cancel;
@@ -3460,7 +3458,11 @@
       try {
         var _annotations;
 
-        // Default to decorators
+        if ("development" !== "production" && annotations && target[storedAnnotationsSymbol]) {
+          die("makeObservable second arg must be nullish when using decorators. Mixing @decorator syntax with annotations is not supported.");
+        } // Default to decorators
+
+
         (_annotations = annotations) != null ? _annotations : annotations = collectStoredAnnotations(target); // Annotate
 
         ownKeys(annotations).forEach(function (key) {
@@ -3683,9 +3685,12 @@
 
           return (_this$values_ = this.values_).splice.apply(_this$values_, [index, deleteCount].concat(newItems));
         } else {
-          var res = this.values_.slice(index, index + deleteCount);
-          var oldItems = this.values_.slice(index + deleteCount);
-          this.values_.length = index + newItems.length - deleteCount;
+          // The items removed by the splice
+          var res = this.values_.slice(index, index + deleteCount); // The items that that should remain at the end of the array
+
+          var oldItems = this.values_.slice(index + deleteCount); // New length is the previous length + addition count - deletion count
+
+          this.values_.length += newItems.length - deleteCount;
 
           for (var i = 0; i < newItems.length; i++) {
             this.values_[index + i] = newItems[i];