mobx 6.3.3 → 6.3.7

package/dist/mobx.umd.development.js

@@ -677,7 +677,7 @@
 
     function createActionDescriptor(adm, annotation, key, descriptor, // provides ability to disable safeDescriptors for prototypes
     safeDescriptors) {
-      var _annotation$options_, _annotation$options_$, _annotation$options_2, _annotation$options_$2, _annotation$options_3;
+      var _annotation$options_, _annotation$options_$, _annotation$options_2, _annotation$options_$2, _annotation$options_3, _annotation$options_4, _adm$proxy_2;
 
       if (safeDescriptors === void 0) {
         safeDescriptors = globalState.safeDescriptors;
@@ -693,7 +693,8 @@
       }
 
       return {
-        value: createAction((_annotation$options_$ = (_annotation$options_2 = annotation.options_) == null ? void 0 : _annotation$options_2.name) != null ? _annotation$options_$ : key.toString(), value, (_annotation$options_$2 = (_annotation$options_3 = annotation.options_) == null ? void 0 : _annotation$options_3.autoAction) != null ? _annotation$options_$2 : false),
+        value: createAction((_annotation$options_$ = (_annotation$options_2 = annotation.options_) == null ? void 0 : _annotation$options_2.name) != null ? _annotation$options_$ : key.toString(), value, (_annotation$options_$2 = (_annotation$options_3 = annotation.options_) == null ? void 0 : _annotation$options_3.autoAction) != null ? _annotation$options_$2 : false, // https://github.com/mobxjs/mobx/discussions/3140
+        ((_annotation$options_4 = annotation.options_) == null ? void 0 : _annotation$options_4.bound) ? (_adm$proxy_2 = adm.proxy_) != null ? _adm$proxy_2 : adm.target_ : undefined),
         // Non-configurable for classes
         // prevents accidental field redefinition in subclass
         configurable: safeDescriptors ? adm.isPlainObject_ : true,
@@ -1540,22 +1541,21 @@
         /* see #1208 */
         this.dependenciesState_ === IDerivationState_.NOT_TRACKING_;
         var newValue = this.computeValue_(true);
-
-        if ( isSpyEnabled()) {
-          spyReport({
-            observableKind: "computed",
-            debugObjectName: this.name_,
-            object: this.scope_,
-            type: "update",
-            oldValue: this.value_,
-            newValue: newValue
-          });
-        }
-
         var changed = wasSuspended || isCaughtException(oldValue) || isCaughtException(newValue) || !this.equals_(oldValue, newValue);
 
         if (changed) {
           this.value_ = newValue;
+
+          if ( isSpyEnabled()) {
+            spyReport({
+              observableKind: "computed",
+              debugObjectName: this.name_,
+              object: this.scope_,
+              type: "update",
+              oldValue: oldValue,
+              newValue: newValue
+            });
+          }
         }
 
         return changed;
@@ -1974,6 +1974,8 @@
       if (global.__mobxGlobals && global.__mobxGlobals.version !== new MobXGlobals().version) canMergeGlobalState = false;
 
       if (!canMergeGlobalState) {
+        // Because this is a IIFE we need to let isolateCalled a chance to change
+        // so we run it after the event loop completed at least 1 iteration
         setTimeout(function () {
           if (!isolateCalled) {
             die(35);
@@ -2221,8 +2223,7 @@
         return;
       }
 
-      lines.push("" + new Array(depth).join("\t") + tree.name); // MWE: not the fastest, but the easiest way :)
-
+      lines.push("" + "\t".repeat(depth - 1) + tree.name);
       if (tree.dependencies) tree.dependencies.forEach(function (child) {
         return printDepTree(child, lines, depth + 1);
       });
@@ -2653,8 +2654,7 @@
       var firstTime = true;
       var isScheduled = false;
       var value;
-      var oldValue = undefined; // only an issue with fireImmediately
-
+      var oldValue;
       var equals = opts.compareStructural ? comparer.structural : opts.equals || comparer["default"];
       var r = new Reaction(name, function () {
         if (firstTime || runSync) {
@@ -2770,7 +2770,7 @@
         if (arguments.length > 4) die("'extendObservable' expected 2-4 arguments");
         if (typeof target !== "object") die("'extendObservable' expects an object as first argument");
         if (isObservableMap(target)) die("'extendObservable' should not be used on maps, use map.merge instead");
-        if (!isPlainObject(properties)) die("'extendObservabe' only accepts plain objects as second argument");
+        if (!isPlainObject(properties)) die("'extendObservable' only accepts plain objects as second argument");
         if (isObservable(properties) || isObservable(annotations)) die("Extending an object with another observable (object) is not supported");
       } // Pull descriptors first, so we don't have to deal with props added by administration ($mobx)
 
@@ -2961,14 +2961,14 @@
     }
 
     function _isComputed(value, property) {
-      if (property !== undefined) {
-        if (isObservableObject(value) === false) return false;
-        if (!value[$mobx].values_.has(property)) return false;
-        var atom = getAtom(value, property);
-        return isComputedValue(atom);
+      if (property === undefined) {
+        return isComputedValue(value);
       }
 
-      return isComputedValue(value);
+      if (isObservableObject(value) === false) return false;
+      if (!value[$mobx].values_.has(property)) return false;
+      var atom = getAtom(value, property);
+      return isComputedValue(atom);
     }
     function isComputed(value) {
       if ( arguments.length > 1) return die("isComputed expects only 1 argument. Use isComputedProp to inspect the observability of a property");
@@ -3327,7 +3327,7 @@
 
         cancel = function cancel() {
           disposer();
-          reject("WHEN_CANCELLED");
+          reject(new Error("WHEN_CANCELLED"));
         };
       });
       res.cancel = cancel;
@@ -3458,7 +3458,11 @@
       try {
         var _annotations;
 
-        // Default to decorators
+        if ("development" !== "production" && annotations && target[storedAnnotationsSymbol]) {
+          die("makeObservable second arg must be nullish when using decorators. Mixing @decorator syntax with annotations is not supported.");
+        } // Default to decorators
+
+
         (_annotations = annotations) != null ? _annotations : annotations = collectStoredAnnotations(target); // Annotate
 
         ownKeys(annotations).forEach(function (key) {
@@ -3619,7 +3623,7 @@
       };
 
       _proto.setArrayLength_ = function setArrayLength_(newLength) {
-        if (typeof newLength !== "number" || newLength < 0) die("Out of range: " + newLength);
+        if (typeof newLength !== "number" || isNaN(newLength) || newLength < 0) die("Out of range: " + newLength);
         var currentLength = this.values_.length;
         if (newLength === currentLength) return;else if (newLength > currentLength) {
           var newItems = new Array(newLength - currentLength);
@@ -4108,9 +4112,11 @@
 
           if ( notifySpy) spyReportStart(_change);
           transaction(function () {
+            var _this2$hasMap_$get;
+
             _this2.keysAtom_.reportChanged();
 
-            _this2.updateHasMapEntry_(key, false);
+            (_this2$hasMap_$get = _this2.hasMap_.get(key)) == null ? void 0 : _this2$hasMap_$get.setNewValue_(false);
 
             var observable = _this2.data_.get(key);
 
@@ -4126,14 +4132,6 @@
         return false;
       };
 
-      _proto.updateHasMapEntry_ = function updateHasMapEntry_(key, value) {
-        var entry = this.hasMap_.get(key);
-
-        if (entry) {
-          entry.setNewValue_(value);
-        }
-      };
-
       _proto.updateValue_ = function updateValue_(key, newValue) {
         var observable = this.data_.get(key);
         newValue = observable.prepareNewValue_(newValue);
@@ -4162,13 +4160,15 @@
 
         checkIfStateModificationsAreAllowed(this.keysAtom_);
         transaction(function () {
+          var _this3$hasMap_$get;
+
           var observable = new ObservableValue(newValue, _this3.enhancer_,  _this3.name_ + "." + stringifyKey(key) , false);
 
           _this3.data_.set(key, observable);
 
           newValue = observable.value_; // value might have been changed
 
-          _this3.updateHasMapEntry_(key, true);
+          (_this3$hasMap_$get = _this3.hasMap_.get(key)) == null ? void 0 : _this3$hasMap_$get.setNewValue_(true);
 
           _this3.keysAtom_.reportChanged();
         });