mobx 6.3.2 → 6.3.6

package/dist/mobx.umd.development.js

@@ -516,7 +516,8 @@
     }
 
     function defaultComparer(a, b) {
-      return Object.is(a, b);
+      if (Object.is) return Object.is(a, b);
+      return a === b ? a !== 0 || 1 / a === 1 / b : a !== a && b !== b;
     }
 
     var comparer = {
@@ -676,7 +677,7 @@
 
     function createActionDescriptor(adm, annotation, key, descriptor, // provides ability to disable safeDescriptors for prototypes
     safeDescriptors) {
-      var _annotation$options_, _annotation$options_$, _annotation$options_2, _annotation$options_$2, _annotation$options_3;
+      var _annotation$options_, _annotation$options_$, _annotation$options_2, _annotation$options_$2, _annotation$options_3, _annotation$options_4, _adm$proxy_2;
 
       if (safeDescriptors === void 0) {
         safeDescriptors = globalState.safeDescriptors;
@@ -692,7 +693,8 @@
       }
 
       return {
-        value: createAction((_annotation$options_$ = (_annotation$options_2 = annotation.options_) == null ? void 0 : _annotation$options_2.name) != null ? _annotation$options_$ : key.toString(), value, (_annotation$options_$2 = (_annotation$options_3 = annotation.options_) == null ? void 0 : _annotation$options_3.autoAction) != null ? _annotation$options_$2 : false),
+        value: createAction((_annotation$options_$ = (_annotation$options_2 = annotation.options_) == null ? void 0 : _annotation$options_2.name) != null ? _annotation$options_$ : key.toString(), value, (_annotation$options_$2 = (_annotation$options_3 = annotation.options_) == null ? void 0 : _annotation$options_3.autoAction) != null ? _annotation$options_$2 : false, // https://github.com/mobxjs/mobx/discussions/3140
+        ((_annotation$options_4 = annotation.options_) == null ? void 0 : _annotation$options_4.bound) ? (_adm$proxy_2 = adm.proxy_) != null ? _adm$proxy_2 : adm.target_ : undefined),
         // Non-configurable for classes
         // prevents accidental field redefinition in subclass
         configurable: safeDescriptors ? adm.isPlainObject_ : true,
@@ -961,6 +963,10 @@
       return observableAnnotation.extend_(adm, key, descriptor, proxyTrap);
     }
 
+    var OBSERVABLE = "observable";
+    var OBSERVABLE_REF = "observable.ref";
+    var OBSERVABLE_SHALLOW = "observable.shallow";
+    var OBSERVABLE_STRUCT = "observable.struct"; // Predefined bags of create observable options, to avoid allocating temporarily option objects
     // in the majority of cases
 
     var defaultCreateObservableOptions = {
@@ -973,14 +979,14 @@
     function asCreateObservableOptions(thing) {
       return thing || defaultCreateObservableOptions;
     }
-    var observableAnnotation = /*#__PURE__*/createObservableAnnotation("observable");
-    var observableRefAnnotation = /*#__PURE__*/createObservableAnnotation("observable.ref", {
+    var observableAnnotation = /*#__PURE__*/createObservableAnnotation(OBSERVABLE);
+    var observableRefAnnotation = /*#__PURE__*/createObservableAnnotation(OBSERVABLE_REF, {
       enhancer: referenceEnhancer
     });
-    var observableShallowAnnotation = /*#__PURE__*/createObservableAnnotation("observable.shallow", {
+    var observableShallowAnnotation = /*#__PURE__*/createObservableAnnotation(OBSERVABLE_SHALLOW, {
       enhancer: shallowEnhancer
     });
-    var observableStructAnnotation = /*#__PURE__*/createObservableAnnotation("observable.struct", {
+    var observableStructAnnotation = /*#__PURE__*/createObservableAnnotation(OBSERVABLE_STRUCT, {
       enhancer: refStructEnhancer
     });
     var observableDecoratorAnnotation = /*#__PURE__*/createDecoratorAnnotation(observableAnnotation);
@@ -1535,22 +1541,21 @@
         /* see #1208 */
         this.dependenciesState_ === IDerivationState_.NOT_TRACKING_;
         var newValue = this.computeValue_(true);
-
-        if ( isSpyEnabled()) {
-          spyReport({
-            observableKind: "computed",
-            debugObjectName: this.name_,
-            object: this.scope_,
-            type: "update",
-            oldValue: this.value_,
-            newValue: newValue
-          });
-        }
-
         var changed = wasSuspended || isCaughtException(oldValue) || isCaughtException(newValue) || !this.equals_(oldValue, newValue);
 
         if (changed) {
           this.value_ = newValue;
+
+          if ( isSpyEnabled()) {
+            spyReport({
+              observableKind: "computed",
+              debugObjectName: this.name_,
+              object: this.scope_,
+              type: "update",
+              oldValue: oldValue,
+              newValue: newValue
+            });
+          }
         }
 
         return changed;
@@ -1585,6 +1590,10 @@
         if (!this.keepAlive_) {
           clearObserving(this);
           this.value_ = undefined; // don't hold on to computed value!
+
+          if ( this.isTracing_ !== TraceMode.NONE) {
+            console.log("[mobx.trace] Computed value '" + this.name_ + "' was suspended and it will recompute on the next access.");
+          }
         }
       };
 
@@ -1617,16 +1626,12 @@
 
       _proto.warnAboutUntrackedRead_ = function warnAboutUntrackedRead_() {
 
-        if (this.requiresReaction_ === true) {
-          die("[mobx] Computed value " + this.name_ + " is read outside a reactive context");
-        }
-
         if (this.isTracing_ !== TraceMode.NONE) {
-          console.log("[mobx.trace] '" + this.name_ + "' is being read outside a reactive context. Doing a full recompute");
+          console.log("[mobx.trace] Computed value '" + this.name_ + "' is being read outside a reactive context. Doing a full recompute.");
         }
 
-        if (globalState.computedRequiresReaction) {
-          console.warn("[mobx] Computed value " + this.name_ + " is being read outside a reactive context. Doing a full recompute");
+        if (globalState.computedRequiresReaction || this.requiresReaction_) {
+          console.warn("[mobx] Computed value '" + this.name_ + "' is being read outside a reactive context. Doing a full recompute.");
         }
       };
 
@@ -1759,7 +1764,7 @@
     }
     function checkIfStateReadsAreAllowed(observable) {
       if ( !globalState.allowStateReads && globalState.observableRequiresReaction) {
-        console.warn("[mobx] Observable " + observable.name_ + " being read outside a reactive context");
+        console.warn("[mobx] Observable '" + observable.name_ + "' being read outside a reactive context.");
       }
     }
     /**
@@ -1803,7 +1808,7 @@
       if (derivation.observing_.length !== 0) return;
 
       if (globalState.reactionRequiresObservable || derivation.requiresObservable_) {
-        console.warn("[mobx] Derivation " + derivation.name_ + " is created/updated without reading any observable value");
+        console.warn("[mobx] Derivation '" + derivation.name_ + "' is created/updated without reading any observable value.");
       }
     }
     /**
@@ -1969,6 +1974,8 @@
       if (global.__mobxGlobals && global.__mobxGlobals.version !== new MobXGlobals().version) canMergeGlobalState = false;
 
       if (!canMergeGlobalState) {
+        // Because this is a IIFE we need to let isolateCalled a chance to change
+        // so we run it after the event loop completed at least 1 iteration
         setTimeout(function () {
           if (!isolateCalled) {
             die(35);
@@ -2216,8 +2223,7 @@
         return;
       }
 
-      lines.push("" + new Array(depth).join("\t") + tree.name); // MWE: not the fastest, but the easiest way :)
-
+      lines.push("" + "\t".repeat(depth - 1) + tree.name);
       if (tree.dependencies) tree.dependencies.forEach(function (child) {
         return printDepTree(child, lines, depth + 1);
       });
@@ -2648,8 +2654,7 @@
       var firstTime = true;
       var isScheduled = false;
       var value;
-      var oldValue = undefined; // only an issue with fireImmediately
-
+      var oldValue;
       var equals = opts.compareStructural ? comparer.structural : opts.equals || comparer["default"];
       var r = new Reaction(name, function () {
         if (firstTime || runSync) {
@@ -2765,7 +2770,7 @@
         if (arguments.length > 4) die("'extendObservable' expected 2-4 arguments");
         if (typeof target !== "object") die("'extendObservable' expects an object as first argument");
         if (isObservableMap(target)) die("'extendObservable' should not be used on maps, use map.merge instead");
-        if (!isPlainObject(properties)) die("'extendObservabe' only accepts plain objects as second argument");
+        if (!isPlainObject(properties)) die("'extendObservable' only accepts plain objects as second argument");
         if (isObservable(properties) || isObservable(annotations)) die("Extending an object with another observable (object) is not supported");
       } // Pull descriptors first, so we don't have to deal with props added by administration ($mobx)
 
@@ -2956,14 +2961,14 @@
     }
 
     function _isComputed(value, property) {
-      if (property !== undefined) {
-        if (isObservableObject(value) === false) return false;
-        if (!value[$mobx].values_.has(property)) return false;
-        var atom = getAtom(value, property);
-        return isComputedValue(atom);
+      if (property === undefined) {
+        return isComputedValue(value);
       }
 
-      return isComputedValue(value);
+      if (isObservableObject(value) === false) return false;
+      if (!value[$mobx].values_.has(property)) return false;
+      var atom = getAtom(value, property);
+      return isComputedValue(atom);
     }
     function isComputed(value) {
       if ( arguments.length > 1) return die("isComputed expects only 1 argument. Use isComputedProp to inspect the observability of a property");
@@ -3287,10 +3292,10 @@
       var timeoutHandle;
 
       if (typeof opts.timeout === "number") {
+        var error = new Error("WHEN_TIMEOUT");
         timeoutHandle = setTimeout(function () {
           if (!disposer[$mobx].isDisposed_) {
             disposer();
-            var error = new Error("WHEN_TIMEOUT");
             if (opts.onError) opts.onError(error);else throw error;
           }
         }, opts.timeout);
@@ -3322,7 +3327,7 @@
 
         cancel = function cancel() {
           disposer();
-          reject("WHEN_CANCELLED");
+          reject(new Error("WHEN_CANCELLED"));
         };
       });
       res.cancel = cancel;
@@ -3453,7 +3458,11 @@
       try {
         var _annotations;
 
-        // Default to decorators
+        if ("development" !== "production" && annotations && target[storedAnnotationsSymbol]) {
+          die("makeObservable second arg must be nullish when using decorators. Mixing @decorator syntax with annotations is not supported.");
+        } // Default to decorators
+
+
         (_annotations = annotations) != null ? _annotations : annotations = collectStoredAnnotations(target); // Annotate
 
         ownKeys(annotations).forEach(function (key) {
@@ -3614,7 +3623,7 @@
       };
 
       _proto.setArrayLength_ = function setArrayLength_(newLength) {
-        if (typeof newLength !== "number" || newLength < 0) die("Out of range: " + newLength);
+        if (typeof newLength !== "number" || isNaN(newLength) || newLength < 0) die("Out of range: " + newLength);
         var currentLength = this.values_.length;
         if (newLength === currentLength) return;else if (newLength > currentLength) {
           var newItems = new Array(newLength - currentLength);
@@ -4103,9 +4112,11 @@
 
           if ( notifySpy) spyReportStart(_change);
           transaction(function () {
+            var _this2$hasMap_$get;
+
             _this2.keysAtom_.reportChanged();
 
-            _this2.updateHasMapEntry_(key, false);
+            (_this2$hasMap_$get = _this2.hasMap_.get(key)) == null ? void 0 : _this2$hasMap_$get.setNewValue_(false);
 
             var observable = _this2.data_.get(key);
 
@@ -4121,14 +4132,6 @@
         return false;
       };
 
-      _proto.updateHasMapEntry_ = function updateHasMapEntry_(key, value) {
-        var entry = this.hasMap_.get(key);
-
-        if (entry) {
-          entry.setNewValue_(value);
-        }
-      };
-
       _proto.updateValue_ = function updateValue_(key, newValue) {
         var observable = this.data_.get(key);
         newValue = observable.prepareNewValue_(newValue);
@@ -4157,13 +4160,15 @@
 
         checkIfStateModificationsAreAllowed(this.keysAtom_);
         transaction(function () {
+          var _this3$hasMap_$get;
+
           var observable = new ObservableValue(newValue, _this3.enhancer_,  _this3.name_ + "." + stringifyKey(key) , false);
 
           _this3.data_.set(key, observable);
 
           newValue = observable.value_; // value might have been changed
 
-          _this3.updateHasMapEntry_(key, true);
+          (_this3$hasMap_$get = _this3.hasMap_.get(key)) == null ? void 0 : _this3$hasMap_$get.setNewValue_(true);
 
           _this3.keysAtom_.reportChanged();
         });
@@ -5740,7 +5745,7 @@
      * - utils/   Utility stuff.
      *
      */
-    ["Symbol", "Map", "Set", "Symbol"].forEach(function (m) {
+    ["Symbol", "Map", "Set"].forEach(function (m) {
       var g = getGlobal();
 
       if (typeof g[m] === "undefined") {