mobx 6.12.3 → 6.12.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # mobx
 
+## 6.12.4
+
+### Patch Changes
+
+-   [`e9e1955f`](https://github.com/mobxjs/mobx/commit/e9e1955f745545d796d906b6e0ba04a6cde3f1ee) [#3880](https://github.com/mobxjs/mobx/pull/3880) Thanks [@peterm-canva](https://github.com/peterm-canva)! - Shrink ComputedValue using a bitfield
+
 ## 6.12.2
 
 ### Patch Changes

package/README.md

@@ -23,11 +23,16 @@ Documentation can be found at **[mobx.js.org](https://mobx.js.org/)**.
 
 MobX is made possible by the generosity of the sponsors below, and many other [individual backers](https://github.com/mobxjs/mobx/blob/main/docs/backers-sponsors.md#backers). Sponsoring directly impacts the longevity of this project.
 
-**🥇 Gold sponsors (\$2500+ total contribution):**
+**🥇🥇 Platinum sponsors (\$5000+ total contribution): 🥇🥇**
 
 <br/>
 <a href="https://www.guilded.gg/"><img src="https://mobx.js.org/assets/guilded.jpg" align="center" width="100" title="Guilded" alt="Guilded" /></a>
+<a href="https://www.canva.com/"><img src="https://mobx.js.org/assets/canva.svg" align="center" width="100" title="Canva" alt="Canva" /></a>
 <a href="https://www.getparallax.com/"><img src="https://mobx.js.org/assets/parallax.png" align="center" width="100" title="Parallax" alt="Parallax" /></a>
+
+**🥇 Gold sponsors (\$2500+ total contribution):**
+
+<br/>
 <a href="https://www.one-beyond.com"><img src="https://mobx.js.org/assets/dcsl.png" align="center" width="100" title="One Beyond" alt="One Beyond"/></a>
 <a href="https://frontendmasters.com/"><img src="https://mobx.js.org/assets/frontendmasters.jpg" align="center" width="100" title="Frontend Masters" alt="Frontend Masters"></a>
 <a href="http://auctionfrontier.com/"><img src="https://mobx.js.org/assets/auctionfrontier.jpeg" align="center" width="100" title="Auction Frontier" alt="Auction Frontier"></a>
@@ -36,7 +41,6 @@ MobX is made possible by the generosity of the sponsors below, and many other [i
 <a href="https://coinbase.com/"><img src="https://mobx.js.org/assets/coinbase.jpeg" align="center" width="100" title="Coinbase" alt="Coinbase" /></a>
 <a href="https://curology.com/blog/tech"><img src="https://mobx.js.org/assets/curology.png" align="center" width="100" title="Curology" alt="Curology"/></a>
 <a href="https://mendix.com/"><img src="https://mobx.js.org/assets/mendix-logo.png" align="center" width="100" title="Mendix" alt="Mendix" /></a>
-<a href="https://www.canva.com/"><img src="https://mobx.js.org/assets/canva.svg" align="center" width="100" title="Canva" alt="Canva" /></a>
 <a href="https://opensource.facebook.com/"><img src="https://mobx.js.org/assets/fbos.jpeg" align="center" width="100" title="Facebook Open Source" alt="Facebook Open Source" /></a>
 <a href="https://casinosites.ltd.uk/?utm_source=sponsorship&utm_medium=mobx&utm_campaign=readme"><img src="https://mobx.js.org/assets/casino2.png" align="center" width="100" title="Casino Sites" alt="Casino Sites"/></a>
 <a href="https://www.bugsnag.com/platforms/react-error-reporting?utm_source=MobX&utm_medium=Website&utm_content=open-source&utm_campaign=2019-community&utm_term=20190913"><img src="https://mobx.js.org/assets/bugsnag.jpg" align="center" width="100" title="Bugsnag" alt="Bugsnag"/></a>

package/dist/api/object-api.d.ts

@@ -32,5 +32,5 @@ export declare function has<T extends Object>(obj: T, key: string): boolean;
 export declare function get<K, V>(obj: ObservableMap<K, V>, key: K): V | undefined;
 export declare function get<T>(obj: IObservableArray<T>, index: number): T | undefined;
 export declare function get<T extends Object>(obj: T, key: string): any;
-export declare function apiDefineProperty(obj: Object, key: PropertyKey, descriptor: PropertyDescriptor): any;
-export declare function apiOwnKeys(obj: Object): any;
+export declare function apiDefineProperty(obj: Object, key: PropertyKey, descriptor: PropertyDescriptor): boolean | null;
+export declare function apiOwnKeys(obj: Object): (string | symbol)[];

package/dist/core/atom.d.ts

@@ -6,8 +6,8 @@ export interface IAtom extends IObservable {
 }
 export declare class Atom implements IAtom {
     name_: string;
-    isPendingUnobservation_: boolean;
-    isBeingObserved_: boolean;
+    isPendingUnobservation: boolean;
+    isBeingObserved: boolean;
     observers_: Set<IDerivation>;
     diffValue_: number;
     lastAccessedBy_: number;

package/dist/core/computedvalue.d.ts

@@ -43,8 +43,6 @@ export declare class ComputedValue<T> implements IObservable, IComputedValue<T>,
     dependenciesState_: IDerivationState_;
     observing_: IObservable[];
     newObserving_: null;
-    isBeingObserved_: boolean;
-    isPendingUnobservation_: boolean;
     observers_: Set<IDerivation>;
     diffValue_: number;
     runId_: number;
@@ -54,8 +52,11 @@ export declare class ComputedValue<T> implements IObservable, IComputedValue<T>,
     protected value_: T | undefined | CaughtException;
     name_: string;
     triggeredBy_?: string;
-    isComputing_: boolean;
-    isRunningSetter_: boolean;
+    private static readonly isComputingMask_;
+    private static readonly isRunningSetterMask_;
+    private static readonly isBeingObservedMask_;
+    private static readonly isPendingUnobservationMask_;
+    private flags_;
     derivation: () => T;
     setter_?: (value: T) => void;
     isTracing_: TraceMode;
@@ -81,6 +82,14 @@ export declare class ComputedValue<T> implements IObservable, IComputedValue<T>,
     onBUOL: Set<Lambda> | undefined;
     onBO(): void;
     onBUO(): void;
+    private get isComputing();
+    private set isComputing(value);
+    private get isRunningSetter();
+    private set isRunningSetter(value);
+    get isBeingObserved(): boolean;
+    set isBeingObserved(newValue: boolean);
+    get isPendingUnobservation(): boolean;
+    set isPendingUnobservation(newValue: boolean);
     /**
      * Returns the current value of this computed value.
      * Will evaluate its computation first if needed.

package/dist/core/observable.d.ts

@@ -11,9 +11,9 @@ export interface IObservable extends IDepTreeNode {
      * the dependency is already established
      */
     lastAccessedBy_: number;
-    isBeingObserved_: boolean;
+    isBeingObserved: boolean;
     lowestObserverState_: IDerivationState_;
-    isPendingUnobservation_: boolean;
+    isPendingUnobservation: boolean;
     observers_: Set<IDerivation>;
     onBUO(): void;
     onBO(): void;

package/dist/mobx.cjs.development.js

@@ -437,8 +437,8 @@ var Atom = /*#__PURE__*/function () {
       name_ =  "Atom@" + getNextId() ;
     }
     this.name_ = void 0;
-    this.isPendingUnobservation_ = false;
-    this.isBeingObserved_ = false;
+    this.isPendingUnobservation = false;
+    this.isBeingObserved = false;
     this.observers_ = new Set();
     this.diffValue_ = 0;
     this.lastAccessedBy_ = 0;
@@ -1461,6 +1461,17 @@ var ObservableValue = /*#__PURE__*/function (_Atom) {
 var isObservableValue = /*#__PURE__*/createInstanceofPredicate("ObservableValue", ObservableValue);
 
 var _Symbol$toPrimitive$1;
+function getFlag(flags, mask) {
+  return !!(flags & mask);
+}
+function setFlag(flags, mask, newValue) {
+  if (newValue) {
+    flags |= mask;
+  } else {
+    flags &= ~mask;
+  }
+  return flags;
+}
 /**
  * A node in the state dependency root that observes other nodes, and can be observed itself.
  *
@@ -1485,8 +1496,6 @@ var ComputedValue = /*#__PURE__*/function () {
   // nodes we are looking at. Our value depends on these nodes
   // during tracking it's an array with new observed observers
 
-  // to check for cycles
-
   // N.B: unminified as it is used by MST
 
   /**
@@ -1505,8 +1514,6 @@ var ComputedValue = /*#__PURE__*/function () {
     this.dependenciesState_ = IDerivationState_.NOT_TRACKING_;
     this.observing_ = [];
     this.newObserving_ = null;
-    this.isBeingObserved_ = false;
-    this.isPendingUnobservation_ = false;
     this.observers_ = new Set();
     this.diffValue_ = 0;
     this.runId_ = 0;
@@ -1516,8 +1523,7 @@ var ComputedValue = /*#__PURE__*/function () {
     this.value_ = new CaughtException(null);
     this.name_ = void 0;
     this.triggeredBy_ = void 0;
-    this.isComputing_ = false;
-    this.isRunningSetter_ = false;
+    this.flags_ = 0;
     this.derivation = void 0;
     this.setter_ = void 0;
     this.isTracing_ = TraceMode.NONE;
@@ -1558,12 +1564,14 @@ var ComputedValue = /*#__PURE__*/function () {
       });
     }
   }
+  // to check for cycles
+  ;
   /**
    * Returns the current value of this computed value.
    * Will evaluate its computation first if needed.
-   */;
+   */
   _proto.get = function get() {
-    if (this.isComputing_) {
+    if (this.isComputing) {
       die(32, this.name_, this.derivation);
     }
     if (globalState.inBatch === 0 &&
@@ -1596,14 +1604,14 @@ var ComputedValue = /*#__PURE__*/function () {
   };
   _proto.set = function set(value) {
     if (this.setter_) {
-      if (this.isRunningSetter_) {
+      if (this.isRunningSetter) {
         die(33, this.name_);
       }
-      this.isRunningSetter_ = true;
+      this.isRunningSetter = true;
       try {
         this.setter_.call(this.scope_, value);
       } finally {
-        this.isRunningSetter_ = false;
+        this.isRunningSetter = false;
       }
     } else {
       die(34, this.name_);
@@ -1631,7 +1639,7 @@ var ComputedValue = /*#__PURE__*/function () {
     return changed;
   };
   _proto.computeValue_ = function computeValue_(track) {
-    this.isComputing_ = true;
+    this.isComputing = true;
     // don't allow state changes during computation
     var prev = allowStateChangesStart(false);
     var res;
@@ -1649,7 +1657,7 @@ var ComputedValue = /*#__PURE__*/function () {
       }
     }
     allowStateChangesEnd(prev);
-    this.isComputing_ = false;
+    this.isComputing = false;
     return res;
   };
   _proto.suspend_ = function suspend_() {
@@ -1701,8 +1709,45 @@ var ComputedValue = /*#__PURE__*/function () {
   _proto[_Symbol$toPrimitive$1] = function () {
     return this.valueOf();
   };
+  _createClass(ComputedValue, [{
+    key: "isComputing",
+    get: function get() {
+      return getFlag(this.flags_, ComputedValue.isComputingMask_);
+    },
+    set: function set(newValue) {
+      this.flags_ = setFlag(this.flags_, ComputedValue.isComputingMask_, newValue);
+    }
+  }, {
+    key: "isRunningSetter",
+    get: function get() {
+      return getFlag(this.flags_, ComputedValue.isRunningSetterMask_);
+    },
+    set: function set(newValue) {
+      this.flags_ = setFlag(this.flags_, ComputedValue.isRunningSetterMask_, newValue);
+    }
+  }, {
+    key: "isBeingObserved",
+    get: function get() {
+      return getFlag(this.flags_, ComputedValue.isBeingObservedMask_);
+    },
+    set: function set(newValue) {
+      this.flags_ = setFlag(this.flags_, ComputedValue.isBeingObservedMask_, newValue);
+    }
+  }, {
+    key: "isPendingUnobservation",
+    get: function get() {
+      return getFlag(this.flags_, ComputedValue.isPendingUnobservationMask_);
+    },
+    set: function set(newValue) {
+      this.flags_ = setFlag(this.flags_, ComputedValue.isPendingUnobservationMask_, newValue);
+    }
+  }]);
   return ComputedValue;
 }();
+ComputedValue.isComputingMask_ = 1;
+ComputedValue.isRunningSetterMask_ = 2;
+ComputedValue.isBeingObservedMask_ = 4;
+ComputedValue.isPendingUnobservationMask_ = 8;
 var isComputedValue = /*#__PURE__*/createInstanceofPredicate("ComputedValue", ComputedValue);
 
 var IDerivationState_;
@@ -2104,9 +2149,9 @@ function removeObserver(observable, node) {
 }
 
 function queueForUnobservation(observable) {
-  if (observable.isPendingUnobservation_ === false) {
+  if (observable.isPendingUnobservation === false) {
     // invariant(observable._observers.length === 0, "INTERNAL ERROR, should only queue for unobservation unobserved observables");
-    observable.isPendingUnobservation_ = true;
+    observable.isPendingUnobservation = true;
     globalState.pendingUnobservations.push(observable);
   }
 }
@@ -2125,11 +2170,11 @@ function endBatch() {
     var list = globalState.pendingUnobservations;
     for (var i = 0; i < list.length; i++) {
       var observable = list[i];
-      observable.isPendingUnobservation_ = false;
+      observable.isPendingUnobservation = false;
       if (observable.observers_.size === 0) {
-        if (observable.isBeingObserved_) {
+        if (observable.isBeingObserved) {
           // if this observable had reactive observers, trigger the hooks
-          observable.isBeingObserved_ = false;
+          observable.isBeingObserved = false;
           observable.onBUO();
         }
         if (observable instanceof ComputedValue) {
@@ -2155,12 +2200,12 @@ function reportObserved(observable) {
       observable.lastAccessedBy_ = derivation.runId_;
       // Tried storing newObserving, or observing, or both as Set, but performance didn't come close...
       derivation.newObserving_[derivation.unboundDepsCount_++] = observable;
-      if (!observable.isBeingObserved_ && globalState.trackingContext) {
-        observable.isBeingObserved_ = true;
+      if (!observable.isBeingObserved && globalState.trackingContext) {
+        observable.isBeingObserved = true;
         observable.onBO();
       }
     }
-    return observable.isBeingObserved_;
+    return observable.isBeingObserved;
   } else if (observable.observers_.size === 0 && globalState.inBatch > 0) {
     queueForUnobservation(observable);
   }