mobx 6.12.0 → 6.12.3

package/dist/mobx.umd.development.js

@@ -1822,10 +1822,12 @@
      */
     function trackDerivedFunction(derivation, f, context) {
       var prevAllowStateReads = allowStateReadsStart(true);
-      // pre allocate array allocation + room for variation in deps
-      // array will be trimmed by bindDependencies
       changeDependenciesStateTo0(derivation);
-      derivation.newObserving_ = new Array(derivation.observing_.length + 100);
+      // Preallocate array; will be trimmed by bindDependencies.
+      derivation.newObserving_ = new Array(
+      // Reserve constant space for initial dependencies, dynamic space otherwise.
+      // See https://github.com/mobxjs/mobx/pull/3833
+      derivation.runId_ === 0 ? 100 : derivation.observing_.length);
       derivation.unboundDepsCount_ = 0;
       derivation.runId_ = ++globalState.runId;
       var prevTracking = globalState.trackingDerivation;
@@ -2666,7 +2668,6 @@
       var firstTime = true;
       var isScheduled = false;
       var value;
-      var oldValue;
       var equals = opts.compareStructural ? comparer.structural : opts.equals || comparer["default"];
       var r = new Reaction(name, function () {
         if (firstTime || runSync) {
@@ -2682,12 +2683,12 @@
           return;
         }
         var changed = false;
+        var oldValue = value;
         r.track(function () {
           var nextValue = allowStateChanges(false, function () {
             return expression(r);
           });
           changed = firstTime || !equals(value, nextValue);
-          oldValue = value;
           value = nextValue;
         });
         if (firstTime && opts.fireImmediately) {
@@ -3994,7 +3995,7 @@
         return dehancedValues[funcName].apply(dehancedValues, arguments);
       };
     }
-    // Make sure callbacks recieve correct array arg #2326
+    // Make sure callbacks receive correct array arg #2326
     function mapLikeFunc(funcName) {
       return function (callback, thisArg) {
         var _this2 = this;
@@ -4006,7 +4007,7 @@
         });
       };
     }
-    // Make sure callbacks recieve correct array arg #2326
+    // Make sure callbacks receive correct array arg #2326
     function reduceLikeFunc(funcName) {
       return function () {
         var _this3 = this;
@@ -5339,7 +5340,7 @@
             _this.spliceWithArray(0, 0, initialValues);
           }
           if (safariPrototypeSetterInheritanceBug) {
-            // Seems that Safari won't use numeric prototype setter untill any * numeric property is
+            // Seems that Safari won't use numeric prototype setter until any * numeric property is
             // defined on the instance. After that it works fine, even if this property is deleted.
             Object.defineProperty(_assertThisInitialized(_this), "0", ENTRY_0);
           }