mobx 6.12.0 → 6.12.1

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "mobx",
-    "version": "6.12.0",
+    "version": "6.12.1",
     "description": "Simple, scalable state management.",
     "source": "src/mobx.ts",
     "main": "dist/index.js",

package/src/api/autorun.ts

@@ -139,7 +139,6 @@ export function reaction<T, FireImmediately extends boolean = false>(
     let firstTime = true
     let isScheduled = false
     let value: T
-    let oldValue: T | undefined
 
     const equals: IEqualsComparer<T> = (opts as any).compareStructural
         ? comparer.structural
@@ -165,14 +164,14 @@ export function reaction<T, FireImmediately extends boolean = false>(
             return
         }
         let changed: boolean = false
+        const oldValue = value
         r.track(() => {
             const nextValue = allowStateChanges(false, () => expression(r))
             changed = firstTime || !equals(value, nextValue)
-            oldValue = value
             value = nextValue
         })
 
-        // This casting is nesessary as TS cannot infer proper type in current funciton implementation
+        // This casting is nesessary as TS cannot infer proper type in current function implementation
         type OldValue = FireImmediately extends true ? T | undefined : T
         if (firstTime && opts.fireImmediately!) {
             effectAction(value, oldValue as OldValue, r)

package/src/core/derivation.ts

@@ -166,10 +166,13 @@ export function checkIfStateReadsAreAllowed(observable: IObservable) {
  */
 export function trackDerivedFunction<T>(derivation: IDerivation, f: () => T, context: any) {
     const prevAllowStateReads = allowStateReadsStart(true)
-    // pre allocate array allocation + room for variation in deps
-    // array will be trimmed by bindDependencies
     changeDependenciesStateTo0(derivation)
-    derivation.newObserving_ = new Array(derivation.observing_.length + 100)
+    // Preallocate array; will be trimmed by bindDependencies.
+    derivation.newObserving_ = new Array(
+        // Reserve constant space for initial dependencies, dynamic space otherwise.
+        // See https://github.com/mobxjs/mobx/pull/3833
+        derivation.runId_ === 0 ? 100 : derivation.observing_.length
+    )
     derivation.unboundDepsCount_ = 0
     derivation.runId_ = ++globalState.runId
     const prevTracking = globalState.trackingDerivation

package/src/types/legacyobservablearray.ts

@@ -71,7 +71,7 @@ export class LegacyObservableArray<T> extends StubArray {
             }
 
             if (safariPrototypeSetterInheritanceBug) {
-                // Seems that Safari won't use numeric prototype setter untill any * numeric property is
+                // Seems that Safari won't use numeric prototype setter until any * numeric property is
                 // defined on the instance. After that it works fine, even if this property is deleted.
                 Object.defineProperty(this, "0", ENTRY_0)
             }

package/src/types/observablearray.ts

@@ -563,7 +563,7 @@ function simpleFunc(funcName) {
     }
 }
 
-// Make sure callbacks recieve correct array arg #2326
+// Make sure callbacks receive correct array arg #2326
 function mapLikeFunc(funcName) {
     return function (callback, thisArg) {
         const adm: ObservableArrayAdministration = this[$mobx]
@@ -575,7 +575,7 @@ function mapLikeFunc(funcName) {
     }
 }
 
-// Make sure callbacks recieve correct array arg #2326
+// Make sure callbacks receive correct array arg #2326
 function reduceLikeFunc(funcName) {
     return function () {
         const adm: ObservableArrayAdministration = this[$mobx]