mobx 6.11.0 → 6.12.1

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "mobx",
-    "version": "6.11.0",
+    "version": "6.12.1",
     "description": "Simple, scalable state management.",
     "source": "src/mobx.ts",
     "main": "dist/index.js",

package/src/api/autorun.ts

@@ -139,7 +139,6 @@ export function reaction<T, FireImmediately extends boolean = false>(
     let firstTime = true
     let isScheduled = false
     let value: T
-    let oldValue: T | undefined
 
     const equals: IEqualsComparer<T> = (opts as any).compareStructural
         ? comparer.structural
@@ -165,14 +164,14 @@ export function reaction<T, FireImmediately extends boolean = false>(
             return
         }
         let changed: boolean = false
+        const oldValue = value
         r.track(() => {
             const nextValue = allowStateChanges(false, () => expression(r))
             changed = firstTime || !equals(value, nextValue)
-            oldValue = value
             value = nextValue
         })
 
-        // This casting is nesessary as TS cannot infer proper type in current funciton implementation
+        // This casting is nesessary as TS cannot infer proper type in current function implementation
         type OldValue = FireImmediately extends true ? T | undefined : T
         if (firstTime && opts.fireImmediately!) {
             effectAction(value, oldValue as OldValue, r)

package/src/core/action.ts

@@ -50,6 +50,7 @@ export function createAction(
         return executeAction(actionName, autoAction, fn, ref || this, arguments)
     }
     res.isMobxAction = true
+    res.toString = () => fn.toString()
     if (isFunctionNameConfigurable) {
         tmpNameDescriptor.value = actionName
         defineProperty(res, "name", tmpNameDescriptor)

package/src/core/atom.ts

@@ -11,8 +11,7 @@ import {
     propagateChanged,
     reportObserved,
     startBatch,
-    Lambda,
-    globalState
+    Lambda
 } from "../internal"
 
 export const $mobx = Symbol("mobx administration")
@@ -27,7 +26,6 @@ export class Atom implements IAtom {
     isBeingObserved_ = false
     observers_ = new Set<IDerivation>()
 
-    batchId_: number
     diffValue_ = 0
     lastAccessedBy_ = 0
     lowestObserverState_ = IDerivationState_.NOT_TRACKING_
@@ -35,9 +33,7 @@ export class Atom implements IAtom {
      * Create a new atom. For debugging purposes it is recommended to give it a name.
      * The onBecomeObserved and onBecomeUnobserved callbacks can be used for resource management.
      */
-    constructor(public name_ = __DEV__ ? "Atom@" + getNextId() : "Atom") {
-        this.batchId_ = globalState.inBatch ? globalState.batchId : NaN
-    }
+    constructor(public name_ = __DEV__ ? "Atom@" + getNextId() : "Atom") {}
 
     // onBecomeObservedListeners
     public onBOL: Set<Lambda> | undefined
@@ -68,17 +64,6 @@ export class Atom implements IAtom {
      * Invoke this method _after_ this method has changed to signal mobx that all its observers should invalidate.
      */
     public reportChanged() {
-        if (!globalState.inBatch || this.batchId_ !== globalState.batchId) {
-            // We could update state version only at the end of batch,
-            // but we would still have to switch some global flag here to signal a change.
-            globalState.stateVersion =
-                globalState.stateVersion < Number.MAX_SAFE_INTEGER
-                    ? globalState.stateVersion + 1
-                    : Number.MIN_SAFE_INTEGER
-            // Avoids the possibility of hitting the same globalState.batchId when it cycled through all integers (necessary?)
-            this.batchId_ = NaN
-        }
-
         startBatch()
         propagateChanged(this)
         endBatch()

package/src/core/derivation.ts

@@ -166,10 +166,13 @@ export function checkIfStateReadsAreAllowed(observable: IObservable) {
  */
 export function trackDerivedFunction<T>(derivation: IDerivation, f: () => T, context: any) {
     const prevAllowStateReads = allowStateReadsStart(true)
-    // pre allocate array allocation + room for variation in deps
-    // array will be trimmed by bindDependencies
     changeDependenciesStateTo0(derivation)
-    derivation.newObserving_ = new Array(derivation.observing_.length + 100)
+    // Preallocate array; will be trimmed by bindDependencies.
+    derivation.newObserving_ = new Array(
+        // Reserve constant space for initial dependencies, dynamic space otherwise.
+        // See https://github.com/mobxjs/mobx/pull/3833
+        derivation.runId_ === 0 ? 100 : derivation.observing_.length
+    )
     derivation.unboundDepsCount_ = 0
     derivation.runId_ = ++globalState.runId
     const prevTracking = globalState.trackingDerivation

package/src/core/globalstate.ts

@@ -63,12 +63,6 @@ export class MobXGlobals {
      */
     inBatch: number = 0
 
-    /**
-     * ID of the latest batch. Used to suppress reportChanged of newly created atoms.
-     * Note the value persists even after batch ended.
-     */
-    batchId: number = Number.MIN_SAFE_INTEGER
-
     /**
      * Observables that don't have observers anymore, and are about to be
      * suspended, unless somebody else accesses it in the same batch
@@ -156,11 +150,6 @@ export class MobXGlobals {
      * configurable: true
      */
     safeDescriptors = true
-
-    /**
-     * Changes with each state update, used by useSyncExternalStore
-     */
-    stateVersion = Number.MIN_SAFE_INTEGER
 }
 
 let canMergeGlobalState = true

package/src/core/observable.ts

@@ -104,12 +104,6 @@ export function queueForUnobservation(observable: IObservable) {
  * Avoids unnecessary recalculations.
  */
 export function startBatch() {
-    if (globalState.inBatch === 0) {
-        globalState.batchId =
-            globalState.batchId < Number.MAX_SAFE_INTEGER
-                ? globalState.batchId + 1
-                : Number.MIN_SAFE_INTEGER
-    }
     globalState.inBatch++
 }
 

package/src/types/legacyobservablearray.ts

@@ -71,7 +71,7 @@ export class LegacyObservableArray<T> extends StubArray {
             }
 
             if (safariPrototypeSetterInheritanceBug) {
-                // Seems that Safari won't use numeric prototype setter untill any * numeric property is
+                // Seems that Safari won't use numeric prototype setter until any * numeric property is
                 // defined on the instance. After that it works fine, even if this property is deleted.
                 Object.defineProperty(this, "0", ENTRY_0)
             }

package/src/types/observablearray.ts

@@ -518,6 +518,7 @@ export var arrayExtensions = {
  * Without this, everything works as well, but this works
  * faster as everything works on unproxied values
  */
+addArrayExtension("at", simpleFunc)
 addArrayExtension("concat", simpleFunc)
 addArrayExtension("flat", simpleFunc)
 addArrayExtension("includes", simpleFunc)
@@ -527,15 +528,21 @@ addArrayExtension("lastIndexOf", simpleFunc)
 addArrayExtension("slice", simpleFunc)
 addArrayExtension("toString", simpleFunc)
 addArrayExtension("toLocaleString", simpleFunc)
+addArrayExtension("toSorted", simpleFunc)
+addArrayExtension("toSpliced", simpleFunc)
+addArrayExtension("with", simpleFunc)
 // map
 addArrayExtension("every", mapLikeFunc)
 addArrayExtension("filter", mapLikeFunc)
 addArrayExtension("find", mapLikeFunc)
 addArrayExtension("findIndex", mapLikeFunc)
+addArrayExtension("findLast", mapLikeFunc)
+addArrayExtension("findLastIndex", mapLikeFunc)
 addArrayExtension("flatMap", mapLikeFunc)
 addArrayExtension("forEach", mapLikeFunc)
 addArrayExtension("map", mapLikeFunc)
 addArrayExtension("some", mapLikeFunc)
+addArrayExtension("toReversed", mapLikeFunc)
 // reduce
 addArrayExtension("reduce", reduceLikeFunc)
 addArrayExtension("reduceRight", reduceLikeFunc)
@@ -556,7 +563,7 @@ function simpleFunc(funcName) {
     }
 }
 
-// Make sure callbacks recieve correct array arg #2326
+// Make sure callbacks receive correct array arg #2326
 function mapLikeFunc(funcName) {
     return function (callback, thisArg) {
         const adm: ObservableArrayAdministration = this[$mobx]
@@ -568,7 +575,7 @@ function mapLikeFunc(funcName) {
     }
 }
 
-// Make sure callbacks recieve correct array arg #2326
+// Make sure callbacks receive correct array arg #2326
 function reduceLikeFunc(funcName) {
     return function () {
         const adm: ObservableArrayAdministration = this[$mobx]