mobx 6.11.0-pre → 6.12.0

package/dist/types/observableobject.d.ts

@@ -94,6 +94,5 @@ export interface IIsObservableObject {
     $mobx: ObservableObjectAdministration;
 }
 export declare function asObservableObject(target: any, options?: CreateObservableOptions): IIsObservableObject;
-export declare function getCachedFallthroughPropDescriptor(key: any): any;
 export declare function isObservableObject(thing: any): boolean;
 export declare function recordAnnotationApplied(adm: ObservableObjectAdministration, annotation: Annotation, key: PropertyKey): void;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "mobx",
-    "version": "6.11.0-pre",
+    "version": "6.12.0",
     "description": "Simple, scalable state management.",
     "source": "src/mobx.ts",
     "main": "dist/index.js",

package/src/api/decorators.ts

@@ -89,6 +89,10 @@ export function assert20223DecoratorType(
     types: DecoratorContext["kind"][]
 ) {
     if (__DEV__ && !types.includes(context.kind)) {
-        die(`Decorator may not be used like this`)
+        die(
+            `The decorator applied to '${String(context.name)}' cannot be used on a ${
+                context.kind
+            } element`
+        )
     }
 }

package/src/api/observable.ts

@@ -156,6 +156,7 @@ export interface IObservableFactory
         PropertyDecorator,
         ClassAccessorDecorator,
         ClassFieldDecorator {
+    // TODO: remove ClassFieldDecorator, this is only temporarily support for legacy decorators
     <T = any>(value: T[], options?: CreateObservableOptions): IObservableArray<T>
     <T = any>(value: Set<T>, options?: CreateObservableOptions): ObservableSet<T>
     <K = any, V = any>(value: Map<K, V>, options?: CreateObservableOptions): ObservableMap<K, V>

package/src/core/action.ts

@@ -50,6 +50,7 @@ export function createAction(
         return executeAction(actionName, autoAction, fn, ref || this, arguments)
     }
     res.isMobxAction = true
+    res.toString = () => fn.toString()
     if (isFunctionNameConfigurable) {
         tmpNameDescriptor.value = actionName
         defineProperty(res, "name", tmpNameDescriptor)

package/src/core/atom.ts

@@ -11,8 +11,7 @@ import {
     propagateChanged,
     reportObserved,
     startBatch,
-    Lambda,
-    globalState
+    Lambda
 } from "../internal"
 
 export const $mobx = Symbol("mobx administration")
@@ -27,7 +26,6 @@ export class Atom implements IAtom {
     isBeingObserved_ = false
     observers_ = new Set<IDerivation>()
 
-    batchId_: number
     diffValue_ = 0
     lastAccessedBy_ = 0
     lowestObserverState_ = IDerivationState_.NOT_TRACKING_
@@ -35,9 +33,7 @@ export class Atom implements IAtom {
      * Create a new atom. For debugging purposes it is recommended to give it a name.
      * The onBecomeObserved and onBecomeUnobserved callbacks can be used for resource management.
      */
-    constructor(public name_ = __DEV__ ? "Atom@" + getNextId() : "Atom") {
-        this.batchId_ = globalState.inBatch ? globalState.batchId : NaN
-    }
+    constructor(public name_ = __DEV__ ? "Atom@" + getNextId() : "Atom") {}
 
     // onBecomeObservedListeners
     public onBOL: Set<Lambda> | undefined
@@ -68,17 +64,6 @@ export class Atom implements IAtom {
      * Invoke this method _after_ this method has changed to signal mobx that all its observers should invalidate.
      */
     public reportChanged() {
-        if (!globalState.inBatch || this.batchId_ !== globalState.batchId) {
-            // We could update state version only at the end of batch,
-            // but we would still have to switch some global flag here to signal a change.
-            globalState.stateVersion =
-                globalState.stateVersion < Number.MAX_SAFE_INTEGER
-                    ? globalState.stateVersion + 1
-                    : Number.MIN_SAFE_INTEGER
-            // Avoids the possibility of hitting the same globalState.batchId when it cycled through all integers (necessary?)
-            this.batchId_ = NaN
-        }
-
         startBatch()
         propagateChanged(this)
         endBatch()

package/src/core/globalstate.ts

@@ -63,12 +63,6 @@ export class MobXGlobals {
      */
     inBatch: number = 0
 
-    /**
-     * ID of the latest batch. Used to suppress reportChanged of newly created atoms.
-     * Note the value persists even after batch ended.
-     */
-    batchId: number = Number.MIN_SAFE_INTEGER
-
     /**
      * Observables that don't have observers anymore, and are about to be
      * suspended, unless somebody else accesses it in the same batch
@@ -156,11 +150,6 @@ export class MobXGlobals {
      * configurable: true
      */
     safeDescriptors = true
-
-    /**
-     * Changes with each state update, used by useSyncExternalStore
-     */
-    stateVersion = Number.MIN_SAFE_INTEGER
 }
 
 let canMergeGlobalState = true

package/src/core/observable.ts

@@ -104,12 +104,6 @@ export function queueForUnobservation(observable: IObservable) {
  * Avoids unnecessary recalculations.
  */
 export function startBatch() {
-    if (globalState.inBatch === 0) {
-        globalState.batchId =
-            globalState.batchId < Number.MAX_SAFE_INTEGER
-                ? globalState.batchId + 1
-                : Number.MIN_SAFE_INTEGER
-    }
     globalState.inBatch++
 }
 

package/src/types/observableannotation.ts

@@ -7,8 +7,7 @@ import {
     assert20223DecoratorType,
     ObservableValue,
     asObservableObject,
-    $mobx,
-    storeAnnotation
+    $mobx
 } from "../internal"
 
 export function createObservableAnnotation(name: string, options?: object): Annotation {
@@ -52,25 +51,26 @@ function decorate_20223_(
     context: ClassAccessorDecoratorContext | ClassFieldDecoratorContext
 ) {
     if (__DEV__) {
-        assert20223DecoratorType(context, ["accessor", "field"])
+        if (context.kind === "field") {
+            throw die(
+                `Please use \`@observable accessor ${String(
+                    context.name
+                )}\` instead of \`@observable ${String(context.name)}\``
+            )
+        }
+        assert20223DecoratorType(context, ["accessor"])
     }
 
     const ann = this
-    const { kind, name, addInitializer } = context
-
-    // Backwards/Legacy behavior, expects makeObservable(this)
-    if (kind == "field") {
-        addInitializer(function () {
-            storeAnnotation(this, name, ann)
-        })
-        return
-    }
+    const { kind, name } = context
 
     // The laziness here is not ideal... It's a workaround to how 2022.3 Decorators are implemented:
     //   `addInitializer` callbacks are executed _before_ any accessors are defined (instead of the ideal-for-us right after each).
     //   This means that, if we were to do our stuff in an `addInitializer`, we'd attempt to read a private slot
     //   before it has been initialized. The runtime doesn't like that and throws a `Cannot read private member
     //   from an object whose class did not declare it` error.
+    // TODO: it seems that this will not be required anymore in the final version of the spec
+    // See TODO: link
     const initializedObjects = new WeakSet()
 
     function initializeObservable(target, value) {

package/src/types/observablearray.ts

@@ -518,6 +518,7 @@ export var arrayExtensions = {
  * Without this, everything works as well, but this works
  * faster as everything works on unproxied values
  */
+addArrayExtension("at", simpleFunc)
 addArrayExtension("concat", simpleFunc)
 addArrayExtension("flat", simpleFunc)
 addArrayExtension("includes", simpleFunc)
@@ -527,15 +528,21 @@ addArrayExtension("lastIndexOf", simpleFunc)
 addArrayExtension("slice", simpleFunc)
 addArrayExtension("toString", simpleFunc)
 addArrayExtension("toLocaleString", simpleFunc)
+addArrayExtension("toSorted", simpleFunc)
+addArrayExtension("toSpliced", simpleFunc)
+addArrayExtension("with", simpleFunc)
 // map
 addArrayExtension("every", mapLikeFunc)
 addArrayExtension("filter", mapLikeFunc)
 addArrayExtension("find", mapLikeFunc)
 addArrayExtension("findIndex", mapLikeFunc)
+addArrayExtension("findLast", mapLikeFunc)
+addArrayExtension("findLastIndex", mapLikeFunc)
 addArrayExtension("flatMap", mapLikeFunc)
 addArrayExtension("forEach", mapLikeFunc)
 addArrayExtension("map", mapLikeFunc)
 addArrayExtension("some", mapLikeFunc)
+addArrayExtension("toReversed", mapLikeFunc)
 // reduce
 addArrayExtension("reduce", reduceLikeFunc)
 addArrayExtension("reduceRight", reduceLikeFunc)

package/src/types/observableobject.ts

@@ -712,22 +712,6 @@ function getCachedObservablePropDescriptor(key) {
     )
 }
 
-const fallthroughDescriptorCache = Object.create(null)
-
-export function getCachedFallthroughPropDescriptor(key) {
-    return (
-        fallthroughDescriptorCache[key] ||
-        (fallthroughDescriptorCache[key] = {
-            get() {
-                return Reflect.get(Object.getPrototypeOf(this), key, this)
-            },
-            set(v) {
-                return Reflect.set(Object.getPrototypeOf(this), key, v, this)
-            }
-        })
-    )
-}
-
 export function isObservableObject(thing: any): boolean {
     if (isObject(thing)) {
         return isObservableObjectAdministration((thing as any)[$mobx])