mobx 6.1.4 → 6.1.8

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # mobx
 
+## 6.1.8
+
+### Patch Changes
+
+-   [`ca4914f9`](https://github.com/mobxjs/mobx/commit/ca4914f978aef427e7b2223328fd66b82e522d89) [#2836](https://github.com/mobxjs/mobx/pull/2836) Thanks [@urugator](https://github.com/urugator)! - Fix [#2832](https://github.com/mobxjs/mobx/issues/2832) - annotation cache ignores overrides
+
+## 6.1.7
+
+### Patch Changes
+
+-   [`5640aa77`](https://github.com/mobxjs/mobx/commit/5640aa7794420a5fc2f99ac0819de11696d6ba71) [#2799](https://github.com/mobxjs/mobx/pull/2799) Thanks [@urugator](https://github.com/urugator)! - - fix: user provided debug names are not preserved on production
+    -   fix: property atom's debug name is dynamic on production
+    -   fix: `observable(primitive, options)` ignores `options`
+    -   fix: `getDebugName(action)` throws `[MobX] Cannot obtain atom from undefined`
+    -   [fix: terser using `unsafe: true`](https://github.com/mobxjs/mobx/issues/2751#issuecomment-778171773)
+
+## 6.1.6
+
+### Patch Changes
+
+-   [`9b195b17`](https://github.com/mobxjs/mobx/commit/9b195b17bd661b9c0c4ab3a8ef323e23c2f118e4) [#2780](https://github.com/mobxjs/mobx/pull/2780) Thanks [@iChenLei](https://github.com/iChenLei)! - The overall memory usage of MobX has been reduced in production builds by skipping the generation of debug identifiers. The internal `mapid_` field of Reaction has been removed as part of the change.
+
+## 6.1.5
+
+### Patch Changes
+
+-   [`3979bee3`](https://github.com/mobxjs/mobx/commit/3979bee36c82d342050978834197ea15a7ddbbf8) [#2773](https://github.com/mobxjs/mobx/pull/2773) Thanks [@urugator](https://github.com/urugator)! - Decorators optimization
+
+*   [`7820e5ea`](https://github.com/mobxjs/mobx/commit/7820e5eae0c9dcdfa1e69cf92e0bfa209b2b478b) [#2769](https://github.com/mobxjs/mobx/pull/2769) Thanks [@iChenLei](https://github.com/iChenLei)! - add warn for extending builtins
+
+-   [`a7c15171`](https://github.com/mobxjs/mobx/commit/a7c1517133915c2891e92a865fe5475627b6b89f) [#2775](https://github.com/mobxjs/mobx/pull/2775) Thanks [@pkit](https://github.com/pkit)! - use globalThis in global detection
+
+*   [`5d41b646`](https://github.com/mobxjs/mobx/commit/5d41b6462cf609df869a088e353bc485846c88f8) [#2774](https://github.com/mobxjs/mobx/pull/2774) Thanks [@urugator](https://github.com/urugator)! - Fix: `makeAutoObservable` now working properly with symbolic keys
+    Fix: `isComputedProp` and `getAtom` second arg type is incompatible with Symbols
+
 ## 6.1.4
 
 ### Patch Changes

package/dist/api/annotation.d.ts

@@ -4,7 +4,6 @@ export declare type Annotation = {
     make_(adm: ObservableObjectAdministration, key: PropertyKey): void;
     extend_(adm: ObservableObjectAdministration, key: PropertyKey, descriptor: PropertyDescriptor, proxyTrap: boolean): boolean | null;
     options_?: any;
-    isDecorator_?: boolean;
 };
 export declare type AnnotationMapEntry = Annotation | true | false;
 export declare type AnnotationsMap<T, AdditionalFields extends PropertyKey> = {

package/dist/api/iscomputed.d.ts

@@ -1,3 +1,3 @@
-export declare function _isComputed(value: any, property?: string): boolean;
+export declare function _isComputed(value: any, property?: PropertyKey): boolean;
 export declare function isComputed(value: any): boolean;
-export declare function isComputedProp(value: any, propName: string): boolean;
+export declare function isComputedProp(value: any, propName: PropertyKey): boolean;

package/dist/core/computedvalue.d.ts

@@ -52,7 +52,6 @@ export declare class ComputedValue<T> implements IObservable, IComputedValue<T>,
     lastAccessedBy_: number;
     lowestObserverState_: IDerivationState_;
     unboundDepsCount_: number;
-    mapid_: string;
     protected value_: T | undefined | CaughtException;
     name_: string;
     triggeredBy_?: string;

package/dist/core/derivation.d.ts

@@ -27,7 +27,6 @@ export interface IDerivation extends IDepTreeNode {
      * amount of dependencies used by the derivation in this run, which has not been bound yet.
      */
     unboundDepsCount_: number;
-    mapid_: string;
     onBecomeStale_(): void;
     isTracing_: TraceMode;
     /**

package/dist/core/reaction.d.ts

@@ -36,7 +36,6 @@ export declare class Reaction implements IDerivation, IReactionPublic {
     diffValue_: number;
     runId_: number;
     unboundDepsCount_: number;
-    mapid_: string;
     isDisposed_: boolean;
     isScheduled_: boolean;
     isTrackPending_: boolean;

package/dist/mobx.cjs.development.js

@@ -80,6 +80,10 @@ function die(error) {
 
 var mockGlobal = {};
 function getGlobal() {
+  if (typeof globalThis !== "undefined") {
+    return globalThis;
+  }
+
   if (typeof window !== "undefined") {
     return window;
   }
@@ -361,9 +365,7 @@ function storeAnnotation(prototype, key, annotation) {
   assertNotDecorated(prototype, annotation, key); // Ignore override
 
   if (!isOverride(annotation)) {
-    prototype[storedAnnotationsSymbol][key] = _extends({}, annotation, {
-      isDecorator_: true
-    });
+    prototype[storedAnnotationsSymbol][key] = annotation;
   }
 }
 
@@ -403,7 +405,7 @@ var Atom = /*#__PURE__*/function () {
    */
   function Atom(name_) {
     if (name_ === void 0) {
-      name_ = "Atom@" + getNextId();
+      name_ =  "Atom@" + getNextId() ;
     }
 
     this.name_ = void 0;
@@ -593,7 +595,7 @@ function createActionAnnotation(name, options) {
 }
 
 function make_$1(adm, key) {
-  var _this$options_$bound, _this$options_;
+  var _this$options_$bound, _this$options_, _adm$target_$storedAn;
 
   var annotated = false;
   var source = adm.target_;
@@ -643,7 +645,7 @@ function make_$1(adm, key) {
 
   if (annotated) {
     recordAnnotationApplied(adm, this, key);
-  } else if (!this.isDecorator_) {
+  } else if (!((_adm$target_$storedAn = adm.target_[storedAnnotationsSymbol]) == null ? void 0 : _adm$target_$storedAn[key])) {
     // Throw on missing key, except for decorators:
     // Decorator annotations are collected from whole prototype chain.
     // When called from super() some props may not exist yet.
@@ -707,6 +709,8 @@ function createFlowAnnotation(name, options) {
 }
 
 function make_$2(adm, key) {
+  var _adm$target_$storedAn;
+
   var annotated = false;
   var source = adm.target_;
 
@@ -744,7 +748,7 @@ function make_$2(adm, key) {
 
   if (annotated) {
     recordAnnotationApplied(adm, this, key);
-  } else if (!this.isDecorator_) {
+  } else if (!((_adm$target_$storedAn = adm.target_[storedAnnotationsSymbol]) == null ? void 0 : _adm$target_$storedAn[key])) {
     // Throw on missing key, except for decorators:
     // Decorator annotations are collected from whole prototype chain.
     // When called from super() some props may not exist yet.
@@ -798,6 +802,8 @@ function createComputedAnnotation(name, options) {
 }
 
 function make_$3(adm, key) {
+  var _adm$target_$storedAn;
+
   var source = adm.target_;
 
   while (source && source !== objectPrototype) {
@@ -822,7 +828,7 @@ function make_$3(adm, key) {
     source = Object.getPrototypeOf(source);
   }
 
-  if (!this.isDecorator_) {
+  if (!((_adm$target_$storedAn = adm.target_[storedAnnotationsSymbol]) == null ? void 0 : _adm$target_$storedAn[key])) {
     // Throw on missing key, except for decorators:
     // Decorator annotations are collected from whole prototype chain.
     // When called from super() some props may not exist yet.
@@ -859,6 +865,8 @@ function createObservableAnnotation(name, options) {
 }
 
 function make_$4(adm, key) {
+  var _adm$target_$storedAn;
+
   var source = adm.target_; // Copy props from proto as well, see test:
   // "decorate should work with Object.create"
 
@@ -883,7 +891,7 @@ function make_$4(adm, key) {
     source = Object.getPrototypeOf(source);
   }
 
-  if (!this.isDecorator_) {
+  if (!((_adm$target_$storedAn = adm.target_[storedAnnotationsSymbol]) == null ? void 0 : _adm$target_$storedAn[key])) {
     // Throw on missing key, except for decorators:
     // Decorator annotations are collected from whole prototype chain.
     // When called from super() some props may not exist yet.
@@ -967,7 +975,7 @@ function createObservable(v, arg2, arg3) {
 
   if (typeof v === "object" && v !== null) return v; // anything else
 
-  return observable.box(v);
+  return observable.box(v, arg2);
 }
 
 Object.assign(createObservable, observableDecoratorAnnotation);
@@ -1029,7 +1037,7 @@ var computed = function computed(arg1, arg2) {
 
   var opts = isPlainObject(arg2) ? arg2 : {};
   opts.get = arg1;
-  opts.name = opts.name || arg1.name || "";
+  opts.name || (opts.name = arg1.name || "");
   /* for generated name */
 
   return new ComputedValue(opts);
@@ -1177,7 +1185,7 @@ var ObservableValue = /*#__PURE__*/function (_Atom) {
     var _this;
 
     if (name_ === void 0) {
-      name_ = "ObservableValue@" + getNextId();
+      name_ =  "ObservableValue@" + getNextId() ;
     }
 
     if (notifySpy === void 0) {
@@ -1377,7 +1385,6 @@ var ComputedValue = /*#__PURE__*/function () {
     this.lastAccessedBy_ = 0;
     this.lowestObserverState_ = IDerivationState_.UP_TO_DATE_;
     this.unboundDepsCount_ = 0;
-    this.mapid_ = "#" + getNextId();
     this.value_ = new CaughtException(null);
     this.name_ = void 0;
     this.triggeredBy_ = void 0;
@@ -1394,8 +1401,12 @@ var ComputedValue = /*#__PURE__*/function () {
     this.onBUOL = void 0;
     if (!options.get) die(31);
     this.derivation = options.get;
-    this.name_ = options.name || "ComputedValue@" + getNextId();
-    if (options.set) this.setter_ = createAction(this.name_ + "-setter", options.set);
+    this.name_ = options.name || ( "ComputedValue@" + getNextId() );
+
+    if (options.set) {
+      this.setter_ = createAction( this.name_ + "-setter" , options.set);
+    }
+
     this.equals_ = options.equals || (options.compareStructural || options.struct ? comparer.structural : comparer["default"]);
     this.scope_ = options.context;
     this.requiresReaction_ = !!options.requiresReaction;
@@ -2166,7 +2177,7 @@ var Reaction = /*#__PURE__*/function () {
   // nodes we are looking at. Our value depends on these nodes
   function Reaction(name_, onInvalidate_, errorHandler_, requiresObservable_) {
     if (name_ === void 0) {
-      name_ = "Reaction@" + getNextId();
+      name_ =  "Reaction@" + getNextId() ;
     }
 
     if (requiresObservable_ === void 0) {
@@ -2183,7 +2194,6 @@ var Reaction = /*#__PURE__*/function () {
     this.diffValue_ = 0;
     this.runId_ = 0;
     this.unboundDepsCount_ = 0;
-    this.mapid_ = "#" + getNextId();
     this.isDisposed_ = false;
     this.isScheduled_ = false;
     this.isTrackPending_ = false;
@@ -2516,6 +2526,8 @@ function isAction(thing) {
  */
 
 function autorun(view, opts) {
+  var _opts$name, _opts;
+
   if (opts === void 0) {
     opts = EMPTY_OBJECT;
   }
@@ -2525,7 +2537,7 @@ function autorun(view, opts) {
     if (isAction(view)) die("Autorun does not accept actions since actions are untrackable");
   }
 
-  var name = opts && opts.name || view.name || "Autorun@" + getNextId();
+  var name = (_opts$name = (_opts = opts) == null ? void 0 : _opts.name) != null ? _opts$name :  view.name || "Autorun@" + getNextId() ;
   var runSync = !opts.scheduler && !opts.delay;
   var reaction;
 
@@ -2568,6 +2580,8 @@ function createSchedulerFromOptions(opts) {
 }
 
 function reaction(expression, effect, opts) {
+  var _opts$name2;
+
   if (opts === void 0) {
     opts = EMPTY_OBJECT;
   }
@@ -2577,7 +2591,7 @@ function reaction(expression, effect, opts) {
     if (!isPlainObject(opts)) die("Third argument of reactions should be an object");
   }
 
-  var name = opts.name || "Reaction@" + getNextId();
+  var name = (_opts$name2 = opts.name) != null ? _opts$name2 :  "Reaction@" + getNextId() ;
   var effectAction = action(name, opts.onError ? wrapErrorHandler(opts.onError, effect) : effect);
   var runSync = !opts.scheduler && !opts.delay;
   var scheduler = createSchedulerFromOptions(opts);
@@ -3214,8 +3228,8 @@ function _when(predicate, effect, opts) {
     }, opts.timeout);
   }
 
-  opts.name = opts.name || "When@" + getNextId();
-  var effectAction = createAction(opts.name + "-effect", effect); // eslint-disable-next-line
+  opts.name =  opts.name || "When@" + getNextId() ;
+  var effectAction = createAction( opts.name + "-effect" , effect); // eslint-disable-next-line
 
   var disposer = autorun(function (r) {
     // predicate should not change state
@@ -3399,9 +3413,20 @@ function makeAutoObservable(target, overrides, options) {
   startBatch();
 
   try {
+    // Use cached inferred annotations if available (only in classes)
     if (target[inferredAnnotationsSymbol]) {
-      for (var key in target[inferredAnnotationsSymbol]) {
-        adm.make_(key, target[inferredAnnotationsSymbol][key]);
+      target[inferredAnnotationsSymbol].forEach(function (value, key) {
+        return adm.make_(key, value);
+      }); // Overrides are not cached, unless `true`, see #2832
+
+      if (overrides) {
+        ownKeys(overrides).forEach(function (key) {
+          var annotation = overrides[key];
+
+          if (annotation !== true) {
+            adm.make_(key, annotation);
+          }
+        });
       }
     } else {
       var _ignoreKeys;
@@ -3472,6 +3497,10 @@ var arrayTraps = {
 var ObservableArrayAdministration = /*#__PURE__*/function () {
   // this is the prop that gets proxied, so can't replace it!
   function ObservableArrayAdministration(name, enhancer, owned_, legacyMode_) {
+    if (name === void 0) {
+      name =  "ObservableArray@" + getNextId() ;
+    }
+
     this.owned_ = void 0;
     this.legacyMode_ = void 0;
     this.atom_ = void 0;
@@ -3484,10 +3513,10 @@ var ObservableArrayAdministration = /*#__PURE__*/function () {
     this.lastKnownLength_ = 0;
     this.owned_ = owned_;
     this.legacyMode_ = legacyMode_;
-    this.atom_ = new Atom(name || "ObservableArray@" + getNextId());
+    this.atom_ = new Atom(name);
 
     this.enhancer_ = function (newV, oldV) {
-      return enhancer(newV, oldV, name + "[..]");
+      return enhancer(newV, oldV,  name + "[..]" );
     };
   }
 
@@ -3702,7 +3731,7 @@ var ObservableArrayAdministration = /*#__PURE__*/function () {
 }();
 function createObservableArray(initialValues, enhancer, name, owned) {
   if (name === void 0) {
-    name = "ObservableArray@" + getNextId();
+    name =  "ObservableArray@" + getNextId() ;
   }
 
   if (owned === void 0) {
@@ -3924,7 +3953,7 @@ var ObservableMap = /*#__PURE__*/function () {
     }
 
     if (name_ === void 0) {
-      name_ = "ObservableMap@" + getNextId();
+      name_ =  "ObservableMap@" + getNextId() ;
     }
 
     this.enhancer_ = void 0;
@@ -3943,7 +3972,7 @@ var ObservableMap = /*#__PURE__*/function () {
       die(18);
     }
 
-    this.keysAtom_ = createAtom(this.name_ + ".keys()");
+    this.keysAtom_ = createAtom( this.name_ + ".keys()" );
     this.data_ = new Map();
     this.hasMap_ = new Map();
     this.merge(initialData);
@@ -3962,7 +3991,7 @@ var ObservableMap = /*#__PURE__*/function () {
     var entry = this.hasMap_.get(key);
 
     if (!entry) {
-      var newEntry = entry = new ObservableValue(this.has_(key), referenceEnhancer, this.name_ + "." + stringifyKey(key) + "?", false);
+      var newEntry = entry = new ObservableValue(this.has_(key), referenceEnhancer,  this.name_ + "." + stringifyKey(key) + "?" , false);
       this.hasMap_.set(key, newEntry);
       onBecomeUnobserved(newEntry, function () {
         return _this.hasMap_["delete"](key);
@@ -4078,7 +4107,7 @@ var ObservableMap = /*#__PURE__*/function () {
 
     checkIfStateModificationsAreAllowed(this.keysAtom_);
     transaction(function () {
-      var observable = new ObservableValue(newValue, _this3.enhancer_, _this3.name_ + "." + stringifyKey(key), false);
+      var observable = new ObservableValue(newValue, _this3.enhancer_,  _this3.name_ + "." + stringifyKey(key) , false);
 
       _this3.data_.set(key, observable);
 
@@ -4375,7 +4404,7 @@ var ObservableSet = /*#__PURE__*/function () {
     }
 
     if (name_ === void 0) {
-      name_ = "ObservableSet@" + getNextId();
+      name_ =  "ObservableSet@" + getNextId() ;
     }
 
     this.name_ = void 0;
@@ -4659,7 +4688,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
     this.name_ = name_;
     this.defaultAnnotation_ = defaultAnnotation_;
     this.autoBind_ = autoBind_;
-    this.keysAtom_ = new Atom(name_ + ".keys"); // Optimization: we use this frequently
+    this.keysAtom_ = new Atom( this.name_ + ".keys" ); // Optimization: we use this frequently
 
     this.isPlainObject_ = isPlainObject(this.target_);
 
@@ -4786,7 +4815,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
     var entry = this.pendingKeys_.get(key);
 
     if (!entry) {
-      entry = new ObservableValue(key in this.target_, referenceEnhancer, this.name_ + "." + stringifyKey(key) + "?", false);
+      entry = new ObservableValue(key in this.target_, referenceEnhancer,  this.name_ + "." + stringifyKey(key) + "?" , false);
       this.pendingKeys_.set(key, entry);
     }
 
@@ -4846,7 +4875,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
     var _this$target_$inferre;
 
     // Inherited is fine - annotation cannot differ in subclass
-    var annotation = (_this$target_$inferre = this.target_[inferredAnnotationsSymbol]) == null ? void 0 : _this$target_$inferre[key];
+    var annotation = (_this$target_$inferre = this.target_[inferredAnnotationsSymbol]) == null ? void 0 : _this$target_$inferre.get(key);
     if (annotation) return annotation;
     var current = this.target_;
 
@@ -4873,10 +4902,10 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
       var closestProto = Object.getPrototypeOf(this.target_);
 
       if (!hasProp(closestProto, inferredAnnotationsSymbol)) {
-        addHiddenProp(closestProto, inferredAnnotationsSymbol, {});
+        addHiddenProp(closestProto, inferredAnnotationsSymbol, new Map());
       }
 
-      closestProto[inferredAnnotationsSymbol][key] = annotation;
+      closestProto[inferredAnnotationsSymbol].set(key, annotation);
     }
 
     return annotation;
@@ -4984,7 +5013,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
         defineProperty(this.target_, key, descriptor);
       }
 
-      var _observable = new ObservableValue(value, enhancer, this.name_ + "." + stringifyKey(key), false);
+      var _observable = new ObservableValue(value, enhancer, "development" !== "production" ? this.name_ + "." + key.toString() : "ObservableObject.key", false);
 
       this.values_.set(key, _observable); // Notify (value possibly changed by ObservableValue)
 
@@ -5023,7 +5052,7 @@ var ObservableObjectAdministration = /*#__PURE__*/function () {
         if (!change) return null;
       }
 
-      options.name || (options.name = this.name_ + "." + stringifyKey(key));
+      options.name || (options.name = "development" !== "production" ? this.name_ + "." + key.toString() : "ObservableObject.key");
       options.context = this.proxy_ || this.target_;
       var cachedDescriptor = getCachedObservablePropDescriptor(key);
       var descriptor = {
@@ -5215,10 +5244,17 @@ function asObservableObject(target, options) {
     die("Options can't be provided for already observable objects.");
   }
 
-  if (hasProp(target, $mobx)) return target;
+  if (hasProp(target, $mobx)) {
+    if ( !(getAdministration(target) instanceof ObservableObjectAdministration)) {
+      die("Cannot convert '" + getDebugName(target) + "' into observable object:" + "\nThe target is already observable of different type." + "\nExtending builtins is not supported.");
+    }
+
+    return target;
+  }
+
   if ( !Object.isExtensible(target)) die("Cannot make the designated object observable; it is not extensible");
-  var name = (_options$name = options == null ? void 0 : options.name) != null ? _options$name : (isPlainObject(target) ? "ObservableObject" : target.constructor.name) + "@" + getNextId();
-  var adm = new ObservableObjectAdministration(target, new Map(), stringifyKey(name), getAnnotationFromOptions(options), options == null ? void 0 : options.autoBind);
+  var name = (_options$name = options == null ? void 0 : options.name) != null ? _options$name :  (isPlainObject(target) ? "ObservableObject" : target.constructor.name) + "@" + getNextId() ;
+  var adm = new ObservableObjectAdministration(target, new Map(), String(name), getAnnotationFromOptions(options), options == null ? void 0 : options.autoBind);
   addHiddenProp(target, $mobx, adm);
   return target;
 }
@@ -5243,14 +5279,14 @@ function isObservableObject(thing) {
   return false;
 }
 function recordAnnotationApplied(adm, annotation, key) {
+  var _adm$target_$storedAn;
+
   {
     adm.appliedAnnotations_[key] = annotation;
   } // Remove applied decorator annotation so we don't try to apply it again in subclass constructor
 
 
-  if (annotation.isDecorator_) {
-    delete adm.target_[storedAnnotationsSymbol][key];
-  }
+  (_adm$target_$storedAn = adm.target_[storedAnnotationsSymbol]) == null ? true : delete _adm$target_$storedAn[key];
 }
 
 function assertAnnotable(adm, annotation, key) {
@@ -5330,7 +5366,7 @@ var LegacyObservableArray = /*#__PURE__*/function (_StubArray) {
     var _this;
 
     if (name === void 0) {
-      name = "ObservableArray@" + getNextId();
+      name =  "ObservableArray@" + getNextId() ;
     }
 
     if (owned === void 0) {
@@ -5489,7 +5525,17 @@ function getAdministration(thing, property) {
 }
 function getDebugName(thing, property) {
   var named;
-  if (property !== undefined) named = getAtom(thing, property);else if (isObservableObject(thing) || isObservableMap(thing) || isObservableSet(thing)) named = getAdministration(thing);else named = getAtom(thing); // valid for arrays as well
+
+  if (property !== undefined) {
+    named = getAtom(thing, property);
+  } else if (isAction(thing)) {
+    return thing.name;
+  } else if (isObservableObject(thing) || isObservableMap(thing) || isObservableSet(thing)) {
+    named = getAdministration(thing);
+  } else {
+    // valid for arrays as well
+    named = getAtom(thing);
+  }
 
   return named.name_;
 }