mobx-state-tree 5.0.5 → 5.1.0

package/README.md

@@ -4,7 +4,7 @@
 
 [![npm version](https://badge.fury.io/js/mobx-state-tree.svg)](https://badge.fury.io/js/mobx-state-tree)
 [![CircleCI](https://circleci.com/gh/mobxjs/mobx-state-tree.svg?style=svg)](https://circleci.com/gh/mobxjs/mobx-state-tree)
-[![Coverage Status](https://coveralls.io/repos/github/mobxjs/mobx-state-tree/badge.svg?branch=master)](https://coveralls.io/github/mobxjs/mobx-state-tree?branch=master)
+[![Codecov](https://codecov.io/gh/mobxjs/mobx-state-tree/branch/master/graph/badge.svg?token=BFkuCB6CtL)](https://codecov.io/gh/mobxjs/mobx-state-tree)
 [![Have a question? Ask on GitHub Discussions!](https://img.shields.io/badge/Have%20a%20question%3F-Ask%20on%20GitHub%20Discussions!-blue)](https://github.com/mobxjs/mobx-state-tree/discussions)
 
 ## What is mobx-state-tree?

package/dist/mobx-state-tree.js

@@ -580,7 +580,7 @@ function resolveIdentifier(type, target, identifier) {
     assertIsStateTreeNode(target, 2);
     assertIsValidIdentifier(identifier, 3);
     var node = getStateTreeNode(target).root.identifierCache.resolve(type, normalizeIdentifier(identifier));
-    return node ? node.value : undefined;
+    return node === null || node === void 0 ? void 0 : node.value;
 }
 /**
  * Returns the identifier of the target node.
@@ -3930,14 +3930,12 @@ function isMutable(value) {
  */
 function isPrimitive(value, includeDate) {
     if (includeDate === void 0) { includeDate = true; }
-    if (value === null || value === undefined)
-        return true;
-    if (typeof value === "string" ||
+    return (value === null ||
+        value === undefined ||
+        typeof value === "string" ||
         typeof value === "number" ||
         typeof value === "boolean" ||
-        (includeDate && value instanceof Date))
-        return true;
-    return false;
+        (includeDate && value instanceof Date));
 }
 /**
  * @internal
@@ -5033,18 +5031,17 @@ var MapType = /** @class */ (function (_super) {
             }
             var modelTypes = [];
             if (tryCollectModelTypes(this._subType, modelTypes)) {
-                var identifierAttribute_1 = undefined;
-                modelTypes.forEach(function (type) {
-                    if (type.identifierAttribute) {
-                        if (identifierAttribute_1 && identifierAttribute_1 !== type.identifierAttribute) {
-                            throw fail$1("The objects in a map should all have the same identifier attribute, expected '" + identifierAttribute_1 + "', but child of type '" + type.name + "' declared attribute '" + type.identifierAttribute + "' as identifier");
-                        }
-                        identifierAttribute_1 = type.identifierAttribute;
+                var identifierAttribute = modelTypes.reduce(function (current, type) {
+                    if (!type.identifierAttribute)
+                        return current;
+                    if (current && current !== type.identifierAttribute) {
+                        throw fail$1("The objects in a map should all have the same identifier attribute, expected '" + current + "', but child of type '" + type.name + "' declared attribute '" + type.identifierAttribute + "' as identifier");
                     }
-                });
-                if (identifierAttribute_1) {
+                    return type.identifierAttribute;
+                }, undefined);
+                if (identifierAttribute) {
                     this.identifierMode = MapIdentifierMode.YES;
-                    this.mapIdentifierAttribute = identifierAttribute_1;
+                    this.mapIdentifierAttribute = identifierAttribute;
                 }
                 else {
                     this.identifierMode = MapIdentifierMode.NO;