mobile-growth-mcp 2.3.7 → 2.3.9

package/dist/index.js

@@ -63,43 +63,50 @@ async function jsonRpcRequest(apiKey2, method, params) {
     throw err;
   }
 }
+async function jsonRpcRequestWithRetry(apiKey2, method, params, maxAttempts = 2) {
+  let lastError;
+  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+    try {
+      return await jsonRpcRequest(apiKey2, method, params);
+    } catch (err) {
+      lastError = err;
+      const isRetryable = lastError.name === "AbortError" || lastError.name === "TimeoutError" || lastError.message?.includes("fetch failed");
+      if (!isRetryable || attempt === maxAttempts) break;
+      await new Promise((r) => setTimeout(r, 2e3));
+    }
+  }
+  throw lastError ?? new Error(`${method} failed after ${maxAttempts} attempts`);
+}
 async function fetchRemoteTools(apiKey2) {
-  const resp = await jsonRpcRequest(apiKey2, "tools/list");
+  const resp = await jsonRpcRequestWithRetry(apiKey2, "tools/list");
   if (resp.error) {
     throw new Error(`tools/list error: ${resp.error.message}`);
   }
   return resp.result?.tools ?? [];
 }
 async function callRemoteTool(apiKey2, name, args) {
-  const maxAttempts = 2;
-  let lastError;
-  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
-    try {
-      const resp = await jsonRpcRequest(apiKey2, "tools/call", {
-        name,
-        arguments: args
-      });
-      if (resp.error) {
-        return {
-          content: [{ type: "text", text: `Remote error: ${resp.error.message}` }],
-          isError: true
-        };
-      }
+  try {
+    const resp = await jsonRpcRequestWithRetry(apiKey2, "tools/call", {
+      name,
+      arguments: args
+    });
+    if (resp.error) {
       return {
-        content: resp.result?.content ?? [{ type: "text", text: "No content returned" }],
-        isError: resp.result?.isError
+        content: [{ type: "text", text: `Remote error: ${resp.error.message}` }],
+        isError: true
       };
-    } catch (err) {
-      lastError = err;
-      const isRetryable = lastError.name === "AbortError" || lastError.name === "TimeoutError" || lastError.message?.includes("fetch failed");
-      if (!isRetryable || attempt === maxAttempts) break;
-      await new Promise((r) => setTimeout(r, 2e3));
     }
+    return {
+      content: resp.result?.content ?? [{ type: "text", text: "No content returned" }],
+      isError: resp.result?.isError
+    };
+  } catch (err) {
+    const lastError = err;
+    return {
+      content: [{ type: "text", text: `Remote call failed after retry: ${lastError.message ?? "unknown error"}` }],
+      isError: true
+    };
   }
-  return {
-    content: [{ type: "text", text: `Remote call failed after retry: ${lastError?.message ?? "unknown error"}` }],
-    isError: true
-  };
 }
 function jsonSchemaToZodShape(inputSchema) {
   const properties = inputSchema.properties ?? {};
@@ -146,14 +153,14 @@ function registerFetchedTools(server2, apiKey2, tools) {
   }
 }
 async function fetchRemotePrompts(apiKey2) {
-  const resp = await jsonRpcRequest(apiKey2, "prompts/list");
+  const resp = await jsonRpcRequestWithRetry(apiKey2, "prompts/list");
   if (resp.error) {
     throw new Error(`prompts/list error: ${resp.error.message}`);
   }
   return resp.result?.prompts ?? [];
 }
 async function getRemotePrompt(apiKey2, name, args) {
-  const resp = await jsonRpcRequest(apiKey2, "prompts/get", {
+  const resp = await jsonRpcRequestWithRetry(apiKey2, "prompts/get", {
     name,
     arguments: args
   });
@@ -1556,13 +1563,16 @@ Sources: goog-pdf-018, ab-pt-008, goog-pdf-019, ab-pt-007
 import { z as z8 } from "zod";
 import { readFile } from "fs/promises";
 import { basename, resolve } from "path";
+var FETCH_TIMEOUT_MS = 3e4;
 async function fetchAsBase64(url) {
   if (url.startsWith("data:")) {
     const commaIdx = url.indexOf(",");
     if (commaIdx === -1) throw new Error("Invalid data URI");
     return url.slice(commaIdx + 1);
   }
-  const res = await fetch(url);
+  const res = await fetch(url, {
+    signal: AbortSignal.timeout(FETCH_TIMEOUT_MS)
+  });
   if (!res.ok) throw new Error(`Failed to fetch ${url}: ${res.status}`);
   const buf = Buffer.from(await res.arrayBuffer());
   return buf.toString("base64");
@@ -1625,38 +1635,68 @@ Would link to campaign ${campaign_id} as ${effectiveFieldType}`;
           }
           return { content: [{ type: "text", text: text2 }] };
         }
+        const assetNames = images.map(
+          (img) => img.name ?? basename(img.source).replace(/\?.*$/, "") ?? "unnamed"
+        );
+        const fetchResults = await Promise.allSettled(
+          images.map((img) => {
+            const isUrl = img.source.startsWith("http://") || img.source.startsWith("https://") || img.source.startsWith("data:");
+            return isUrl ? fetchAsBase64(img.source) : readFileAsBase64(img.source);
+          })
+        );
         const assetOps = [];
-        const assetNames = [];
-        for (const img of images) {
-          const name = img.name ?? basename(img.source).replace(/\?.*$/, "") ?? "unnamed";
-          assetNames.push(name);
-          const isUrl = img.source.startsWith("http://") || img.source.startsWith("https://") || img.source.startsWith("data:");
-          const data = isUrl ? await fetchAsBase64(img.source) : await readFileAsBase64(img.source);
-          assetOps.push({
-            assetOperation: {
-              create: {
-                name,
-                type: "IMAGE",
-                imageAsset: { data }
+        const opOriginIndex = [];
+        const fetchFailures = [];
+        fetchResults.forEach((r, i) => {
+          if (r.status === "fulfilled") {
+            assetOps.push({
+              assetOperation: {
+                create: {
+                  name: assetNames[i],
+                  type: "IMAGE",
+                  imageAsset: { data: r.value }
+                }
               }
-            }
+            });
+            opOriginIndex.push(i);
+          } else {
+            fetchFailures.push({
+              index: i,
+              error: r.reason instanceof Error ? r.reason.message : String(r.reason)
+            });
+          }
+        });
+        const createdResourceNames = new Array(images.length).fill("");
+        let successCount = 0;
+        if (assetOps.length > 0) {
+          const assetResult = await googleAdsMutate(normalizedId, assetOps);
+          const responses = assetResult.mutateOperationResponses;
+          if (responses.length !== assetOps.length) {
+            throw new Error(
+              `Google Ads response length mismatch: sent ${assetOps.length} ops, got ${responses.length} responses`
+            );
+          }
+          responses.forEach((r, i) => {
+            const originalIdx = opOriginIndex[i];
+            const rn = r.assetResult?.resourceName ?? "";
+            createdResourceNames[originalIdx] = rn;
+            if (rn) successCount++;
           });
         }
-        const assetResult = await googleAdsMutate(normalizedId, assetOps);
-        const createdResourceNames = assetResult.mutateOperationResponses.map(
-          (r) => r.assetResult?.resourceName ?? ""
-        );
-        const successCount = createdResourceNames.filter(Boolean).length;
         let text = `**Uploaded ${successCount}/${images.length} image assets**
 
 `;
         for (let i = 0; i < images.length; i++) {
           const rn = createdResourceNames[i];
+          const failure = fetchFailures.find((f) => f.index === i);
           if (rn) {
             text += `\u2713 ${assetNames[i]} \u2192 ${rn}
+`;
+          } else if (failure) {
+            text += `\u2717 ${assetNames[i]} \u2014 fetch failed: ${failure.error}
 `;
           } else {
-            text += `\u2717 ${assetNames[i]} \u2014 failed
+            text += `\u2717 ${assetNames[i]} \u2014 upload failed
 `;
           }
         }
@@ -1715,13 +1755,19 @@ Assets exist in the account and can be linked manually.`;
 }
 
 // src/tools/connection-status.ts
+var SERVER_VERSION = true ? "2.3.9" : "dev";
 function registerConnectionStatus(server2, status2) {
   server2.tool(
     "connection_status",
     "Check the connection status of the knowledge base and Google Ads API. Call this if tools seem missing or you get unexpected errors.",
     {},
     async () => {
-      const lines = ["# Connection Status", ""];
+      const lines = [
+        "# Connection Status",
+        "",
+        `**Server version:** mobile-growth-mcp@${SERVER_VERSION}`,
+        ""
+      ];
       if (status2.kb.connected) {
         lines.push(
           `## Knowledge Base: Connected`,
@@ -2330,8 +2376,10 @@ function saveToEnv(vars) {
 `);
   }
 }
+var OAUTH_CALLBACK_TIMEOUT_MS = 5 * 60 * 1e3;
 async function waitForOAuthCallback(clientId, clientSecret) {
   return new Promise((resolve3, reject) => {
+    let timer;
     const server2 = createServer(
       async (req, res) => {
         const url = new URL(req.url ?? "/", `http://localhost:${OAUTH_PORT}`);
@@ -2398,8 +2446,20 @@ async function waitForOAuthCallback(clientId, clientSecret) {
       }
     );
     server2.listen(OAUTH_PORT, () => {
+      timer = setTimeout(() => {
+        server2.close();
+        reject(
+          new Error(
+            `OAuth authorization timed out after ${OAUTH_CALLBACK_TIMEOUT_MS / 1e3}s. Re-run the auth command and complete the consent screen in the browser.`
+          )
+        );
+      }, OAUTH_CALLBACK_TIMEOUT_MS);
+    });
+    server2.on("close", () => {
+      if (timer) clearTimeout(timer);
     });
     server2.on("error", (err) => {
+      if (timer) clearTimeout(timer);
       if (err.code === "EADDRINUSE") {
         reject(
           new Error(
@@ -2502,6 +2562,7 @@ if (googleAdsResult.refreshToken)
   process.env.GOOGLE_ADS_REFRESH_TOKEN = googleAdsResult.refreshToken;
 if (googleAdsResult.loginCustomerId)
   process.env.GOOGLE_ADS_LOGIN_CUSTOMER_ID = googleAdsResult.loginCustomerId;
+console.error(`mobile-growth-mcp@${SERVER_VERSION} starting`);
 var apiKey = apiKeyResult.value;
 console.error(
   apiKey ? `API key: ${apiKeyResult.source}` : "API key: not configured \u2014 KB tools will not be available"
@@ -2511,7 +2572,7 @@ console.error(
 );
 var server = new McpServer({
   name: "mobile-growth-mcp",
-  version: "2.0.0"
+  version: SERVER_VERSION
 });
 var status = {
   kb: { connected: false, toolCount: 0, promptCount: 0 },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobile-growth-mcp",
-  "version": "2.3.7",
+  "version": "2.3.9",
   "description": "MCP server for mobile growth & UA knowledge base — campaign optimization, creative strategy, and subscription app insights",
   "type": "module",
   "main": "dist/index.js",