mobile-debug-mcp 0.12.6 → 0.12.8

package/dist/server.js

@@ -389,13 +389,37 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
     try {
         if (name === "start_app") {
             const { platform, appId, deviceId } = args;
-            const res = await (platform === 'android' ? new AndroidManage().startApp(appId, deviceId) : new iOSManage().startApp(appId, deviceId));
-            const response = {
-                device: res.device,
-                appStarted: res.appStarted,
-                launchTimeMs: res.launchTimeMs
-            };
-            return wrapResponse(response);
+            // Defensive validation: ensure required args are present and log malformed requests
+            if (!platform || !appId) {
+                try {
+                    require('fs').appendFileSync('/tmp/mcp_bad_requests.log', JSON.stringify({ ts: new Date().toISOString(), tool: 'start_app', args }) + '\n');
+                }
+                catch (e) { }
+                const deviceFallback = { platform: platform || 'ios', id: deviceId || 'unknown', osVersion: '', model: '', simulator: true };
+                const response = { device: deviceFallback, appStarted: false, launchTimeMs: 0, error: 'Missing required argument: platform and/or appId', diagnostics: { receivedArgs: args } };
+                return wrapResponse(response);
+            }
+            try {
+                const res = await (platform === 'android' ? new AndroidManage().startApp(appId, deviceId) : new iOSManage().startApp(appId, deviceId));
+                // Preserve diagnostics and instrumentation from platform managers so agents receive full context
+                const response = {
+                    device: res.device,
+                    appStarted: res.appStarted,
+                    launchTimeMs: res.launchTimeMs,
+                    error: res.error,
+                    diagnostics: res.diagnostics,
+                    instrumentation: res.instrumentation
+                };
+                return wrapResponse(response);
+            }
+            catch (err) {
+                try {
+                    require('fs').appendFileSync('/tmp/mcp_bad_requests.log', JSON.stringify({ ts: new Date().toISOString(), tool: 'start_app', args, error: err && err.message ? err.message : String(err) }) + '\n');
+                }
+                catch (e) { }
+                const deviceFallback = { platform: platform || 'ios', id: deviceId || 'unknown', osVersion: '', model: '', simulator: true };
+                return wrapResponse({ device: deviceFallback, appStarted: false, launchTimeMs: 0, error: err instanceof Error ? err.message : String(err), diagnostics: { receivedArgs: args } });
+            }
         }
         if (name === "terminate_app") {
             const { platform, appId, deviceId } = args;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobile-debug-mcp",
-  "version": "0.12.6",
+  "version": "0.12.8",
   "description": "MCP server for mobile app debugging (Android + iOS), with focus on security and reliability",
   "type": "module",
   "bin": {

package/src/server.ts

@@ -412,13 +412,31 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
   try {
     if (name === "start_app") {
       const { platform, appId, deviceId } = args as any
-      const res = await (platform === 'android' ? new AndroidManage().startApp(appId, deviceId) : new iOSManage().startApp(appId, deviceId))
-      const response: StartAppResponse = {
-        device: res.device,
-        appStarted: res.appStarted,
-        launchTimeMs: res.launchTimeMs
+      // Defensive validation: ensure required args are present and log malformed requests
+      if (!platform || !appId) {
+        try { require('fs').appendFileSync('/tmp/mcp_bad_requests.log', JSON.stringify({ ts: new Date().toISOString(), tool: 'start_app', args }) + '\n') } catch (e) {}
+        const deviceFallback: any = { platform: platform || 'ios', id: deviceId || 'unknown', osVersion: '', model: '', simulator: true }
+        const response: StartAppResponse = { device: deviceFallback, appStarted: false, launchTimeMs: 0, error: 'Missing required argument: platform and/or appId', diagnostics: { receivedArgs: args } }
+        return wrapResponse(response)
+      }
+
+      try {
+        const res = await (platform === 'android' ? new AndroidManage().startApp(appId, deviceId) : new iOSManage().startApp(appId, deviceId))
+        // Preserve diagnostics and instrumentation from platform managers so agents receive full context
+        const response: StartAppResponse = {
+          device: res.device,
+          appStarted: res.appStarted,
+          launchTimeMs: res.launchTimeMs,
+          error: (res as any).error,
+          diagnostics: (res as any).diagnostics,
+          instrumentation: (res as any).instrumentation
+        }
+        return wrapResponse(response)
+      } catch (err:any) {
+        try { require('fs').appendFileSync('/tmp/mcp_bad_requests.log', JSON.stringify({ ts: new Date().toISOString(), tool: 'start_app', args, error: err && err.message ? err.message : String(err) }) + '\n') } catch (e) {}
+        const deviceFallback: any = { platform: platform || 'ios', id: deviceId || 'unknown', osVersion: '', model: '', simulator: true }
+        return wrapResponse({ device: deviceFallback, appStarted: false, launchTimeMs: 0, error: err instanceof Error ? err.message : String(err), diagnostics: { receivedArgs: args } })
       }
-      return wrapResponse(response)
     }
 
     if (name === "terminate_app") {