mobbdev 1.2.34 → 1.2.36

package/dist/args/commands/upload_ai_blame.mjs

@@ -2255,20 +2255,20 @@ function computeCanonicalUrl(data) {
   } = data;
   switch (scmType) {
     case "GitHub" /* GitHub */:
-      return `https://${hostname}/${organization}/${repoName}`;
+      return `https://${hostname}/${organization.toLowerCase()}/${repoName.toLowerCase()}`;
     case "GitLab" /* GitLab */:
-      return `https://${hostname}/${projectPath}`;
+      return `https://${hostname}/${projectPath.toLowerCase()}`;
     case "Bitbucket" /* Bitbucket */:
-      return `https://${hostname}/${organization}/${repoName}`;
+      return `https://${hostname}/${organization.toLowerCase()}/${repoName.toLowerCase()}`;
     case "Ado" /* Ado */: {
       const adoHostname = hostname === "ssh.dev.azure.com" ? "dev.azure.com" : hostname;
       if (projectName) {
-        return `https://${adoHostname}/${organization}/${projectName}/_git/${repoName}`;
+        return `https://${adoHostname}/${organization.toLowerCase()}/${projectName.toLowerCase()}/_git/${repoName.toLowerCase()}`;
       }
-      return `https://${adoHostname}/${organization}/_git/${repoName}`;
+      return `https://${adoHostname}/${organization.toLowerCase()}/_git/${repoName.toLowerCase()}`;
     }
     default:
-      return `https://${hostname}/${projectPath}`;
+      return `https://${hostname}/${projectPath.toLowerCase()}`;
   }
 }
 function detectAdoUrl(args) {
@@ -4333,7 +4333,7 @@ var VUL_REPORT_DIGEST_TIMEOUT_MS = 1e3 * 60 * 30;
 
 // src/features/analysis/graphql/gql.ts
 import Debug6 from "debug";
-import { GraphQLClient } from "graphql-request";
+import { ClientError, GraphQLClient } from "graphql-request";
 import { v4 as uuidv4 } from "uuid";
 
 // src/mcp/core/Errors.ts
@@ -6691,6 +6691,19 @@ var GetVulByNodesMetadataZ = z26.object({
 
 // src/features/analysis/graphql/gql.ts
 var debug7 = Debug6("mobbdev:gql");
+function isAuthError(error) {
+  if (error instanceof ClientError) {
+    const gqlErrors = error.response?.errors;
+    return gqlErrors?.some(
+      (e) => e.extensions?.["code"] === "access-denied" || e.message?.includes("Authentication hook unauthorized")
+    ) ?? false;
+  }
+  return false;
+}
+function isNetworkError(error) {
+  const errorString = error?.toString() ?? "";
+  return errorString.includes("FetchError") || errorString.includes("TypeError") || errorString.includes("ECONNREFUSED") || errorString.includes("ENOTFOUND") || errorString.includes("ETIMEDOUT") || errorString.includes("UND_ERR");
+}
 var API_KEY_HEADER_NAME = "x-mobb-key";
 var REPORT_STATE_CHECK_DELAY = 5 * 1e3;
 var GQLClient = class {
@@ -6750,23 +6763,35 @@ var GQLClient = class {
     try {
       await this.getUserInfo();
     } catch (e) {
-      if (e?.toString().startsWith("FetchError")) {
-        debug7("verify connection failed %o", e);
+      if (isNetworkError(e)) {
+        debug7("verify connection failed (network error) %o", e);
         return false;
       }
+      debug7("verify connection: endpoint reachable but request failed %o", e);
     }
     return true;
   }
   async validateUserToken() {
-    await this.createCommunityUser();
-    let info;
     try {
-      info = await this.getUserInfo();
+      await this.createCommunityUser();
+      const info = await this.getUserInfo();
+      if (!info) {
+        debug7("verify token failed - no user info returned");
+        return false;
+      }
+      return info.email || true;
     } catch (e) {
-      debug7("verify token failed %o", e);
-      return false;
+      if (isAuthError(e)) {
+        debug7("verify token failed - auth error %o", e);
+        return false;
+      }
+      if (isNetworkError(e)) {
+        debug7("verify token failed - network error, rethrowing %o", e);
+        throw e;
+      }
+      debug7("verify token failed - unexpected error, rethrowing %o", e);
+      throw e;
     }
-    return info?.email || true;
   }
   async getLastOrgAndNamedProject(params) {
     const me = await this.getUserInfo();

package/dist/index.mjs

@@ -2304,20 +2304,20 @@ function computeCanonicalUrl(data) {
   } = data;
   switch (scmType) {
     case "GitHub" /* GitHub */:
-      return `https://${hostname}/${organization}/${repoName}`;
+      return `https://${hostname}/${organization.toLowerCase()}/${repoName.toLowerCase()}`;
     case "GitLab" /* GitLab */:
-      return `https://${hostname}/${projectPath}`;
+      return `https://${hostname}/${projectPath.toLowerCase()}`;
     case "Bitbucket" /* Bitbucket */:
-      return `https://${hostname}/${organization}/${repoName}`;
+      return `https://${hostname}/${organization.toLowerCase()}/${repoName.toLowerCase()}`;
     case "Ado" /* Ado */: {
       const adoHostname = hostname === "ssh.dev.azure.com" ? "dev.azure.com" : hostname;
       if (projectName) {
-        return `https://${adoHostname}/${organization}/${projectName}/_git/${repoName}`;
+        return `https://${adoHostname}/${organization.toLowerCase()}/${projectName.toLowerCase()}/_git/${repoName.toLowerCase()}`;
       }
-      return `https://${adoHostname}/${organization}/_git/${repoName}`;
+      return `https://${adoHostname}/${organization.toLowerCase()}/_git/${repoName.toLowerCase()}`;
     }
     default:
-      return `https://${hostname}/${projectPath}`;
+      return `https://${hostname}/${projectPath.toLowerCase()}`;
   }
 }
 function detectAdoUrl(args) {
@@ -11761,7 +11761,7 @@ import open from "open";
 
 // src/features/analysis/graphql/gql.ts
 import Debug6 from "debug";
-import { GraphQLClient } from "graphql-request";
+import { ClientError, GraphQLClient } from "graphql-request";
 import { v4 as uuidv4 } from "uuid";
 
 // src/mcp/core/Errors.ts
@@ -12097,6 +12097,19 @@ var GetVulByNodesMetadataZ = z26.object({
 
 // src/features/analysis/graphql/gql.ts
 var debug7 = Debug6("mobbdev:gql");
+function isAuthError(error) {
+  if (error instanceof ClientError) {
+    const gqlErrors = error.response?.errors;
+    return gqlErrors?.some(
+      (e) => e.extensions?.["code"] === "access-denied" || e.message?.includes("Authentication hook unauthorized")
+    ) ?? false;
+  }
+  return false;
+}
+function isNetworkError(error) {
+  const errorString = error?.toString() ?? "";
+  return errorString.includes("FetchError") || errorString.includes("TypeError") || errorString.includes("ECONNREFUSED") || errorString.includes("ENOTFOUND") || errorString.includes("ETIMEDOUT") || errorString.includes("UND_ERR");
+}
 var API_KEY_HEADER_NAME = "x-mobb-key";
 var REPORT_STATE_CHECK_DELAY = 5 * 1e3;
 var GQLClient = class {
@@ -12156,23 +12169,35 @@ var GQLClient = class {
     try {
       await this.getUserInfo();
     } catch (e) {
-      if (e?.toString().startsWith("FetchError")) {
-        debug7("verify connection failed %o", e);
+      if (isNetworkError(e)) {
+        debug7("verify connection failed (network error) %o", e);
         return false;
       }
+      debug7("verify connection: endpoint reachable but request failed %o", e);
     }
     return true;
   }
   async validateUserToken() {
-    await this.createCommunityUser();
-    let info;
     try {
-      info = await this.getUserInfo();
+      await this.createCommunityUser();
+      const info = await this.getUserInfo();
+      if (!info) {
+        debug7("verify token failed - no user info returned");
+        return false;
+      }
+      return info.email || true;
     } catch (e) {
-      debug7("verify token failed %o", e);
-      return false;
+      if (isAuthError(e)) {
+        debug7("verify token failed - auth error %o", e);
+        return false;
+      }
+      if (isNetworkError(e)) {
+        debug7("verify token failed - network error, rethrowing %o", e);
+        throw e;
+      }
+      debug7("verify token failed - unexpected error, rethrowing %o", e);
+      throw e;
     }
-    return info?.email || true;
   }
   async getLastOrgAndNamedProject(params) {
     const me = await this.getUserInfo();
@@ -16405,7 +16430,7 @@ var log = logger.log.bind(logger);
 
 // src/mcp/services/McpGQLClient.ts
 import crypto3 from "crypto";
-import { GraphQLClient as GraphQLClient2 } from "graphql-request";
+import { ClientError as ClientError2, GraphQLClient as GraphQLClient2 } from "graphql-request";
 import { v4 as uuidv42 } from "uuid";
 init_client_generates();
 init_configs();
@@ -16544,12 +16569,15 @@ import crypto2 from "crypto";
 import os5 from "os";
 import open4 from "open";
 init_configs();
-var McpAuthService = class {
+var _McpAuthService = class _McpAuthService {
   constructor(client) {
     __publicField(this, "client");
-    __publicField(this, "lastBrowserOpenTime", 0);
     this.client = client;
   }
+  /** Reset cooldown state. Used by tests to ensure isolation. */
+  static resetCooldown() {
+    _McpAuthService.lastBrowserOpenTime = 0;
+  }
   /**
    * Opens a browser window for authentication
    * @param url URL to open in browser
@@ -16558,14 +16586,15 @@ var McpAuthService = class {
   async openBrowser(url, isBackgoundCall) {
     if (isBackgoundCall) {
       const now = Date.now();
-      if (now - this.lastBrowserOpenTime < MCP_TOOLS_BROWSER_COOLDOWN_MS) {
+      if (now - _McpAuthService.lastBrowserOpenTime < MCP_TOOLS_BROWSER_COOLDOWN_MS) {
         logDebug(`browser cooldown active, skipping open for ${url}`);
-        return;
+        return false;
       }
     }
     logDebug(`opening browser url ${url}`);
     await open4(url);
-    this.lastBrowserOpenTime = Date.now();
+    _McpAuthService.lastBrowserOpenTime = Date.now();
+    return true;
   }
   /**
    * Handles the complete authentication flow
@@ -16587,7 +16616,12 @@ var McpAuthService = class {
     logDebug(`cli login created ${loginId}`);
     const webLoginUrl = `${WEB_APP_URL}/mvs-login`;
     const browserUrl = loginContext ? buildLoginUrl(webLoginUrl, loginId, os5.hostname(), loginContext) : `${webLoginUrl}/${loginId}?hostname=${os5.hostname()}`;
-    await this.openBrowser(browserUrl, isBackgoundCall);
+    const browserOpened = await this.openBrowser(browserUrl, isBackgoundCall);
+    if (!browserOpened) {
+      throw new AuthenticationError(
+        "Authentication required but browser cooldown is active"
+      );
+    }
     logDebug(`waiting for login to complete`);
     let newApiToken = null;
     for (let i = 0; i < MCP_LOGIN_MAX_WAIT / MCP_LOGIN_CHECK_DELAY; i++) {
@@ -16618,8 +16652,24 @@ var McpAuthService = class {
     return newApiToken;
   }
 };
+// Static so cooldown persists across McpAuthService instances
+__publicField(_McpAuthService, "lastBrowserOpenTime", 0);
+var McpAuthService = _McpAuthService;
 
 // src/mcp/services/McpGQLClient.ts
+function isAuthError2(error) {
+  if (error instanceof ClientError2) {
+    const gqlErrors = error.response?.errors;
+    return gqlErrors?.some(
+      (e) => e.extensions?.["code"] === "access-denied" || e.message?.includes("Authentication hook unauthorized")
+    ) ?? false;
+  }
+  return false;
+}
+function isNetworkError2(error) {
+  const errorString = error?.toString() ?? "";
+  return errorString.includes("FetchError") || errorString.includes("TypeError") || errorString.includes("ECONNREFUSED") || errorString.includes("ENOTFOUND") || errorString.includes("ETIMEDOUT") || errorString.includes("UND_ERR");
+}
 var McpGQLClient = class {
   constructor(args) {
     __publicField(this, "client");
@@ -16673,14 +16723,16 @@ var McpGQLClient = class {
       logDebug("[GraphQL] Me query successful", { result });
       return true;
     } catch (e) {
-      const error = e;
-      logDebug(`[GraphQL] API connection verification failed`, { error });
-      if (error?.toString().includes("FetchError")) {
-        logError("[GraphQL] API connection verification failed", { error });
+      logDebug("[GraphQL] API connection verification failed", { error: e });
+      if (isNetworkError2(e)) {
+        logError("[GraphQL] API endpoint unreachable (network error)", {
+          error: e
+        });
         return false;
       }
+      logDebug("[GraphQL] API endpoint is reachable (non-network error)");
+      return true;
     }
-    return true;
   }
   /**
    * Verifies both API endpoint reachability and user authentication
@@ -16951,11 +17003,27 @@ var McpGQLClient = class {
     try {
       await this.clientSdk.CreateCommunityUser();
       const info = await this.getUserInfo();
+      if (!info) {
+        logDebug("[GraphQL] User token is invalid (no user info returned)");
+        return false;
+      }
       logDebug("[GraphQL] User token validated successfully");
-      return info?.email || true;
+      return info.email || true;
     } catch (e) {
-      logError("[GraphQL] User token validation failed");
-      return false;
+      if (isAuthError2(e)) {
+        logDebug("[GraphQL] User token is invalid (auth error from server)");
+        return false;
+      }
+      if (isNetworkError2(e)) {
+        logError("[GraphQL] Token validation failed due to network error", {
+          error: e
+        });
+        throw e;
+      }
+      logError("[GraphQL] Token validation failed with unexpected error", {
+        error: e
+      });
+      throw e;
     }
   }
   async createCliLogin(variables) {
@@ -17263,7 +17331,15 @@ async function createAuthenticatedMcpGQLClient({
     throw new ApiConnectionError("Error: failed to reach Mobb GraphQL endpoint");
   }
   logDebug("[GraphQL] Validating user token");
-  const userVerify = await initialClient.validateUserToken();
+  let userVerify;
+  try {
+    userVerify = await initialClient.validateUserToken();
+  } catch (e) {
+    logError("[GraphQL] Token validation failed due to transient error", {
+      error: e
+    });
+    throw e;
+  }
   if (userVerify) {
     return initialClient;
   }
@@ -20214,13 +20290,7 @@ var BaseTool = class {
   }
   async execute(args) {
     if (this.hasAuthentication) {
-      logDebug(`Authenticating tool: ${this.name}`, { args });
-      const loginContext = createMcpLoginContext(this.name);
-      const mcpGqlClient = await createAuthenticatedMcpGQLClient({
-        loginContext
-      });
-      const userInfo2 = await mcpGqlClient.getUserInfo();
-      logDebug("User authenticated successfully", { userInfo: userInfo2 });
+      logDebug(`Tool ${this.name} requires authentication (handled by service)`);
     }
     const validatedArgs = this.validateInput(args);
     logDebug(`Tool ${this.name} input validation successful`, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobbdev",
-  "version": "1.2.34",
+  "version": "1.2.36",
   "description": "Automated secure code remediation tool",
   "repository": "git+https://github.com/mobb-dev/bugsy.git",
   "main": "dist/index.mjs",