mobbdev 1.0.185 → 1.0.188

package/dist/index.mjs

@@ -1692,6 +1692,7 @@ var IssueType_Enum = /* @__PURE__ */ ((IssueType_Enum2) => {
   IssueType_Enum2["DeclareVariableExplicitly"] = "DECLARE_VARIABLE_EXPLICITLY";
   IssueType_Enum2["DefaultRightsInObjDefinition"] = "DEFAULT_RIGHTS_IN_OBJ_DEFINITION";
   IssueType_Enum2["DeprecatedFunction"] = "DEPRECATED_FUNCTION";
+  IssueType_Enum2["DjangoBlankFieldNeedsNullOrDefault"] = "DJANGO_BLANK_FIELD_NEEDS_NULL_OR_DEFAULT";
   IssueType_Enum2["DosStringBuilder"] = "DOS_STRING_BUILDER";
   IssueType_Enum2["DoNotRaiseException"] = "DO_NOT_RAISE_EXCEPTION";
   IssueType_Enum2["DoNotThrowGenericException"] = "DO_NOT_THROW_GENERIC_EXCEPTION";
@@ -1765,6 +1766,7 @@ var IssueType_Enum = /* @__PURE__ */ ((IssueType_Enum2) => {
   IssueType_Enum2["Pt"] = "PT";
   IssueType_Enum2["RaceConditionFormatFlaw"] = "RACE_CONDITION_FORMAT_FLAW";
   IssueType_Enum2["Redos"] = "REDOS";
+  IssueType_Enum2["RedundantNilErrorCheck"] = "REDUNDANT_NIL_ERROR_CHECK";
   IssueType_Enum2["RegexInjection"] = "REGEX_INJECTION";
   IssueType_Enum2["RegexMissingTimeout"] = "REGEX_MISSING_TIMEOUT";
   IssueType_Enum2["RequestParametersBoundViaInput"] = "REQUEST_PARAMETERS_BOUND_VIA_INPUT";
@@ -2916,7 +2918,9 @@ var fixDetailsData = {
   ["FUNCTION_CALL_WITHOUT_PARENTHESES" /* FunctionCallWithoutParentheses */]: void 0,
   ["SPRING_DEFAULT_PERMIT" /* SpringDefaultPermit */]: void 0,
   ["RETURN_IN_INIT" /* ReturnInInit */]: void 0,
-  ["ACTION_NOT_PINNED_TO_COMMIT_SHA" /* ActionNotPinnedToCommitSha */]: void 0
+  ["ACTION_NOT_PINNED_TO_COMMIT_SHA" /* ActionNotPinnedToCommitSha */]: void 0,
+  ["DJANGO_BLANK_FIELD_NEEDS_NULL_OR_DEFAULT" /* DjangoBlankFieldNeedsNullOrDefault */]: void 0,
+  ["REDUNDANT_NIL_ERROR_CHECK" /* RedundantNilErrorCheck */]: void 0
 };
 
 // src/features/analysis/scm/shared/src/getIssueType.ts
@@ -3054,7 +3058,9 @@ var issueTypeMap = {
   ["FUNCTION_CALL_WITHOUT_PARENTHESES" /* FunctionCallWithoutParentheses */]: "Function Call Without Parentheses",
   ["SPRING_DEFAULT_PERMIT" /* SpringDefaultPermit */]: "Spring Default Permit",
   ["RETURN_IN_INIT" /* ReturnInInit */]: "Return in Init",
-  ["ACTION_NOT_PINNED_TO_COMMIT_SHA" /* ActionNotPinnedToCommitSha */]: "Action Not Pinned to Commit Sha"
+  ["ACTION_NOT_PINNED_TO_COMMIT_SHA" /* ActionNotPinnedToCommitSha */]: "Action Not Pinned to Commit Sha",
+  ["DJANGO_BLANK_FIELD_NEEDS_NULL_OR_DEFAULT" /* DjangoBlankFieldNeedsNullOrDefault */]: "Django Blank Field Needs Null or Default",
+  ["REDUNDANT_NIL_ERROR_CHECK" /* RedundantNilErrorCheck */]: "Redundant Nil Error Check"
 };
 var issueTypeZ = z.nativeEnum(IssueType_Enum);
 var getIssueTypeFriendlyString = (issueType) => {
@@ -5409,9 +5415,7 @@ var VulnerabilityReportIssueZ = BaseVulnerabilityReportIssueZ.merge(
 );
 var VulnerabilityReportIssueWithCodeFilePathZ = BaseVulnerabilityReportIssueZ.merge(
   z11.object({
-    codeFilePath: z11.string().nullable(),
-    //TODO: REMOVE THIS once we flush out all the reports that don't have codeFilePath
-    codeNodes: z11.array(z11.object({ path: z11.string() }))
+    codeFilePath: z11.string().nullable()
   })
 );
 var GetReportIssuesQueryZ = z11.object({
@@ -7619,14 +7623,38 @@ function getOctoKit(options) {
     //to debug the performance of these API calls.
     log: GITHUB_API_TOKEN ? console : void 0,
     request: {
-      fetch: getFetch(baseUrl)
-    },
-    retry: {
-      enabled: false
+      fetch: getFetch(baseUrl),
+      timeout: 1e4
+      // 10 second timeout
     },
-    throttle: {
-      enabled: false
-    }
+    retry: options?.isEnableRetries ? {
+      doNotRetry: [400, 401, 403, 404, 422],
+      // Don't retry on these status codes
+      retries: 3
+      // Retry up to 3 times
+    } : { enabled: false },
+    throttle: options?.isEnableRetries ? {
+      onRateLimit: (retryAfter, options2, octokit, retryCount) => {
+        octokit.log.warn(
+          `Request quota exhausted for request ${options2.method} ${options2.url}`
+        );
+        if (retryCount === 0) {
+          octokit.log.info(`Retrying after ${retryAfter} seconds!`);
+          return true;
+        }
+        return false;
+      },
+      onSecondaryRateLimit: (retryAfter, options2, octokit, retryCount) => {
+        octokit.log.warn(
+          `SecondaryRateLimit detected for request ${options2.method} ${options2.url}`
+        );
+        if (retryCount === 0) {
+          octokit.log.info(`Retrying after ${retryAfter} seconds!`);
+          return true;
+        }
+        return false;
+      }
+    } : { enabled: false }
   });
 }
 function isGithubActionActionToken(token) {
@@ -12373,6 +12401,12 @@ var WorkspaceService = class {
   static getKnownWorkspacePath() {
     return this.knownWorkspacePath;
   }
+  /**
+   * Clears the known workspace path cache
+   */
+  static clearKnownWorkspacePath() {
+    this.knownWorkspacePath = void 0;
+  }
   /**
    * Gets the workspace folder path from known path or environment variables
    * @returns The workspace folder path or undefined if none found
@@ -13883,6 +13917,7 @@ var McpServer = class {
     __publicField(this, "eventHandlers", /* @__PURE__ */ new Map());
     __publicField(this, "parentProcessCheckInterval");
     __publicField(this, "parentPid");
+    __publicField(this, "socketEventHandlers", /* @__PURE__ */ new Map());
     __publicField(this, "mcpUsageService");
     this.parentPid = process.ppid;
     this.mcpUsageService = govOrgId ? new McpUsageService(govOrgId) : null;
@@ -14003,31 +14038,43 @@ var McpServer = class {
     logInfo("Setting up parent process monitoring", {
       parentPid: this.parentPid
     });
-    process.stdin.on("close", async () => {
+    const stdinCloseHandler = async () => {
       logDebug("stdin closed - parent likely terminated");
       await this.handleParentProcessDeath("stdin-close");
-    });
-    process.stdin.on("end", async () => {
+    };
+    const stdinEndHandler = async () => {
       logDebug("stdin ended - parent likely terminated");
       await this.handleParentProcessDeath("stdin-end");
-    });
-    process.stdout.on("error", async (error) => {
+    };
+    const stdoutErrorHandler = async (...args) => {
+      const error = args[0];
       logWarn("stdout error - parent may have terminated", { error });
       if (error.message.includes("EPIPE") || error.message.includes("ECONNRESET")) {
         await this.handleParentProcessDeath("stdout-error");
       }
-    });
-    process.stderr.on("error", async (error) => {
+    };
+    const stderrErrorHandler = async (...args) => {
+      const error = args[0];
       logWarn("stderr error - parent may have terminated", { error });
       if (error.message.includes("EPIPE") || error.message.includes("ECONNRESET")) {
         await this.handleParentProcessDeath("stderr-error");
       }
-    });
+    };
+    const disconnectHandler = async () => {
+      logDebug("IPC disconnected - parent terminated");
+      await this.handleParentProcessDeath("ipc-disconnect");
+    };
+    this.socketEventHandlers.set("stdin-close", stdinCloseHandler);
+    this.socketEventHandlers.set("stdin-end", stdinEndHandler);
+    this.socketEventHandlers.set("stdout-error", stdoutErrorHandler);
+    this.socketEventHandlers.set("stderr-error", stderrErrorHandler);
+    this.socketEventHandlers.set("disconnect", disconnectHandler);
+    process.stdin.on("close", stdinCloseHandler);
+    process.stdin.on("end", stdinEndHandler);
+    process.stdout.on("error", stdoutErrorHandler);
+    process.stderr.on("error", stderrErrorHandler);
     if (process.send) {
-      process.on("disconnect", async () => {
-        logDebug("IPC disconnected - parent terminated");
-        await this.handleParentProcessDeath("ipc-disconnect");
-      });
+      process.on("disconnect", disconnectHandler);
       logDebug("IPC monitoring enabled");
     } else {
       logDebug("IPC not available - skipping IPC monitoring");
@@ -14094,6 +14141,7 @@ var McpServer = class {
         logError("Failed to connect to the API, skipping background scan");
         return;
       }
+      WorkspaceService.clearKnownWorkspacePath();
       const workspacePath = WorkspaceService.getWorkspaceFolderPath();
       if (workspacePath) {
         try {
@@ -14250,6 +14298,31 @@ var McpServer = class {
       this.parentProcessCheckInterval = void 0;
       logDebug("Parent process check interval cleared");
     }
+    this.socketEventHandlers.forEach((handler, eventType) => {
+      try {
+        switch (eventType) {
+          case "stdin-close":
+            process.stdin.removeListener("close", handler);
+            break;
+          case "stdin-end":
+            process.stdin.removeListener("end", handler);
+            break;
+          case "stdout-error":
+            process.stdout.removeListener("error", handler);
+            break;
+          case "stderr-error":
+            process.stderr.removeListener("error", handler);
+            break;
+          case "disconnect":
+            process.removeListener("disconnect", handler);
+            break;
+        }
+      } catch (error) {
+        logWarn(`Failed to remove ${eventType} listener`, { error });
+      }
+    });
+    this.socketEventHandlers.clear();
+    logDebug("Socket event handlers cleaned up");
     this.eventHandlers.forEach((handler, signal) => {
       process.removeListener(signal, handler);
     });
@@ -15968,28 +16041,21 @@ var PatchApplicationService = class {
     let finalContent = content;
     if (MCP_AUTO_FIX_DEBUG_MODE) {
       const fixType = fix.safeIssueType || "Security Issue";
-      let fixLink;
-      if (fix.fixUrl) {
-        fixLink = fix.fixUrl;
-      } else {
-        const apiUrl = process.env["API_URL"] || MCP_DEFAULT_API_URL;
-        const appBaseUrl = apiUrl.replace("/v1/graphql", "").replace("api.", "");
-        fixLink = `${appBaseUrl}/fixes/${fix.id}`;
-      }
       const commentPrefix = this.getCommentSyntax(filePath);
       const lines = content.split("\n");
       const lastLine = lines[lines.length - 1]?.trim() || "";
       const isMobbComment = lastLine.includes("Mobb security fix applied:");
       const spacing = isMobbComment ? "\n" : "\n\n";
+      const fixComment = `Mobb security fix applied: ${fixType} ${fix.fixUrl || ""}`;
       let comment;
       if (commentPrefix === "<!--") {
-        comment = `${spacing}<!-- Mobb security fix applied: ${fixType} ${fixLink} -->`;
+        comment = `${spacing}<!-- ${fixComment} -->`;
       } else if (commentPrefix === "/*") {
-        comment = `${spacing}/* Mobb security fix applied: ${fixType} ${fixLink} */`;
+        comment = `${spacing}/* ${fixComment} */`;
       } else if (commentPrefix === "(*") {
-        comment = `${spacing}(* Mobb security fix applied: ${fixType} ${fixLink} *)`;
+        comment = `${spacing}(* ${fixComment} *)`;
       } else {
-        comment = `${spacing}${commentPrefix} Mobb security fix applied: ${fixType} ${fixLink}`;
+        comment = `${spacing}${commentPrefix} ${fixComment}`;
       }
       finalContent = content + comment;
       logInfo(
@@ -15997,7 +16063,7 @@ var PatchApplicationService = class {
         {
           fixId: fix.id,
           fixType,
-          fixLink,
+          fixLink: fix.fixUrl,
           commentSyntax: commentPrefix,
           spacing: isMobbComment ? "single line" : "empty line above"
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobbdev",
-  "version": "1.0.185",
+  "version": "1.0.188",
   "description": "Automated secure code remediation tool",
   "repository": "git+https://github.com/mobb-dev/bugsy.git",
   "main": "dist/index.mjs",