mnfst 0.5.246 → 0.5.248

package/lib/manifest.appwrite.data.js

@@ -2,7 +2,7 @@
 
 (function () {
 
-const MANIFEST_BUILD_VERSION = '0.5.246';
+const MANIFEST_BUILD_VERSION = '0.5.248';
 
 /* Manifest Data Sources - Appwrite Integration */
 
@@ -91,6 +91,20 @@ async function initializeAppwriteClient() {
     return appwriteClientPromise;
 }
 
+// Shared Realtime: ONE instance (one socket) per tab, keyed to the client it
+// wraps. Auth identity events drop it (below) so the next use rebuilds against
+// the current session; manifest.data.realtime.js re-binds live channels.
+let realtimeCache = null;
+let realtimeClient = null;
+function getSharedRealtime(client) {
+    if (!client || !window.Appwrite?.Realtime) return null;
+    if (!realtimeCache || realtimeClient !== client) {
+        realtimeCache = new window.Appwrite.Realtime(client);
+        realtimeClient = client;
+    }
+    return realtimeCache;
+}
+
 // Get Appwrite data services (TablesDB, Storage, Realtime)
 // Works with or without auth plugin
 async function getAppwriteDataServices() {
@@ -102,7 +116,7 @@ async function getAppwriteDataServices() {
     return {
         tablesDB: window.Appwrite.TablesDB ? new window.Appwrite.TablesDB(client) : null,
         storage: window.Appwrite.Storage ? new window.Appwrite.Storage(client) : null,
-        realtime: window.Appwrite.Realtime ? new window.Appwrite.Realtime(client) : null
+        realtime: getSharedRealtime(client)
     };
 }
 
@@ -110,7 +124,10 @@ async function getAppwriteDataServices() {
 let authCheck = null;
 let authVerified = false;
 ['manifest:auth:login', 'manifest:auth:logout', 'manifest:auth:anonymous', 'manifest:auth:session-cleared', 'manifest:auth:initialized']
-    .forEach(type => window.addEventListener(type, () => { authCheck = null; authVerified = false; }));
+    .forEach(type => window.addEventListener(type, () => {
+        authCheck = null; authVerified = false;
+        realtimeCache = null; realtimeClient = null; // socket re-authenticates as the new identity
+    }));
 
 async function verifyAuthenticated() {
     if (!window.ManifestAppwriteAuthConfig || authVerified) return;
@@ -665,103 +682,89 @@ window.ManifestDataAppwrite = {
 };
 
 
-/* Manifest Data Sources - Real-time Subscriptions */
-
-// Track active subscriptions
-const subscriptions = new Map(); // Map<dataSourceName, unsubscribeFunction>
+/* Manifest Data Sources - Real-time Subscriptions
+   One shared Realtime client per tab; channels ref-counted across sources. */
+
+// Map<channel, { refs, unsubscribe, handlers: Map<sourceName, handler> }>
+const channels = new Map();
+// Map<sourceName, { channel, token }> — token guards a stale unsubscribe closure
+const sources = new Map();
+// Map<sourceName, fn(eventType, row)> — pre-filters, run per event per source
+const filters = new Map();
+// Back-compat/debug surface: Map<sourceName, unsubscribeFunction>
+const subscriptions = new Map();
+// Instance the current channel subscriptions live on
+let activeRealtime = null;
+
+function classify(event) {
+    if (typeof event !== 'string') return null;
+    if (event.includes('create')) return 'create';
+    if (event.includes('update')) return 'update';
+    if (event.includes('delete')) return 'delete';
+    return null;
+}
 
-// Subscribe to storage bucket file changes
-// isCurrent: false once the requesting load is superseded (logout) — skip, never touch a newer entry
-async function subscribeToStorageBucket(dataSourceName, bucketId, scope, onEvent, isCurrent) {
-    // Unsubscribe from existing subscription if any
-    if (subscriptions.has(dataSourceName)) {
-        const unsubscribe = subscriptions.get(dataSourceName);
-        if (unsubscribe && typeof unsubscribe === 'function') {
-            unsubscribe();
+// Fan one SDK message out: each registered source handler gets each event once,
+// after that source's pre-filter (setFilter) — before any merge/dedup work
+function dispatch(channel, response) {
+    const entry = channels.get(channel);
+    if (!entry || !response || !response.events) return;
+    const events = Array.isArray(response.events) ? response.events : [response.events];
+    let payload = response.payload;
+    if (!payload || (!payload.$id && !payload.row)) payload = response;
+    for (const event of events) {
+        const type = classify(event);
+        if (!type) continue;
+        for (const [name, handler] of entry.handlers) {
+            const filter = filters.get(name);
+            if (filter && filter(type, payload) === false) continue;
+            handler(type, payload);
         }
-        subscriptions.delete(dataSourceName);
     }
+}
 
-    const services = await window.ManifestDataAppwrite.getAppwriteDataServices();
-    if (isCurrent && !isCurrent()) return null;
-    if (!services?.realtime) {
-        console.warn('[Manifest Data] Realtime service not available for', dataSourceName);
-        return null;
-    }
-
-    // Channel format: buckets.[BUCKET_ID].files
-    const channel = `buckets.${bucketId}.files`;
-
-
-    try {
-        const unsubscribe = services.realtime.subscribe(channel, (response) => {
-            if (!response || !response.events) {
-                return;
-            }
-
-            // Handle both array and single event formats
-            const events = Array.isArray(response.events) ? response.events : [response.events];
-
-            events.forEach(event => {
-                if (typeof event !== 'string') return;
-
-                // Payload might be in response.payload or response directly
-                const payload = response.payload || response;
-
-                // Handle different event types
-                if (event.includes('create') || event.includes('storage.files.create')) {
-                    // New file created
-                    onEvent('create', payload);
-                } else if (event.includes('update') || event.includes('storage.files.update')) {
-                    // File updated
-                    onEvent('update', payload);
-                } else if (event.includes('delete') || event.includes('storage.files.delete')) {
-                    // File deleted
-                    onEvent('delete', payload);
-                }
-            });
-        });
-
-        subscriptions.set(dataSourceName, unsubscribe);
-
-        return unsubscribe;
-    } catch (error) {
-        console.error('[Manifest Data] Failed to subscribe to storage bucket:', error);
-        return null;
-    }
+function sdkSubscribe(realtime, channel) {
+    return realtime.subscribe(channel, response => dispatch(channel, response));
 }
 
-// Unsubscribe from a data source
-function unsubscribeFromDataSource(dataSourceName) {
-    if (subscriptions.has(dataSourceName)) {
-        const unsubscribe = subscriptions.get(dataSourceName);
-        if (unsubscribe && typeof unsubscribe === 'function') {
-            unsubscribe();
+// Drop a source's registration; tear the channel down when the last source leaves
+function detach(name, token) {
+    const cur = sources.get(name);
+    if (!cur || (token && cur.token !== token)) return;
+    sources.delete(name);
+    const entry = channels.get(cur.channel);
+    if (!entry) return;
+    entry.handlers.delete(name);
+    entry.refs = entry.handlers.size;
+    if (entry.refs === 0) {
+        channels.delete(cur.channel);
+        if (typeof entry.unsubscribe === 'function') {
+            try { entry.unsubscribe(); } catch (e) { /* socket already gone */ }
         }
-        subscriptions.delete(dataSourceName);
     }
 }
 
-// Unsubscribe from all data sources
-function unsubscribeAll() {
-    subscriptions.forEach((unsubscribe, dataSourceName) => {
-        if (unsubscribe && typeof unsubscribe === 'function') {
-            unsubscribe();
+// Instance changed (client rebuilt on identity change): re-bind live channels
+function syncInstance(realtime) {
+    if (activeRealtime === realtime) return;
+    activeRealtime = realtime;
+    for (const [channel, entry] of channels) {
+        if (typeof entry.unsubscribe === 'function') {
+            try { entry.unsubscribe(); } catch (e) { /* old instance */ }
         }
-    });
-    subscriptions.clear();
-}
-
-// Subscribe to database table row changes
-async function subscribeToTable(dataSourceName, databaseId, tableId, scope, onEvent, isCurrent) {
-    // Unsubscribe from existing subscription if any
-    if (subscriptions.has(dataSourceName)) {
-        const unsubscribe = subscriptions.get(dataSourceName);
-        if (unsubscribe && typeof unsubscribe === 'function') {
-            unsubscribe();
+        try {
+            entry.unsubscribe = sdkSubscribe(realtime, channel);
+        } catch (error) {
+            console.error('[Manifest Data] Failed to re-subscribe channel:', channel, error);
         }
-        subscriptions.delete(dataSourceName);
     }
+}
+
+// One SDK subscribe per distinct channel, however many sources share it.
+// isCurrent: false once the requesting load is superseded (logout) — skip, never touch a newer entry
+async function subscribeChannel(dataSourceName, channel, onEvent, isCurrent) {
+    detach(dataSourceName);
+    subscriptions.delete(dataSourceName);
 
     const services = await window.ManifestDataAppwrite.getAppwriteDataServices();
     if (isCurrent && !isCurrent()) return null;
@@ -769,55 +772,67 @@ async function subscribeToTable(dataSourceName, databaseId, tableId, scope, onEv
         console.warn('[Manifest Data] Realtime service not available for', dataSourceName);
         return null;
     }
+    syncInstance(services.realtime);
 
-    // Channel format: databases.[DATABASE_ID].tables.[TABLE_ID].rows
-    const channel = `databases.${databaseId}.tables.${tableId}.rows`;
-
-    try {
-        const unsubscribe = services.realtime.subscribe(channel, (response) => {
-            if (!response || !response.events) {
-                return;
-            }
+    let entry = channels.get(channel);
+    if (!entry) {
+        entry = { refs: 0, unsubscribe: null, handlers: new Map() };
+        try {
+            entry.unsubscribe = sdkSubscribe(services.realtime, channel);
+        } catch (error) {
+            console.error('[Manifest Data] Failed to subscribe:', channel, error);
+            return null;
+        }
+        channels.set(channel, entry);
+    }
+    const token = Symbol(dataSourceName);
+    entry.handlers.set(dataSourceName, onEvent);
+    entry.refs = entry.handlers.size;
+    sources.set(dataSourceName, { channel, token });
 
-            // Handle both array and single event formats
-            const events = Array.isArray(response.events) ? response.events : [response.events];
+    const unsubscribe = () => detach(dataSourceName, token);
+    subscriptions.set(dataSourceName, unsubscribe);
+    return unsubscribe;
+}
 
-            events.forEach(event => {
-                if (typeof event !== 'string') {
-                    return;
-                }
+// Subscribe to storage bucket file changes
+function subscribeToStorageBucket(dataSourceName, bucketId, scope, onEvent, isCurrent) {
+    return subscribeChannel(dataSourceName, `buckets.${bucketId}.files`, onEvent, isCurrent);
+}
 
-                // Payload might be in response.payload or response directly
-                // Appwrite realtime structure: { events: [...], payload: {...} }
-                let payload = response.payload;
+// Subscribe to database table row changes
+function subscribeToTable(dataSourceName, databaseId, tableId, scope, onEvent, isCurrent) {
+    return subscribeChannel(dataSourceName, `databases.${databaseId}.tables.${tableId}.rows`, onEvent, isCurrent);
+}
 
-                // If payload doesn't have $id, try response directly
-                if (!payload || (!payload.$id && !payload.row)) {
-                    payload = response;
-                }
+// Unsubscribe from a data source
+function unsubscribeFromDataSource(dataSourceName) {
+    detach(dataSourceName);
+    subscriptions.delete(dataSourceName);
+}
 
-                // Handle different event types
-                if (event.includes('create') || event.includes('rows.create') || event.includes('documents.create')) {
-                    // New row created
-                    onEvent('create', payload);
-                } else if (event.includes('update') || event.includes('rows.update') || event.includes('documents.update')) {
-                    // Row updated
-                    onEvent('update', payload);
-                } else if (event.includes('delete') || event.includes('rows.delete') || event.includes('documents.delete')) {
-                    // Row deleted
-                    onEvent('delete', payload);
-                } else {
-                }
-            });
-        });
+// Unsubscribe from all data sources
+function unsubscribeAll() {
+    for (const name of [...sources.keys()]) detach(name);
+    subscriptions.clear();
+}
 
-        subscriptions.set(dataSourceName, unsubscribe);
+// Programmatic pre-filter: fn(eventType, row) runs per event per source BEFORE
+// any merge/dedup work; returning false drops the event. null clears it.
+function setFilter(sourceName, fn) {
+    if (fn == null) filters.delete(sourceName);
+    else if (typeof fn === 'function') filters.set(sourceName, fn);
+}
 
-        return unsubscribe;
-    } catch (error) {
-        console.error('[Manifest Data] Failed to subscribe to table:', error);
-        return null;
-    }
+// Identity events rebuild the shared Realtime (manifest.data.appwrite.js drops
+// its memo on the same events); re-bind any live channels to the new instance
+if (typeof window !== 'undefined') {
+    ['manifest:auth:login', 'manifest:auth:logout', 'manifest:auth:anonymous', 'manifest:auth:session-cleared', 'manifest:auth:initialized']
+        .forEach(type => window.addEventListener(type, async () => {
+            if (!channels.size) return;
+            const services = await window.ManifestDataAppwrite?.getAppwriteDataServices?.();
+            if (services?.realtime) syncInstance(services.realtime);
+        }));
 }
 
 // Export functions
@@ -826,7 +841,9 @@ window.ManifestDataRealtime = {
     subscribeToTable,
     unsubscribeFromDataSource,
     unsubscribeAll,
-    subscriptions // Expose for debugging
+    setFilter,
+    subscriptions, // Expose for debugging
+    _channels: channels // Expose for debugging
 };
 
 
@@ -1186,6 +1203,86 @@ async function buildQueries(queriesConfig, scope, scopeColumns) {
     return [...scopeQueries, ...userQueries];
 }
 
+// Query methods buildAppwriteQueries serializes (anything else is dropped at
+// load and must therefore never drop rows in the realtime matcher below)
+const QUERY_MAP = {
+    'equal': 'equal',
+    'notEqual': 'notEqual',
+    'lessThan': 'lessThan',
+    'lessThanEqual': 'lessThanEqual',
+    'greaterThan': 'greaterThan',
+    'greaterThanEqual': 'greaterThanEqual',
+    'contains': 'contains',
+    'search': 'search',
+    'or': 'or', // Support for multi-team queries (Query.or([Query.equal(...), ...]))
+    'orderAsc': 'orderAsc',
+    'orderDesc': 'orderDesc',
+    'limit': 'limit',
+    'offset': 'offset',
+    'cursorAfter': 'cursorAfter',
+    'cursorBefore': 'cursorBefore'
+};
+
+// Client-side row matcher for realtime events: evaluates a source's configured
+// filter queries against one row. Only operators the load actually serializes
+// (QUERY_MAP) are evaluable. Liveness over precision: anything unevaluable —
+// search, an operator the load drops, or a $auth. arg that can't resolve
+// synchronously — counts as a MATCH so live events are never silently dropped.
+const NON_FILTER_METHODS = new Set(['limit', 'offset', 'orderAsc', 'orderDesc', 'select', 'cursorAfter', 'cursorBefore']);
+
+function rowMatchesQueries(row, queriesConfig) {
+    if (!row || !Array.isArray(queriesConfig) || queriesConfig.length === 0) return true;
+    return queriesConfig.every(query => matchQuery(row, query));
+}
+
+function matchQuery(row, query) {
+    if (!Array.isArray(query) || query.length === 0) return true;
+    let interpolated;
+    try {
+        interpolated = interpolateQuery(query);
+    } catch (e) {
+        if (e === NOT_READY) return true; // unresolved $auth. arg
+        throw e;
+    }
+    const [method, ...args] = interpolated;
+    if (NON_FILTER_METHODS.has(method)) return true;
+    if (!(method in QUERY_MAP)) return true; // load drops it: unevaluable
+    if (method === 'and') return Array.isArray(args[0]) ? args[0].every(sub => matchQuery(row, sub)) : true;
+    if (method === 'or') return Array.isArray(args[0]) ? args[0].some(sub => matchQuery(row, sub)) : true;
+
+    const attr = args[0];
+    const val = row ? row[attr] : undefined;
+    const values = Array.isArray(args[1]) ? args[1] : [args[1]];
+    // Strings compare case-insensitively (Appwrite's ci collation); other types strictly
+    const eq = (a, b) => (typeof a === 'string' && typeof b === 'string')
+        ? a.toLowerCase() === b.toLowerCase()
+        : a === b;
+    const anyEqual = () => Array.isArray(val)
+        ? values.some(v => val.some(el => eq(el, v)))
+        : values.some(v => eq(val, v));
+    const cmp = (bound, op) => val !== null && val !== undefined && bound !== null && bound !== undefined && op(val, bound);
+    const lower = s => String(s).toLowerCase();
+
+    switch (method) {
+        case 'equal': return anyEqual();
+        case 'notEqual': return !anyEqual();
+        case 'lessThan': return cmp(args[1], (a, b) => a < b);
+        case 'lessThanEqual': return cmp(args[1], (a, b) => a <= b);
+        case 'greaterThan': return cmp(args[1], (a, b) => a > b);
+        case 'greaterThanEqual': return cmp(args[1], (a, b) => a >= b);
+        case 'between': return cmp(args[1], (a, b) => a >= b) && cmp(args[2], (a, b) => a <= b);
+        case 'isNull': return val === null || val === undefined;
+        case 'isNotNull': return val !== null && val !== undefined;
+        case 'startsWith': return typeof val === 'string' && values.some(v => lower(val).startsWith(lower(v)));
+        case 'endsWith': return typeof val === 'string' && values.some(v => lower(val).endsWith(lower(v)));
+        case 'contains':
+            if (Array.isArray(val)) return values.some(v => val.some(el => eq(el, v)));
+            if (typeof val === 'string') return values.some(v => lower(val).includes(lower(v)));
+            return false;
+        default: return true; // search: unevaluable
+    }
+}
+
 // Convert query array to Appwrite Query object
 function toAppwriteQuery(queryArray) {
     if (!Array.isArray(queryArray) || queryArray.length === 0) {
@@ -1194,24 +1291,9 @@ function toAppwriteQuery(queryArray) {
 
     const [method, ...args] = queryArray;
 
-    // Map common query methods to Appwrite Query methods
-    const queryMap = {
-        'equal': 'equal',
-        'notEqual': 'notEqual',
-        'lessThan': 'lessThan',
-        'lessThanEqual': 'lessThanEqual',
-        'greaterThan': 'greaterThan',
-        'greaterThanEqual': 'greaterThanEqual',
-        'contains': 'contains',
-        'search': 'search',
-        'or': 'or', // Support for multi-team queries (Query.or([Query.equal(...), ...]))
-        'orderAsc': 'orderAsc',
-        'orderDesc': 'orderDesc',
-        'limit': 'limit',
-        'offset': 'offset',
-        'cursorAfter': 'cursorAfter',
-        'cursorBefore': 'cursorBefore'
-    };
+    // Map common query methods to Appwrite Query methods (QUERY_MAP above —
+    // also the realtime matcher's evaluable set)
+    const queryMap = QUERY_MAP;
 
     if (!window.Appwrite || !window.Appwrite.Query) {
         console.error('[Manifest Data] Appwrite Query not available');
@@ -1271,6 +1353,7 @@ window.ManifestDataQueries = {
     getAuthValue,
     buildQueries,
     buildAppwriteQueries,
+    rowMatchesQueries,
     toAppwriteQuery,
     ALLOWED_VARIABLES,
     DEFAULT_SCOPE_COLUMNS