mlgym-deploy 3.3.13 → 3.3.14

package/index.js

@@ -1042,6 +1042,9 @@ async function detectDeploymentStrategy(projectPath) {
 }
 
 // Validate and potentially fix docker-compose.yml for Coolify compliance
+// IMPORTANT: For Coolify/Traefik routing, we must use "expose:" instead of "ports:"
+// Using "ports: 80:3000" tries to bind host port 80, which conflicts with Traefik
+// Using "expose: 3000" lets Traefik route traffic via docker labels (correct approach)
 function validateAndFixDockerCompose(content) {
   const lines = content.split('\n');
   const issues = [];
@@ -1049,8 +1052,10 @@ function validateAndFixDockerCompose(content) {
   let fixed = [...lines];
   let inServicesSection = false;
   let inPortsSection = false;
+  let portsLineIndex = -1;
   let currentService = '';
   let currentIndent = '';
+  let portsIndent = '';
 
   for (let i = 0; i < lines.length; i++) {
     const line = lines[i];
@@ -1074,38 +1079,45 @@ function validateAndFixDockerCompose(content) {
     if ((line.startsWith('  ') || line.startsWith('\t')) &&
         trimmed.endsWith(':') &&
         !trimmed.startsWith('-') &&
-        !['ports:', 'expose:', 'environment:', 'volumes:', 'networks:'].includes(trimmed)) {
+        !['ports:', 'expose:', 'environment:', 'volumes:', 'networks:', 'depends_on:', 'healthcheck:', 'build:', 'image:', 'command:', 'labels:'].includes(trimmed)) {
       currentService = trimmed.slice(0, -1);
       currentIndent = line.match(/^(\s*)/)[1];
     }
 
-    // Check for ports section
+    // Check for ports section - we'll convert this to expose
     if (trimmed === 'ports:') {
       inPortsSection = true;
+      portsLineIndex = i;
+      portsIndent = line.match(/^(\s*)/)[1];
+      // Change "ports:" to "expose:"
+      fixed[i] = line.replace('ports:', 'expose:');
+      fixes.push(`${currentService}: Changed "ports:" to "expose:" for Traefik compatibility`);
       continue;
     }
 
-    // Process port entries
+    // Process port entries - convert "HOST:CONTAINER" to just "CONTAINER"
     if (inPortsSection && trimmed.startsWith('- ')) {
       const portEntry = trimmed.slice(2).replace(/['"]/g, '');
 
       if (portEntry.includes(':')) {
+        // Has host:container mapping - extract just the container port
         const [external, internal] = portEntry.split(':').map(p => p.trim());
-        const webPorts = ['80', '8080', '3000', '4000', '5000', '8000', '9000'];
+        const webPorts = ['80', '8080', '3000', '4000', '5000', '8000', '9000', '4567', '8888'];
 
-        if (webPorts.includes(internal) && external !== '80') {
+        if (webPorts.includes(internal)) {
           issues.push({
             line: i + 1,
             service: currentService,
-            issue: `Port mapping "${external}:${internal}" not allowed`,
-            fix: `Use "80:${internal}" instead`
+            issue: `Port mapping "${external}:${internal}" binds to host port`,
+            fix: `Use expose: "${internal}" for Traefik routing`
           });
 
-          // Fix the line - preserve internal port
-          fixed[i] = line.replace(trimmed, `- "80:${internal}"`);
-          fixes.push(`Fixed ${currentService}: ${external}:${internal} → 80:${internal}`);
+          // Fix the line - use only internal port for expose
+          fixed[i] = line.replace(trimmed, `- "${internal}"`);
+          fixes.push(`${currentService}: ${external}:${internal} → expose: ${internal}`);
         }
       }
+      // If it's just a single port (no colon), leave it as-is for expose
     } else if (inPortsSection && !trimmed.startsWith('-')) {
       inPortsSection = false;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mlgym-deploy",
-  "version": "3.3.13",
+  "version": "3.3.14",
   "description": "MCP server for MLGym - Complete deployment management: deploy, configure, monitor, and rollback applications",
   "main": "index.js",
   "type": "module",