mixdog 0.9.38 → 0.9.39

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (114) hide show
  1. package/package.json +9 -4
  2. package/scripts/abort-recovery-test.mjs +43 -2
  3. package/scripts/agent-tag-reuse-smoke.mjs +146 -6
  4. package/scripts/agent-terminal-reap-test.mjs +127 -0
  5. package/scripts/agent-trace-io-test.mjs +69 -0
  6. package/scripts/code-graph-disk-hit-test.mjs +224 -0
  7. package/scripts/execution-completion-dedup-test.mjs +157 -0
  8. package/scripts/execution-pending-resume-kick-test.mjs +57 -2
  9. package/scripts/execution-resume-esc-integration-test.mjs +174 -0
  10. package/scripts/explore-bench.mjs +38 -2
  11. package/scripts/explore-prompt-policy-test.mjs +152 -11
  12. package/scripts/find-fuzzy-hidden-test.mjs +122 -0
  13. package/scripts/internal-comms-bench-test.mjs +226 -0
  14. package/scripts/internal-comms-bench.mjs +185 -58
  15. package/scripts/internal-comms-smoke.mjs +171 -23
  16. package/scripts/live-worker-smoke.mjs +38 -2
  17. package/scripts/memory-cycle-routing-test.mjs +111 -0
  18. package/scripts/memory-rule-contract-test.mjs +93 -0
  19. package/scripts/output-style-smoke.mjs +2 -2
  20. package/scripts/rg-runner-test.mjs +240 -0
  21. package/scripts/routing-corpus-test.mjs +349 -0
  22. package/scripts/routing-corpus.mjs +211 -32
  23. package/scripts/session-orphan-sweep-test.mjs +83 -0
  24. package/scripts/steering-drain-buckets-test.mjs +179 -0
  25. package/scripts/tool-smoke.mjs +21 -13
  26. package/scripts/tool-tui-presentation-test.mjs +202 -0
  27. package/src/agents/heavy-worker/AGENT.md +10 -7
  28. package/src/agents/reviewer/AGENT.md +6 -4
  29. package/src/agents/worker/AGENT.md +7 -5
  30. package/src/rules/agent/00-common.md +4 -4
  31. package/src/rules/agent/00-core.md +11 -14
  32. package/src/rules/agent/20-skip-protocol.md +3 -3
  33. package/src/rules/agent/30-explorer.md +50 -60
  34. package/src/rules/agent/40-cycle1-agent.md +15 -24
  35. package/src/rules/agent/41-cycle2-agent.md +33 -57
  36. package/src/rules/agent/42-cycle3-agent.md +28 -42
  37. package/src/rules/lead/01-general.md +7 -10
  38. package/src/rules/lead/lead-brief.md +11 -14
  39. package/src/rules/lead/lead-tool.md +6 -5
  40. package/src/rules/shared/01-tool.md +44 -45
  41. package/src/runtime/agent/orchestrator/agent-trace-format.mjs +37 -1
  42. package/src/runtime/agent/orchestrator/agent-trace-io.mjs +20 -5
  43. package/src/runtime/agent/orchestrator/providers/codex-client-meta.mjs +21 -1
  44. package/src/runtime/agent/orchestrator/providers/openai-oauth.mjs +17 -38
  45. package/src/runtime/agent/orchestrator/session/agent-loop.mjs +17 -8
  46. package/src/runtime/agent/orchestrator/session/context-utils.mjs +270 -78
  47. package/src/runtime/agent/orchestrator/session/loop/tool-helpers.mjs +2 -1
  48. package/src/runtime/agent/orchestrator/session/manager/delivered-completions.mjs +123 -0
  49. package/src/runtime/agent/orchestrator/session/manager/idle-cleanup.mjs +15 -2
  50. package/src/runtime/agent/orchestrator/session/manager/pending-messages.mjs +41 -2
  51. package/src/runtime/agent/orchestrator/session/manager/session-close.mjs +1 -1
  52. package/src/runtime/agent/orchestrator/session/store.mjs +223 -42
  53. package/src/runtime/agent/orchestrator/tools/builtin/arg-guard.mjs +12 -1
  54. package/src/runtime/agent/orchestrator/tools/builtin/builtin-tools.mjs +25 -20
  55. package/src/runtime/agent/orchestrator/tools/builtin/fs-reachability.mjs +6 -2
  56. package/src/runtime/agent/orchestrator/tools/builtin/fuzzy-match.mjs +118 -53
  57. package/src/runtime/agent/orchestrator/tools/builtin/list-tool.mjs +106 -29
  58. package/src/runtime/agent/orchestrator/tools/builtin/path-utils.mjs +8 -1
  59. package/src/runtime/agent/orchestrator/tools/builtin/read-batch.mjs +4 -2
  60. package/src/runtime/agent/orchestrator/tools/builtin/read-range-index.mjs +3 -1
  61. package/src/runtime/agent/orchestrator/tools/builtin/read-snapshot-runtime.mjs +4 -1
  62. package/src/runtime/agent/orchestrator/tools/builtin/read-tool.mjs +33 -2
  63. package/src/runtime/agent/orchestrator/tools/builtin/rg-runner.mjs +151 -64
  64. package/src/runtime/agent/orchestrator/tools/builtin/search-path-diagnostics.mjs +37 -13
  65. package/src/runtime/agent/orchestrator/tools/builtin/search-tool.mjs +84 -49
  66. package/src/runtime/agent/orchestrator/tools/code-graph/build.mjs +172 -23
  67. package/src/runtime/agent/orchestrator/tools/code-graph/constants.mjs +3 -0
  68. package/src/runtime/agent/orchestrator/tools/code-graph/disk-cache.mjs +68 -5
  69. package/src/runtime/agent/orchestrator/tools/code-graph/dispatch.mjs +17 -3
  70. package/src/runtime/agent/orchestrator/tools/code-graph/graph-binary.mjs +24 -10
  71. package/src/runtime/agent/orchestrator/tools/code-graph-prewarm-worker.mjs +6 -3
  72. package/src/runtime/agent/orchestrator/tools/code-graph-tool-defs.mjs +4 -7
  73. package/src/runtime/agent/orchestrator/tools/code-graph.mjs +1 -0
  74. package/src/runtime/agent/orchestrator/tools/patch-tool-defs.mjs +1 -1
  75. package/src/runtime/memory/lib/memory-cycle2-gate.mjs +4 -4
  76. package/src/runtime/memory/lib/memory-cycle2-mutations.mjs +4 -3
  77. package/src/runtime/memory/lib/memory-cycle3.mjs +12 -2
  78. package/src/runtime/shared/tool-primitives.mjs +4 -1
  79. package/src/runtime/shared/tool-status.mjs +27 -0
  80. package/src/runtime/shared/tool-surface.mjs +6 -3
  81. package/src/session-runtime/config-helpers.mjs +14 -0
  82. package/src/session-runtime/context-status.mjs +1 -0
  83. package/src/session-runtime/effort.mjs +6 -2
  84. package/src/session-runtime/model-recency.mjs +5 -2
  85. package/src/session-runtime/runtime-core.mjs +35 -2
  86. package/src/session-runtime/tool-catalog.mjs +34 -0
  87. package/src/standalone/agent-tool/notify.mjs +13 -0
  88. package/src/standalone/agent-tool.mjs +45 -69
  89. package/src/standalone/explore-tool.mjs +6 -7
  90. package/src/tui/App.jsx +31 -0
  91. package/src/tui/app/model-options.mjs +5 -3
  92. package/src/tui/app/model-picker.mjs +12 -24
  93. package/src/tui/app/transcript-window.mjs +1 -0
  94. package/src/tui/components/ToolExecution.jsx +11 -6
  95. package/src/tui/components/TranscriptItem.jsx +1 -1
  96. package/src/tui/components/tool-execution/surface-detail.mjs +24 -10
  97. package/src/tui/components/tool-execution/text-format.mjs +10 -19
  98. package/src/tui/dist/index.mjs +517 -142
  99. package/src/tui/engine/agent-job-feed.mjs +144 -17
  100. package/src/tui/engine/agent-response-tail.mjs +68 -0
  101. package/src/tui/engine/notification-plan.mjs +16 -0
  102. package/src/tui/engine/session-api.mjs +8 -2
  103. package/src/tui/engine/session-flow.mjs +19 -1
  104. package/src/tui/engine/tool-card-results.mjs +54 -32
  105. package/src/tui/engine/tool-result-status.mjs +75 -21
  106. package/src/tui/engine/turn.mjs +77 -42
  107. package/src/tui/engine.mjs +63 -2
  108. package/src/workflows/bench/WORKFLOW.md +25 -35
  109. package/src/workflows/default/WORKFLOW.md +38 -32
  110. package/src/workflows/solo/WORKFLOW.md +19 -22
  111. package/scripts/_jitter-fuzz.mjs +0 -44410
  112. package/scripts/_jitter-fuzz2.mjs +0 -44400
  113. package/scripts/_jitter-probe.mjs +0 -44397
  114. package/scripts/_jp2.mjs +0 -45614
@@ -8,27 +8,75 @@
8
8
  * keeps calling them unchanged.
9
9
  */
10
10
  import { toolErrorDisplay } from './tool-result-text.mjs';
11
+ import {
12
+ normalizeToolTerminalStatus,
13
+ toolResultTerminalStatus,
14
+ } from '../../runtime/shared/tool-status.mjs';
11
15
 
12
16
  export const CANCELLED_RESULT_STATUS_LINE = '[status: cancelled]';
13
17
 
18
+ // Detect a shell command that RAN but exited non-zero (a process exit code)
19
+ // as opposed to a real tool-call failure (`[shell-tool-failed]`) or a
20
+ // timeout/abort. bash-tool.mjs emits `Error: [shell-run-failed] [exit code: N]`
21
+ // for a plain non-zero exit; timeout/signal cases carry `[timeout: …]`/
22
+ // `[signal: …]` instead of an `[exit code: …]` marker. Returns the numeric
23
+ // exit code (>= 0) for a command-exit, or null otherwise.
24
+ export function shellCommandExitCode(text) {
25
+ const body = String(text || '');
26
+ // Anchor to the START of the result so a success/non-shell body that merely
27
+ // QUOTES the marker mid-output is never misclassified. bash-tool emits
28
+ // `Error: [shell-run-failed] [exit code: N]` as the leading marker header.
29
+ if (!/^\s*(?:Error:\s*)?\[shell-run-failed\]/i.test(body)) return null;
30
+ // Restrict marker parsing to the header region (first line) so only the
31
+ // engine-emitted status header — not quoted command output below — counts.
32
+ const header = body.split('\n', 1)[0] || '';
33
+ // Timeout / signal / abort are NOT a plain command exit — keep them "Failed".
34
+ if (/\[timeout:|\[signal:|timed out|aborted|interrupted/i.test(header)) return null;
35
+ const m = header.match(/\[exit code:\s*(\d+)\]/i);
36
+ if (!m) return null;
37
+ const code = Number(m[1]);
38
+ return Number.isFinite(code) ? code : null;
39
+ }
40
+
41
+ // Only provider envelope metadata establishes a failed invocation. Result
42
+ // bodies can contain "Error:"/HTTP/domain/task status text without making the
43
+ // call itself fail. A recognized plain shell exit wins over provider envelope
44
+ // error flags: adapters commonly label non-zero process exits as tool errors
45
+ // even though the shell tool itself ran successfully.
46
+ export function toolCallOutcome(message, rawText) {
47
+ const exitCode = shellCommandExitCode(rawText);
48
+ if (exitCode != null) {
49
+ return { isCallError: false, isExitError: true, exitCode };
50
+ }
51
+ const isCallError = message?.isError === true || message?.toolKind === 'error';
52
+ return {
53
+ isCallError,
54
+ isExitError: false,
55
+ exitCode,
56
+ };
57
+ }
58
+
59
+ // Build the collapsed failure/exit detail string. Real tool-call/result
60
+ // failures keep the red-adjacent "Failed" wording; shell command-exits render
61
+ // as the distinct neutral "Exit" state ("Exit N" for a single exit, "Y Exit"
62
+ // grouped). A mixed group surfaces both ("1 Ok · 1 Failed · 1 Exit").
63
+ export function failureDetailText({ succeeded = 0, realErrors = 0, exitErrors = 0, exitCode } = {}) {
64
+ const parts = [];
65
+ if (succeeded > 0) parts.push(`${succeeded} Ok`);
66
+ if (realErrors > 0) parts.push(`${realErrors} Failed`);
67
+ if (exitErrors > 0) {
68
+ const solo = exitErrors === 1 && realErrors === 0 && succeeded === 0;
69
+ parts.push(solo && Number.isFinite(exitCode) ? `Exit ${exitCode}` : `${exitErrors} Exit`);
70
+ }
71
+ return parts.join(' · ');
72
+ }
73
+
14
74
  export function normalizedResultStatusToken(value) {
15
- const raw = String(value || '').trim().toLowerCase();
16
- if (!raw) return '';
17
- if (/^(running|pending|queued|in_progress|in-progress)$/.test(raw)) return 'running';
18
- if (/^(completed|complete|done|success|succeeded|ok)$/.test(raw)) return 'completed';
19
- if (/^(failed|fail|error|errored|timeout|timed_out|killed)$/.test(raw)) return 'failed';
20
- if (/^(cancelled|canceled|cancel)$/.test(raw)) return 'cancelled';
21
- return '';
75
+ return normalizeToolTerminalStatus(value);
22
76
  }
23
77
 
24
78
  export function resultTextTerminalStatus(text) {
25
- const body = String(text || '');
26
- const tagged = body.match(/<status[^>]*>([\s\S]*?)<\/status>/i)?.[1]?.trim();
27
- if (tagged) return normalizedResultStatusToken(tagged);
28
- const bracketed = body.match(/^\[status:\s*([^\]]*)\]/mi)?.[1]?.trim();
29
- if (bracketed) return normalizedResultStatusToken(bracketed);
30
- const inline = body.match(/^(?:status|state):\s*([^\s·,;]+)/mi)?.[1]?.trim();
31
- return normalizedResultStatusToken(inline);
79
+ return toolResultTerminalStatus(text);
32
80
  }
33
81
 
34
82
  export function itemHasKnownTerminalStatus(item, texts = []) {
@@ -57,16 +105,18 @@ export function withCancelledResultMarker(text, item) {
57
105
  export function groupedToolResultText(group) {
58
106
  const completed = Math.min(group.count, group.completed);
59
107
  if (group.count <= 1) return group.results.at(-1)?.text ?? '';
60
- if (group.errors > 0) {
61
- const succeeded = Math.max(0, completed - group.errors);
108
+ const exitErrors = Number(group.exitErrors || 0);
109
+ if (group.errors > 0 || exitErrors > 0) {
110
+ const realErrors = Math.max(0, Number(group.callErrors || group.errors || 0));
111
+ const succeeded = Math.max(0, completed - group.errors - exitErrors);
112
+ const exitCode = group.results.find((result) => result?.isExitError)?.exitCode;
113
+ // Command-exits carry no failure reason line; only real failures do.
62
114
  const reasons = group.results
63
- .filter((result) => result?.isError)
115
+ .filter((result) => result?.isError && !result?.isExitError)
64
116
  .map((result) => firstErrorLine(result?.text))
65
117
  .filter(Boolean);
66
118
  const uniqueReasons = [...new Set(reasons)].slice(0, 2);
67
- const base = succeeded > 0
68
- ? `${succeeded} Ok · ${group.errors} Failed`
69
- : `${group.errors} Failed`;
119
+ const base = failureDetailText({ succeeded, realErrors, exitErrors, exitCode });
70
120
  return [
71
121
  `${base}${uniqueReasons[0] ? ` · ${uniqueReasons[0]}` : ''}`,
72
122
  ...uniqueReasons.slice(1),
@@ -102,7 +152,7 @@ export function aggregateRawResult(calls) {
102
152
  return chunks.join('\n\n');
103
153
  }
104
154
 
105
- export function aggregateBucketForCategory(category) {
155
+ export function aggregateBucketForCategory(category, { agentBatch = '' } = {}) {
106
156
  // Merge consecutive tool calls of the SAME category into one aggregate card;
107
157
  // a different category opens a fresh card (no cross-category merge). The
108
158
  // bucket key is the category itself, so a run of Search calls collapses into
@@ -117,6 +167,10 @@ export function aggregateBucketForCategory(category) {
117
167
  // header still spells out both. State-changing categories (Patch/Shell/…)
118
168
  // stay separate.
119
169
  if (key === 'Read' || key === 'Search') return 'category:Read+Search';
170
+ // Agent actions are grouped only inside the provider callback that emitted
171
+ // them. This keeps a later provider batch from changing an older outbound
172
+ // card above an intervening result/transcript boundary.
173
+ if (key === 'Agent') return agentBatch ? `category:Agent:${agentBatch}` : 'category:Agent';
120
174
  return key ? `category:${key}` : 'default';
121
175
  }
122
176
 
@@ -6,11 +6,9 @@ import { applyUsageDelta } from './session-stats.mjs';
6
6
  import { pickVerb, pickDoneVerb, compactEventLabel, compactEventDetail } from './labels.mjs';
7
7
  import { toolResultText, toolErrorDisplay } from './tool-result-text.mjs';
8
8
  import { toolCallId, toolResultCallId, toolCallName, toolCallArgs } from './tool-call-fields.mjs';
9
- import { toolResultStatus, isErrorToolStatus } from './agent-envelope.mjs';
10
9
  import { promptDisplayText, STEERING_SUPPRESSED_DISPLAY } from './queue-helpers.mjs';
11
- import { memoryCoreResultErrorText } from '../app/input-parsers.mjs';
12
10
  import { yieldToRenderer } from './render-timing.mjs';
13
- import { aggregateRawResult, aggregateBucketForCategory, aggregateSummaries, assignAggregateSummaryOrder } from './tool-result-status.mjs';
11
+ import { aggregateRawResult, aggregateBucketForCategory, aggregateSummaries, assignAggregateSummaryOrder, failureDetailText, toolCallOutcome } from './tool-result-status.mjs';
14
12
 
15
13
  export function createRunTurn(bag) {
16
14
  const {
@@ -42,6 +40,9 @@ export function createRunTurn(bag) {
42
40
  reclaimed: false,
43
41
  committed: false,
44
42
  requeueEntries: Array.isArray(options.requeueOnAbort) ? options.requeueOnAbort.slice() : [],
43
+ discardExecutionPendingResumeKeys: Array.isArray(options.discardExecutionPendingResumeKeys)
44
+ ? options.discardExecutionPendingResumeKeys.slice()
45
+ : [],
45
46
  };
46
47
  set({ busy: true, lastTurn: null, spinner: { active: true, verb: pickVerb(turnIndex), startedAt, responseLength: 0, inputTokens: 0, outputTokens: 0, mode: 'requesting' } });
47
48
 
@@ -130,6 +131,15 @@ export function createRunTurn(bag) {
130
131
  };
131
132
  armWatchdog();
132
133
  let currentAssistantText = '';
134
+ // Segments sealed as their own assistant item(s) this turn via
135
+ // commitAssistantSegment (e.g. a tool preamble, then a no-newline tail
136
+ // committed by onSteerMessage before an injected steering row). Kept as an
137
+ // ordered list — NOT one concatenated string — so finalization can strip
138
+ // each committed segment out of the provider's final content individually.
139
+ // A single concatenation breaks when the provider omits an earlier segment
140
+ // (e.g. a tool preamble) from result.content: the combined prefix no longer
141
+ // matches and the tail would duplicate after the steering row.
142
+ const committedSegments = [];
133
143
  let thinkingText = '';
134
144
  let thinkingStartedAt = 0;
135
145
  let thinkingSegmentStartedAt = 0;
@@ -147,6 +157,7 @@ export function createRunTurn(bag) {
147
157
  const earlyResultBuffer = new Map();
148
158
  const aggregateCards = []; // active aggregate cards in the current consecutive tool block
149
159
  let tailAggregate = null; // most recently touched aggregate card; only the tail may absorb the next same-bucket call
160
+ let providerToolBatch = 0;
150
161
 
151
162
  // ── Deferred tool-card push (scroll/text sync) ────────────────────────────
152
163
  // A tool card used to enter the transcript the instant onToolCall fired,
@@ -163,13 +174,11 @@ export function createRunTurn(bag) {
163
174
  // cards are pushed alongside the result-bearing one before their own delay
164
175
  // elapses and would otherwise paint an empty reserved band.
165
176
  // Mirrors components/ToolExecution.jsx TOOL_PENDING_SHOW_DELAY_MS.
166
- // [jitter fix] Reserve the tool-card row immediately instead of after a
167
- // 1000ms delay. Delayed insertion made rows appear late and shove the body
168
- // vertically; pushing now (with the real 'Running' header height via
169
- // deferredDisplayReady) keeps the layout stable. The timer path is kept as a
170
- // 0ms microtask fallback for entries that are registered but not explicitly
171
- // surfaced, preserving call-order flush semantics.
172
- const TOOL_CARD_PUSH_DELAY_MS = 0;
177
+ // Keep a fast call off-screen until it either resolves or has genuinely
178
+ // been pending long enough to communicate work. This avoids a one-frame
179
+ // Running→Finished flash while preserving the deferred entry's ordered,
180
+ // result-forced materialization path.
181
+ const TOOL_CARD_PUSH_DELAY_MS = 1000;
173
182
  let deferredSeqCounter = 0;
174
183
  const deferredEntries = []; // creation-order list; each is pushed at most once
175
184
  // Push this entry AND every earlier-created still-deferred entry, in order,
@@ -328,13 +337,15 @@ export function createRunTurn(bag) {
328
337
  aggregate.ensureVisible?.();
329
338
  const errors = allCalls.filter((r) => r.isError).length;
330
339
  const callErrors = allCalls.filter((r) => r.isCallError).length;
340
+ const exitErrors = allCalls.filter((r) => r.isExitError).length;
331
341
  const completed = allCalls.filter((r) => r.resolved).length;
332
- const succeeded = completed - errors;
342
+ const succeeded = Math.max(0, completed - errors - exitErrors);
333
343
  const rawResult = aggregateRawResult(allCalls);
334
- // Merged count summary (see patchToolCardResult); failures keep
335
- // 'N Ok · N Failed'. Raw preserved for ctrl+o expansion.
336
- const displayDetail = errors > 0
337
- ? (succeeded > 0 ? `${succeeded} Ok · ${errors} Failed` : `${errors} Failed`)
344
+ // Merged count summary (see patchToolCardResult); real failures keep
345
+ // 'N Failed', shell command-exits render 'Exit N'/'Y Exit'. Raw
346
+ // preserved for ctrl+o expansion.
347
+ const displayDetail = errors > 0 || exitErrors > 0
348
+ ? failureDetailText({ succeeded, realErrors: callErrors, exitErrors, exitCode: allCalls.find((r) => r.isExitError)?.exitCode })
338
349
  : formatAggregateDetail(aggregateSummaries(aggregate));
339
350
  patchItem(aggregate.itemId, {
340
351
  result: displayDetail,
@@ -343,6 +354,7 @@ export function createRunTurn(bag) {
343
354
  isError: errors > 0,
344
355
  errorCount: errors,
345
356
  callErrorCount: callErrors,
357
+ exitErrorCount: exitErrors,
346
358
  count: allCalls.length,
347
359
  completedCount: allCalls.length,
348
360
  doneCategories: aggregateDoneCategories(allCalls),
@@ -463,6 +475,7 @@ export function createRunTurn(bag) {
463
475
  if (sealToolBlock) clearAggregateContinuation();
464
476
  const id = currentAssistantId || ensureAssistant(text);
465
477
  patchItem(id, { text, streaming: false });
478
+ committedSegments.push(text);
466
479
  closeAssistantSegment();
467
480
  return true;
468
481
  };
@@ -658,35 +671,33 @@ export function createRunTurn(bag) {
658
671
  if (!callRec || callRec.resolved || callRec.completedEarly) return;
659
672
  aggregate.ensureVisible?.();
660
673
  const rawText = toolResultText(message?.content);
661
- // Recover flattened memory "core" op failures (isError dropped upstream)
662
- // so they are excluded from the done count see memoryCoreResultErrorText.
663
- // Gated to Memory calls: the text-matcher's ^(error|failed) catch-all
664
- // would otherwise misflag legitimate non-memory success output.
665
- const isMemoryCall = classifyToolCategory(callRec.name, callRec.args) === 'Memory';
666
- // Same split as tool-card-results.mjs: a REAL tool-call error drives the
667
- // red ● dot; command/result failures only mark the card Failed in L2.
668
- const isCallError = message?.isError === true || message?.toolKind === 'error';
669
- const isResultError = /^\s*\[?error/i.test(rawText) || isErrorToolStatus(toolResultStatus(rawText)) || (isMemoryCall && memoryCoreResultErrorText(rawText) != null);
670
- const isError = isCallError || isResultError;
674
+ // Tool result text (including HTTP/domain failures, zero matches, task
675
+ // statuses, and shell output) is detail, not a failed invocation. Only
676
+ // the provider's isError/error-tool envelope drives failure counts/red.
677
+ const { exitCode, isExitError, isCallError } = toolCallOutcome(message, rawText);
678
+ const isError = isCallError;
671
679
  const text = isError ? toolErrorDisplay(rawText, callRec.name || 'tool') : rawText;
672
680
  callRec.summary = !isError ? summarizeToolResult(callRec.name, callRec.args, rawText, isError) : null;
673
681
  assignAggregateSummaryOrder(aggregate, callRec);
674
682
  callRec.isError = isError;
675
683
  callRec.isCallError = isCallError;
684
+ callRec.isExitError = isExitError;
685
+ callRec.exitCode = exitCode;
676
686
  callRec.resultText = text;
677
687
  callRec.completedEarly = true;
678
688
  const allCalls = [...aggregate.calls.values()];
679
689
  const completedCount = allCalls.filter((r) => r.resolved || r.completedEarly).length;
680
690
  const errors = allCalls.filter((r) => r.isError).length;
681
691
  const callErrors = allCalls.filter((r) => r.isCallError).length;
682
- const succeeded = completedCount - errors;
692
+ const exitErrors = allCalls.filter((r) => r.isExitError).length;
693
+ const succeeded = Math.max(0, completedCount - errors - exitErrors);
683
694
  const rawResult = aggregateRawResult(allCalls);
684
695
  // Collapsed detail carries the merged per-call count summary even on
685
696
  // the early-notify path; patching '' here flipped the detail row back
686
697
  // to the 'Running' placeholder between count updates (the visible
687
698
  // jitter). Failures keep 'N Failed'. Raw preserved for ctrl+o expansion.
688
- const displayDetail = errors > 0
689
- ? (succeeded > 0 ? `${succeeded} Ok · ${errors} Failed` : `${errors} Failed`)
699
+ const displayDetail = errors > 0 || exitErrors > 0
700
+ ? failureDetailText({ succeeded, realErrors: callErrors, exitErrors, exitCode: allCalls.find((r) => r.isExitError)?.exitCode })
690
701
  : formatAggregateDetail(aggregateSummaries(aggregate));
691
702
  const currentItem = getState().items.find((it) => it.id === card.itemId);
692
703
  const visualCompleted = Math.max(
@@ -699,6 +710,7 @@ export function createRunTurn(bag) {
699
710
  isError: errors > 0,
700
711
  errorCount: errors,
701
712
  callErrorCount: callErrors,
713
+ exitErrorCount: exitErrors,
702
714
  count: allCalls.length,
703
715
  completedCount: visualCompleted,
704
716
  };
@@ -737,10 +749,12 @@ export function createRunTurn(bag) {
737
749
  // assistant segment first so the steered user turn and the next
738
750
  // assistant response do not get visually merged into one bubble.
739
751
  flushStreamBatch();
740
- if (currentAssistantId) {
741
- patchItem(currentAssistantId, { text: currentAssistantText || assistantText, streaming: false });
742
- closeAssistantSegment();
743
- }
752
+ // Commit any pending assistant segment — including a streamed tail
753
+ // that never got a trailing '\n' (no row/currentAssistantId created
754
+ // yet). Using the shared segment-commit helper ensures that tail is
755
+ // materialized as an assistant item instead of being dropped when a
756
+ // steering/agent-completion injection races turn finalization.
757
+ commitAssistantSegment({ sealToolBlock: true });
744
758
  assistantText = '';
745
759
  const value = String(text || '').trim();
746
760
  if (value) {
@@ -769,6 +783,7 @@ export function createRunTurn(bag) {
769
783
  }
770
784
  const batchCalls = (calls || []).filter(Boolean);
771
785
  if (batchCalls.length === 0) return;
786
+ const agentBatch = ++providerToolBatch;
772
787
  const committedAssistantSegment = commitAssistantSegment({ sealToolBlock: true });
773
788
  if (committedAssistantSegment) {
774
789
  // Let the pre-tool assistant preamble paint and settle before the
@@ -792,11 +807,10 @@ export function createRunTurn(bag) {
792
807
  // Category drives the aggregate bucket so only same-category calls
793
808
  // merge into one card; classify first, then bucket by it.
794
809
  const category = classifyToolCategory(name, args);
795
- // Agent/bridge calls always get their own standalone card so
796
- // ToolExecution's isAgentTool/agentActionTitle path renders a
797
- // "Spawn <Agent> (model, tag)" header instead of being folded
798
- // into the "Called N agent(s)" category-aggregate card.
799
- const bucket = category === 'Agent' ? null : aggregateBucketForCategory(category);
810
+ // Agent actions aggregate only within this provider-emitted batch.
811
+ // They stay outbound category cards; asynchronous inbound Responses
812
+ // are separately tailed by the notification feed and never mix here.
813
+ const bucket = aggregateBucketForCategory(category, { agentBatch });
800
814
  const callId = toolCallId(c);
801
815
  const callKey = callId || `__tool_${toolCards.length}_${i}`;
802
816
  // The old App scan counted multi-pattern calls via
@@ -859,7 +873,7 @@ export function createRunTurn(bag) {
859
873
  ...categoryEntry,
860
874
  count: Number(prevCategory?.count || 0) + Number(categoryEntry.count || 1),
861
875
  });
862
- aggregateCard.calls.set(callKey, { name, args, category, summary: null, summarySeq: null, isError: false, isCallError: false, resultText: null, resolved: false, completedEarly: false });
876
+ aggregateCard.calls.set(callKey, { name, args, category, summary: null, summarySeq: null, isError: false, isCallError: false, isExitError: false, exitCode: null, resultText: null, resolved: false, completedEarly: false });
863
877
  touchedAggregates.add(aggregateCard);
864
878
  const card = { itemId: aggregateCard.itemId, callId: callKey, done: false, aggregate: aggregateCard };
865
879
  if (callId) {
@@ -1043,16 +1057,37 @@ export function createRunTurn(bag) {
1043
1057
  syncContextStats({ allowEstimated: true });
1044
1058
 
1045
1059
  const finalText = result?.content != null ? String(result.content) : '';
1046
- if (finalText.trim()) {
1060
+ // Strip text already sealed as its own item(s) this turn (a tool
1061
+ // preamble, then a no-newline tail committed by onSteerMessage before an
1062
+ // injected steering row) so finalization reconciles only the uncommitted
1063
+ // remainder — never re-creating a committed segment as a duplicate item
1064
+ // that also reorders after the steering row. Walk the segments IN ORDER,
1065
+ // peeling each off the front of the remaining content; skip leading
1066
+ // whitespace/newlines between segments. A segment that does not match at
1067
+ // the current position (provider omitted it from result.content, e.g. a
1068
+ // tool preamble) is left in place and the walk moves on.
1069
+ let finalRemainder = finalText;
1070
+ for (const seg of committedSegments) {
1071
+ // Compare against the whitespace-skipped remainder AND a
1072
+ // whitespace-trimmed segment: a segment sealed with its own leading
1073
+ // newline ('\nTAIL') would otherwise never match the skipped remainder
1074
+ // ('TAIL') and duplicate after the steering row.
1075
+ const skipped = finalRemainder.replace(/^\s+/, '');
1076
+ const trimmedSeg = seg ? seg.replace(/^\s+/, '') : '';
1077
+ if (trimmedSeg && skipped.startsWith(trimmedSeg)) {
1078
+ finalRemainder = skipped.slice(trimmedSeg.length);
1079
+ }
1080
+ }
1081
+ if (finalRemainder.trim()) {
1047
1082
  // The persisted transcript is written from the provider's final content,
1048
1083
  // while the live TUI row is fed by streaming deltas. If a provider/parser
1049
1084
  // misses or suppresses an early delta, keeping the streamed buffer here
1050
1085
  // leaves the final on-screen assistant row missing leading characters even
1051
1086
  // though the transcript is correct. Always reconcile the active segment to
1052
1087
  // the final provider text when it is available.
1053
- const id = currentAssistantId || ensureAssistant(finalText);
1054
- currentAssistantText = finalText;
1055
- patchItem(id, { text: finalText, streaming: false });
1088
+ const id = currentAssistantId || ensureAssistant(finalRemainder);
1089
+ currentAssistantText = finalRemainder;
1090
+ patchItem(id, { text: finalRemainder, streaming: false });
1056
1091
  } else if (currentAssistantId && (currentAssistantText.trim() || assistantText.trim())) {
1057
1092
  const streamedText = currentAssistantText || assistantText;
1058
1093
  patchItem(currentAssistantId, { text: streamedText, streaming: false });
@@ -81,6 +81,7 @@ import {
81
81
  import { createToolApproval } from './engine/tool-approval.mjs';
82
82
  import { createToolCardResults } from './engine/tool-card-results.mjs';
83
83
  import { createAgentJobFeed } from './engine/agent-job-feed.mjs';
84
+ import { appendAgentResponseTail } from './engine/agent-response-tail.mjs';
84
85
  import {
85
86
  appendTuiSteeringPersist,
86
87
  dropTuiSteeringPersist,
@@ -424,6 +425,64 @@ export async function createEngineSession({
424
425
  if (origin === 'user') appendPromptHistory(state.cwd, text);
425
426
  pushItem({ kind: 'user', id, text });
426
427
  };
428
+ const pushAsyncAgentResponse = (text, id = nextId(), origin = 'injected', metadata = {}) => {
429
+ const synthetic = parseSyntheticAgentMessage(text);
430
+ const isAgent = synthetic?.name === 'agent';
431
+ if (!isAgent) return pushUserOrSyntheticItem(text, id, origin);
432
+ const responseHasBody = /\n\s*\n[\s\S]*\S/.test(String(text || ''));
433
+ const rawResult = synthetic.rawResult ?? text;
434
+ const args = {
435
+ ...(synthetic.args && typeof synthetic.args === 'object' ? synthetic.args : {}),
436
+ type: 'result',
437
+ };
438
+ const responseKey = String(metadata.responseKey || metadata.executionId || args.task_id || '').trim();
439
+ const previous = state.items.at(-1);
440
+ // Tail-only aggregation prevents a later completion from mutating a card
441
+ // above any outbound tool, assistant, user, or preview/body boundary.
442
+ if (
443
+ previous?.kind === 'tool'
444
+ && previous.agentDirection === 'inbound'
445
+ ) {
446
+ const patch = appendAgentResponseTail(previous, {
447
+ key: responseKey,
448
+ args,
449
+ result: synthetic.result,
450
+ rawResult,
451
+ hasBody: responseHasBody,
452
+ isError: synthetic.isError === true,
453
+ });
454
+ if (patch) {
455
+ patchItem(previous.id, patch);
456
+ return true;
457
+ }
458
+ }
459
+ pushItem({
460
+ kind: 'tool',
461
+ id,
462
+ name: 'agent',
463
+ args,
464
+ result: synthetic.result,
465
+ rawResult,
466
+ isError: synthetic.isError === true,
467
+ expanded: false,
468
+ count: 1,
469
+ completedCount: 1,
470
+ startedAt: Date.now(),
471
+ completedAt: Date.now(),
472
+ agentDirection: 'inbound',
473
+ agentResponseKey: responseKey,
474
+ agentResponseHasBody: responseHasBody,
475
+ agentResponseAggregate: false,
476
+ agentResponseEntries: [{
477
+ key: responseKey,
478
+ raw: String(rawResult ?? '').trim(),
479
+ result: synthetic.result,
480
+ hasBody: responseHasBody,
481
+ isError: synthetic.isError === true,
482
+ }],
483
+ });
484
+ return true;
485
+ };
427
486
  const pushToast = (text, tone = 'info', ttlMs = 3000) => {
428
487
  const id = nextId();
429
488
  const value = String(text ?? '').trim();
@@ -524,6 +583,7 @@ export async function createEngineSession({
524
583
  kickExecutionPendingResume,
525
584
  flushDeferredExecutionPendingResumeKick,
526
585
  scheduleExecutionPendingResumeKick,
586
+ discardExecutionPendingResume,
527
587
  updateAgentJobCard,
528
588
  buildAgentJobCardPatch,
529
589
  subscribeRuntimeNotifications,
@@ -537,6 +597,7 @@ export async function createEngineSession({
537
597
  enqueue: (...args) => bag.enqueue(...args),
538
598
  drain: (...args) => bag.drain(...args),
539
599
  pushUserOrSyntheticItem,
600
+ pushAsyncAgentResponse,
540
601
  makeQueueEntry: (...args) => bag.makeQueueEntry(...args),
541
602
  getPending: () => pending,
542
603
  agentStatusState,
@@ -574,12 +635,12 @@ export async function createEngineSession({
574
635
  flags, lifecycle, pending, pendingNotificationKeys, displayedExecutionNotificationKeys, listeners, itemIndexById,
575
636
  getState: () => state, set,
576
637
  pushItem, patchItem, replaceItems, pushToast, pushNotice, removeNotice, setProgressHint,
577
- pushUserOrSyntheticItem, upsertSyntheticToolItem,
638
+ pushUserOrSyntheticItem, pushAsyncAgentResponse, upsertSyntheticToolItem,
578
639
  markToolCallActive, markToolCallDone, clearActiveToolSummary, clearToastTimers,
579
640
  autoClearState, agentStatusState, baseRouteState, routeState, syncContextStats,
580
641
  presentNextToolApproval, finishToolApproval, denyAllToolApprovals, requestToolApproval,
581
642
  patchToolCardResult, flushToolResults,
582
- kickExecutionPendingResume, flushDeferredExecutionPendingResumeKick, scheduleExecutionPendingResumeKick, updateAgentJobCard, subscribeRuntimeNotifications,
643
+ kickExecutionPendingResume, flushDeferredExecutionPendingResumeKick, scheduleExecutionPendingResumeKick, discardExecutionPendingResume, updateAgentJobCard, subscribeRuntimeNotifications,
583
644
  });
584
645
  Object.assign(bag, createSessionFlow(bag));
585
646
  bag.runTurn = createRunTurn(bag);
@@ -6,41 +6,31 @@ hidden: true
6
6
  agents: worker, heavy-worker, reviewer, debugger, maintainer
7
7
  ---
8
8
 
9
- # Bench Workflow
9
+ # Bench
10
10
 
11
- Autonomous run: no user is present. Never wait for approval or ask
12
- questions — decide and proceed immediately. Loop until the task is verified
13
- complete or provably blocked.
11
+ Autonomous: no user. Never wait for approval or ask questions; decide/proceed.
12
+ Loop until verified complete or provably blocked.
14
13
 
15
- Lead supervises: delegates, coordinates, judges, decides. Route by complexity:
16
- - Lead directly: simple 1–2 step work, plus coordination, pre-planning, config
17
- changes, and final git deployment.
18
- - Worker: implementation that takes several steps. Heavy Worker:
19
- high-complexity, multi-step implementation.
20
- - Reviewer: verify implementation scopes (diff, regressions, missing checks).
21
- - Debugger: very high complexity, or when root-causing has already failed at
22
- least once.
14
+ Lead supervises, delegates, coordinates, judges, decides. Lead directly handles
15
+ simple 1–2-step work, coordination, pre-planning, config, final git deployment.
16
+ Worker: several-step implementation; Heavy Worker: high-complexity multi-step
17
+ implementation; Reviewer: implementation diff/regression/missing-check review;
18
+ Debugger: very high complexity or root cause already failed once.
23
19
 
24
- 1. Plan form the plan yourself and start executing immediately; no approval
25
- step exists.
26
- 2. Delegate split into the maximum number of independent scopes.
27
- - PARALLEL across independent scopes by default (implementation, analysis,
28
- review, debugging alike); spawn every scope in the SAME turn. Shared or
29
- cross-cutting code does NOT justify merging split per path and verify
30
- the shared parts yourself. The only single scope is a genuinely
31
- inseparable dependency; then state it.
32
- - SEQUENTIAL within a single complex scope: ordered steps with a
33
- build/test-green gate between them, not one shot.
34
- - Write briefs per the Lead brief contract.
35
- - After spawning async agents, END THE TURN — no polling, guessing, or
36
- dependent work until the completion notification resumes you.
37
- 3. Review pair one reviewer 1:1 with each implementation scope, spawned in the
38
- same turn, never deferred or batched; wait for its result. Fact-check agent
39
- responses and cross-check implementation and review results yourself before
40
- acting. Send fixes back to the original scope and loop verify -> fix ->
41
- re-verify until clean. Skip review only for simple, low-risk tasks. If a bug
42
- survives 2+ fix cycles, have the debugger investigate first instead of
43
- another fix round.
44
- 4. Finish — verify the final state yourself; only stop when the task is
45
- complete and verified, or a hard blocker makes progress impossible. State
46
- the outcome and evidence in the final message.
20
+ 1. Plan: form it and execute immediately; no approval step.
21
+ 2. Delegate: split to the maximum independent scopes. Parallelize independent
22
+ implementation/analysis/review/debugging, spawning every scope in one turn.
23
+ Shared/cross-cutting code does not justify merging: split by path and verify
24
+ shared parts yourself. A single scope needs a genuinely inseparable
25
+ dependency; state it. Within one complex scope, sequence steps with a
26
+ build/test-green gate between them. Briefs follow the Lead brief contract.
27
+ After async spawn, end turn: no polling, guessing, or dependent work until
28
+ completion notification.
29
+ 3. Review: one Reviewer per implementation scope, spawned 1:1 in the same turn,
30
+ never deferred/batched; wait. Fact-check agent responses and cross-check
31
+ implementation/review yourself before acting. Return fixes to the original
32
+ scope; loop verify -> fix -> re-verify until clean. Skip only simple,
33
+ low-risk review. If a bug survives 2+ fix cycles, Debugger investigates
34
+ before another fix round.
35
+ 4. Finish: verify final state yourself; stop only verified complete or hard
36
+ blocked. Final states outcome and evidence.