mixdog 0.9.174 → 1.0.0

package/src/runtime/office/core/excel-snapshot-normalize.mjs

@@ -0,0 +1,149 @@
+import { normalizeExcelCellStyle } from '../portable/portable-sheet-styles.mjs';
+
+// Excel's cells read like the portable snapshot's: RRGGBB colors with
+// defaults omitted, and text cells flagged, so the formula audit and the
+// model see one shape from both readers.
+// Excel names a validation's and a conditional format's kind and operator by enumeration number (3 for a list, 2 for
+// an expression) and reads its formulas with a leading "="; the portable reader names them as the file does. One
+// shape from both: the OOXML word, the ranges as a list, the formulas without "=", a list literal in its quotes.
+const EXCEL_VALIDATION_TYPES = ['none', 'whole', 'decimal', 'list', 'date', 'time', 'textLength', 'custom'];
+const EXCEL_OPERATORS = [
+  '',
+  'between',
+  'notBetween',
+  'equal',
+  'notEqual',
+  'greaterThan',
+  'lessThan',
+  'greaterThanOrEqual',
+  'lessThanOrEqual',
+];
+const EXCEL_CONDITION_TYPES = {
+  1: 'cellIs',
+  2: 'expression',
+  3: 'colorScale',
+  4: 'dataBar',
+  5: 'top10',
+  6: 'iconSet',
+  8: 'uniqueValues',
+  9: 'containsText',
+  10: 'containsBlanks',
+  11: 'timePeriod',
+  12: 'aboveAverage',
+  13: 'notContainsBlanks',
+  16: 'containsErrors',
+  17: 'notContainsErrors',
+};
+const withoutEquals = (formula) => String(formula ?? '').replace(/^=/, '');
+
+function normalizeExcelRules(sheet) {
+  if (Array.isArray(sheet?.validations)) {
+    sheet.validations = sheet.validations.map((entry) => {
+      if (!entry || typeof entry.type !== 'number') return entry;
+      const type = EXCEL_VALIDATION_TYPES[entry.type] ?? String(entry.type);
+      let formula1 = withoutEquals(entry.formula1);
+      if (type === 'list' && formula1 && !String(entry.formula1).startsWith('=')) formula1 = `"${formula1}"`;
+      return {
+        ...entry,
+        type,
+        operator: type === 'list' || type === 'custom' ? '' : (EXCEL_OPERATORS[entry.operator] ?? ''),
+        formula1,
+        formula2: withoutEquals(entry.formula2),
+      };
+    });
+  }
+  if (Array.isArray(sheet?.conditionalFormats)) {
+    sheet.conditionalFormats = sheet.conditionalFormats.map((entry) => {
+      if (!entry || typeof entry.type !== 'number') return entry;
+      const { range, formula1, formula2, ...rest } = entry;
+      const type = EXCEL_CONDITION_TYPES[entry.type] ?? String(entry.type);
+      return {
+        ...rest,
+        ranges: String(range || '')
+          .split(/[ ,]+/)
+          .filter(Boolean),
+        type,
+        operator: type === 'cellIs' ? (EXCEL_OPERATORS[entry.operator] ?? '') : '',
+        formulas: [formula1, formula2].filter(Boolean).map(withoutEquals),
+      };
+    });
+  }
+}
+
+// Excel reports a chart's series as one =SERIES(name, categories, values, order) formula and its kind by number; the
+// portable reader splits the three references and names the kind as add_chart does, and the chart audits read them
+// split. The arguments are cut at commas outside quotes and parentheses: a quoted sheet name may hold one.
+function seriesArguments(formula) {
+  const inner = /^=?SERIES\(([\s\S]*)\)$/i.exec(String(formula || '').trim())?.[1];
+  if (inner === undefined) return null;
+  const parts = [];
+  let current = '';
+  let depth = 0;
+  let quoted = false;
+  for (const character of inner) {
+    if (character === "'" || character === '"') quoted = !quoted;
+    else if (!quoted && character === '(') depth += 1;
+    else if (!quoted && character === ')') depth -= 1;
+    if (character === ',' && !quoted && depth === 0) {
+      parts.push(current.trim());
+      current = '';
+    } else current += character;
+  }
+  parts.push(current.trim());
+  return parts;
+}
+
+const EXCEL_CHART_KINDS = {
+  51: 'column',
+  52: 'stacked_column',
+  57: 'bar',
+  58: 'stacked_bar',
+  4: 'line',
+  65: 'line',
+  1: 'area',
+  5: 'pie',
+  '-4120': 'doughnut',
+  '-4169': 'scatter',
+};
+
+function normalizeExcelCharts(sheet) {
+  if (!Array.isArray(sheet?.charts)) return;
+  sheet.charts = sheet.charts.map((chart) => {
+    if (!chart || typeof chart !== 'object') return chart;
+    const next = { ...chart };
+    if (typeof next.chartType === 'number' && EXCEL_CHART_KINDS[next.chartType])
+      next.chartType = EXCEL_CHART_KINDS[next.chartType];
+    if (Array.isArray(next.series)) {
+      next.series = next.series.map((series) => {
+        const parts = seriesArguments(series?.formula);
+        if (!parts) return series;
+        const [name = '', categories = '', values = ''] = parts;
+        const reference = (text) => (/^'?[^'"]*'?!\$?[A-Z]/i.test(text) ? text : '');
+        return {
+          ...series,
+          formula: reference(name),
+          categoryFormula: categories,
+          valueFormula: values,
+        };
+      });
+      next.seriesCount = next.series.length;
+    }
+    // The frame's place is the anchor's; the same four numbers beside it repeat it.
+    if (next.anchor && ['left', 'top', 'width', 'height'].every((key) => next[key] === next.anchor[key])) {
+      for (const key of ['left', 'top', 'width', 'height']) delete next[key];
+    }
+    return next;
+  });
+}
+
+export function normalizeExcelSnapshotStyles(document) {
+  for (const sheet of document?.sheets || []) {
+    normalizeExcelRules(sheet);
+    normalizeExcelCharts(sheet);
+    for (const cell of sheet?.cells || []) {
+      if (!cell || typeof cell !== 'object') continue;
+      if (cell.style) cell.style = normalizeExcelCellStyle(cell.style);
+      if (!cell.formula && typeof cell.value === 'string' && cell.value !== '') cell.dataType = 'text';
+    }
+  }
+}

package/src/runtime/office/core/office-actions-batch.mjs

@@ -26,6 +26,7 @@ import { PIXELS_TO_POINTS, imagePixelSize } from '../portable/portable-opc.mjs';
 import { naturalColumnWidths } from '../shared/column-widths.mjs';
 import { figureColumnAlignments } from '../shared/column-alignments.mjs';
 import { pageSizePoints } from '../shared/page-sizes.mjs';
+import { koreanParticleReplacements } from '../shared/korean-particles.mjs';
 import {
   TABULAR_FORMATS,
   emptyOfficeDesignState,
@@ -42,8 +43,6 @@ import {
   transactionView,
 } from './office-transactions.mjs';
 
-import { koreanParticleReplacements } from '../shared/korean-particles.mjs';
-
 // Excel fills an unstyled series from the workbook theme (a teal and an orange on the default one) while the
 // portable writer paints its own hue family, so the same add_chart drew two different charts. A chart that
 // names no colours takes the portable palette on both backends; a named palette is kept as written.
@@ -277,7 +276,7 @@ function withProvenanceCitations(operations) {
 }
 
 async function microsoftBatch(session, args, target, operations) {
-  const result = await microsoftOfficeCall(
+  return await microsoftOfficeCall(
     session,
     target,
     {
@@ -288,7 +287,6 @@ async function microsoftBatch(session, args, target, operations) {
     },
     Math.min(300_000, 90_000 + operations.length * 500)
   );
-  return result;
 }
 
 // Runs the batch on the Office host. An empty new deck first takes the
@@ -528,9 +526,8 @@ async function withDocumentCharts(session, operations, scratch) {
     const pdf = join(directory, `chart-${index + 1}.pdf`);
     await createChartPdf(pdf, block, { width: pointsWide });
     // Three pixels a point: the picture stays sharp in print and at the zoom a reader uses.
-    const [image] = (
-      await renderPdfPages(pdf, { pages: [1], maxWidth: Math.round(pointsWide * 3), maximumScale: 3 })
-    ).images;
+    const [image] = (await renderPdfPages(pdf, { pages: [1], maxWidth: Math.round(pointsWide * 3), maximumScale: 3 }))
+      .images;
     output.push({
       op: 'add_image',
       path: image.path,

package/src/runtime/office/core/office-actions-inspect.mjs

@@ -18,6 +18,10 @@ import { reviewOfficeStructure } from '../quality/assurance.mjs';
 import { OOXML_FORMATS, TABULAR_FORMATS } from './office-core.mjs';
 import { readComSavedCopy, snapshot } from './office-sessions.mjs';
 
+// A finding is the same finding wherever its code and path agree; the merges below drop the ones a result already holds.
+const findingKey = (entry) => `${entry.code}\0${entry.path}`;
+const knownFindings = (result) => new Set((result.issues || []).map(findingKey));
+
 // One document read per document version for every review that needs the whole
 // document: issues and qa both ask for it, and reading it twice per call costs
 // the caller seconds on a large workbook.
@@ -187,9 +191,9 @@ function auditSavedCopy(session, audit) {
 
 function mergeComPptxMeasuredRead(result, { value: measured, error }) {
   if (error) return { ...result, measuredRead: { status: 'unavailable', reason: error?.message || String(error) } };
-  const seen = new Set((result.issues || []).map((issue) => `${issue.code}|${issue.path}`));
+  const seen = knownFindings(result);
   const added = (measured.issues || []).filter(
-    (issue) => !HOST_OWNED_PPTX_CODES.has(String(issue.code || '')) && !seen.has(`${issue.code}|${issue.path}`)
+    (issue) => !HOST_OWNED_PPTX_CODES.has(String(issue.code || '')) && !seen.has(findingKey(issue))
   );
   if (!added.length) return { ...result, measuredRead: { status: 'merged', added: 0 } };
   const issues = normalizeOfficeReviewIssues([...(result.issues || []), ...added]);
@@ -206,7 +210,11 @@ function mergeComPptxMeasuredRead(result, { value: measured, error }) {
 // validated cells, so a cut label, a figure run into the label beside it, ink nobody can see, a number cut below the
 // sample, and a form nobody can type into passed on Excel while the portable audit reported them. The saved copy is
 // read by the portable audits themselves; a number the host already saw cut in a column stays the host's finding.
-const cellColumn = (path) => /^\/sheet\[(.*)\]\/cell\[\$?([A-Z]+)\$?\d+\]$/.exec(String(path || ''))?.slice(1).join('\0');
+const cellColumn = (path) =>
+  /^\/sheet\[(.*)\]\/cell\[\$?([A-Z]+)\$?\d+\]$/
+    .exec(String(path || ''))
+    ?.slice(1)
+    .join('\0');
 
 function xlsxSheetAudits(session, args) {
   return auditSavedCopy(session, async (copy) => {
@@ -222,14 +230,13 @@ function xlsxSheetAudits(session, args) {
 
 function mergeXlsxSheetAudits(result, { value: found, error }) {
   if (error) return { ...result, sheetAudit: { status: 'unavailable', reason: error?.message || String(error) } };
-  const known = new Set((result.issues || []).map((entry) => `${entry.code}\0${entry.path}`));
+  const known = knownFindings(result);
   const overflowing = new Set(
     (result.issues || []).filter((entry) => entry.code === 'cell_overflow').map((entry) => cellColumn(entry.path))
   );
   const added = found.filter(
     (entry) =>
-      !known.has(`${entry.code}\0${entry.path}`) &&
-      !(entry.code === 'column_too_narrow' && overflowing.has(cellColumn(entry.path)))
+      !known.has(findingKey(entry)) && !(entry.code === 'column_too_narrow' && overflowing.has(cellColumn(entry.path)))
   );
   if (!added.length) return { ...result, sheetAudit: { status: 'merged', added: 0 } };
   return {
@@ -275,10 +282,8 @@ async function microsoftOfficeIssues(session, args) {
   // portable rule applies to it and an unlabelled figure no longer passes on Word alone.
   if (session.format === 'docx') {
     const read = await snapshot(session, {}, { full: true });
-    const known = new Set((result.issues || []).map((entry) => `${entry.code}\0${entry.path}`));
-    const added = pictureDescriptionIssues(read?.document || {}).filter(
-      (entry) => !known.has(`${entry.code}\0${entry.path}`)
-    );
+    const known = knownFindings(result);
+    const added = pictureDescriptionIssues(read?.document || {}).filter((entry) => !known.has(findingKey(entry)));
     if (added.length) result = { ...result, issues: normalizeOfficeReviewIssues([...(result.issues || []), ...added]) };
   }
   return result;
@@ -298,10 +303,8 @@ export async function issues(session, args = {}) {
   // A finding the package reader already made at the same place is the same finding worded twice: the portable
   // contrast measure (against the resolved surface) and the format review's (against the slide) both reported
   // "Hard to read" once the portable snapshot carried text colours. The package reader's, the more exact, stays.
-  const found = new Set((result.issues || []).map((entry) => `${entry.code}\0${entry.path}`));
-  const structural = (await structureIssues(session, args)).filter(
-    (entry) => !found.has(`${entry.code}\0${entry.path}`)
-  );
+  const found = knownFindings(result);
+  const structural = (await structureIssues(session, args)).filter((entry) => !found.has(findingKey(entry)));
   // Normalized whether or not the structure review added anything: skipped when it found nothing, a portable deck's
   // overflow and overlap kept the warning the Office backend's copy of the same finding had been raised from.
   const merged = normalizeOfficeReviewIssues([...(result.issues || []), ...structural]);

package/src/runtime/office/core/office-actions-open.mjs

@@ -10,12 +10,7 @@ import {
   releaseOfficeSession,
   toolResult,
 } from './office-core.mjs';
-import { createSession, openSession, snapshot } from './office-sessions.mjs';
-
-function initialOfficeOperations(args) {
-  if (Array.isArray(args.operations) && args.operations.length) return args.operations;
-  return Array.isArray(args.design?.operations) ? args.design.operations : [];
-}
+import { createSession, initialOfficeOperations, openSession, snapshot } from './office-sessions.mjs';
 
 async function discardFailedOfficeSession(session, { action, initialEditSettled }) {
   if (session.reused) return;

package/src/runtime/office/core/office-core.mjs

@@ -309,7 +309,14 @@ function officeDesignDigest(design) {
 // a count per operation. A write that did not change, or reports anything past
 // its address, stays in place, as does every object a later call names (a
 // table, a chart).
-const PRESET_ROUTINE_OPS = new Set(['append_text', 'set_table_cell_style', 'set_style', 'merge_cells', 'set_cell', 'set_row_height']);
+const PRESET_ROUTINE_OPS = new Set([
+  'append_text',
+  'set_table_cell_style',
+  'set_style',
+  'merge_cells',
+  'set_cell',
+  'set_row_height',
+]);
 const PRESET_ROUTINE_FIELDS = new Set(['op', 'changed', 'style', 'table', 'row', 'col', 'sheet', 'cell', 'range']);
 function presetResults(results, semantic) {
   if (!Array.isArray(semantic) || !semantic.length) return results;
@@ -410,7 +417,13 @@ function modelFacingQaResult(result, topVisualReview, { finalized = false } = {}
       ...review.checklist,
       items: review.checklist.items.filter((item) => item?.status !== 'pass' && !renderOwed(item)),
       ...(dropped && summary
-        ? { summary: { ...summary, total: summary.total - dropped, failed: Math.max(0, (summary.failed || 0) - dropped) } }
+        ? {
+            summary: {
+              ...summary,
+              total: summary.total - dropped,
+              failed: Math.max(0, (summary.failed || 0) - dropped),
+            },
+          }
         : {}),
     };
   }
@@ -480,7 +493,12 @@ function finalizeValidationDigest(validation, result, session = null) {
   for (const key of ['format', 'entries', 'mainPart', 'mainContentType', 'validation']) delete digest[key];
   if (digest.mainContentTypeMissing === false) delete digest.mainContentTypeMissing;
   const security = digest.security;
-  if (security && security.macroExecution === 'disabled' && !security.digitalSignatureInvalidated && Object.keys(security).length <= 2) {
+  if (
+    security &&
+    security.macroExecution === 'disabled' &&
+    !security.digitalSignatureInvalidated &&
+    Object.keys(security).length <= 2
+  ) {
     delete digest.security;
   }
   for (const [check, detail] of Object.entries(PASSED_CHECK_DETAIL)) {
@@ -530,7 +548,13 @@ const bgrHex = (value) =>
     .join('')
     .toUpperCase();
 
-const POWERPOINT_TEXT_FRAME = { marginLeft: 7.2, marginTop: 3.6, marginRight: 7.2, marginBottom: 3.6, paragraphSpacing: 0 };
+const POWERPOINT_TEXT_FRAME = {
+  marginLeft: 7.2,
+  marginTop: 3.6,
+  marginRight: 7.2,
+  marginBottom: 3.6,
+  paragraphSpacing: 0,
+};
 
 // Excel's chart kinds by the name the portable reader and add_chart use; a kind outside this list keeps its number.
 const EXCEL_CHART_TYPES = {
@@ -550,10 +574,18 @@ const EXCEL_CHART_TYPES = {
   15: 'bubble',
   '-4151': 'radar',
 };
-const chartTypeName = (value) => (typeof value === 'number' && EXCEL_CHART_TYPES[value] ? EXCEL_CHART_TYPES[value] : value);
+const chartTypeName = (value) =>
+  typeof value === 'number' && EXCEL_CHART_TYPES[value] ? EXCEL_CHART_TYPES[value] : value;
 
 // A series on the primary axis with no name formula, trendline, error bars, or labels says so by omission.
-const QUIET_SERIES = { formula: '', axisGroup: 1, trendlineCount: 0, hasErrorBars: false, hasDataLabels: false, dataLabels: null };
+const QUIET_SERIES = {
+  formula: '',
+  axisGroup: 1,
+  trendlineCount: 0,
+  hasErrorBars: false,
+  hasDataLabels: false,
+  dataLabels: null,
+};
 
 function comSeriesDigest(entry) {
   const kept = Object.fromEntries(
@@ -562,6 +594,9 @@ function comSeriesDigest(entry) {
   return { ...kept, ...(entry.chartType !== undefined ? { chartType: chartTypeName(entry.chartType) } : {}) };
 }
 
+// A digest step applied to the object entries of a list; anything else passes through.
+const digestObjectWith = (digestEntry) => (entry) => (entry && typeof entry === 'object' ? digestEntry(entry) : entry);
+
 function comShapeDigest(shape) {
   const digest = {};
   for (const [key, value] of Object.entries(shape)) {
@@ -575,13 +610,9 @@ function comShapeDigest(shape) {
     if (digest.font && !digest.font.name && !Number(digest.font.size)) delete digest.font;
   }
   if (digest.chart && typeof digest.chart === 'object') {
-    digest.chart = {
-      ...digest.chart,
-      chartType: chartTypeName(digest.chart.chartType),
-      ...(Array.isArray(digest.chart.series)
-        ? { series: digest.chart.series.map((entry) => (entry && typeof entry === 'object' ? comSeriesDigest(entry) : entry)) }
-        : {}),
-    };
+    const chart = { ...digest.chart, chartType: chartTypeName(digest.chart.chartType) };
+    if (Array.isArray(digest.chart.series)) chart.series = digest.chart.series.map(digestObjectWith(comSeriesDigest));
+    digest.chart = chart;
   }
   for (const key of ['textBounds', 'textFrame']) {
     if (digest[key] && typeof digest[key] === 'object') digest[key] = roundAll(digest[key]);
@@ -607,14 +638,18 @@ function comShapeDigest(shape) {
   if (digest.geometry === '') delete digest.geometry;
   if (digest.textFrame && typeof digest.textFrame === 'object') {
     const frame = Object.fromEntries(
-      Object.entries(digest.textFrame).filter(([key, value]) => !(Object.hasOwn(POWERPOINT_TEXT_FRAME, key) && POWERPOINT_TEXT_FRAME[key] === value))
+      Object.entries(digest.textFrame).filter(
+        ([key, value]) => !(Object.hasOwn(POWERPOINT_TEXT_FRAME, key) && POWERPOINT_TEXT_FRAME[key] === value)
+      )
     );
     if (Object.keys(frame).length) digest.textFrame = frame;
     else delete digest.textFrame;
   }
   if (digest.font && typeof digest.font === 'object') {
     const font = Object.fromEntries(
-      Object.entries(digest.font).filter(([key, value]) => !(['bold', 'italic', 'underline'].includes(key) && (value === 0 || value === false)))
+      Object.entries(digest.font).filter(
+        ([key, value]) => !(['bold', 'italic', 'underline'].includes(key) && (value === 0 || value === false))
+      )
     );
     digest.font = font;
   }
@@ -662,11 +697,9 @@ function pptxDocumentDigest(document) {
   if (document?.format !== 'pptx' || !Array.isArray(document.slides)) return document;
   // add_slide names a layout by its name or position; the part it lives in and a path built from that same
   // position repeat what the runtime resolves itself, on every one of a template's dozens of layouts.
-  const layouts = Array.isArray(document.layouts)
-    ? document.layouts.map((layout, position) =>
-        layout && typeof layout === 'object' ? { index: layout.index ?? position + 1, name: layout.name } : layout
-      )
-    : document.layouts;
+  const layoutDigest = (layout, position) =>
+    layout && typeof layout === 'object' ? { index: layout.index ?? position + 1, name: layout.name } : layout;
+  const layouts = Array.isArray(document.layouts) ? document.layouts.map(layoutDigest) : document.layouts;
   return {
     ...document,
     ...(layouts ? { layouts } : {}),
@@ -699,12 +732,11 @@ export function officeDocumentDigest(document) {
 // A delimited file's cell names its place twice: the reference already says the row and the column.
 function tabularDocumentDigest(document) {
   if (!Array.isArray(document.sheets)) return document;
+  const cellDigest = digestObjectWith(({ row, column, ...rest }) => rest);
   return {
     ...document,
     sheets: document.sheets.map((sheet) =>
-      Array.isArray(sheet?.cells)
-        ? { ...sheet, cells: sheet.cells.map((cell) => (cell && typeof cell === 'object' ? (({ row, column, ...rest }) => rest)(cell) : cell)) }
-        : sheet
+      Array.isArray(sheet?.cells) ? { ...sheet, cells: sheet.cells.map(cellDigest) } : sheet
     ),
   };
 }
@@ -730,7 +762,8 @@ function xlsxSheetDigest(sheet, defaults) {
   if (digest.pageSetup && typeof digest.pageSetup === 'object') {
     const setup = Object.fromEntries(
       Object.entries(digest.pageSetup).filter(
-        ([key, entry]) => entry !== '' && entry !== false && !(Object.hasOwn(QUIET_PAGE_SETUP, key) && QUIET_PAGE_SETUP[key] === entry)
+        ([key, entry]) =>
+          entry !== '' && entry !== false && !(Object.hasOwn(QUIET_PAGE_SETUP, key) && QUIET_PAGE_SETUP[key] === entry)
       )
     );
     if (Object.keys(setup).length) digest.pageSetup = setup;
@@ -743,7 +776,9 @@ function xlsxSheetDigest(sheet, defaults) {
     digest.formulaLineage = digest.formulaLineage.map((entry) => {
       const cell = /\/cell\[([^\]]+)\]$/.exec(String(entry?.from || ''))?.[1] || entry?.from;
       const precedents = (entry?.precedents || []).map((precedent) =>
-        precedent?.sheet && precedent.sheet !== sheet.name ? `${precedent.sheet}!${precedent.ref}` : precedent?.ref ?? precedent
+        precedent?.sheet && precedent.sheet !== sheet.name
+          ? `${precedent.sheet}!${precedent.ref}`
+          : (precedent?.ref ?? precedent)
       );
       return { cell, precedents };
     });
@@ -783,7 +818,8 @@ function xlsxDocumentDigest(document) {
     delete digest.definedNames;
     if (digest.definedNameCount === 0) delete digest.definedNameCount;
   }
-  if (plainObject(digest.calculation) && Object.values(digest.calculation).every((value) => !value)) delete digest.calculation;
+  if (plainObject(digest.calculation) && Object.values(digest.calculation).every((value) => !value))
+    delete digest.calculation;
   return digest;
 }
 
@@ -815,13 +851,17 @@ const roundPoint = (field) => (typeof field === 'number' ? Math.round(field * 10
 function pdfDocumentDigest(document) {
   if (document?.format !== 'pdf') return document;
   const digest = withoutPdfDefaults(document);
-  for (const key of Object.keys(digest)) if (/Count$/.test(key) && key !== 'pageCount' && digest[key] === 0) delete digest[key];
+  for (const key of Object.keys(digest))
+    if (/Count$/.test(key) && key !== 'pageCount' && digest[key] === 0) delete digest[key];
   if (digest.metadata && typeof digest.metadata === 'object') {
-    const metadata = Object.fromEntries(Object.entries(digest.metadata).filter(([, field]) => field !== '' && field != null));
+    const metadata = Object.fromEntries(
+      Object.entries(digest.metadata).filter(([, field]) => field !== '' && field != null)
+    );
     if (Object.keys(metadata).length) digest.metadata = metadata;
     else delete digest.metadata;
   }
-  if (digest.pagination && digest.pagination.hasMore !== true && !(Number(digest.pagination.offset) > 0)) delete digest.pagination;
+  if (digest.pagination && digest.pagination.hasMore !== true && !(Number(digest.pagination.offset) > 0))
+    delete digest.pagination;
   if (Array.isArray(digest.pages)) {
     digest.pages = digest.pages.map((page) => {
       const { rotation, width, height, ...rest } = page || {};
@@ -853,7 +893,9 @@ function quietParagraph(raw) {
   if (paragraph.pageEnd !== undefined && paragraph.pageEnd === paragraph.pageStart) delete paragraph.pageEnd;
   if (paragraph.font && typeof paragraph.font === 'object') {
     paragraph.font = Object.fromEntries(
-      Object.entries(paragraph.font).filter(([key, value]) => !(Object.hasOwn(QUIET_PARAGRAPH_FONT, key) && QUIET_PARAGRAPH_FONT[key] === value))
+      Object.entries(paragraph.font).filter(
+        ([key, value]) => !(Object.hasOwn(QUIET_PARAGRAPH_FONT, key) && QUIET_PARAGRAPH_FONT[key] === value)
+      )
     );
     if (!Object.keys(paragraph.font).length) delete paragraph.font;
   }
@@ -915,11 +957,18 @@ function docxDocumentDigest(document) {
   const parts = Array.isArray(document.parts)
     ? document.parts.filter(
         (part) =>
-          !(complete && part?.part === 'word/document.xml' && paragraphs.length && Object.keys(part).every((key) => key === 'part' || key === 'text'))
+          !(
+            complete &&
+            part?.part === 'word/document.xml' &&
+            paragraphs.length &&
+            Object.keys(part).every((key) => key === 'part' || key === 'text')
+          )
       )
     : document.parts;
   // A family the counts already call empty (comments, revisions, notes, controls, images) reads the same absent.
-  const digest = Object.fromEntries(Object.entries(document).filter(([, value]) => !(Array.isArray(value) && !value.length)));
+  const digest = Object.fromEntries(
+    Object.entries(document).filter(([, value]) => !(Array.isArray(value) && !value.length))
+  );
   // Word (COM) places a table by character offsets and reports its left alignment as 0; a comment that is open and
   // unanswered says so by omission, as the portable reader writes it.
   if (Array.isArray(digest.tables)) {
@@ -970,7 +1019,8 @@ function docxDocumentDigest(document) {
       return rest;
     });
   }
-  if (Array.isArray(document.blockOrder) && document.blockOrder.length) digest.blockOrder = blockOrderDigest(document.blockOrder);
+  if (Array.isArray(document.blockOrder) && document.blockOrder.length)
+    digest.blockOrder = blockOrderDigest(document.blockOrder);
   if (!parts?.length) delete digest.parts;
   return { ...digest, paragraphs, ...(parts?.length ? { parts } : {}) };
 }
@@ -1023,7 +1073,8 @@ export function finalizeOfficeResult(value, { action, session = null, startedAt
   if (finalizing && value.review) {
     value.review = modelFacingQaResult(value.review, value.visualReview, { finalized: value.finalized === true });
     const inner = value.review.review;
-    if (inner?.design) value.review = { ...value.review, review: { ...inner, design: modelReviewOnce(inner.design, session) } };
+    if (inner?.design)
+      value.review = { ...value.review, review: { ...inner, design: modelReviewOnce(inner.design, session) } };
   }
   if (finalizing) {
     // The reopened file's full shape inventory proves persistence, which its
@@ -1092,8 +1143,11 @@ export function finalizeOfficeResult(value, { action, session = null, startedAt
   }
   // An operation's result names what it did; an empty string field says nothing.
   const withoutBlank = (entry) =>
-    entry && typeof entry === 'object' ? Object.fromEntries(Object.entries(entry).filter(([, field]) => field !== '')) : entry;
-  if (Array.isArray(value.results)) value.results = presetResults(value.results.map(withoutBlank), value.semanticOperations);
+    entry && typeof entry === 'object'
+      ? Object.fromEntries(Object.entries(entry).filter(([, field]) => field !== ''))
+      : entry;
+  if (Array.isArray(value.results))
+    value.results = presetResults(value.results.map(withoutBlank), value.semanticOperations);
   if (Array.isArray(value.batch?.results)) {
     value.batch = {
       ...value.batch,
@@ -1110,6 +1164,12 @@ export function finalizeOfficeResult(value, { action, session = null, startedAt
     value.factsMode = 'sample';
     value.disclosure = FACTS_SAMPLE_DISCLOSURE;
   }
+  attachOfficeArtifacts(value, action, session);
+  return value;
+}
+
+// The file an action produced or edited, named as an artifact of the result.
+function attachOfficeArtifacts(value, action, session) {
   let operation = '';
   if (action === 'create' || (action === 'author' && value.output)) operation = 'create';
   else if (action === 'render') operation = 'render';
@@ -1117,19 +1177,17 @@ export function finalizeOfficeResult(value, { action, session = null, startedAt
   let artifactPath = '';
   if (action === 'render' || action === 'secure') artifactPath = value.output;
   else if (operation && session) artifactPath = session.target;
-  if (operation && artifactPath) {
-    value.artifacts = [
-      officeArtifact(
-        session?.format || (action === 'secure' ? 'pdf' : ''),
-        session?.fileKind || (action === 'secure' ? 'pdf' : ''),
-        artifactPath,
-        operation
-      ),
-    ];
-    value.outputCount = value.artifacts.length;
-    value.expectedOutputCount = 1;
-  }
-  return value;
+  if (!operation || !artifactPath) return;
+  value.artifacts = [
+    officeArtifact(
+      session?.format || (action === 'secure' ? 'pdf' : ''),
+      session?.fileKind || (action === 'secure' ? 'pdf' : ''),
+      artifactPath,
+      operation
+    ),
+  ];
+  value.outputCount = value.artifacts.length;
+  value.expectedOutputCount = 1;
 }
 
 export function bounded(value, maxChars, length = null) {

package/src/runtime/office/core/office-finalize/review-stage.mjs

@@ -21,7 +21,10 @@ const AUTHORED_ADVISORY_SOURCES = new Set([
 const VISIBLE_DEFECT_CODES = new Set(['drawing_covers_cells', 'drawing_overlap']);
 
 export function blocksFinalize(issue, { failOn, authored }) {
-  if (VISIBLE_DEFECT_CODES.has(String(issue?.code || '')) && ['error', 'warning'].includes(String(issue?.severity || '')))
+  if (
+    VISIBLE_DEFECT_CODES.has(String(issue?.code || '')) &&
+    ['error', 'warning'].includes(String(issue?.severity || ''))
+  )
     return true;
   if (authored && AUTHORED_ADVISORY_SOURCES.has(String(issue?.source || ''))) return false;
   return issue?.severity === 'error' || (failOn === 'warning' && issue?.severity === 'warning');

package/src/runtime/office/core/office-qa/design-review-stage.mjs

@@ -2,6 +2,7 @@
 // per-page roles the render review needs; an unreadable document degrades to
 // one advisory issue instead of failing QA.
 import { inferPptxSlideRoles, reviewOfficeDesign } from '../../quality/design-review.mjs';
+import { issue } from '../../quality/assurance-issue.mjs';
 import { reviewSnapshot } from '../office-actions-inspect.mjs';
 
 function unavailableDesignReview(session, error) {
@@ -11,15 +12,7 @@ function unavailableDesignReview(session, error) {
     profile: session.design?.profile || '',
     requiresVisualInspection: true,
     modelReview: [],
-    issues: [
-      {
-        severity: 'warning',
-        code: 'design_review_unavailable',
-        path: '/',
-        message: error?.message || String(error),
-        source: 'design-review',
-      },
-    ],
+    issues: [issue('design_review_unavailable', '/', error?.message || String(error), 'design-review')],
   };
 }