mirinjs 0.1.0-alpha.7 → 0.1.0-alpha.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mirinjs",
-  "version": "0.1.0-alpha.7",
+  "version": "0.1.0-alpha.9",
   "description": "Build desktop apps with Bun, TypeScript, and Chromium (CEF). The Bun-native Electron alternative.",
   "type": "module",
   "license": "MIT",

package/src/updater.ts

@@ -15,7 +15,15 @@
 
 import { homedir, tmpdir } from "node:os";
 import { join } from "node:path";
-import { existsSync, mkdirSync, readFileSync, readdirSync, renameSync, rmSync } from "node:fs";
+import {
+  existsSync,
+  mkdirSync,
+  readFileSync,
+  readdirSync,
+  renameSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
 import { $ } from "bun";
 import { runtime } from "./runtime.ts";
 import { loadCodec } from "./codec.ts";
@@ -213,32 +221,59 @@ export class Updater {
       // to exit (the exe/bundle is locked while running), swaps the folder, relaunches.
       if (IS_WINDOWS) {
         const runningApp = join(this.#resourcesDir()!, "..");
-        const exe = join(runningApp, `${this.#version()!.name}.exe`);
+        const name = this.#version()!.name;
+        const exe = join(runningApp, `${name}.exe`);
+        const script = join(tmpdir(), `mirin-apply-${name}.ps1`);
+        const applyVbs = join(tmpdir(), `mirin-apply-${name}.vbs`);
+        const launchVbs = join(tmpdir(), `mirin-launch-${name}.vbs`);
         const ps = [
           `$ErrorActionPreference='SilentlyContinue'`,
-          // Wait for the host process to exit (it locks the exe).
+          // Never let the app dir be this process's cwd (Windows can't delete a cwd).
+          `Set-Location $env:TEMP`,
+          // Wait for the host to exit (it locks the exe), then a beat for CEF's
+          // helper subprocesses to release their file locks (libcef.dll etc.).
           `while (Get-Process -Id ${process.pid} -ErrorAction SilentlyContinue) { Start-Sleep -Milliseconds 200 }`,
-          // Give CEF's helper subprocesses a beat to exit and release their file
-          // locks (libcef.dll etc.) — they go just after the host.
           `Start-Sleep -Milliseconds 700`,
-          // Replace the app folder, retrying while any lingering lock clears
-          // (~10s max). Unlike Unix, Windows can't delete a dir that's still a
-          // process's cwd or holds an open handle — hence the neutral cwd below.
+          // Replace the app folder, retrying ~10s while any lingering lock clears.
           `for ($i=0; $i -lt 50; $i++) { Remove-Item -Recurse -Force ${psq(runningApp)}; if (-not (Test-Path ${psq(runningApp)})) { break }; Start-Sleep -Milliseconds 200 }`,
           `Move-Item -Force ${psq(this.#staged)} ${psq(runningApp)}`,
           `Start-Process -FilePath ${psq(exe)} -WorkingDirectory ${psq(runningApp)}`,
-        ].join("; ");
-        Bun.spawn(
-          ["powershell", "-NoProfile", "-NonInteractive", "-WindowStyle", "Hidden", "-Command", ps],
-          {
-            // Run from a neutral dir, NOT the inherited install dir — otherwise the
-            // app folder is this PowerShell's cwd and Windows refuses to delete it.
-            cwd: tmpdir(),
-            stdin: "ignore",
-            stdout: "ignore",
-            stderr: "ignore",
-          },
-        ).unref();
+          // self-clean the temp launch scripts (this .ps1 + the two .vbs shims)
+          `Remove-Item -Force ${psq(script)},${psq(applyVbs)},${psq(launchVbs)}`,
+        ].join("\n");
+        writeFileSync(script, ps, "utf8");
+
+        // No terminal window may appear during the update. powershell.exe is a
+        // console-subsystem program: launching it directly (even with
+        // -WindowStyle Hidden) flashes a console, because the OS allocates the
+        // console before powershell can hide it. wscript.exe is a GUI-subsystem
+        // host with no console; its Shell.Run(cmd, 0) starts powershell with
+        // SW_HIDE in the initial STARTUPINFO, so no window is ever shown.
+        writeFileSync(
+          applyVbs,
+          `CreateObject("WScript.Shell").Run "powershell -NoProfile -NonInteractive ` +
+            `-ExecutionPolicy Bypass -WindowStyle Hidden -File ""${script}""", 0, False\n`,
+          "utf8",
+        );
+
+        // The swap MUST outlive this process. A Bun.spawn child is in our job
+        // object and is killed when we quit — even with unref/detached (verified).
+        // WMI's Win32_Process.Create has the WMI service spawn it, outside our job,
+        // so it survives. Issue that WMI call from a console-less wscript host too,
+        // so the launcher itself never flashes a window. `await` the short launcher
+        // so the swap process exists before core.quit() (no race), then quit.
+        writeFileSync(
+          launchVbs,
+          `GetObject("winmgmts:Win32_Process").Create ` +
+            `"wscript.exe //B //Nologo ""${applyVbs}""", Null, Null, pid\n`,
+          "utf8",
+        );
+        const launcher = Bun.spawn(["wscript.exe", "//B", "//Nologo", launchVbs], {
+          stdin: "ignore",
+          stdout: "ignore",
+          stderr: "ignore",
+        });
+        await launcher.exited;
       } else {
         const runningApp = join(this.#resourcesDir()!, "..", "..");
         const script = [