miravo 0.3.0 → 0.5.0

package/src/commands/start.test.ts

@@ -221,6 +221,7 @@ describe("resolveProtocolBootPlans", () => {
     ).toEqual([
       { name: "mqtt", shouldEnable: true, overrideRestore: false },
       { name: "opcua", shouldEnable: false, overrideRestore: false },
+      { name: "modbus", shouldEnable: false, overrideRestore: false },
     ]);
   });
 
@@ -236,6 +237,7 @@ describe("resolveProtocolBootPlans", () => {
     ).toEqual([
       { name: "mqtt", shouldEnable: true, overrideRestore: true },
       { name: "opcua", shouldEnable: false, overrideRestore: true },
+      { name: "modbus", shouldEnable: false, overrideRestore: true },
     ]);
   });
 
@@ -300,6 +302,126 @@ describe("resolveProtocolBootPlans", () => {
   });
 });
 
+describe("resolveDetachAdapterConfigs", () => {
+  test("uses template adapter configs when no CLI/env overrides are provided", async () => {
+    const { resolveDetachAdapterConfigs } = await import("./start.ts");
+
+    const template = createTemplateWithNamespace({ prefix: "factory" });
+    const withProtocols: MiravoTemplate = {
+      ...template,
+      protocols: {
+        mqtt: { port: 1889, embedded: true, retain: false, metadata: "base" },
+        opcua: { port: 4851, host: "127.0.0.1", security: "none" },
+        modbus: { port: 1602, host: "127.0.0.1" },
+      },
+    };
+
+    expect(
+      resolveDetachAdapterConfigs({
+        template: withProtocols,
+        simulationName: "factory-sim",
+        mqtt: { enabled: true, portOverride: undefined, overrides: {} },
+        opcua: {
+          enabled: true,
+          portOverride: undefined,
+          hostOverride: undefined,
+          writeBudgetOverride: undefined,
+        },
+        modbus: { enabled: true, portOverride: undefined, hostOverride: undefined },
+      }),
+    ).toEqual({
+      mqtt: { port: 1889, host: "127.0.0.1", embedded: true },
+      opcua: { port: 4851, host: "127.0.0.1" },
+      modbus: { port: 1602, host: "127.0.0.1" },
+    });
+  });
+
+  test("CLI/env overrides take precedence over template values", async () => {
+    const { resolveDetachAdapterConfigs } = await import("./start.ts");
+
+    const template = createTemplateWithNamespace({ prefix: "factory" });
+    const withProtocols: MiravoTemplate = {
+      ...template,
+      protocols: {
+        mqtt: { port: 1889, embedded: true, retain: false, metadata: "base" },
+        opcua: { port: 4851, host: "127.0.0.1", security: "none" },
+        modbus: { port: 1602, host: "127.0.0.1" },
+      },
+    };
+
+    expect(
+      resolveDetachAdapterConfigs({
+        template: withProtocols,
+        simulationName: "factory-sim",
+        mqtt: {
+          enabled: true,
+          portOverride: 1999,
+          overrides: { host: "0.0.0.0" },
+        },
+        opcua: {
+          enabled: true,
+          portOverride: 4852,
+          hostOverride: "0.0.0.0",
+          writeBudgetOverride: undefined,
+        },
+        modbus: { enabled: true, portOverride: 1702, hostOverride: "0.0.0.0" },
+      }),
+    ).toEqual({
+      mqtt: { port: 1999, host: "0.0.0.0", embedded: true },
+      opcua: { port: 4852, host: "0.0.0.0" },
+      modbus: { port: 1702, host: "0.0.0.0" },
+    });
+  });
+
+  test("returns disabled placeholders when adapters are disabled", async () => {
+    const { resolveDetachAdapterConfigs } = await import("./start.ts");
+    const template = createTemplateWithNamespace({ prefix: "factory" });
+
+    expect(
+      resolveDetachAdapterConfigs({
+        template,
+        simulationName: "factory-sim",
+        mqtt: { enabled: false, portOverride: 1999, overrides: { host: "0.0.0.0" } },
+        opcua: {
+          enabled: false,
+          portOverride: 4852,
+          hostOverride: "0.0.0.0",
+          writeBudgetOverride: 4096,
+        },
+        modbus: { enabled: false, portOverride: 1702, hostOverride: "0.0.0.0" },
+      }),
+    ).toEqual({
+      mqtt: { port: undefined, host: undefined, embedded: false },
+      opcua: { port: undefined, host: undefined },
+      modbus: { port: undefined, host: undefined },
+    });
+  });
+
+  test("marks external MQTT mode as non-embedded for detach conflict checks", async () => {
+    const { resolveDetachAdapterConfigs } = await import("./start.ts");
+    const template = createTemplateWithNamespace({ prefix: "factory" });
+
+    expect(
+      resolveDetachAdapterConfigs({
+        template,
+        simulationName: "factory-sim",
+        mqtt: {
+          enabled: true,
+          portOverride: undefined,
+          overrides: { mode: "external", url: "mqtt://broker.example.com:1883" },
+        },
+        opcua: {
+          enabled: false,
+          portOverride: undefined,
+          hostOverride: undefined,
+          writeBudgetOverride: undefined,
+        },
+        modbus: { enabled: false, portOverride: undefined, hostOverride: undefined },
+      }).mqtt.embedded,
+    ).toBe(false);
+  });
+});
+
 describe("error context aggregation", () => {
   test("normalizeErrorContext redacts high-cardinality fragments", async () => {
     const { normalizeErrorContext } = await import("./start.ts");