minimal-agent 0.11.0 → 0.12.0

package/src/memory/memoryService.ts

@@ -12,8 +12,19 @@ import {
   sha256,
   validateMemoryInput,
 } from './codec.js';
-import { DEFAULT_SETTINGS, PERSONA_MAX_CHARS } from './constants.js';
-import { episodicMemoryService } from './episodicMemory.js';
+import {
+  DEFAULT_RETENTION,
+  DEFAULT_SETTINGS,
+  MEMORY_RETENTION_DAYS_MAX,
+  MEMORY_RETENTION_DAYS_MIN,
+  MEMORY_RETENTION_MB_MAX,
+  MEMORY_RETENTION_MB_MIN,
+  PERSONA_MAX_CHARS,
+} from './constants.js';
+import {
+  clearConversationEpisodes,
+  episodicMemoryService,
+} from './episodicMemory.js';
 import {
   acquireFileLock,
   appendPrivateLine,
@@ -26,7 +37,9 @@ import {
 } from './fileStore.js';
 import { ensureMemoryMigrated } from './migration.js';
 import {
+  clearScopeTransactionQuarantine,
   readVersionedMemory,
+  refreshTopicView,
   removeVersionedMemory,
   replaceMemoryBatchVersioned,
   replaceVersionedMemory,
@@ -86,6 +99,7 @@ export { containsForbiddenSecret } from './codec.js';
 
 function mergeSettings(raw: Partial<MemorySettings>): MemorySettings {
   const review = raw.reviewAfterDays;
+  const retention = raw.retention;
   return {
     autoRemember:
       typeof raw.autoRemember === 'boolean'
@@ -100,16 +114,44 @@ function mergeSettings(raw: Partial<MemorySettings>): MemorySettings {
       project: review?.project ?? DEFAULT_SETTINGS.reviewAfterDays!.project,
       decision: review?.decision ?? DEFAULT_SETTINGS.reviewAfterDays!.decision,
     },
+    retention: {
+      episodeDays: retention?.episodeDays ?? DEFAULT_RETENTION.episodeDays,
+      episodeMaxMegabytes:
+        retention?.episodeMaxMegabytes ?? DEFAULT_RETENTION.episodeMaxMegabytes,
+    },
   };
 }
 
 function validateSettingsPatch(patch: Partial<MemorySettings>): void {
-  if (patch.reviewAfterDays === undefined) return;
-  for (const [category, days] of Object.entries(patch.reviewAfterDays)) {
-    if (!Number.isInteger(days) || days < 7 || days > 3_650) {
-      throw new Error(`复核周期 ${category} 必须是 7-3650 之间的整数天`);
+  if (patch.reviewAfterDays !== undefined) {
+    for (const [category, days] of Object.entries(patch.reviewAfterDays)) {
+      if (!Number.isInteger(days) || days < 7 || days > 3_650) {
+        throw new Error(`复核周期 ${category} 必须是 7-3650 之间的整数天`);
+      }
     }
   }
+  if (patch.retention === undefined) return;
+  const { episodeDays, episodeMaxMegabytes } = patch.retention;
+  if (
+    episodeDays !== undefined
+    && (!Number.isInteger(episodeDays)
+      || episodeDays < MEMORY_RETENTION_DAYS_MIN
+      || episodeDays > MEMORY_RETENTION_DAYS_MAX)
+  ) {
+    throw new Error(
+      `会话原文保留天数必须是 ${MEMORY_RETENTION_DAYS_MIN}-${MEMORY_RETENTION_DAYS_MAX} 之间的整数`,
+    );
+  }
+  if (
+    episodeMaxMegabytes !== undefined
+    && (!Number.isInteger(episodeMaxMegabytes)
+      || episodeMaxMegabytes < MEMORY_RETENTION_MB_MIN
+      || episodeMaxMegabytes > MEMORY_RETENTION_MB_MAX)
+  ) {
+    throw new Error(
+      `会话原文体积上限必须是 ${MEMORY_RETENTION_MB_MIN}-${MEMORY_RETENTION_MB_MAX} 之间的整数 MB`,
+    );
+  }
 }
 
 async function settingsDocument(): Promise<VersionedMemorySettings> {
@@ -129,6 +171,9 @@ async function settingsDocument(): Promise<VersionedMemorySettings> {
   }
 }
 
+/** 审计日志单代上限；超限挪成 `.1`，保留最近两代。 */
+const AUDIT_MAX_BYTES = 4 * 1024 * 1024;
+
 async function appendAudit(input: {
   action: string;
   record?: MemoryRecord;
@@ -147,28 +192,69 @@ async function appendAudit(input: {
       version: input.version,
       result: input.result,
     }),
+    // 审计日志同样是 append-only，必须轮转——它此前是仓库里第二个只增不减的存储。
+    { maxBytes: AUDIT_MAX_BYTES },
   ).catch(() => undefined);
 }
 
+const EMPTY_SCOPE_SNAPSHOT: MemorySnapshot = Object.freeze({
+  records: [],
+  versions: {},
+  diagnostics: [],
+  createdAt: 0,
+}) as MemorySnapshot;
+
+/**
+ * 合并快照的记忆化。
+ *
+ * ⚠️ 这不是"顺手加个缓存"，是修一个死缓存：`retrieval.ts` 用
+ * `WeakMap<MemorySnapshot, Bm25Index>` 按快照对象缓存 BM25 索引，而本函数以前**每次都
+ * 返回全新对象字面量** —— 于是 recall / buildContextBundle 这两条热路径上 WeakMap 永远
+ * miss，每轮对话都要重建整个索引，`recordSearchIndexCacheHit()` 一次都不会触发（诊断计数
+ * 器因此说谎）。单测直接对同一个 snapshot 对象调两次 recallFromSnapshot，机制是对的，
+ * 但生产集成从不复用对象，属于"测试通过、生产死代码"。
+ *
+ * 用底层两个 scope 快照的**对象标识**做键：scanMemoryScope 在缓存命中时返回同一个对象，
+ * 有变更时才换新对象——比时间戳更精确，也不怕时钟碰撞。
+ */
+let combinedSnapshotCache: {
+  personal: MemorySnapshot;
+  workspace: MemorySnapshot;
+  workspaceId?: string;
+  combined: MemorySnapshot;
+} | null = null;
+
 async function combinedSnapshot(workspaceId?: string): Promise<MemorySnapshot> {
   await ensureMemoryMigrated();
   const personal = await scanMemoryScope('personal');
   const workspace = workspaceId
     ? await scanMemoryScope('workspace', workspaceId)
-    : { records: [], versions: {}, diagnostics: [], createdAt: Date.now() };
-  return {
+    : EMPTY_SCOPE_SNAPSHOT;
+  const cached = combinedSnapshotCache;
+  if (
+    cached
+    && cached.personal === personal
+    && cached.workspace === workspace
+    && cached.workspaceId === workspaceId
+  ) {
+    return cached.combined;
+  }
+  const combined: MemorySnapshot = {
     records: [...personal.records, ...workspace.records],
     versions: { ...personal.versions, ...workspace.versions },
     diagnostics: [...personal.diagnostics, ...workspace.diagnostics],
     createdAt: Date.now(),
   };
+  combinedSnapshotCache = { personal, workspace, workspaceId, combined };
+  return combined;
 }
 
 function refreshTopicViewAfterMutation(
   scope: MemoryScope,
   workspaceId?: string,
 ): void {
-  void scanMemoryScope(scope, workspaceId).catch(() => undefined);
+  combinedSnapshotCache = null;
+  void refreshTopicView(scope, workspaceId).catch(() => undefined);
 }
 
 function sameTopic(
@@ -565,6 +651,19 @@ export const memoryService = {
         await removeVersionedMemory({ record, version }, version);
         await appendAudit({ action: 'clear', record, version, result: 'ok' });
       }
+      // ★ 会话原文日志也要清掉。
+      //   Desktop「永久清空」以前只删 records，而同一个记忆中心页面还提供
+      //   ConversationHistorySearch —— 用户"清空记忆"后全部对话原文依然可搜，
+      //   与按钮承诺严重不符。工作区范围才有对应的 episodes 文件。
+      if (scope === 'workspace' && workspaceId) {
+        const removed = await clearConversationEpisodes(workspaceId).catch(() => 0);
+        if (removed) {
+          await appendAudit({ action: 'clear-episodes', result: 'ok' });
+        }
+      }
+      // 只有用户明确清空整个 scope 才表示隔离事务的复核现场也不再需要。
+      // 普通新增/更新记忆不得清除这类诊断。
+      await clearScopeTransactionQuarantine(scope, workspaceId);
       refreshTopicViewAfterMutation(scope, workspaceId);
     });
   },