mini-coder 0.5.10 → 0.5.12

package/src/ui/commands.test.ts

@@ -2,40 +2,19 @@ import { afterEach, describe, expect, test } from "bun:test";
 import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
-import type { ContainerNode, Node } from "@cel-tui/types";
+import type { ContainerNode } from "@cel-tui/types";
 import { registerFauxProvider } from "@mariozechner/pi-ai";
 import type { AppState } from "../index.ts";
-import { COMMANDS } from "../input.ts";
 import {
-  appendPromptHistory,
   computeContextTokens,
   createSession,
   openDatabase,
 } from "../session.ts";
 import { loadSettings } from "../settings.ts";
 import { DEFAULT_THEME } from "../theme.ts";
-import {
-  createCommandController,
-  formatPromptHistoryLabel,
-  formatPromptHistoryPreview,
-  formatRelativeDate,
-  formatSessionLabel,
-} from "./commands.ts";
+import { createCommandController } from "./commands.ts";
 import type { ActiveOverlay } from "./overlay.ts";
 
-function collectText(node: Node | null): string[] {
-  if (!node) {
-    return [];
-  }
-  if (node.type === "text") {
-    return [node.content];
-  }
-  if (node.type === "textinput") {
-    return [];
-  }
-  return node.children.flatMap((child) => collectText(child));
-}
-
 function expectOverlay(overlay: ActiveOverlay | null): ActiveOverlay {
   if (!overlay) {
     throw new Error("Expected an active overlay");
@@ -107,204 +86,11 @@ afterEach(() => {
 });
 
 describe("ui/commands", () => {
-  test("showCommandAutocomplete clears the current draft and opens the commands overlay", () => {
-    const state = createTestState();
-    const runtimeState = { overlay: null as ActiveOverlay | null };
-    let inputValue = "draft";
-    const controller = createCommandController({
-      openOverlay: (nextOverlay) => {
-        runtimeState.overlay = nextOverlay;
-      },
-      dismissOverlay: () => {
-        runtimeState.overlay = null;
-      },
-      setInputValue: (value) => {
-        inputValue = value;
-      },
-      appendInfoMessage: () => {},
-      appendTodoMessage: () => {},
-      scrollConversationToBottom: () => {},
-      render: () => {},
-      reloadPromptContext: async () => {},
-      openInBrowser: () => {},
-    });
-
-    try {
-      controller.showCommandAutocomplete(state);
-
-      const overlay = expectOverlay(runtimeState.overlay);
-
-      expect(inputValue).toBe("");
-      expect(overlay.title).toBe("Commands");
-
-      const text = collectText(overlay.select());
-      for (const command of COMMANDS) {
-        expect(text.some((line) => line.includes(`/${command}`))).toBe(true);
-      }
-    } finally {
-      state.db.close();
-    }
-  });
-
-  test("showInputHistoryOverlay restores the selected raw prompt", () => {
-    const state = createTestState();
-    const runtimeState = { overlay: null as ActiveOverlay | null };
-    let inputValue = "draft";
-    const rawPrompt = "first line\nsecond line";
-    const controller = createCommandController({
-      openOverlay: (nextOverlay) => {
-        runtimeState.overlay = nextOverlay;
-      },
-      dismissOverlay: () => {
-        runtimeState.overlay = null;
-      },
-      setInputValue: (value) => {
-        inputValue = value;
-      },
-      appendInfoMessage: () => {},
-      appendTodoMessage: () => {},
-      scrollConversationToBottom: () => {},
-      render: () => {},
-      reloadPromptContext: async () => {},
-      openInBrowser: () => {},
-    });
-
-    try {
-      appendPromptHistory(state.db, {
-        text: "older prompt",
-        cwd: "/tmp/older",
-      });
-      appendPromptHistory(state.db, { text: rawPrompt, cwd: state.cwd });
-
-      controller.showInputHistoryOverlay(state);
-
-      const overlay = expectOverlay(runtimeState.overlay);
-
-      expect(overlay.title).toBe("Input history");
-
-      const selectNode = renderSelect(overlay);
-
-      selectNode.props.onKeyPress?.("enter");
-
-      expect(runtimeState.overlay).toBeNull();
-      expect(inputValue).toBe(rawPrompt);
-    } finally {
-      state.db.close();
-    }
-  });
-
-  test("showInputHistoryOverlay dismissal leaves the current draft unchanged", () => {
-    const state = createTestState();
-    const runtimeState = { overlay: null as ActiveOverlay | null };
-    let inputValue = "draft prompt";
-    const controller = createCommandController({
-      openOverlay: (nextOverlay) => {
-        runtimeState.overlay = nextOverlay;
-      },
-      dismissOverlay: () => {
-        runtimeState.overlay = null;
-      },
-      setInputValue: (value) => {
-        inputValue = value;
-      },
-      appendInfoMessage: () => {},
-      appendTodoMessage: () => {},
-      scrollConversationToBottom: () => {},
-      render: () => {},
-      reloadPromptContext: async () => {},
-      openInBrowser: () => {},
-    });
-
-    try {
-      appendPromptHistory(state.db, {
-        text: "saved prompt",
-        cwd: state.cwd,
-      });
-
-      controller.showInputHistoryOverlay(state);
-
-      const overlay = expectOverlay(runtimeState.overlay);
-      const selectNode = renderSelect(overlay);
-
-      selectNode.props.onBlur?.();
-
-      expect(runtimeState.overlay).toBeNull();
-      expect(inputValue).toBe("draft prompt");
-    } finally {
-      state.db.close();
-    }
-  });
-
-  test("handleCommand('session') overlay includes the first user preview for disambiguation", () => {
-    const state = createTestState();
-    const runtimeState = { overlay: null as ActiveOverlay | null };
-    const controller = createCommandController({
-      openOverlay: (nextOverlay) => {
-        runtimeState.overlay = nextOverlay;
-      },
-      dismissOverlay: () => {
-        runtimeState.overlay = null;
-      },
-      setInputValue: () => {},
-      appendInfoMessage: () => {},
-      appendTodoMessage: () => {},
-      scrollConversationToBottom: () => {},
-      render: () => {},
-      reloadPromptContext: async () => {},
-      openInBrowser: () => {},
-    });
-    const session = createSession(state.db, {
-      cwd: state.canonicalCwd,
-      model: "test/beta",
-      effort: "high",
-    });
-
-    state.db.run(
-      "INSERT INTO messages (session_id, turn, data, created_at) VALUES (?, ?, ?, ?)",
-      [
-        session.id,
-        null,
-        JSON.stringify({
-          role: "ui",
-          kind: "info",
-          content: "Help output",
-          timestamp: 1,
-        }),
-        1,
-      ],
-    );
-    state.db.run(
-      "INSERT INTO messages (session_id, turn, data, created_at) VALUES (?, ?, ?, ?)",
-      [
-        session.id,
-        1,
-        JSON.stringify({
-          role: "user",
-          content: "Investigate\nthis session label",
-          timestamp: 2,
-        }),
-        2,
-      ],
-    );
-
-    try {
-      expect(controller.handleCommand("session", state)).toBe(true);
-
-      const overlay = expectOverlay(runtimeState.overlay);
-      const text = collectText(renderSelect(overlay));
-
-      expect(
-        text.some((line) => line.includes("Investigate this session")),
-      ).toBe(true);
-    } finally {
-      state.db.close();
-    }
-  });
-
   test("handleCommand('session') restores the selected session and recomputes stats", () => {
     const state = createTestState();
     const runtimeState = { overlay: null as ActiveOverlay | null };
     let scrollCalls = 0;
+    let renderCalls = 0;
     const controller = createCommandController({
       openOverlay: (nextOverlay) => {
         runtimeState.overlay = nextOverlay;
@@ -318,7 +104,9 @@ describe("ui/commands", () => {
       scrollConversationToBottom: () => {
         scrollCalls += 1;
       },
-      render: () => {},
+      requestRender: () => {
+        renderCalls += 1;
+      },
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -368,13 +156,12 @@ describe("ui/commands", () => {
       expect(controller.handleCommand("session", state)).toBe(true);
 
       const overlay = expectOverlay(runtimeState.overlay);
-      expect(overlay.title).toBe("Resume a session");
-
       const selectNode = renderSelect(overlay);
       selectNode.props.onKeyPress?.("enter");
 
       expect(runtimeState.overlay).toBeNull();
       expect(scrollCalls).toBe(1);
+      expect(renderCalls).toBe(1);
       expect(state.session?.id).toBe(session.id);
       expect(state.messages.map((message) => message.role)).toEqual([
         "user",
@@ -391,27 +178,6 @@ describe("ui/commands", () => {
     }
   });
 
-  test("handleCommand returns false for unknown commands", () => {
-    const state = createTestState();
-    const controller = createCommandController({
-      openOverlay: () => {},
-      dismissOverlay: () => {},
-      setInputValue: () => {},
-      appendInfoMessage: () => {},
-      appendTodoMessage: () => {},
-      scrollConversationToBottom: () => {},
-      render: () => {},
-      reloadPromptContext: async () => {},
-      openInBrowser: () => {},
-    });
-
-    try {
-      expect(controller.handleCommand("unknown", state)).toBe(false);
-    } finally {
-      state.db.close();
-    }
-  });
-
   test("/new clears the active session state and reloads prompt context", async () => {
     const state = createTestState();
     let reloadCount = 0;
@@ -423,7 +189,7 @@ describe("ui/commands", () => {
       appendInfoMessage: () => {},
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async (nextState) => {
         reloadCount++;
         nextState.agentsMd = [
@@ -479,7 +245,7 @@ describe("ui/commands", () => {
       appendInfoMessage: () => {},
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -505,7 +271,7 @@ describe("ui/commands", () => {
       appendInfoMessage: () => {},
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -520,7 +286,7 @@ describe("ui/commands", () => {
     }
   });
 
-  test("/help appends markdown help without creating a session", () => {
+  test("/help appends a markdown info message without creating a session", () => {
     const state = createTestState();
     const appended: Array<{
       text: string;
@@ -540,7 +306,7 @@ describe("ui/commands", () => {
       },
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -548,8 +314,7 @@ describe("ui/commands", () => {
     try {
       expect(controller.handleCommand("help", state)).toBe(true);
       expect(appended).toHaveLength(1);
-      expect(appended[0]?.text).toContain("# Help");
-      expect(appended[0]?.text).toContain("## Commands");
+      expect(appended[0]?.text.length).toBeGreaterThan(0);
       expect(appended[0]?.format).toBe("markdown");
       expect(appended[0]?.sessionId).toBeNull();
       expect(state.session).toBeNull();
@@ -596,7 +361,7 @@ describe("ui/commands", () => {
         });
       },
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -629,7 +394,7 @@ describe("ui/commands", () => {
       appendInfoMessage: () => {},
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -657,7 +422,7 @@ describe("ui/commands", () => {
       appendInfoMessage: () => {},
       appendTodoMessage: () => {},
       scrollConversationToBottom: () => {},
-      render: () => {},
+      requestRender: () => {},
       reloadPromptContext: async () => {},
       openInBrowser: () => {},
     });
@@ -674,55 +439,4 @@ describe("ui/commands", () => {
       state.db.close();
     }
   });
-
-  test("formatRelativeDate accepts an explicit clock for deterministic output", () => {
-    const now = new Date("2026-04-07T12:00:00Z");
-
-    expect(formatRelativeDate(new Date("2026-04-07T11:59:45Z"), now)).toBe(
-      "just now",
-    );
-    expect(formatRelativeDate(new Date("2026-04-07T11:50:00Z"), now)).toBe(
-      "10m ago",
-    );
-    expect(formatRelativeDate(new Date("2026-04-07T10:00:00Z"), now)).toBe(
-      "2h ago",
-    );
-    expect(formatRelativeDate(new Date("2026-04-04T12:00:00Z"), now)).toBe(
-      "3d ago",
-    );
-  });
-
-  test("formatPromptHistoryPreview collapses whitespace into one line", () => {
-    expect(formatPromptHistoryPreview("  first\n\n second\tthird  ")).toBe(
-      "first second third",
-    );
-  });
-
-  test("formatPromptHistoryLabel_longPromptAndCwd_returnsATruncatedSingleLineLabel", () => {
-    expect(
-      formatPromptHistoryLabel(
-        "  Investigate\n\n this prompt history row because it is much too wide for the overlay  ",
-        "/tmp/projects/very/deeply/nested/mini-coder-audit",
-        "5m ago",
-      ),
-    ).toBe(
-      "Investigate this prompt history…  ·  …/mini-coder-audit  ·  5m ago",
-    );
-  });
-
-  test("formatSessionLabel_longPreviewAndModel_returnsATruncatedReadableLabel", () => {
-    expect(
-      formatSessionLabel(
-        {
-          model: "openai-codex/gpt-5.4-super-long-variant",
-          firstUserPreview:
-            "Audit the session selector because every entry looks identical in real usage",
-        },
-        "just now",
-        true,
-      ),
-    ).toBe(
-      "Audit the session selector…  ·  openai-codex/gpt…  ·  just now  ·  current",
-    );
-  });
 });

package/src/ui/commands.ts

@@ -19,20 +19,22 @@ import type { AppState } from "../index.ts";
 import { getAvailableModels, saveOAuthCredentials } from "../index.ts";
 import { COMMANDS } from "../input.ts";
 import {
-  computeContextTokens,
-  computeStats,
+  clearConversationState,
   forkSession,
   listPromptHistory,
   listSessions,
   loadMessages,
+  replaceConversationState,
   type SessionListEntry,
   type UiInfoFormat,
   undoLastTurn,
 } from "../session.ts";
 import { updateSettings } from "../settings.ts";
+import { collapseWhitespace, truncateText } from "../text.ts";
 import { getTodoItems } from "../tools.ts";
 import { buildHelpText, COMMAND_DESCRIPTIONS } from "./help.ts";
 import { type ActiveOverlay, OVERLAY_MAX_VISIBLE } from "./overlay.ts";
+import type { UiRenderPriority } from "./runtime.ts";
 import { abbreviatePath } from "./status.ts";
 
 /** Effort levels available for selection. */
@@ -45,9 +47,9 @@ const EFFORT_LEVELS: { label: string; value: ThinkingLevel }[] = [
 
 /** Runtime hooks injected from the stateful UI module. */
 interface UiCommandRuntime {
-  /** Open an overlay and trigger a re-render. */
+  /** Open an overlay. */
   openOverlay: (overlay: ActiveOverlay) => void;
-  /** Dismiss the active overlay and trigger a re-render. */
+  /** Dismiss the active overlay. */
   dismissOverlay: () => void;
   /** Update the current input draft. */
   setInputValue: (value: string) => void;
@@ -64,8 +66,8 @@ interface UiCommandRuntime {
   ) => void;
   /** Re-enable stick-to-bottom behavior for the conversation log. */
   scrollConversationToBottom: () => void;
-  /** Trigger a UI re-render. */
-  render: () => void;
+  /** Schedule a UI re-render. */
+  requestRender: (priority?: UiRenderPriority) => void;
   /** Reload prompt/session context at a boundary like `/new`. */
   reloadPromptContext: (state: AppState) => Promise<void>;
   /** Open a URL in the user's default browser. */
@@ -142,7 +144,7 @@ export function formatRelativeDate(date: Date, now = new Date()): string {
  * @returns A single-line preview string.
  */
 export function formatPromptHistoryPreview(text: string): string {
-  return text.replace(/\s+/g, " ").trim();
+  return collapseWhitespace(text);
 }
 
 const HISTORY_PREVIEW_MAX_CHARS = 32;
@@ -150,26 +152,6 @@ const HISTORY_CWD_MAX_CHARS = 18;
 const SESSION_PREVIEW_MAX_CHARS = 27;
 const SESSION_MODEL_MAX_CHARS = 17;
 
-function truncateTrailingText(text: string, maxChars: number): string {
-  if (text.length <= maxChars) {
-    return text;
-  }
-  if (maxChars <= 1) {
-    return "…";
-  }
-  return `${text.slice(0, maxChars - 1)}…`;
-}
-
-function truncateLeadingText(text: string, maxChars: number): string {
-  if (text.length <= maxChars) {
-    return text;
-  }
-  if (maxChars <= 1) {
-    return "…";
-  }
-  return `…${text.slice(text.length - (maxChars - 1))}`;
-}
-
 /**
  * Format a prompt-history row for the Select overlay.
  *
@@ -183,13 +165,14 @@ export function formatPromptHistoryLabel(
   cwd: string,
   date: string,
 ): string {
-  const preview = truncateTrailingText(
+  const preview = truncateText(
     formatPromptHistoryPreview(text),
     HISTORY_PREVIEW_MAX_CHARS,
   );
-  const displayCwd = truncateLeadingText(
+  const displayCwd = truncateText(
     abbreviatePath(cwd),
     HISTORY_CWD_MAX_CHARS,
+    "start",
   );
   return `${preview}  ·  ${displayCwd}  ·  ${date}`;
 }
@@ -207,11 +190,11 @@ export function formatSessionLabel(
   date: string,
   isCurrent: boolean,
 ): string {
-  const preview = truncateTrailingText(
+  const preview = truncateText(
     session.firstUserPreview ?? "No messages yet",
     SESSION_PREVIEW_MAX_CHARS,
   );
-  const model = truncateTrailingText(
+  const model = truncateText(
     session.model ?? "no model",
     SESSION_MODEL_MAX_CHARS,
   );
@@ -397,13 +380,12 @@ export function createCommandController(
           const picked = sessions.find((session) => session.id === sessionId);
           if (picked) {
             state.session = picked;
-            state.messages = loadMessages(state.db, picked.id);
-            state.stats = computeStats(state.messages);
-            state.contextTokens = computeContextTokens(state.messages);
+            replaceConversationState(state, loadMessages(state.db, picked.id));
             runtime.scrollConversationToBottom();
           }
         }
         runtime.dismissOverlay();
+        runtime.requestRender("normal");
       },
     );
   };
@@ -413,12 +395,10 @@ export function createCommandController(
       return;
     }
     state.session = null;
-    state.messages = [];
-    state.stats = { totalInput: 0, totalOutput: 0, totalCost: 0 };
-    state.contextTokens = 0;
+    clearConversationState(state);
     await runtime.reloadPromptContext(state);
     runtime.scrollConversationToBottom();
-    runtime.render();
+    runtime.requestRender("normal");
   };
 
   const handleForkCommand = (state: AppState): void => {
@@ -427,9 +407,7 @@ export function createCommandController(
     }
     const forked = forkSession(state.db, state.session.id);
     state.session = forked;
-    state.messages = loadMessages(state.db, forked.id);
-    state.stats = computeStats(state.messages);
-    state.contextTokens = computeContextTokens(state.messages);
+    replaceConversationState(state, loadMessages(state.db, forked.id));
     runtime.appendInfoMessage("Forked session.", state);
   };
 
@@ -447,11 +425,9 @@ export function createCommandController(
     }
     const removed = undoLastTurn(state.db, state.session.id);
     if (removed) {
-      state.messages = loadMessages(state.db, state.session.id);
-      state.stats = computeStats(state.messages);
-      state.contextTokens = computeContextTokens(state.messages);
+      replaceConversationState(state, loadMessages(state.db, state.session.id));
       runtime.scrollConversationToBottom();
-      runtime.render();
+      runtime.requestRender("normal");
     }
   };
 
@@ -460,7 +436,6 @@ export function createCommandController(
     state.settings = updateSettings(state.settingsPath, {
       showReasoning: state.showReasoning,
     });
-    runtime.render();
   };
 
   const handleVerboseCommand = (state: AppState): void => {
@@ -468,7 +443,6 @@ export function createCommandController(
     state.settings = updateSettings(state.settingsPath, {
       verbose: state.verbose,
     });
-    runtime.render();
   };
 
   const performLogin = async (