mingdao-harness 0.2.1 → 0.2.2

package/docs/ROADMAP-NEXT.md

@@ -0,0 +1,53 @@
+# 下一步迭代规划（v0.2.2 → v0.3.0）
+
+基于四路审计剩余清单、六份评估综合路线与近期反馈收敛。原则不变：每期可独立发布、全绿测试门禁、零依赖不动摇。**待确认后开工。**
+
+## 待办盘点（当前真实剩余）
+
+- 审计遗留（QUALITY-REVIEW 清单中未做的 12 项中低危）：sync-server devices/meta 互斥、sync login 密码走参数、fs-browse 基目录约束、readBody 按路由分级、draft 单槽、日志双文件 O(n) 重写、桌面崩溃循环护栏、notify 转义、cli 共享助手去重（offpeak/mcpFacade/参数解析）、会话/任务 misc。
+- 结构渐进（0.2.1 标注的渐进项）：routes/api.js 按域细分、cli.js REPL/worker 拆分。
+- strict 棘轮：1584 条隐式 any 待消（每版定削减配额，先安全关键模块）。
+- 省钱路线剩余（EVALUATION-SYNTHESIS 中期 6 项）：工具 Schema 按需挂载、Batch 输入侧智能、费用二级分账+看板、护栏 downgrade、评测基准扩充（压缩质量集/路由标注集/V4 词表对拍）。
+- 能力演进：跨平台沙箱补位、记忆语义检索、增量上下文。
+- 工程：覆盖率阈值随版本上调、CHANGELOG 历史回填、GitHub Release 附件自动清理（需 PAT）。
+
+## 分期方案
+
+### Phase A「正确性收尾」v0.2.2（约 1–1.5 天）
+审计遗留全部落地，零新功能：
+1. sync-server devices/meta 读改写加锁（withFileLockSync 复用）
+2. `mingdao sync login` 密码改隐藏输入/stdin，拒绝位置参数
+3. `/api/fs-browse` 限定基目录集合（工作空间根+显式授权），禁止向上越界、不回传绝对路径
+4. readBody 按路由分级（chat 40MB，其余 1MB）
+5. draft 按会话维度存储（key=session 而非全局单槽）
+6. 日志统一工具函数（append+按天滚动+按行截断），桌面/服务端共用口径
+7. 桌面渲染进程崩溃计数护栏（超 3 次弹窗提示重启）
+8. notify 结构化 argv（去掉启发式转义）
+9. cli.js 共享助手抽取（offpeak defer、mcpFacade 构建、run/run-worker 参数解析合一）
+- 验收：全绿 + 新增 fs-browse 越界与限流回归断言。
+
+### Phase B「省钱第二轮」v0.2.3（约 2–3 天）
+1. **工具 Schema 按需挂载**（每请求省 1–2K tokens）：只读阶段只发 read/ls/glob/grep/skill + 本回合已用工具；写类工具首次调用时动态注入
+2. **Batch 输入侧**：文本哈希去重（结果按 custom_id 回填全部位置）、单问超窗口预检报错、`--max-cost` 上限
+3. **费用二级分账 + 看板**：cache-stats 增 reasoning/tool 维度与 byTool 累加；WebUI 仪表盘加模型/工具 Top5 与按天折线（零依赖 SVG）
+4. **护栏 downgrade**：`action:'downgrade'` —— 触顶后自动切 flash + 明确提示（默认仍 warn/block 可选）
+5. **评测基准扩充**：压缩质量集（5 组长会话样本→压缩→关键事实追问断言）、路由 100 条标注集入 bench
+- 验收：bench 断言数 38→60+；覆盖率阈值上调至 60%。
+
+### Phase C「结构渐进」v0.2.4（约 2 天）
+1. routes/api.js 按域细分（config/sessions/sync/schedule/skills/workspace/misc 7 模块 + 共享中间件），每域配 API 契约测试
+2. cli.js REPL → commands/repl.js、worker → tasks/worker.js（e2e-local 16 项全绿做护栏）
+3. strict 棘轮削 300 条（先 credentials/permissions/config/sync-server/session 五个安全关键模块全量注解）
+- 验收：tsc full 错误数 ≤1284；结构清单在文档登记。
+
+### Phase D「能力演进」v0.3.0（约 3–5 天，可按需裁剪）
+1. **跨平台沙箱补位**：Windows Job Object + 降权 token（零依赖原生 API）、macOS seatbelt 规则；敏感命令平台无关拦截清单兜底
+2. **记忆语义检索**：零依赖实现（内存向量 + 余弦/哈希相似度；Node 22 可用 node:sqlite 持久化，Node 18 回退 JSONL 索引），记忆注入从「最近 3 条」升级为「相关 3 条」
+3. **WebUI 看板扩展**：预算燃尽预测、费用导出 CSV
+4. GitHub Release 附件自动清理（如你提供 PAT）+ 发布清单文档化
+
+## 需要你拍板的三件事
+
+1. **Phase 顺序**：A→B→C→D 直接推进，还是把 B（省钱）提前到 A 之前？
+2. **GitHub PAT**：是否提供（用于 Release 附件自动清理与发版自动化）？
+3. **Phase D 裁剪**：跨平台沙箱与语义检索是否都进 0.3.0，还是只做其一？

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mingdao-harness",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "MingDao Harness —— 开源智能体框架（Agent Harness）。零依赖、开箱即用，针对 DeepSeek-V4 系列优化，开放主流模型接入。",
   "type": "module",
   "bin": {

package/src/atomic-write.js

@@ -11,7 +11,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import crypto from 'node:crypto';
 
-export function atomicWriteFileSync(target, data, options = {}) {
+export function atomicWriteFileSync(/** @type {string} */ target, /** @type {string|Buffer} */ data, /** @type {any} */ options = {}) {
   const dir = path.dirname(target);
   const tmp = path.join(dir, `.${path.basename(target)}.${process.pid}.${crypto.randomBytes(4).toString('hex')}.tmp`);
   try {
@@ -25,16 +25,16 @@ export function atomicWriteFileSync(target, data, options = {}) {
   }
 }
 
-export function atomicWriteJsonSync(target, value, { mode = 0o600 } = {}) {
+export function atomicWriteJsonSync(/** @type {string} */ target, /** @type {any} */ value, { mode = 0o600 } = {}) {
   atomicWriteFileSync(target, JSON.stringify(value, null, 2) + '\n', { mode });
 }
 
 // 极简互斥锁：O_EXCL 创建 lockfile；持锁期间执行 fn（同步）；异常/完成释放。
 // 进程崩溃遗留的陈旧锁（> staleMs 未更新）自动回收，避免永久卡死。
 const sleepBuf = new Int32Array(new SharedArrayBuffer(4));
-const sleepMs = (ms) => Atomics.wait(sleepBuf, 0, 0, ms);
+const sleepMs = (/** @type {number} */ ms) => Atomics.wait(sleepBuf, 0, 0, ms);
 
-export function withFileLockSync(lockPath, fn, { timeoutMs = 5000, staleMs = 15000 } = {}) {
+export function withFileLockSync(/** @type {string} */ lockPath, /** @type {() => any} */ fn, { timeoutMs = 5000, staleMs = 15000 } = {}) {
   fs.mkdirSync(path.dirname(lockPath), { recursive: true });
   const t0 = Date.now();
   for (;;) {
@@ -53,7 +53,7 @@ export function withFileLockSync(lockPath, fn, { timeoutMs = 5000, staleMs = 150
         } catch {}
       }
     } catch (err) {
-      if (err.code !== 'EEXIST') throw err;
+      if (/** @type {any} */ (err).code !== 'EEXIST') throw err;
       try {
         const st = fs.statSync(lockPath);
         if (Date.now() - st.mtimeMs > staleMs) {

package/src/cli.js

@@ -296,45 +296,36 @@ async function main() {
     }
   }
 
-  // 后台任务 worker（内部入口，由 mingdao run 启动）
-  if (opts.prompt[0] === 'run-worker') {
-    const id = opts.prompt[1];
-    let question = '';
-    let permission = null;
-    let model = null;
-    let offpeak = false;
-    for (let i = 2; i < opts.prompt.length; i++) {
-      const a = opts.prompt[i];
-      if (a === '--permission') permission = opts.prompt[++i];
-      else if (a === '--model') model = opts.prompt[++i];
-      else if (a === '--offpeak') offpeak = true;
+  // 质检 A9：run/run-worker 共用同一参数解析（此前两份重复且语义微妙不同）
+  const parseRunArgs = (argv, { questionFlag = false } = {}) => {
+    const out = { question: '', permission: null, model: null, offpeak: false };
+    for (let i = 0; i < argv.length; i++) {
+      const a = argv[i];
+      if (a === '--permission') out.permission = argv[++i];
+      else if (a === '--model') out.model = argv[++i];
+      else if (a === '--offpeak') out.offpeak = true;
       else if (a === '--question') {
-        // 收集到下一个已知 flag 为止（参数顺序：--question <任务> --permission … --model …）
         const parts = [];
-        while (i + 1 < opts.prompt.length && !['--permission', '--model', '--offpeak'].includes(opts.prompt[i + 1])) {
-          parts.push(opts.prompt[++i]);
+        while (i + 1 < argv.length && !['--permission', '--model', '--offpeak'].includes(argv[i + 1])) {
+          parts.push(argv[++i]);
         }
-        question = parts.join(' ');
-      }
+        out.question = parts.join(' ');
+      } else if (!out.question) out.question = a;
     }
+    return out;
+  };
+
+  // 后台任务 worker（内部入口，由 mingdao run 启动）
+  if (opts.prompt[0] === 'run-worker') {
+    const id = opts.prompt[1];
+    const { question, permission, model, offpeak } = parseRunArgs(opts.prompt.slice(2));
     await runWorkerTask(id, question, { permission, model, offpeak });
     return;
   }
 
   // 后台任务启动：mingdao run "<任务>" [--permission auto] [--model x]
   if (opts.prompt[0] === 'run') {
-    const rest = opts.prompt.slice(1);
-    let question = '';
-    let permission = null;
-    let model = null;
-    let offpeak = false;
-    for (let i = 0; i < rest.length; i++) {
-      const a = rest[i];
-      if (a === '--permission') permission = rest[++i];
-      else if (a === '--model') model = rest[++i];
-      else if (a === '--offpeak') offpeak = true;
-      else if (question === '') question = a;
-    }
+    const { question, permission, model, offpeak } = parseRunArgs(opts.prompt.slice(1));
     if (!question) {
       console.log('用法：mingdao run "<任务>" [--permission auto|readonly] [--model 模型名] [--offpeak]');
       process.exitCode = 1;

package/src/commands/sync.js

@@ -35,21 +35,31 @@ export async function handleSync(cmd, args) {
   if (sub === 'login') {
     const username = args[1];
     if (!username) {
-      console.log('用法：mingdao sync login <用户名> [密码] [服务器地址]（地址默认取已配置项）');
+      console.log('用法：mingdao sync login <用户名> [服务器地址] [--insecure]（密码将隐藏输入，绝不走命令行参数）');
+      process.exitCode = 1;
+      return true;
+    }
+    // 质检 A2：密码绝不接受位置参数（明文出现在 ps/shell history）——隐藏输入或 stdin 单行
+    if (args[2] && !String(args[2]).startsWith('http')) {
+      console.log('[错误] 出于安全考虑，密码不再支持命令行参数——运行 mingdao sync login <用户名> <地址> 后按提示隐藏输入。');
       process.exitCode = 1;
       return true;
     }
     const s0 = syncStatus();
-    const url = args[3] || s0.url;
+    const url = args[2] && String(args[2]).startsWith('http') ? args[2] : s0.url;
     if (!url) {
-      console.log('缺少服务器地址：mingdao sync login <用户名> [密码] <http(s)://地址>');
+      console.log('缺少服务器地址：mingdao sync login <用户名> <http(s)://地址>');
+      process.exitCode = 1;
+      return true;
+    }
+    const insecureFlag = args.includes('--insecure');
+    let password = await askHidden('密码（至少 8 位）：');
+    if (!password) {
+      console.log('[错误] 未输入密码');
       process.exitCode = 1;
       return true;
     }
-    let password = args[2];
-    if (!password) password = await askHidden('密码（至少 8 位）：');
-    const insecureFlag = args[4] === '--insecure' || args[5] === '--insecure';
-    const r = await syncLogin({ url, username, password, deviceName: args[4] === '--insecure' ? undefined : args[4], insecure: insecureFlag });
+    const r = await syncLogin({ url, username, password, deviceName: undefined, insecure: insecureFlag });
     if (r.error) {
       console.log('[错误] ' + r.error);
       process.exitCode = 1;

package/src/log-writer.js

@@ -0,0 +1,27 @@
+// 统一日志写入器（质检 A6）：追加写 + 超限按行截断（原子替换，绝不截断在行中间）。
+// 桌面主进程（appLog）与 Web 服务端（srvlog）共用同一实现，消除双文件口径漂移与 O(n) 全量重写。
+import fs from 'node:fs';
+import path from 'node:path';
+import crypto from 'node:crypto';
+
+export function createLogWriter(/** @type {string} */ file, { maxBytes = 512 * 1024 } = {}) {
+  return (/** @type {string} */ msg) => {
+    try {
+      fs.mkdirSync(path.dirname(file), { recursive: true });
+      const line = new Date().toISOString() + ' ' + String(msg) + '\n';
+      fs.appendFileSync(file, line);
+      const st = fs.statSync(file);
+      if (st.size > maxBytes) {
+        const raw = fs.readFileSync(file, 'utf8');
+        const cut = raw.length - maxBytes;
+        const nl = raw.indexOf('\n', cut);
+        const keep = nl === -1 ? raw.slice(cut) : raw.slice(nl + 1); // 行对齐保留尾部
+        const tmp = file + '.' + process.pid + '.' + crypto.randomBytes(3).toString('hex') + '.tmp';
+        fs.writeFileSync(tmp, keep);
+        fs.renameSync(tmp, file);
+      }
+    } catch {
+      // 日志失败绝不抛错（best-effort）
+    }
+  };
+}

package/src/notify.js

@@ -16,15 +16,15 @@ export function notify(title, message) {
       child.on('error', () => {});
       child.unref();
     } else if (process.platform === 'darwin') {
-      const safe = text.replace(/[\\"]/g, '\\$&');
-      const safeT = t.replace(/[\\"]/g, '\\$&');
-      const child = spawn('osascript', ['-e', `display notification "${safe}" with title "${safeT}"`], { detached: true, stdio: 'ignore' });
+      // 质检 A8：osascript 逐参数传递（spawn 不经 shell，无需手工引号转义）
+      const child = spawn('osascript', ['-e', 'display notification ' + JSON.stringify(text) + ' with title ' + JSON.stringify(t)], { detached: true, stdio: 'ignore' });
       child.on('error', () => {});
       child.unref();
     } else if (process.platform === 'win32') {
-      const safe = text.replace(/'/g, "''");
-      const safeT = t.replace(/'/g, "''");
-      const child = spawn('powershell', ['-NoProfile', '-Command', `(New-Object -ComObject Wscript.Shell).Popup('${safe}', 10, '${safeT}', 64)`], { detached: true, stdio: 'ignore' });
+      // 质检 A8：PowerShell 用 -EncodedCommand（Base64 UTF-16LE）传递，彻底消除引号/元字符问题
+      const script = `(New-Object -ComObject Wscript.Shell).Popup(${JSON.stringify(text)}, 10, ${JSON.stringify(t)}, 64)`;
+      const enc = Buffer.from(script, 'utf16le').toString('base64');
+      const child = spawn('powershell', ['-NoProfile', '-NonInteractive', '-EncodedCommand', enc], { detached: true, stdio: 'ignore' });
       child.on('error', () => {});
       child.unref();
     }

package/src/sync-server.js

@@ -201,6 +201,21 @@ function findDeviceByToken(token) {
 }
 
 // ---------- 业务 ----------
+// 质检 A1：通用写互斥（注册/pair/lastSeen/meta 更新串行化），防 devices.json/meta.json 读改写竞态
+let writeLock = null;
+async function withWriteLock(fn) {
+  const prev = writeLock || Promise.resolve();
+  let release;
+  writeLock = new Promise((resolve) => {
+    release = resolve;
+  });
+  await prev;
+  try {
+    return await fn();
+  } finally {
+    release();
+  }
+}
 let registerLock = null;
 async function doRegister(body) {
   const username = String(body.username || '').trim();
@@ -232,7 +247,7 @@ async function doRegister(body) {
   }
 }
 
-function doPair(body) {
+async function doPair(body) {
   const username = String(body.username || '').trim();
   const password = String(body.password || '');
   const deviceName = String(body.deviceName || '').trim().slice(0, 60) || '未命名设备';
@@ -240,15 +255,17 @@ function doPair(body) {
   const u = users[username];
   if (!u) return { notFound: '用户不存在（请先注册）' };
   if (!verifyPassword(password, u.salt, u.hash)) return { unauthorized: '密码错误' };
-  const deviceId = crypto.randomBytes(8).toString('hex');
-  const token = crypto.randomBytes(24).toString('hex');
-  const devices = readJson(devicesFile(), {});
-  devices[username] = devices[username] || {};
-  devices[username][deviceId] = { name: deviceName, tokenHash: sha(token), createdAt: Date.now(), lastSeen: Date.now() };
-  writeJson(devicesFile(), devices);
-  invalidateDeviceCache();
-  log('pair', username, deviceName, deviceId);
-  return { ok: true, username, deviceId, deviceName, token };
+  return withWriteLock(() => {
+    const deviceId = crypto.randomBytes(8).toString('hex');
+    const token = crypto.randomBytes(24).toString('hex');
+    const devices = readJson(devicesFile(), {});
+    devices[username] = devices[username] || {};
+    devices[username][deviceId] = { name: deviceName, tokenHash: sha(token), createdAt: Date.now(), lastSeen: Date.now() };
+    writeJson(devicesFile(), devices);
+    invalidateDeviceCache();
+    log('pair', username, deviceName, deviceId);
+    return { ok: true, username, deviceId, deviceName, token };
+  });
 }
 
 function doListSessions(username) {
@@ -280,10 +297,12 @@ function doPush(username, body) {
   const tmp = file + '.tmp';
   fs.writeFileSync(tmp, content, { mode: 0o600 });
   fs.renameSync(tmp, file);
-  const meta = readJson(metaFile(username), {});
-  meta[name] = { mtime: Date.now(), size: Buffer.byteLength(content) };
-  writeJson(metaFile(username), meta);
-  return { ok: true, name, mtime: meta[name].mtime, size: meta[name].size };
+  return withWriteLock(() => {
+    const meta = readJson(metaFile(username), {});
+    meta[name] = { mtime: Date.now(), size: Buffer.byteLength(content) };
+    writeJson(metaFile(username), meta);
+    return { ok: true, name, mtime: meta[name].mtime, size: meta[name].size };
+  });
 }
 
 function doPull(username, name) {
@@ -307,10 +326,12 @@ function doDelete(username, name) {
   } catch {
     return { notFound: '会话不存在' };
   }
-  const meta = readJson(metaFile(username), {});
-  delete meta[name];
-  writeJson(metaFile(username), meta);
-  return { ok: true, name };
+  return withWriteLock(() => {
+    const meta = readJson(metaFile(username), {});
+    delete meta[name];
+    writeJson(metaFile(username), meta);
+    return { ok: true, name };
+  });
 }
 
 // ---------- 密码修改 ----------
@@ -410,23 +431,25 @@ function doShareAccept(username, shareId) {
     fs.mkdirSync(sessionsDir(username), { recursive: true, mode: 0o700 });
     atomicWriteFileSync(target, content, { mode: 0o600 }); // 质检 H4
   }
-  const meta = readJson(metaFile(username), {});
-  meta[savedAs] = { mtime: Date.now(), size: Buffer.byteLength(content) };
-  writeJson(metaFile(username), meta);
-  accepted[username] = accepted[username] || {};
-  accepted[username][shareId] = { owner: s.owner, name: s.name, savedAs, acceptedAt: Date.now(), copyHash: sha(content) };
-  writeJson(acceptedFile(), accepted);
-  shares[shareId].pulls = (shares[shareId].pulls || 0) + 1;
-  writeJson(sharesFile(), shares);
-  log('share-accept', username, shareId, savedAs, conflict ? '(conflict-copy)' : '(refresh)');
-  return {
-    ok: true,
-    shareId,
-    savedAs,
-    conflict,
-    content,
-    mtime: meta[savedAs]?.mtime || Date.now(),
-  };
+  return withWriteLock(() => {
+    const meta = readJson(metaFile(username), {});
+    meta[savedAs] = { mtime: Date.now(), size: Buffer.byteLength(content) };
+    writeJson(metaFile(username), meta);
+    accepted[username] = accepted[username] || {};
+    accepted[username][shareId] = { owner: s.owner, name: s.name, savedAs, acceptedAt: Date.now(), copyHash: sha(content) };
+    writeJson(acceptedFile(), accepted);
+    shares[shareId].pulls = (shares[shareId].pulls || 0) + 1;
+    writeJson(sharesFile(), shares);
+    log('share-accept', username, shareId, savedAs, conflict ? '(conflict-copy)' : '(refresh)');
+    return {
+      ok: true,
+      shareId,
+      savedAs,
+      conflict,
+      content,
+      mtime: meta[savedAs]?.mtime || Date.now(),
+    };
+  });
 }
 
 // ---------- 路由 ----------
@@ -457,7 +480,7 @@ async function handle(req, res) {
       const body = await parseBody(req);
       if (body.__error) return json(res, 400, { error: 'JSON 解析失败' });
       if (rateLimited(req, 5, String(body.username || '').toLowerCase())) return json(res, 429, { error: '该用户名的尝试过于频繁，请稍后再试' });
-      const r = doPair(body);
+      const r = await doPair(body);
       if (r.notFound) return json(res, 404, r);
       if (r.unauthorized) return json(res, 401, r);
       return json(res, 200, r);
@@ -469,11 +492,14 @@ async function handle(req, res) {
     const nowSeen = Date.now();
     if (nowSeen - (dev.device.lastSeen || 0) > 60000) {
       dev.device.lastSeen = nowSeen;
-      const devices = readJson(devicesFile(), {});
-      if (devices[dev.username]?.[dev.deviceId]) {
-        devices[dev.username][dev.deviceId] = dev.device;
-        writeJson(devicesFile(), devices);
-      }
+      // 质检 A1：与 pair 的 devices 写入互斥（60s 节流只降频，不消除竞态——加锁消除）
+      withWriteLock(() => {
+        const devices = readJson(devicesFile(), {});
+        if (devices[dev.username]?.[dev.deviceId]) {
+          devices[dev.username][dev.deviceId] = dev.device;
+          writeJson(devicesFile(), devices);
+        }
+      });
     }
 
     if (req.method === 'POST' && p === '/api/devices') {
@@ -492,7 +518,7 @@ async function handle(req, res) {
     if (req.method === 'POST' && p === '/api/sessions/push') {
       const body = await parseBody(req);
       if (body.__error) return json(res, 400, { error: 'JSON 解析失败' });
-      const r = doPush(dev.username, body);
+      const r = await doPush(dev.username, body);
       if (r.error) return json(res, 400, r);
       return json(res, 200, r);
     }
@@ -504,7 +530,7 @@ async function handle(req, res) {
     }
     if (req.method === 'POST' && p === '/api/sessions/delete') {
       const body = await parseBody(req);
-      const r = doDelete(dev.username, String(body.name || '').trim());
+      const r = await doDelete(dev.username, String(body.name || '').trim());
       if (r.notFound) return json(res, 404, r);
       return json(res, 200, r);
     }
@@ -536,7 +562,7 @@ async function handle(req, res) {
     if (req.method === 'POST' && p === '/api/share/accept') {
       if (rateLimited(req, 10)) return json(res, 429, { error: '尝试过于频繁，请稍后再试' });
       const body = await parseBody(req);
-      const r = doShareAccept(dev.username, String(body.shareId || '').trim());
+      const r = await doShareAccept(dev.username, String(body.shareId || '').trim());
       if (r.error) return json(res, 400, r);
       if (r.notFound) return json(res, 404, r);
       return json(res, 200, r);

package/src/web/app.js

@@ -634,7 +634,7 @@ async function init(){
   refreshSessions();
   refreshWsSel();
   try{
-    const dr=await fetch('/api/draft',{cache:'no-store'}); const dj=await dr.json();
+    const dr=await fetch('/api/draft?file='+encodeURIComponent(currentSession||''),{cache:'no-store'}); const dj=await dr.json();
     if(dj.text){ input.value=dj.text; input.style.height=Math.min(input.scrollHeight,200)+'px'; input.focus(); }
   }catch(e){}
 }

package/src/web/routes/api.js

@@ -1,6 +1,7 @@
 import http from 'node:http';
 import fs from 'node:fs';
 import path from 'node:path';
+import os from 'node:os';
 import crypto from 'node:crypto';
 import { fileURLToPath } from 'node:url';
 import { ensureHome, loadConfig, saveConfig, mingdaoHome } from '../../config.js';
@@ -49,9 +50,10 @@ import { presetList, buildPreset } from '../../mcp-presets.js';
 import { syncStatus, syncLogin, syncLogout, syncPush, syncPull, syncRemoteList, maybeAutoSync, syncChangePassword, syncShareCreate, syncShareList, syncShareAccept, syncShareRevoke, listSyncConflicts, resolveSyncConflict } from '../../sync.js';
 
 export function createApiDispatch(deps) {
-  const { json, srvlog, readBody, cfg, home, providerCache, getProviderFor, tasks, MAX_CONCURRENT, pruneTasks, handleChat, mcpFacade, provider, validateRemoteUrl, isPrivateHost, authEnabled, tokenMatches, requestToken, trustedHost, INDEX_HTML } = deps;
-  const state = deps.state; // { modelName, workingDir, draftText }
+  const { json, srvlog, readBody, cfg, home, providerCache, getProviderFor, tasks, MAX_CONCURRENT, pruneTasks, handleChat, mcpFacade, provider, validateRemoteUrl, isPrivateHost, authEnabled, tokenMatches, requestToken, trustedHost, INDEX_HTML, draftTexts, startupCwd } = deps;
+  const state = deps.state; // { modelName, workingDir }
   const refs = deps.refs; // { inflight }
+  const MAX_API_BODY = 1024 * 1024; // 质检 A4：普通 JSON 接口 1MB；chat 保持 readBody 默认 40MB
   const dispatch = async (req, res) => {
     const url = new URL(req.url, 'http://localhost');
     const p = url.pathname;
@@ -151,7 +153,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/config') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       // 内存 cfg 可能比磁盘旧（如 CLI 改过同步地址）：先从磁盘刷新 sync，避免保存时回滚
       cfg.sync = loadConfig()?.sync || cfg.sync;
       const next = { model: state.modelName, permission: cfg.permission ?? 'ask' };
@@ -258,7 +260,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/models-config') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const action = body.action;
       // —— 服务商 Key 管理 ——
       if (action === 'setProviderKey') {
@@ -401,7 +403,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/session') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const file = path.basename(String(body.file || ''));
       const full = path.join(home, 'sessions', file);
       if (!file || !fs.existsSync(full)) return json(res, 404, { error: '会话不存在' });
@@ -485,7 +487,7 @@ export function createApiDispatch(deps) {
       });
       let body;
       try {
-        body = await readBody(req);
+        body = await readBody(req, MAX_API_BODY);
       } catch (e) {
         refs.inflight -= 1;
         res.write(`data: ${JSON.stringify({ type: 'error', message: e.message })}\n\n`);
@@ -509,7 +511,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/permission') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const entry = tasks.get(body.taskId);
       if (!entry || !entry.pendingAsk) return json(res, 409, { error: '没有挂起的权限确认' });
       const pa = entry.pendingAsk;
@@ -525,7 +527,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/abort') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       if (body.taskId) {
         const entry = tasks.get(body.taskId);
         if (entry?.abortHandler) {
@@ -547,14 +549,17 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'GET' && p === '/api/draft') {
-      const text = state.draftText;
-      state.draftText = ''; // 读取即清除
+      // 质检 A5：按会话维度读取（无 file 参数用全局槽，兼容旧客户端）
+      const key = String(url.searchParams.get('file') || '');
+      const text = draftTexts.get(key) || '';
+      draftTexts.delete(key); // 读取即清除
       json(res, 200, { ok: true, text });
       return;
     }
     if (req.method === 'POST' && p === '/api/draft') {
-      const body = await readBody(req);
-      state.draftText = String(body.text ?? '').slice(0, 200000);
+      const body = await readBody(req, MAX_API_BODY);
+      const key = String(body.file || '');
+      draftTexts.set(key, String(body.text ?? '').slice(0, 200000));
       json(res, 200, { ok: true });
       return;
     }
@@ -579,7 +584,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/schedule') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const action = String(body.action || '');
       try {
         if (action === 'add') {
@@ -619,7 +624,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/workspaces') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const name = String(body.name || '').trim();
       if (body.action === 'add') {
         if (!name) return json(res, 400, { error: '名称不能为空' });
@@ -672,6 +677,11 @@ export function createApiDispatch(deps) {
     if (req.method === 'GET' && p === '/api/fs-browse') {
       let dir = String(url.searchParams.get('dir') || '').trim();
       if (!path.isAbsolute(dir)) return json(res, 400, { error: '需要绝对路径' });
+      // 质检 A3：目录浏览限定基目录（默认家目录 + config.web.browseRoots 显式授权），
+      // 拒绝越界——此前可枚举服务器任意绝对路径（整机目录结构探测面）
+      const browseRoots = [os.homedir(), startupCwd, state.workingDir, ...(Array.isArray(cfg.web?.browseRoots) ? cfg.web.browseRoots : [])].map((r) => path.resolve(String(r)));
+      const inRoot = browseRoots.some((r) => dir === r || dir.startsWith(r + path.sep));
+      if (!inRoot) return json(res, 403, { error: '目录不在可浏览范围内（家目录或 web.browseRoots 授权目录）' });
       try {
         const st = fs.statSync(dir);
         if (!st.isDirectory()) return json(res, 400, { error: '不是目录' });
@@ -681,7 +691,9 @@ export function createApiDispatch(deps) {
           .map((e) => ({ name: e.name, path: path.join(dir, e.name) }))
           .sort((a, b) => a.name.localeCompare(b.name, 'zh-CN'))
           .slice(0, 300);
-        const parent = path.dirname(dir);
+        let parent = path.dirname(dir);
+        // 父目录同样不得越出基目录
+        if (!browseRoots.some((r) => parent === r || parent.startsWith(r + path.sep))) parent = null;
         json(res, 200, { ok: true, path: dir, parent: parent === dir ? null : parent, entries });
       } catch (err) {
         json(res, 400, { error: String(err?.message || err) });
@@ -693,7 +705,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/memory') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       if (body.action === 'dedupe') {
         const removed = dedupeMemory();
         return json(res, 200, { ok: true, removed });
@@ -720,7 +732,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/mcp-presets') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       const name = String(body.name || '').trim();
       const r = buildPreset(name, body.arg, state.workingDir);
       if (r.error) return json(res, 400, { error: r.error });
@@ -754,7 +766,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/skills') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       if (body.action === 'install') {
         const r = await installSkill(body.arg || body.name || '');
         if (r.error) return json(res, 400, { error: r.error });
@@ -778,7 +790,7 @@ export function createApiDispatch(deps) {
       return;
     }
     if (req.method === 'POST' && p === '/api/sync') {
-      const body = await readBody(req);
+      const body = await readBody(req, MAX_API_BODY);
       if (body.action === 'login') {
         const vurl = validateRemoteUrl(body.url); // 质检 S1：SSRF 防护（同步端点同样只允许公网）
         if (vurl.error) return json(res, 400, { error: vurl.error });

package/src/web/server.js

@@ -16,6 +16,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import crypto from 'node:crypto';
 import { fileURLToPath } from 'node:url';
+import { createLogWriter } from '../log-writer.js';
 import { createApiDispatch } from './routes/api.js';
 import { ensureHome, loadConfig, saveConfig, mingdaoHome } from '../config.js';
 import { setStoredKey, removeStoredKey, getStoredKey, maskKey } from '../credentials.js';
@@ -163,6 +164,7 @@ export async function runWebServer({ host = '127.0.0.1', port = 3820, authToken
   }
 
   let workingDir = process.cwd(); // 工作空间切换时随之更新（后续会话/工具都跟随新目录）
+  const startupCwd = workingDir; // 质检 A3：启动工作目录恒为合法浏览根（工作空间切换后仍可浏览原位）
   // Provider 按模型懒加载缓存：界面切换模型后即时生效
   const providerCache = new Map();
   async function getProviderFor(m) {
@@ -206,23 +208,12 @@ export async function runWebServer({ host = '127.0.0.1', port = 3820, authToken
     sessionLocks.set(file, next.then(() => sessionLocks.delete(file), () => sessionLocks.delete(file)));
     return next;
   }
-  let draftText = ''; // 外部注入的草稿（VS Code 插件选中代码发送）
+  const draftTexts = new Map(); // 质检 A5：草稿按会话维度存储（此前单槽多客户端互相覆盖）
 
   // —— 服务端诊断日志（第二问无反应排查 + 长期运维）：<mingdao-home>/logs/web-server.log ——
   // 记录每次对话的关键阶段与耗时；2MB 滚动。桌面版与 WebUI 共用同一日志。
-  function srvlog(msg) {
-    try {
-      const dir = path.join(mingdaoHome(), 'logs');
-      fs.mkdirSync(dir, { recursive: true });
-      const f = path.join(dir, 'web-server.log');
-      let prev = '';
-      try {
-        prev = fs.readFileSync(f, 'utf8');
-      } catch {}
-      if (prev.length > 2 * 1024 * 1024) prev = prev.slice(-1024 * 1024);
-      fs.writeFileSync(f, prev + new Date().toISOString() + ' ' + msg + '\n');
-    } catch {}
-  }
+  // 质检 A6：统一日志写入器（append + 按行截断 + 原子替换），与桌面 appLog 同款实现
+  const srvlog = createLogWriter(path.join(mingdaoHome(), 'logs', 'web-server.log'));
 
   // —— SSRF 防护（质检 S1）：远端地址校验 ——
   function isPrivateHost(hostname) {
@@ -506,10 +497,9 @@ export async function runWebServer({ host = '127.0.0.1', port = 3820, authToken
     providerCache, getProviderFor, tasks,
     MAX_CONCURRENT, pruneTasks, handleChat,
     mcpFacade, provider, validateRemoteUrl, isPrivateHost,
-    authEnabled, tokenMatches, requestToken, trustedHost, INDEX_HTML,
+    authEnabled, tokenMatches, requestToken, trustedHost, INDEX_HTML, draftTexts, startupCwd,
     state: { get modelName() { return modelName; }, set modelName(v) { modelName = v; },
-             get workingDir() { return workingDir; }, set workingDir(v) { workingDir = v; },
-             get draftText() { return draftText; }, set draftText(v) { draftText = v; } },
+             get workingDir() { return workingDir; }, set workingDir(v) { workingDir = v; } },
     refs: { get inflight() { return inflight; }, set inflight(v) { inflight = v; } },
   });
   const server = http.createServer((req, res) => {