minerender 2.1.0-alpha.55 → 2.1.0-alpha.59

package/dist/browser/index.d.mts

@@ -690,7 +690,7 @@ declare function applyElementRotation(rotation: ElementRotation, geometry: Buffe
 declare function applyGenericRotation(axis: Axis, rotation: number, obj: Object3D): void;
 declare function addBox3WireframeToObject(box: Box3, obj: Object3D, color?: number, w?: number): void;
 declare function addWireframeToObject(obj: Object3D, color?: number, w?: number): void;
-declare function addWireframeToMesh(geo: BufferGeometry, mesh: Mesh, color?: number, w?: number): void;
+declare function addWireframeToMesh(geo: BufferGeometry, mesh: Mesh, color?: number, w?: number): () => void;
 
 declare function captureException(e: any, ...extra: any[]): void;
 declare function timingStart(marker: string): void;
@@ -1179,6 +1179,8 @@ declare class EntityObject extends SceneObject {
     static readonly DEFAULT_OPTIONS: EntityObjectOptions;
     readonly options: EntityObjectOptions;
     private meshesCreated;
+    private readonly geometries;
+    private readonly disposeWireframes;
     /** Scrolling materials are owned: their texture offset follows this entity's age. */
     private readonly scrollMaterials;
     private scrollTicker;
@@ -1190,6 +1192,7 @@ declare class EntityObject extends SceneObject {
     dispose(): void;
     disposeAndRemoveAllChildren(): void;
     private clearScrollMaterials;
+    private updateScrollSubscription;
     /** Applies the entity age to the scrolling materials; the ticker calls this 20 times per second. */
     private updateScroll;
     /** The animation started by {@link playAnimation}, until {@link stopAnimation} or disposal. */

package/dist/browser/index.d.ts

@@ -690,7 +690,7 @@ declare function applyElementRotation(rotation: ElementRotation, geometry: Buffe
 declare function applyGenericRotation(axis: Axis, rotation: number, obj: Object3D): void;
 declare function addBox3WireframeToObject(box: Box3, obj: Object3D, color?: number, w?: number): void;
 declare function addWireframeToObject(obj: Object3D, color?: number, w?: number): void;
-declare function addWireframeToMesh(geo: BufferGeometry, mesh: Mesh, color?: number, w?: number): void;
+declare function addWireframeToMesh(geo: BufferGeometry, mesh: Mesh, color?: number, w?: number): () => void;
 
 declare function captureException(e: any, ...extra: any[]): void;
 declare function timingStart(marker: string): void;
@@ -1179,6 +1179,8 @@ declare class EntityObject extends SceneObject {
     static readonly DEFAULT_OPTIONS: EntityObjectOptions;
     readonly options: EntityObjectOptions;
     private meshesCreated;
+    private readonly geometries;
+    private readonly disposeWireframes;
     /** Scrolling materials are owned: their texture offset follows this entity's age. */
     private readonly scrollMaterials;
     private scrollTicker;
@@ -1190,6 +1192,7 @@ declare class EntityObject extends SceneObject {
     dispose(): void;
     disposeAndRemoveAllChildren(): void;
     private clearScrollMaterials;
+    private updateScrollSubscription;
     /** Applies the entity age to the scrolling materials; the ticker calls this 20 times per second. */
     private updateScroll;
     /** The animation started by {@link playAnimation}, until {@link stopAnimation} or disposal. */

package/dist/browser/index.js

@@ -1729,6 +1729,11 @@ function addWireframeToMesh(geo, mesh, color = 16777215, w = 2) {
   mesh.add(wireframe);
   let axes = new import_three8.AxesHelper(1);
   mesh.add(axes);
+  return () => {
+    wireGeo.dispose();
+    wireMat.dispose();
+    axes.dispose();
+  };
 }
 var import_three8;
 var init_model = __esm({
@@ -5307,12 +5312,16 @@ var _EntityObject = class _EntityObject extends SceneObject {
     this.entity = entity;
     this.isEntityObject = true;
     this.meshesCreated = false;
+    this.geometries = /* @__PURE__ */ new Set();
+    this.disposeWireframes = [];
     /** Scrolling materials are owned: their texture offset follows this entity's age. */
     this.scrollMaterials = [];
     /** Entity age in ticks, as vanilla's `ageInTicks`; drives the scrolling render modes. */
     this.age = 0;
     this.animationPlayer = new EntityAnimationPlayer();
     this.options = (0, import_ts_deepmerge4.default)({}, _EntityObject.DEFAULT_OPTIONS, options ?? {});
+    this.addEventListener("added", () => this.updateScrollSubscription());
+    this.addEventListener("removed", () => this.updateScrollSubscription());
   }
   async init() {
     this.createMeshes();
@@ -5323,6 +5332,9 @@ var _EntityObject = class _EntityObject extends SceneObject {
   }
   disposeAndRemoveAllChildren() {
     this.clearScrollMaterials();
+    for (const geometry of this.geometries) geometry.dispose();
+    this.geometries.clear();
+    for (const dispose of this.disposeWireframes.splice(0)) dispose();
     this.animationPlayer.clear();
     super.disposeAndRemoveAllChildren();
   }
@@ -5334,6 +5346,19 @@ var _EntityObject = class _EntityObject extends SceneObject {
       material.dispose();
     }
   }
+  updateScrollSubscription() {
+    if (this.parent && this.scrollMaterials.length) {
+      if (this.scrollTicker === void 0) {
+        this.scrollTicker = Ticker.add(() => {
+          this.age++;
+          this.updateScroll();
+        });
+      }
+    } else {
+      Ticker.remove(this.scrollTicker);
+      this.scrollTicker = void 0;
+    }
+  }
   /** Applies the entity age to the scrolling materials; the ticker calls this 20 times per second. */
   updateScroll() {
     for (const { offset, speed } of this.scrollMaterials) {
@@ -5444,6 +5469,7 @@ var _EntityObject = class _EntityObject extends SceneObject {
         depth + growZ * 2,
         uv
       ).clone();
+      this.geometries.add(geometry);
       geometry.translate(cube.origin[0] + width / 2, cube.origin[1] + height / 2, cube.origin[2] + depth / 2);
       if (inward && Math.min(width + growX * 2, height + growY * 2, depth + growZ * 2) > 0) {
         const index = Array.from(geometry.getIndex().array);
@@ -5452,7 +5478,7 @@ var _EntityObject = class _EntityObject extends SceneObject {
       const mesh = this.createMesh(name, geometry, material);
       mesh.renderOrder = renderOrder;
       anchor.add(mesh);
-      if (this.options.wireframe) addWireframeToMesh(geometry, mesh);
+      if (this.options.wireframe) this.disposeWireframes.push(addWireframeToMesh(geometry, mesh));
     }
     for (const [childName, child] of Object.entries(part.children)) {
       this.createPart(childName, child, anchor, size, material, renderOrder, inward);
@@ -5486,11 +5512,8 @@ var _EntityObject = class _EntityObject extends SceneObject {
       this.clearScrollMaterials();
     } else if (this.scrollMaterials.length) {
       this.updateScroll();
-      this.scrollTicker = Ticker.add(() => {
-        this.age++;
-        this.updateScroll();
-      });
     }
+    this.updateScrollSubscription();
     this.notifyDirty();
   }
 };