minecraft-renderer 0.1.92 → 0.1.93

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "minecraft-renderer",
-  "version": "0.1.92",
+  "version": "0.1.93",
   "description": "The most Modular Minecraft world renderer with Three.js WebGL backend",
   "type": "module",
   "main": "./dist/index.js",

package/src/graphicsBackend/config.ts

@@ -22,7 +22,7 @@ export const defaultWorldRendererConfig = {
   futuristicReveal: false,
 
   /** Master toggle for section occlusion graph (smart / cave cull). Disabled in spectator. */
-  smartCull: true,
+  smartCull: false,
 
   // Performance settings
   wasmMesher: true,

package/src/lib/worldrendererCommon.ts

@@ -57,7 +57,7 @@ export abstract class WorldRendererCommon<WorkerSend = any, WorkerReceive = any>
     disableEntities: false,
     /** Tint section borders by occlusion BFS step (perf debug overlay). */
     caveCullingDebug: false,
-    smartCull: true
+    smartCull: false
     // disableParticles: false
   })
 

package/src/three/entities.ts

@@ -316,6 +316,7 @@ export class Entities {
   }
 
   handlePlayerEntity(playerData: SceneEntity['originalEntity']) {
+    if (!this.isRenderingAllowed()) return
     // Create player entity if it doesn't exist
     if (!this.playerEntity) {
       // Create the player entity similar to how normal entities are created
@@ -329,7 +330,7 @@ export class Entities {
 
       group.name = 'player_entity'
       this.playerEntity = group
-      this.worldRenderer.scene.add(group)
+      this.syncSceneAttachment(group)
 
       void this.updatePlayerSkin(playerData.id, playerData.username, playerData.uuid ?? undefined, stevePngUrl)
     }
@@ -392,9 +393,27 @@ export class Entities {
   }
 
   setRendering(rendering: boolean, entity: THREE.Object3D | null = null) {
-    this.currentlyRendering = rendering
-    for (const ent of entity ? [entity] : Object.values(this.entities)) {
-      if (rendering) {
+    this.currentlyRendering = rendering && this.isRenderingAllowed()
+    this.setSceneAttached(this.currentlyRendering, entity)
+  }
+
+  isRenderingAllowed(): boolean {
+    return this.worldRenderer.worldRendererConfig.renderEntities !== false && !this.worldRenderer.reactiveDebugParams.disableEntities
+  }
+
+  /** Add or remove entity meshes from the scene (including third-person player). */
+  syncSceneAttachment(entity: THREE.Object3D | null = null): void {
+    const attached = this.isRenderingAllowed()
+    this.currentlyRendering = attached
+    this.setSceneAttached(attached, entity)
+  }
+
+  private setSceneAttached(attached: boolean, entity: THREE.Object3D | null = null): void {
+    const targets = entity
+      ? [entity]
+      : [...Object.values(this.entities), ...(this.playerEntity ? [this.playerEntity] : [])]
+    for (const ent of targets) {
+      if (attached) {
         if (!this.worldRenderer.scene.children.includes(ent)) this.worldRenderer.scene.add(ent)
       } else {
         this.worldRenderer.scene.remove(ent)
@@ -414,10 +433,8 @@ export class Entities {
   }
 
   render() {
-    const renderEntitiesConfig = this.worldRenderer.worldRendererConfig.renderEntities
-    if (renderEntitiesConfig !== this.currentlyRendering) {
-      this.setRendering(renderEntitiesConfig)
-    }
+    this.syncSceneAttachment()
+    if (!this.isRenderingAllowed()) return
 
     this.clock.update(performance.now())
     const dt = Math.min(this.clock.getDelta(), 1 / 30)
@@ -892,6 +909,7 @@ export class Entities {
       delete this.entities[entity.id]
       return
     }
+    if (!this.isRenderingAllowed()) return
 
     let mesh: THREE.Object3D | undefined
     if (e === undefined) {
@@ -985,7 +1003,6 @@ export class Entities {
       group.add(mesh)
       group.add(boxHelper)
       boxHelper.visible = false
-      this.worldRenderer.scene.add(group)
 
       e = group
       e.name = 'entity'
@@ -996,7 +1013,7 @@ export class Entities {
         void this.updatePlayerSkin(entity.id, entity.username, overrides?.texture ? entity.uuid : undefined, overrides?.texture || stevePngUrl)
       }
       this.setDebugMode(this.debugMode, group)
-      this.setRendering(this.currentlyRendering, group)
+      this.syncSceneAttachment(group)
 
       this.afterAddEntity(entity)
     } else {

package/src/three/worldRendererThree.ts

@@ -584,6 +584,9 @@ export class WorldRendererThree extends WorldRendererCommon {
     this.onReactiveConfigUpdated('futuristicReveal', () => {
       this.updateModulesFromConfig()
     })
+    this.onReactiveDebugUpdated('disableEntities', () => {
+      this.entities.syncSceneAttachment()
+    })
 
     let currentHandRenderer = this.displayOptions.inWorldRenderingConfig.handRenderer
     this.onReactiveConfigUpdated('handRenderer', value => {
@@ -1363,11 +1366,9 @@ export class WorldRendererThree extends WorldRendererCommon {
       this.chunkMeshManager.clearCullDirty()
     }
     this.chunkMeshManager.updateCaveCullingDebug(this.reactiveDebugParams.caveCullingDebug, smartCull)
-    if (!this.reactiveDebugParams.disableEntities) {
-      const entitiesStart = performance.now()
-      this.entities.render()
-      entitiesRenderMs = performance.now() - entitiesStart
-    }
+    const entitiesStart = performance.now()
+    this.entities.render()
+    entitiesRenderMs = performance.now() - entitiesStart
     this.chunkMeshManager.sortVisibleBlendSections(camX, camY, camZ)
     if (!didBlendAllAttrUpload && globalLegacyBlendBuffer?.hasPendingIndexUploads()) {
       globalLegacyBlendBuffer.uploadDirtyIndexRange()