minecraft-renderer 0.1.76 → 0.1.77

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "minecraft-renderer",
-  "version": "0.1.76",
+  "version": "0.1.77",
   "description": "The most Modular Minecraft world renderer with Three.js WebGL backend",
   "type": "module",
   "main": "./dist/index.js",

package/src/lib/createPlayerObject.test.ts

@@ -0,0 +1,46 @@
+//@ts-nocheck
+import { describe, expect, it, vi } from 'vitest'
+
+vi.mock('./utils/skins', () => ({
+  stevePngUrl: '',
+  loadSkinImage: vi.fn(),
+}))
+
+import { PlayerObject } from 'skinview3d'
+import { configurePlayerSkinMaterials } from './createPlayerObject'
+
+describe('configurePlayerSkinMaterials', () => {
+  it('configures cutout materials and log-depth bias on arm/leg mats only', () => {
+    const playerObject = new PlayerObject()
+    const skin = playerObject.skin as any
+
+    configurePlayerSkinMaterials(playerObject)
+
+    const allMaterials = [
+      skin.layer1Material,
+      skin.layer1MaterialBiased,
+      skin.layer2Material,
+      skin.layer2MaterialBiased,
+    ]
+    for (const mat of allMaterials) {
+      expect(mat.transparent).toBe(false)
+      expect(mat.alphaTest).toBe(0.1)
+      expect(mat.depthWrite).toBe(true)
+    }
+
+    expect(skin.layer1MaterialBiased.userData.logDepthBiasApplied).toBe(true)
+    expect(skin.layer2MaterialBiased.userData.logDepthBiasApplied).toBe(true)
+    expect(typeof skin.layer1MaterialBiased.onBeforeCompile).toBe('function')
+    expect(typeof skin.layer2MaterialBiased.onBeforeCompile).toBe('function')
+    expect(skin.layer1MaterialBiased.onBeforeCompile).toBe(skin.layer2MaterialBiased.onBeforeCompile)
+
+    expect(skin.layer1Material.userData.logDepthBiasApplied).toBeUndefined()
+    expect(skin.layer2Material.userData.logDepthBiasApplied).toBeUndefined()
+    expect(skin.layer1Material.onBeforeCompile).not.toBe(skin.layer1MaterialBiased.onBeforeCompile)
+    expect(skin.layer2Material.onBeforeCompile).not.toBe(skin.layer2MaterialBiased.onBeforeCompile)
+
+    const firstCompile = skin.layer1MaterialBiased.onBeforeCompile
+    configurePlayerSkinMaterials(playerObject)
+    expect(skin.layer1MaterialBiased.onBeforeCompile).toBe(firstCompile)
+  })
+})

package/src/lib/createPlayerObject.ts

@@ -10,7 +10,30 @@ export type PlayerObjectType = PlayerObject & {
   realUsername: string
 }
 
-/** Starfield + log-depth world: cutout skin mats need alphaTest and depthWrite (not mesh traverse). */
+const LOG_DEPTH_BIAS = -2e-4 // tune visually; negative ≈ polygonOffset “closer”
+
+function patchLogDepthBiasShader (shader: THREE.WebGLProgramParametersWithUniforms): void {
+  shader.uniforms.uLogDepthBias = { value: LOG_DEPTH_BIAS }
+  shader.fragmentShader = shader.fragmentShader.replace(
+    '#include <logdepthbuf_pars_fragment>',
+    `#include <logdepthbuf_pars_fragment>\nuniform float uLogDepthBias;`
+  )
+  shader.fragmentShader = shader.fragmentShader.replace(
+    '#include <logdepthbuf_fragment>',
+    `#if defined( USE_LOGARITHMIC_DEPTH_BUFFER )
+      gl_FragDepth = log2( vFragDepth ) * logDepthBufFC * 0.5 + uLogDepthBias;
+    #endif`
+  )
+}
+
+function applyLogDepthBias (material: THREE.Material): void {
+  if (material.userData.logDepthBiasApplied) return
+  material.userData.logDepthBiasApplied = true
+  material.onBeforeCompile = patchLogDepthBiasShader
+  material.needsUpdate = true
+}
+
+/** Log-depth world: opaque cutout mats (alphaTest + depthWrite, not transparent sort). */
 export function configurePlayerSkinMaterials (playerObject: PlayerObject): void {
   const skin = playerObject.skin as any
   const materials = [
@@ -20,10 +43,12 @@ export function configurePlayerSkinMaterials (playerObject: PlayerObject): void
     skin.layer2MaterialBiased,
   ]
   for (const mat of materials) {
-    mat.transparent = true
+    mat.transparent = false
     mat.alphaTest = 0.1
     mat.depthWrite = true
   }
+  applyLogDepthBias(skin.layer1MaterialBiased)
+  applyLogDepthBias(skin.layer2MaterialBiased)
 }
 
 export function createPlayerObject (options: {