minecraft-packets 1.8.0 → 1.9.0

package/.github/workflows/ci.yml

@@ -18,6 +18,6 @@ jobs:
     - name: Use Node.js 18.x
       uses: actions/setup-node@v1
       with:
-        node-version: 18.x
+        node-version: 24.x
     - run: npm install
     - run: npm test

package/.github/workflows/commands.yml

@@ -0,0 +1,22 @@
+name: Repo Commands
+
+on:
+  issue_comment:        # Handle comment commands
+    types: [created]
+  pull_request:         # Handle renamed PRs
+    types: [edited]
+permissions:
+  contents: write
+
+jobs:
+  comment-trigger:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Check out repository
+      uses: actions/checkout@v3
+    - name: Run command handlers
+      uses: PrismarineJS/prismarine-repo-actions@master
+      with:
+        token: ${{ secrets.PAT_PASSWORD }}
+        install-command: npm install
+        /fixlint.fix-command: npm run fix

package/.github/workflows/publish.yml

@@ -3,6 +3,9 @@ on:
   push:
     branches:
       - master # Change this to your default branch
+permissions:
+  id-token: write
+  contents: write
 jobs:
   npm-publish:
     name: npm-publish
@@ -15,13 +18,12 @@ jobs:
     - name: Set up Node.js
       uses: actions/setup-node@master
       with:
-        node-version: 14.0.0
+        node-version: 24
+        registry-url: 'https://registry.npmjs.org'
     - id: publish
-      uses: JS-DevTools/npm-publish@v1
-      with:
-        token: ${{ secrets.NPM_AUTH_TOKEN }}
+      uses: JS-DevTools/npm-publish@v4
     - name: Create Release
-      if: steps.publish.outputs.type != 'none'
+      if: ${{ steps.publish.outputs.type }}
       id: create_release
       uses: actions/create-release@v1
       env:

package/history.md

@@ -1,4 +1,12 @@
 ## 1.8.0
+
+### 1.9.0
+* [Add repo commands workflow (#30)](https://github.com/PrismarineJS/node-minecraft-packets/commit/6e4f15a892e2af6699759e67be3b1b9c1c3eef84) (thanks @rom1504)
+* [Update CI to Node 24 (#29)](https://github.com/PrismarineJS/node-minecraft-packets/commit/cd70884808961fd8450784b7a66225f7a6eb194c) (thanks @rom1504)
+* [Fix publish workflow for trusted publishing (#28)](https://github.com/PrismarineJS/node-minecraft-packets/commit/f089668ae6d93923bb840658ea82fc8ecca3220c) (thanks @rom1504)
+* [Fix publish condition for npm-publish v4 (#27)](https://github.com/PrismarineJS/node-minecraft-packets/commit/9a63883fb90d962443f8b76b41e4509741fd323f) (thanks @rom1504)
+* [Switch to trusted publishing via OIDC (#26)](https://github.com/PrismarineJS/node-minecraft-packets/commit/4cf8bbeda4ec368fe5e247d6600a22a5b42d0c67) (thanks @rom1504)
+
 * update mcPackets
 
 ## 1.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "minecraft-packets",
-  "version": "1.8.0",
+  "version": "1.9.0",
   "description": "An easy way to query PrismarineJS/minecraft-packets",
   "main": "index.js",
   "scripts": {

package/test/cycle.test.js

@@ -1,4 +1,4 @@
-/* eslint-env mocha */
+/* eslint-env mocha, jest */
 // Tests packet serialization/deserialization from with raw binary in nodejs
 const { createSerializer, createDeserializer, states } = require('minecraft-protocol')
 const mcPackets = require('minecraft-packets')
@@ -7,6 +7,17 @@ const assert = require('assert')
 const makeClientSerializer = version => createSerializer({ state: states.PLAY, version, isServer: true })
 const makeClientDeserializer = version => createDeserializer({ state: states.PLAY, version })
 
+// Upstream bug in minecraft-protocol: the registryEntryHolder write handler
+// does `offset += 1` instead of writing a 0x00 varint byte for inline sound data,
+// leaving uninitialized buffer contents via Buffer.allocUnsafe in protodef.
+// This causes non-deterministic round-trip failures for sound_effect packets
+// that use inline sound names (versions 1.19.3+).
+// Workaround: zero the serialization buffer before writing to neutralize the bug.
+const origAllocUnsafe = Buffer.allocUnsafe
+Buffer.allocUnsafe = function (size) {
+  return Buffer.alloc(size)
+}
+
 Object.entries(mcPackets.pc).forEach(([ver, data]) => {
   let serializer, deserializer
 
@@ -41,3 +52,7 @@ Object.entries(mcPackets.pc).forEach(([ver, data]) => {
     })
   })
 })
+
+afterAll(() => {
+  Buffer.allocUnsafe = origAllocUnsafe
+})