minecraft-data 3.43.1 → 3.45.0

package/doc/history.md

@@ -1,5 +1,13 @@
 # History
 
+## 3.45.0
+
+* update `minecraft-data`
+
+## 3.44.0
+
+* update `minecraft-data`
+
 ## 3.43.1
 
 * update `minecraft-data`

package/minecraft-data/.github/helper-bot/index.js

@@ -1,28 +1,9 @@
 const fs = require('fs')
 const cp = require('child_process')
-const https = require('https')
 const helper = require('./github-helper')
 const pcManifestURL = 'https://launchermeta.mojang.com/mc/game/version_manifest.json'
 const changelogURL = 'https://feedback.minecraft.net/hc/en-us/sections/360001186971-Release-Changelogs'
 
-// this is a polyfill for node <18
-const fetch = globalThis.fetch || function (url) {
-  return new Promise((resolve, reject) => {
-    https.get(url, (res) => {
-      let data = ''
-      res.on('data', (chunk) => {
-        data += chunk
-      })
-      res.on('end', () => {
-        resolve({
-          ok: true,
-          text: () => Promise.resolve(data),
-          json: () => Promise.resolve(JSON.parse(data))
-        })
-      })
-    }).on('error', reject)
-  })
-}
 const download = (url, dest) => cp.execSync(`curl -L ${url} -o ${dest}`)
 
 function buildFirstIssue (title, result, jarData) {
@@ -65,43 +46,78 @@ async function updateManifestPC () {
   const manifest = await fetch(pcManifestURL).then(res => res.json())
   // fs.writeFileSync('./manifest.json', JSON.stringify(manifest, null, 2))
   const knownVersions = protocolVersions.pc.reduce((acc, cur) => (acc[cur.minecraftVersion] = cur, acc), {})
-  const latestRelease = manifest.latest.release
+  const latestVersion = manifest.latest.snapshot
+  const latestVersionData = manifest.versions.find(v => v.id === latestVersion)
+  const latestVersionIsSnapshot = latestVersionData.type !== 'release'
 
-  const title = `Support Minecraft PC ${latestRelease}`
+  const title = `Support Minecraft PC ${latestVersion}`
   const issueStatus = await helper.getIssueStatus(title)
 
-  if (supportedVersions.pc.includes(latestRelease)) {
-    if (issueStatus.open) {
-      helper.close(issueStatus.id, `Closing as PC ${latestRelease} is now supported`)
+  if (latestVersionIsSnapshot) {
+    // don't make issues for snapshots
+    if (supportedVersions.pc.includes(latestVersion) || knownVersions[latestVersion]) {
+      console.log('Latest version is a known snapshot, no work to do')
+      return
     }
-    console.log('Latest PC version is supported.')
-    return
-  } else if (knownVersions[latestRelease]) {
-    console.log(`Latest PC version ${latestRelease} is known in protocolVersions.json, but not in versions.json (protocol version ${knownVersions[latestRelease].version})`)
-    return
   } else {
-    console.log(`Latest PC version ${latestRelease} is not known in protocolVersions.json, adding and making issue`)
+    if (supportedVersions.pc.includes(latestVersion)) {
+      if (issueStatus.open) {
+        helper.close(issueStatus.id, `Closing as PC ${latestVersion} is now supported`)
+      }
+      console.log('Latest PC version is supported.')
+      return
+    } else if (knownVersions[latestVersion]) {
+      console.log(`Latest PC version ${latestVersion} is known in protocolVersions.json, but not in versions.json (protocol version ${knownVersions[latestVersion].version})`)
+      return
+    } else {
+      console.log(`Latest PC version ${latestVersion} is not known in protocolVersions.json, adding and making issue`)
+    }
   }
-  const latestReleaseData = manifest.versions.find(v => v.id === latestRelease)
 
-  // Note: We don't use the below check to track if the version is supported properly or not
-  // (data like protocol/blocks/items/etc is present), just to make sure the known protocol version is correct.
+  let versionJson
   try {
-    const latestReleaseManifest = await fetch(latestReleaseData.url).then(res => res.json())
+    versionJson = await addEntryFor(latestVersion, latestVersionData)
+  } catch (e) {
+    console.error(e)
+
+    if (latestVersionIsSnapshot) {
+      console.warn('Failed to update protocolVersions.json for the snapshot', latestVersion)
+    } else {
+      console.log('Latest PC version is not supported and we failed to load data. Opening issue...')
+      const issuePayload = buildFirstIssue(title, latestVersionData)
+      helper.createIssue(issuePayload)
+
+      fs.writeFileSync('./issue.md', issuePayload.body)
+      console.log('OK, wrote to ./issue.md', issuePayload)
+    }
+  }
+
+  if (!latestVersionIsSnapshot && !issueStatus.open && !issueStatus.closed) {
+    console.log('Opening issue', versionJson)
+    const issuePayload = buildFirstIssue(title, latestVersionData, versionJson)
+
+    helper.createIssue(issuePayload)
+
+    fs.writeFileSync('./issue.md', issuePayload.body)
+    console.log('OK, wrote to ./issue.md', issuePayload)
+  }
+
+  async function addEntryFor (releaseVersion, releaseData) {
+    const latestReleaseManifest = await fetch(releaseData.url).then(res => res.json())
     // Download client jar
-    if (!fs.existsSync(`./${latestRelease}.jar`)) {
+    if (!fs.existsSync(`./${releaseVersion}.jar`)) {
       const clientJarUrl = latestReleaseManifest.downloads.client.url
       console.log('Downloading client jar', clientJarUrl)
-      download(clientJarUrl, `./${latestRelease}.jar`)
+      download(clientJarUrl, `./${releaseVersion}.jar`)
     }
 
     // Log the byte size of the client jar
-    const clientJarSize = fs.statSync(`./${latestRelease}.jar`).size
-    console.log(`Downloaded client jar ${latestRelease}.jar (${clientJarSize} bytes), extracting its version.json...`)
+    const clientJarSize = fs.statSync(`./${releaseVersion}.jar`).size
+    console.log(`Downloaded client jar ${releaseVersion}.jar (${clientJarSize} bytes), extracting its version.json...`)
 
     // unzip with tar / unzip, Actions image uses 7z
-    if (process.platform === 'win32') cp.execSync(`tar -xf ./${latestRelease}.jar version.json`)
-    else cp.execSync(`7z -y e ./${latestRelease}.jar version.json`, { stdio: 'inherit' })
+    if (process.platform === 'win32') cp.execSync(`tar -xf ./${releaseVersion}.jar version.json`)
+    else cp.execSync(`7z -y e ./${releaseVersion}.jar version.json`, { stdio: 'inherit' })
     const versionJson = require('./version.json')
 
     let majorVersion
@@ -118,7 +134,7 @@ async function updateManifestPC () {
       dataVersion: versionJson.world_version,
       usesNetty: true,
       majorVersion,
-      releaseType: latestReleaseData.type
+      releaseType: latestVersionData.type
     }
     console.log('Adding new entry to pc protocolVersions.json', newEntry)
     const updatedProtocolVersions = [newEntry, ...protocolVersions.pc]
@@ -134,24 +150,7 @@ async function updateManifestPC () {
       cp.execSync('git push')
     }
 
-    if (!issueStatus.open && !issueStatus.closed) {
-      console.log('Opening issue', versionJson)
-      const issuePayload = buildFirstIssue(title, latestReleaseData, versionJson)
-
-      helper.createIssue(issuePayload)
-
-      fs.writeFileSync('./issue.md', issuePayload.body)
-      console.log('OK, wrote to ./issue.md', issuePayload)
-    }
-  } catch (e) {
-    console.error(e)
-
-    console.log('Latest PC version is not supported and we failed to load data. Opening issue...')
-    const issuePayload = buildFirstIssue(title, latestReleaseData)
-    helper.createIssue(issuePayload)
-
-    fs.writeFileSync('./issue.md', issuePayload.body)
-    console.log('OK, wrote to ./issue.md', issuePayload)
+    return versionJson
   }
 }
 

package/minecraft-data/.github/workflows/update-helper.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Set up Node.js
       uses: actions/setup-node@master
       with:
-        node-version: 16.0.0
+        node-version: 18.0.0
     - name: Install Github Actions toolkit
       run: npm i @actions/github
       working-directory: .github/helper-bot

package/minecraft-data/data/bedrock/1.16.220/protocol.json

@@ -2064,7 +2064,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2342,7 +2342,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2390,7 +2390,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.16.220/types.yml

@@ -779,7 +779,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -915,7 +915,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -936,7 +936,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.17.0/protocol.json

@@ -2067,7 +2067,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2345,7 +2345,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2393,7 +2393,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.17.0/types.yml

@@ -782,7 +782,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -918,7 +918,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -939,7 +939,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.17.10/protocol.json

@@ -2067,7 +2067,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2345,7 +2345,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2393,7 +2393,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.17.10/types.yml

@@ -782,7 +782,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -918,7 +918,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -939,7 +939,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.17.30/protocol.json

@@ -2075,7 +2075,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2353,7 +2353,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2401,7 +2401,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.17.30/types.yml

@@ -787,7 +787,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -923,7 +923,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -944,7 +944,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.17.40/protocol.json

@@ -2075,7 +2075,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2377,7 +2377,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2425,7 +2425,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.17.40/types.yml

@@ -787,7 +787,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -938,7 +938,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -959,7 +959,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.18.0/protocol.json

@@ -2075,7 +2075,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2377,7 +2377,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2425,7 +2425,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.18.0/types.yml

@@ -787,7 +787,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -938,7 +938,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -959,7 +959,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.18.11/protocol.json

@@ -2075,7 +2075,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2379,7 +2379,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2427,7 +2427,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.18.11/types.yml

@@ -791,7 +791,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -946,7 +946,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -967,7 +967,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.18.30/protocol.json

@@ -2079,7 +2079,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2383,7 +2383,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2431,7 +2431,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",

package/minecraft-data/data/bedrock/1.18.30/types.yml

@@ -799,7 +799,7 @@ StackRequestSlotInfo:
 ItemStackRequest:
    # RequestID is a unique ID for the request. This ID is used by the server to send a response for this
    # specific request in the ItemStackResponse packet.
-   request_id: varint
+   request_id: zigzag32
    actions: []varint
       type_id: u8 =>
          # TakeStackRequestAction is sent by the client to the server to take x amount of items from one slot in a
@@ -954,7 +954,7 @@ ItemStackResponses: []varint
       1: error
    # RequestID is the unique ID of the request that this response is in reaction to. If rejected, the client
    # will undo the actions from the request with this ID.
-   request_id: varint
+   request_id: zigzag32
    _: status ?
       if ok:
          # ContainerInfo holds information on the containers that had their contents changed as a result of the
@@ -975,7 +975,7 @@ ItemStackResponses: []varint
                # sent to the client.
                count: u8
                # StackNetworkID is the network ID of the new stack at a specific slot.
-               item_stack_id: varint
+               item_stack_id: zigzag32
                # CustomName is the custom name of the item stack. It is used in relation to text filtering.
                custom_name: string
                # DurabilityCorrection is the current durability of the item stack. This durability will be shown

package/minecraft-data/data/bedrock/1.19.1/protocol.json

@@ -2081,7 +2081,7 @@
       [
         {
           "name": "request_id",
-          "type": "varint"
+          "type": "zigzag32"
         },
         {
           "name": "actions",
@@ -2385,7 +2385,7 @@
             },
             {
               "name": "request_id",
-              "type": "varint"
+              "type": "zigzag32"
             },
             {
               "anon": true,
@@ -2433,7 +2433,7 @@
                                             },
                                             {
                                               "name": "item_stack_id",
-                                              "type": "varint"
+                                              "type": "zigzag32"
                                             },
                                             {
                                               "name": "custom_name",