mindsystem-cc 3.3.2 → 3.5.0

package/commands/ms/audit-milestone.md

@@ -190,6 +190,211 @@ Plus full markdown report with tables for requirements, phases, integration, tec
 
 Route by status (see `<offer_next>`).
 
+## 8. Code Review (Milestone)
+
+Read code review agent from config:
+
+```bash
+CODE_REVIEW=$(cat .planning/config.json 2>/dev/null | jq -r '.code_review.milestone // empty')
+```
+
+**If CODE_REVIEW = "skip":**
+Report: "Milestone code review skipped (config: skip)"
+Proceed to next steps.
+
+**If CODE_REVIEW = empty/null:**
+Use default: `CODE_REVIEW="ms-flutter-reviewer"`
+
+### Step 8.1: Get Changed Files
+
+```bash
+# Find first commit in milestone (first phase commit)
+FIRST_PHASE=$(ls -d .planning/phases/*/ | sort -V | head -1 | xargs basename | cut -d- -f1)
+FIRST_COMMIT=$(git log --oneline --grep="(${FIRST_PHASE}-" --format="%H" | tail -1)
+
+# Get all implementation files changed since first commit
+CHANGED_FILES=$(git diff --name-only ${FIRST_COMMIT}^..HEAD | grep -E '\.(dart|ts|tsx|js|jsx|swift|kt|py|go|rs)$')
+```
+
+### Step 8.2: Determine Agent Mode
+
+```bash
+# Read agent mode from frontmatter
+AGENT_MODE=$(grep -A10 '^---' ~/.claude/agents/${CODE_REVIEW}.md | grep 'mode:' | awk '{print $2}')
+```
+
+---
+
+### Path A: Analysis-Only Reviewers (mode: analyze-only)
+
+For agents with `mode: analyze-only` (e.g., `ms-flutter-reviewer`):
+
+**A1. Spawn reviewer with read-only tools:**
+
+```
+Task(
+  prompt="
+  <objective>
+  Analyze code from milestone {version} for structural issues.
+  Report findings only — do NOT make changes.
+  </objective>
+
+  <scope>
+  Files to analyze:
+  {CHANGED_FILES}
+  </scope>
+
+  <output>
+  Provide findings report with YAML summary block for parsing.
+  </output>
+  ",
+  subagent_type="{CODE_REVIEW}"
+)
+```
+
+**A2. Parse YAML findings from output:**
+
+Extract the `code_review:` YAML block from the reviewer's response.
+
+**A3. Add findings to MILESTONE-AUDIT.md:**
+
+Append to the YAML frontmatter:
+
+```yaml
+code_review:
+  agent: {CODE_REVIEW}
+  files_analyzed: {N}
+  findings_by_impact:
+    high: {X}
+    medium: {Y}
+    low: {Z}
+  findings: [...]
+
+tech_debt:
+  - source: code_review
+    items:
+      - "{issue}: {description} ({file})"
+```
+
+Add markdown section to report body:
+
+```markdown
+## Code Review Findings
+
+**Agent:** {CODE_REVIEW}
+**Files analyzed:** {N}
+
+{Include full findings report from reviewer}
+```
+
+**A4. Present binary decision:**
+
+```markdown
+## Code Review Complete
+
+**Findings:** {total} ({high} high, {medium} medium, {low} low)
+
+### Options
+
+**A. Create quality phase** — Add phase to address findings before completing milestone
+
+**B. Accept as tech debt** — Document findings, proceed to complete milestone
+
+---
+
+Which would you like to do?
+```
+
+Use AskUserQuestion with options A and B.
+
+**A5. Handle decision:**
+
+**If user chooses "Create quality phase":**
+
+1. Determine next phase number (append at end of current phases)
+2. Create phase directory: `.planning/phases/{NN}-code-quality/`
+3. Create `PHASE-FINDINGS.md` with full review findings
+4. Update ROADMAP.md with new phase:
+
+```markdown
+### Phase {N}: Code Quality (Generated)
+**Goal:** Address structural improvements from milestone code review
+
+**Findings to address:**
+[High impact items from review]
+
+Plans:
+- [ ] {N}-01: High impact structural fixes
+```
+
+5. Report:
+```markdown
+## Quality Phase Created
+
+**Phase {N}:** `.planning/phases/{NN}-code-quality/`
+**Findings documented:** `PHASE-FINDINGS.md`
+
+---
+
+## ▶ Next Up
+
+**Plan the quality phase**
+
+`/ms:plan-phase {N}`
+
+<sub>`/clear` first → fresh context window</sub>
+```
+
+**If user chooses "Accept as tech debt":**
+
+Mark `tech_debt` entries as `status: deferred` in MILESTONE-AUDIT.md and continue to offer_next section.
+
+---
+
+### Path B: Simplifier Agents (default)
+
+For agents without `mode: analyze-only` (e.g., `ms-code-simplifier`, `ms-flutter-simplifier`):
+
+**B1. Spawn code review agent:**
+
+```
+Task(
+  prompt="
+  <objective>
+  Review code from milestone {version}.
+  Focus on architectural patterns, cross-phase consistency, and structural improvements.
+  Preserve all functionality. Make changes that improve clarity and maintainability.
+  </objective>
+
+  <scope>
+  Files to analyze:
+  {CHANGED_FILES}
+  </scope>
+
+  <output>
+  After review, run static analysis and tests.
+  Report what was improved and verification results.
+  </output>
+  ",
+  subagent_type="{CODE_REVIEW}"
+)
+```
+
+**B2. Commit if changes made:**
+
+```bash
+git add [modified files]
+git commit -m "$(cat <<'EOF'
+refactor(milestone): code review improvements
+
+Reviewer: {agent_type}
+Files reviewed: {count}
+EOF
+)"
+```
+
+Report: "Milestone code review complete."
+
 </process>
 
 <offer_next>
@@ -314,5 +519,9 @@ See full list in MILESTONE-AUDIT.md. Consider addressing in next milestone.
 - [ ] Assumptions aggregated by phase
 - [ ] Integration checker spawned for cross-phase wiring
 - [ ] v{version}-MILESTONE-AUDIT.md created with assumptions section
+- [ ] Code review completed (or skipped if config says "skip")
+- [ ] If analyze-only reviewer: YAML findings parsed and added to report
+- [ ] If analyze-only reviewer: Binary decision presented (quality phase vs tech debt)
+- [ ] If quality phase chosen: Phase directory created with PHASE-FINDINGS.md
 - [ ] Results presented with actionable next steps
 </success_criteria>

package/commands/ms/do-work.md

@@ -57,16 +57,16 @@ Run verify commands from tasks.
 Create .planning/adhoc/{timestamp}-{slug}-SUMMARY.md.
 </step>
 
-<step name="simplify_code">
-Read `simplifier` from config.json (default: `ms-code-simplifier`).
+<step name="code_review">
+Read `code_review.adhoc` from config.json (fallback: `code_review.phase`, default: `ms-code-simplifier`).
 If `"skip"`: proceed to update_state_and_commit.
-Spawn simplifier agent with modified files.
-Track if simplifications were applied for commit message.
+Spawn code review agent with modified files.
+Track if code review changes were applied for commit message.
 </step>
 
 <step name="update_state_and_commit">
 Add entry to STATE.md "Recent Adhoc Work" section.
-Single git commit with all changes (code + simplifications + PLAN.md + SUMMARY.md + STATE.md).
+Single git commit with all changes (code + code review changes + PLAN.md + SUMMARY.md + STATE.md).
 </step>
 
 <step name="generate_patch">
@@ -95,10 +95,10 @@ Adhoc work is complete when:
 - [ ] .planning/adhoc/ directory exists
 - [ ] PLAN.md created with tasks
 - [ ] All tasks executed and verified
-- [ ] Code simplified (or skipped if config says "skip")
+- [ ] Code review completed (or skipped if config says "skip")
 - [ ] SUMMARY.md created with outcomes
 - [ ] STATE.md updated with adhoc entry
-- [ ] Single git commit with all changes (including simplifications)
+- [ ] Single git commit with all changes (including code review changes)
 - [ ] Patch file generated OR explicitly skipped with message
 - [ ] User informed of completion and commit hash
 </success_criteria>

package/commands/ms/execute-phase.md

@@ -61,11 +61,11 @@ Phase: $ARGUMENTS
    - Collect summaries from all plans
    - Report phase completion status
 
-6. **Simplify code (optional)**
-   - Read `simplifier` from config.json (default: `ms-code-simplifier`)
+6. **Code review (optional)**
+   - Read `code_review.phase` from config.json (default: `ms-code-simplifier`)
    - If `"skip"`: proceed to step 7
-   - Spawn simplifier agent with phase file scope
-   - If changes made: commit as `refactor({phase}): simplify phase code`
+   - Spawn code review agent with phase file scope
+   - If changes made: commit as `refactor({phase}): code review improvements`
 
 7. **Verify phase goal**
    - Spawn `ms-verifier` subagent with phase directory and goal
@@ -293,7 +293,7 @@ After all plans in phase complete:
 <success_criteria>
 - [ ] All incomplete plans in phase executed
 - [ ] Each plan has SUMMARY.md
-- [ ] Code simplified (or skipped if config says "skip")
+- [ ] Code review completed (or skipped if config says "skip")
 - [ ] Phase goal verified (must_haves checked against codebase)
 - [ ] VERIFICATION.md created in phase directory
 - [ ] Patch file generated OR explicitly skipped with message

package/commands/ms/research-project.md

@@ -299,11 +299,17 @@ Create SUMMARY.md with:
 - Confidence assessment
 - Gaps to address
 
-After creating SUMMARY.md, update config.json simplifier with agent name:
+After creating SUMMARY.md, update config.json code_review fields with agent names:
 1. Read recommended stack from STACK.md
-2. Map to simplifier agent name:
-   - Flutter/Dart → \"ms-flutter-simplifier\"
-   - All others → \"ms-code-simplifier\"
+2. Map to code review agent names:
+   - Flutter/Dart:
+     - adhoc: \"ms-flutter-simplifier\"
+     - phase: \"ms-flutter-simplifier\"
+     - milestone: \"ms-flutter-reviewer\"
+   - All others:
+     - adhoc: \"ms-code-simplifier\"
+     - phase: \"ms-code-simplifier\"
+     - milestone: (leave as null)
 3. Update .planning/config.json (create from template if needed)
 
 Then commit ALL research files together:

package/mindsystem/templates/config.json

@@ -12,5 +12,9 @@
     "always_confirm_destructive": true,
     "always_confirm_external_services": true
   },
-  "simplifier": null
+  "code_review": {
+    "adhoc": null,
+    "phase": null,
+    "milestone": null
+  }
 }

package/mindsystem/workflows/do-work.md

@@ -217,33 +217,33 @@ Verify the work is complete:
 Keep verification focused on the specific changes made.
 </step>
 
-<step name="simplify_code">
-Read simplifier from config:
+<step name="code_review">
+Read code review agent from config:
 
 ```bash
-SIMPLIFIER=$(cat .planning/config.json 2>/dev/null | jq -r '.simplifier // empty')
+CODE_REVIEW=$(cat .planning/config.json 2>/dev/null | jq -r '.code_review.adhoc // .code_review.phase // empty')
 ```
 
-**If SIMPLIFIER = "skip":**
+**If CODE_REVIEW = "skip":**
 Skip to create_adhoc_summary.
 
-**If SIMPLIFIER = empty/null:**
-Use default: `SIMPLIFIER="ms-code-simplifier"`
+**If CODE_REVIEW = empty/null:**
+Use default: `CODE_REVIEW="ms-code-simplifier"`
 
 **Otherwise:**
-Use SIMPLIFIER value directly as agent name.
+Use CODE_REVIEW value directly as agent name.
 
 1. **Get modified files:**
    ```bash
    git diff --name-only HEAD | grep -E '\.(dart|ts|tsx|js|jsx|swift|kt|py|go|rs)$'
    ```
 
-2. **Spawn simplifier with adhoc scope:**
+2. **Spawn code review agent with adhoc scope:**
    ```
    Task(
      prompt="
      <objective>
-     Simplify code modified in adhoc work.
+     Review code modified in adhoc work.
      Preserve all functionality. Improve clarity and consistency.
      </objective>
 
@@ -253,18 +253,18 @@ Use SIMPLIFIER value directly as agent name.
      </scope>
 
      <output>
-     After simplifications, run static analysis and tests.
-     Report what was simplified and verification results.
+     After review and simplifications, run static analysis and tests.
+     Report what was improved and verification results.
      </output>
      ",
-     subagent_type="{SIMPLIFIER}"
+     subagent_type="{CODE_REVIEW}"
    )
    ```
 
-3. **Track simplification changes:**
-   - If changes made: Set `SIMPLIFICATION_APPLIED=true`
-   - Simplified files will be included in the adhoc commit
-   - Note in SUMMARY.md that simplification was applied
+3. **Track review changes:**
+   - If changes made: Set `CODE_REVIEW_APPLIED=true`
+   - Reviewed files will be included in the adhoc commit
+   - Note in SUMMARY.md that code review was applied
 </step>
 
 <step name="create_adhoc_summary">
@@ -339,9 +339,9 @@ If section doesn't exist, add after "### Pending Todos" section:
 Single commit for all changes (including simplifications if applied):
 
 ```bash
-# Add all modified files (code + simplified files)
+# Add all modified files (code + reviewed files)
 git add [code files modified]
-git add [simplified files if SIMPLIFICATION_APPLIED]
+git add [reviewed files if CODE_REVIEW_APPLIED]
 git add "$plan_file"
 git add "$summary_file"
 git add .planning/STATE.md
@@ -351,18 +351,18 @@ git add .planning/STATE.md
 # fix: bug fix, correction
 commit_type="fix"  # or "feat" based on nature of work
 
-# Include simplification note if applied
-if [ "$SIMPLIFICATION_APPLIED" = "true" ]; then
-  simplification_note="Includes code simplification pass."
+# Include code review note if applied
+if [ "$CODE_REVIEW_APPLIED" = "true" ]; then
+  review_note="Includes code review pass."
 else
-  simplification_note=""
+  review_note=""
 fi
 
 git commit -m "$(cat <<'EOF'
 ${commit_type}(adhoc): [description]
 
 Files: [count] modified
-${simplification_note}
+${review_note}
 EOF
 )"
 

package/mindsystem/workflows/execute-phase.md

@@ -341,22 +341,22 @@ After all waves complete, aggregate results:
 ```
 </step>
 
-<step name="simplify_code">
-Read simplifier agent name from config:
+<step name="code_review">
+Read code review agent name from config:
 
 ```bash
-SIMPLIFIER=$(cat .planning/config.json 2>/dev/null | jq -r '.simplifier // empty')
+CODE_REVIEW=$(cat .planning/config.json 2>/dev/null | jq -r '.code_review.phase // empty')
 ```
 
-**If SIMPLIFIER = "skip":**
-Report: "Code simplification skipped (config: skip)"
+**If CODE_REVIEW = "skip":**
+Report: "Code review skipped (config: skip)"
 Proceed to verify_phase_goal.
 
-**If SIMPLIFIER = empty/null:**
-Use default: `SIMPLIFIER="ms-code-simplifier"`
+**If CODE_REVIEW = empty/null:**
+Use default: `CODE_REVIEW="ms-code-simplifier"`
 
 **Otherwise:**
-Use SIMPLIFIER value directly as agent name.
+Use CODE_REVIEW value directly as agent name.
 
 1. **Gather changed files:**
    ```bash
@@ -365,12 +365,12 @@ Use SIMPLIFIER value directly as agent name.
    CHANGED_FILES=$(git diff --name-only $(echo "$PHASE_COMMITS" | tail -1)^..HEAD | grep -E '\.(dart|ts|tsx|js|jsx|swift|kt|py|go|rs)$')
    ```
 
-2. **Spawn simplifier (agent name from config):**
+2. **Spawn code review agent (from config):**
    ```
    Task(
      prompt="
      <objective>
-     Simplify code modified in phase {phase_number}.
+     Review code modified in phase {phase_number}.
      Preserve all functionality. Improve clarity and consistency.
      </objective>
 
@@ -380,31 +380,31 @@ Use SIMPLIFIER value directly as agent name.
      </scope>
 
      <output>
-     After simplifications, run static analysis and tests.
-     Report what was simplified and verification results.
+     After review and simplifications, run static analysis and tests.
+     Report what was improved and verification results.
      </output>
      ",
-     subagent_type="{SIMPLIFIER}"
+     subagent_type="{CODE_REVIEW}"
    )
    ```
 
 3. **Handle result:**
    - If changes made: Stage and commit
-   - If no changes: Report "No simplifications needed"
+   - If no changes: Report "No improvements needed"
 
-4. **Commit simplifications (if any):**
+4. **Commit review changes (if any):**
    ```bash
-   git add [simplified files]
+   git add [modified files]
    git commit -m "$(cat <<'EOF'
-   refactor({phase}): simplify phase code
+   refactor({phase}): code review improvements
 
-   Simplifier: {agent_type}
-   Files simplified: {count}
+   Reviewer: {agent_type}
+   Files reviewed: {count}
    EOF
    )"
    ```
 
-Report: "Code simplified. Proceeding to verification."
+Report: "Code review complete. Proceeding to verification."
 </step>
 
 <step name="verify_phase_goal">

package/mindsystem/workflows/map-codebase.md

@@ -96,13 +96,19 @@ Write these documents to .planning/codebase/:
 - STACK.md - Languages, runtime, frameworks, dependencies, configuration
 - INTEGRATIONS.md - External APIs, databases, auth providers, webhooks
 
-After writing STACK.md, update config.json simplifier field with the appropriate agent name:
+After writing STACK.md, update config.json code_review fields with the appropriate agent names:
 1. Read STACK.md to detect primary framework
-2. Map framework to simplifier agent name:
-   - Flutter/Dart → "ms-flutter-simplifier"
-   - All others (React, Next.js, Node, Swift, Kotlin, etc.) → "ms-code-simplifier"
-3. If .planning/config.json exists: update the simplifier field
-   If not: note the recommended simplifier for later config creation
+2. Map framework to code review agent names:
+   - Flutter/Dart:
+     - adhoc: "ms-flutter-simplifier"
+     - phase: "ms-flutter-simplifier"
+     - milestone: "ms-flutter-reviewer"
+   - All others (React, Next.js, Node, Swift, Kotlin, etc.):
+     - adhoc: "ms-code-simplifier"
+     - phase: "ms-code-simplifier"
+     - milestone: (leave as null — runtime defaults to ms-flutter-reviewer)
+3. If .planning/config.json exists: update all three code_review fields
+   If not: note the recommended code review agents for later config creation
 
 Explore thoroughly. Write documents directly using templates. Return confirmation only.
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mindsystem-cc",
-  "version": "3.3.2",
+  "version": "3.5.0",
   "description": "A meta-prompting, context engineering and spec-driven development system for Claude Code by TÂCHES.",
   "bin": {
     "mindsystem-cc": "bin/install.js"
@@ -10,7 +10,8 @@
     "commands",
     "mindsystem",
     "agents",
-    "scripts"
+    "scripts",
+    "skills"
   ],
   "keywords": [
     "claude",