mindsystem-cc 3.19.0 → 3.21.0

package/commands/ms/complete-milestone.md

@@ -1,8 +1,8 @@
 ---
 type: prompt
 name: ms:complete-milestone
-description: Archive completed milestone and prepare for next version
-argument-hint: <version>
+description: Archive completed milestone and prepare for next milestone
+argument-hint: "[name]"
 allowed-tools:
   - Read
   - Write
@@ -11,10 +11,10 @@ allowed-tools:
 ---
 
 <objective>
-Mark milestone {{version}} complete, archive to milestones/, and update ROADMAP.md and REQUIREMENTS.md.
+Mark milestone complete, archive to milestones/, and update ROADMAP.md and REQUIREMENTS.md.
 
-Purpose: Create historical record of shipped version, archive milestone artifacts (roadmap + requirements), and prepare for next milestone.
-Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tagged.
+Purpose: Create historical record of shipped milestone, archive milestone artifacts (roadmap + requirements), and prepare for next milestone.
+Output: Milestone archived (roadmap + requirements), PROJECT.md evolved.
 </objective>
 
 <execution_context>
@@ -33,16 +33,22 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
 
 **User input:**
 
-- Version: {{version}} (e.g., "1.0", "1.1", "2.0")
+- Milestone: $ARGUMENTS (optional — auto-detect from PROJECT.md `## Current Milestone:` header)
   </context>
 
 <process>
 
 **Follow complete-milestone.md workflow:**
 
-0. **Check for audit:**
+0. **Resolve milestone identity:**
 
-   - Look for `.planning/v{{version}}-MILESTONE-AUDIT.md`
+   - If argument provided: use as milestone name, generate slug
+   - If no argument: parse milestone name from PROJECT.md `## Current Milestone:` header, generate slug
+   - If neither found: error — ask user for milestone name
+
+0.5. **Check for audit:**
+
+   - Look for `.planning/MILESTONE-AUDIT.md`
    - If missing or stale: recommend `/ms:audit-milestone` first
    - If audit status is `gaps_found`: recommend `/ms:plan-milestone-gaps` first
    - If audit status is `passed`: proceed to step 1
@@ -50,7 +56,7 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
    ```markdown
    ## Pre-flight Check
 
-   {If no v{{version}}-MILESTONE-AUDIT.md:}
+   {If no MILESTONE-AUDIT.md:}
    ⚠ No milestone audit found. Run `/ms:audit-milestone` first to verify
    requirements coverage, cross-phase integration, and E2E flows.
 
@@ -65,7 +71,7 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
 1. **Verify readiness and gather stats:**
 
    ```bash
-   ~/.claude/mindsystem/scripts/gather-milestone-stats.sh $PHASE_START $PHASE_END
+   ms-tools gather-milestone-stats $PHASE_START $PHASE_END
    ```
 
    - If NOT READY: stop and report incomplete plans
@@ -89,26 +95,26 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
 
 5. **Archive milestone:**
 
-   - Create `.planning/milestones/v{{version}}/` directory
-   - Create `.planning/milestones/v{{version}}/ROADMAP.md` from template
+   - Create `.planning/milestones/{{slug}}/` directory
+   - Create `.planning/milestones/{{slug}}/ROADMAP.md` from template
    - Delete ROADMAP.md
 
 6. **Archive requirements:**
 
-   - Create `.planning/milestones/v{{version}}/REQUIREMENTS.md`
+   - Create `.planning/milestones/{{slug}}/REQUIREMENTS.md`
    - Mark all requirements as complete with outcomes
    - Delete `.planning/REQUIREMENTS.md`
 
 7. **Archive milestone files:**
 
    ```bash
-   ~/.claude/mindsystem/scripts/archive-milestone-files.sh v{{version}}
+   ms-tools archive-milestone-files {{slug}}
    ```
 
 8. **Archive and cleanup phases:**
 
    ```bash
-   ~/.claude/mindsystem/scripts/archive-milestone-phases.sh $PHASE_START $PHASE_END v{{version}}
+   ms-tools archive-milestone-phases $PHASE_START $PHASE_END {{slug}}
    ```
 
 9. **Update STATE.md:**
@@ -116,12 +122,10 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
     - Update project reference with current core value and next focus
     - Reset current position for next milestone
 
-10. **Commit and tag:**
+10. **Commit:**
 
     - Stage: MILESTONES.md, PROJECT.md, STATE.md, archive files, deletions
-    - Commit: `chore: archive v{{version}} milestone`
-    - Tag: `git tag -a v{{version}} -m "[milestone summary]"`
-    - Ask about pushing tag
+    - Commit: `chore: archive {{name}} milestone`
 
 11. **Offer next steps:**
     - `/ms:new-milestone` — discover goals and update PROJECT.md
@@ -136,10 +140,9 @@ Output: Milestone archived (roadmap + requirements), PROJECT.md evolved, git tag
 - PROJECT.md full evolution review completed (What This Is, Core Value, Requirements, Key Decisions, Context)
 - All shipped requirements moved to Validated in PROJECT.md
 - Key Decisions updated with outcomes
-- Milestone archived to `.planning/milestones/v{{version}}/ROADMAP.md`
-- Requirements archived to `.planning/milestones/v{{version}}/REQUIREMENTS.md`
+- Milestone archived to `.planning/milestones/{{slug}}/ROADMAP.md`
+- Requirements archived to `.planning/milestones/{{slug}}/REQUIREMENTS.md`
 - `.planning/REQUIREMENTS.md` deleted (fresh for next milestone)
-- Git tag v{{version}} created
   </success_criteria>
 
 <critical_rules>

package/commands/ms/config.md

@@ -0,0 +1,202 @@
+---
+name: ms:config
+description: Configure Mindsystem preferences — code reviewers, gitignore, git remote
+allowed-tools:
+  - Read
+  - Write
+  - Bash
+  - AskUserQuestion
+---
+
+<objective>
+
+Configure Mindsystem preferences for the current project.
+
+Manages code reviewer agents, .gitignore patterns for `.planning/` artifacts, and git remote setup. Run anytime to reconfigure — idempotent.
+
+</objective>
+
+<process>
+
+<step name="load_context">
+
+**Load current state:**
+
+```bash
+# Check for existing config
+[ -f .planning/config.json ] && cat .planning/config.json || echo "NO_CONFIG"
+
+# Check for PROJECT.md (tech stack detection)
+[ -f .planning/PROJECT.md ] && echo "HAS_PROJECT" || echo "NO_PROJECT"
+
+# Check for STACK.md (precise tech detection)
+[ -f .planning/codebase/STACK.md ] && echo "HAS_STACK" || echo "NO_STACK"
+
+# Check git remote
+git remote -v 2>/dev/null || echo "NO_REMOTE"
+```
+
+**Run this before proceeding.**
+
+</step>
+
+<step name="git_remote">
+
+**Skip if remote already configured.**
+
+If no remote exists:
+
+Explain: "Your project has a local git repo but no remote. Want to create one on GitHub?"
+
+Use AskUserQuestion:
+- header: "Git remote"
+- question: "Create a GitHub repository for this project?"
+- options:
+  - "Create with gh CLI" — Run `gh repo create` to set up remote and push
+  - "Skip for now" — Continue without remote
+
+If "Create with gh CLI":
+- Derive repo name from directory name
+- Show the command: `gh repo create [name] --source=. --push`
+- Confirm with user before executing
+- Execute via Bash tool
+
+</step>
+
+<step name="code_reviewers">
+
+Show current code_review values from config.json (if loaded).
+
+**If PROJECT.md or STACK.md exists:** Detect tech stack and suggest appropriate reviewers:
+
+- **Flutter/Dart:** adhoc=`ms-flutter-code-quality`, phase=`ms-flutter-code-quality`, milestone=`ms-flutter-reviewer`
+- **All others:** adhoc=`ms-code-simplifier`, phase=`ms-code-simplifier`, milestone=null
+
+**If no PROJECT.md or STACK.md:** Warn: "No PROJECT.md found — can't suggest reviewers based on tech stack. Run `/ms:new-project` first, or pick manually."
+
+Use AskUserQuestion:
+- header: "Code review"
+- question: "Which code reviewer configuration do you want?"
+- options:
+  - "[Suggested based on stack]" — e.g., "Flutter reviewers (ms-flutter-code-quality)" (Recommended)
+  - "Skip code review" — Disable review for all tiers
+  - "Custom" — I'll specify reviewers manually
+
+If "Custom": ask for each tier (adhoc, phase, milestone) individually.
+
+If "Skip code review": set all three values to `"skip"`.
+
+Update config.json with selected values.
+
+</step>
+
+<step name="gitignore_patterns">
+
+Check if `.gitignore` exists and current `.planning/` ignore patterns:
+
+```bash
+[ -f .gitignore ] && grep -n "planning" .gitignore || echo "NO_PLANNING_PATTERNS"
+```
+
+Explain: "We recommend committing `.planning/` to git — it's your project's memory (decisions, requirements, knowledge files). But some artifacts are large or environment-specific."
+
+Use AskUserQuestion (multiSelect):
+- header: "Gitignore"
+- question: "Which `.planning/` artifacts should be git-ignored?"
+- options:
+  - "Phase patch files (`.planning/phases/**/*.patch`)" — Large binary diffs, regeneratable
+  - "Design mockups (`.planning/phases/**/*.html`)" — Generated HTML mockups from design-phase
+
+Apply selected patterns to `.gitignore`. Create the file if needed.
+
+If no selections: skip gitignore changes.
+
+</step>
+
+<step name="validation_summary">
+
+Show final config state:
+
+```
+Configuration updated:
+
+- Code reviewers: [adhoc / phase / milestone values]
+- Gitignore: [patterns added, or "no changes"]
+- Git remote: [remote URL, or "none configured"]
+```
+
+Check subsystems in config.json. If empty or missing, note:
+"Subsystems are derived during `/ms:new-project`. Run `/ms:doctor` to update or verify them."
+
+</step>
+
+<step name="commit">
+
+**Skip if no changes made.**
+
+```bash
+git add .planning/config.json .gitignore
+git commit -m "$(cat <<'EOF'
+chore: configure mindsystem preferences
+EOF
+)"
+```
+
+</step>
+
+<step name="done">
+
+Present next steps:
+
+**If PROJECT.md exists:**
+
+```
+---
+
+## ▶ Next Up
+
+`/ms:new-milestone` — Discover what to build next, create requirements and roadmap
+
+<sub>`/clear` first → fresh context window</sub>
+
+---
+
+**Also available:**
+- `/ms:doctor` — Verify subsystems and artifact health
+
+---
+```
+
+**If no PROJECT.md:**
+
+```
+---
+
+## ▶ Next Up
+
+`/ms:new-project` — Initialize project with business context and vision
+
+<sub>`/clear` first → fresh context window</sub>
+
+---
+
+**Also available:**
+- `/ms:doctor` — Verify subsystems and artifact health
+
+---
+```
+
+</step>
+
+</process>
+
+<success_criteria>
+
+- [ ] Changes committed (if any)
+- [ ] User routed to next step
+- [ ] Gitignore patterns applied (if selected)
+- [ ] Git remote offered (if missing)
+- [ ] Validation summary displayed
+- [ ] Config.json code_review values set (or preserved if skipped)
+
+</success_criteria>

package/commands/ms/design-phase.md

@@ -15,8 +15,6 @@ Create design specifications for a phase. Spawns ms-designer agent with phase co
 
 **Orchestrator role:** Parse phase, validate against roadmap, check existing design, gather context chain (CONTEXT.md → project UI skill → codebase), adaptive Q&A if gaps, spawn designer agent, enable conversational refinement.
 
-**Why subagent:** Design requires focused attention with quality-forcing patterns. Fresh 200k context for design generation. Main context reserved for user refinement conversation.
-
 **When to use:**
 - UI-heavy phases with significant new interface work
 - Novel flows/components not deducible from existing patterns
@@ -43,17 +41,12 @@ ls .planning/phases/${PHASE}-*/*DESIGN.md 2>/dev/null
 ## 1. Parse and Validate Phase
 
 ```bash
-# Extract and normalize phase number from arguments
-PHASE_ARG="$ARGUMENTS"
-PHASE=$(printf "%02d" "$PHASE_ARG" 2>/dev/null || echo "$PHASE_ARG")
-
-# Validate phase exists in roadmap
-grep -A5 "Phase ${PHASE}:" .planning/ROADMAP.md 2>/dev/null
+ms-tools find-phase "$ARGUMENTS"
 ```
 
-**If not found:** Error and exit with message: "Phase ${PHASE} not found in ROADMAP.md"
+**If not found (dir is null):** Error and exit with message: "Phase not found in ROADMAP.md"
 
-**If found:** Extract phase number, name, description. Store for later use.
+**If found:** Extract phase number, name, description from the returned JSON and ROADMAP.md.
 
 ## 2. Check Existing Design
 
@@ -108,7 +101,10 @@ grep -A30 "Phase ${PHASE}:" .planning/ROADMAP.md 2>/dev/null
 Extract from PROJECT.md:
 - What This Is (product type)
 - Core Value (design must serve this)
-- Context (target audience)
+- Who It's For (target audience and their context)
+- Core Problem (what the design must address)
+- How It's Different (competitive context, differentiators)
+- Key User Flows (primary interactions that drive hierarchy)
 - Constraints (platform, technical limits)
 
 Extract from ROADMAP.md:
@@ -148,18 +144,18 @@ Pass the extracted knowledge to ms-designer in the design prompt (see step 6 `<p
 
 ```bash
 # Platform detection
-if [ -f "package.json" ]; then
-  echo "Platform: Web (package.json found)"
-  grep -E "react|vue|angular|svelte" package.json 2>/dev/null | head -5
-fi
-
 if [ -f "pubspec.yaml" ]; then
   echo "Platform: Flutter (pubspec.yaml found)"
+  # Search Flutter project structure
+  find lib -name "*.dart" 2>/dev/null | head -20
+  grep -r "colors\|theme\|spacing" lib/ --include="*.dart" 2>/dev/null | head -10
+elif [ -f "package.json" ]; then
+  echo "Platform: Web (package.json found)"
+  grep -E "react|vue|angular|svelte" package.json 2>/dev/null | head -5
+  # Search web project structure
+  find src -name "*.tsx" -o -name "*.ts" -o -name "*.jsx" 2>/dev/null | head -20
+  grep -r "colors\|theme\|spacing" src/ --include="*.ts" --include="*.tsx" 2>/dev/null | head -10
 fi
-
-# Find existing component/theme files
-find src -name "*.tsx" -o -name "*.dart" 2>/dev/null | head -20
-grep -r "colors\|theme\|spacing" src/ --include="*.ts" --include="*.dart" 2>/dev/null | head -10
 ```
 
 Document discovered patterns for the designer.
@@ -202,8 +198,7 @@ Use AskUserQuestion:
 
 **If user selects "Yes":**
 
-Follow mockup-generation workflow:
-@~/.claude/mindsystem/workflows/mockup-generation.md
+Read `~/.claude/mindsystem/workflows/mockup-generation.md` and follow the mockup-generation workflow.
 
 1. Determine platform from context chain (or ask user)
 2. Identify primary screen for the phase
@@ -230,11 +225,20 @@ Platform: [Inferred from codebase or PROJECT.md constraints]
 Phase: [N]: [Phase name from ROADMAP.md]
 
 Target audience:
-[From PROJECT.md - Context section]
+[From PROJECT.md - Who It's For section]
+
+Core problem:
+[From PROJECT.md - Core Problem section]
+
+Competitive differentiators:
+[From PROJECT.md - How It's Different section]
 
 Core value this design must serve:
 [From PROJECT.md - Core Value section]
 
+Primary user flows:
+[From PROJECT.md - Key User Flows section]
+
 Technical constraints:
 [From PROJECT.md - Constraints section]
 </design_context>
@@ -329,13 +333,13 @@ User preferences:
 [If mockups were NOT generated, omit this entire block.]
 </mockup_direction>
 
-<quality_expectation>
-Commercial benchmark: This design must look like a [benchmark] with intentional decisions, not defaults.
+<quality_constraints>
+Specify exact values for every design token — colors as hex, spacing in px/dp, typography with weight+size+line-height. No "appropriate", "suitable", or "as needed". Every decision must be explicit and implementable without interpretation.
 
-Pre-emptive criticism: Assume the user will say "This looks like generic AI output." Generate something that proves them wrong.
+Differentiate from platform defaults: if a color, radius, or spacing matches the default system value, choose a deliberate alternative that serves the product's identity.
 
-Accountability check: Could you show this design to a professional UI designer and claim it as skilled work? If not, it's not done.
-</quality_expectation>
+Assume the user will say "This looks like generic AI output." Generate something that proves them wrong. Could you show this design to a professional UI designer and claim it as skilled work? If not, it's not done.
+</quality_constraints>
 
 <output_specification>
 Generate: DESIGN.md following template structure
@@ -404,7 +408,7 @@ After initial generation, if user wants to refine:
 
 **For major redesigns (multiple aspects changing):**
 
-Use the iteration template from `~/.claude/mindsystem/templates/design-iteration.md`:
+Read `~/.claude/mindsystem/templates/design-iteration.md` and use the iteration template:
 
 1. Capture feedback using the structured format:
    - What worked well (KEEP)
@@ -441,4 +445,5 @@ Update `.planning/STATE.md` Last Command field:
 - [ ] ms-designer spawned with quality-forcing patterns
 - [ ] DESIGN.md created with Design Direction, Design Tokens, and Screens sections and committed
 - [ ] User informed of refinement options and next steps
+- [ ] STATE.md Last Command updated with timestamp
 </success_criteria>

package/commands/ms/discuss-phase.md

@@ -1,6 +1,6 @@
 ---
 name: ms:discuss-phase
-description: Gather phase context through adaptive questioning before planning
+description: Gather phase context through product-informed collaborative thinking before planning
 argument-hint: "[phase]"
 allowed-tools:
   - Read
@@ -8,14 +8,15 @@ allowed-tools:
   - Bash
   - Glob
   - AskUserQuestion
+  - Task
 ---
 
 <objective>
-Help the user articulate their vision for a phase through collaborative thinking.
+Act as a collaborative product owner — loading milestone-level artifacts, surfacing assumptions, optionally researching competitors, and grounding every question in product analysis.
 
-Purpose: Understand HOW the user imagines this phase working — what it looks like, what's essential. You're a thinking partner helping them crystallize their vision, not an interviewer gathering technical requirements.
+Purpose: Understand HOW the user imagines this phase working, informed by target audience, competitive landscape, and industry patterns. You're a thinking partner with product sense helping them crystallize their vision.
 
-Output: {phase}-CONTEXT.md capturing the user's vision for the phase
+Output: {phase}-CONTEXT.md capturing the user's vision with reasoning-backed decisions
 </objective>
 
 <execution_context>
@@ -25,10 +26,9 @@ Output: {phase}-CONTEXT.md capturing the user's vision for the phase
 <context>
 Phase number: $ARGUMENTS (required)
 
-**Normalize phase number:**
+**Resolve phase:**
 ```bash
-PHASE_ARG="$ARGUMENTS"
-PHASE=$(printf "%02d" "$PHASE_ARG" 2>/dev/null || echo "$PHASE_ARG")
+ms-tools find-phase "$ARGUMENTS"
 ```
 
 **Load project state first:**
@@ -36,31 +36,35 @@ PHASE=$(printf "%02d" "$PHASE_ARG" 2>/dev/null || echo "$PHASE_ARG")
 
 **Load roadmap:**
 @.planning/ROADMAP.md
+
+**Load project context:**
+@.planning/PROJECT.md
 </context>
 
 <process>
 1. Validate phase number argument (error if missing or invalid)
 2. Check if phase exists in roadmap
-3. Check if CONTEXT.md already exists (offer to update if yes)
-3.5. **Load prior knowledge** — determine relevant subsystem(s) by matching ROADMAP.md phase description against subsystem names in config.json. Load matching `.planning/knowledge/{subsystem}.md` files. If knowledge exists, present brief "What we know so far" summary before questioning.
-4. Follow discuss-phase.md workflow with **ALL questions using AskUserQuestion**:
-   - Present phase from roadmap
-   - Use AskUserQuestion: "How do you imagine this working?" with interpretation options
-   - Use AskUserQuestion to follow their thread — probe what excites them
-   - Use AskUserQuestion to sharpen the core — what's essential for THIS phase
-   - Use AskUserQuestion for decision gate (ready / ask more / let me add context)
-   - Create CONTEXT.md capturing their vision
-5. Present pre-work status: Read `~/.claude/mindsystem/references/prework-status.md` and show what's done vs still needed for this phase
-6. Update `.planning/STATE.md` Last Command field:
-   - Format: `Last Command: ms:discuss-phase $ARGUMENTS | YYYY-MM-DD HH:MM`
+3. **Load milestone artifacts** — extract Who It's For, Core Value, How It's Different from PROJECT.md. Parse requirements mapped to this phase from REQUIREMENTS.md. Graceful if any artifact missing.
+4. **Load prior knowledge** — determine relevant subsystem(s) by matching ROADMAP.md phase description against subsystem names in config.json. Load matching `.planning/knowledge/{subsystem}.md` files. If knowledge exists, present brief "What we know so far" summary.
+5. Check if CONTEXT.md already exists (offer to update if yes)
+6. **Assess and research** — evaluate if phase involves user-facing product decisions. If yes, offer product research via AskUserQuestion → spawn ms-product-researcher if accepted. Skip silently for backend/infra phases.
+7. **Present briefing** — weave together: requirements for this phase, Claude's assumptions (approach, scope, risks with confidence levels), and research findings if available. Ask user to validate/correct assumptions.
+8. **Informed discussion** — follow discuss-phase.md workflow. ALL questions use AskUserQuestion.
+9. Create CONTEXT.md capturing their vision with reasoning-backed decisions
+10. Present pre-work status: Read `~/.claude/mindsystem/references/prework-status.md` and show what's done vs still needed for this phase
+11. Update `.planning/STATE.md` Last Command field:
+    - Format: `Last Command: ms:discuss-phase $ARGUMENTS | YYYY-MM-DD HH:MM`
 
 **CRITICAL: ALL questions use AskUserQuestion. Never ask inline text questions.**
 </process>
 
 <success_criteria>
 
-- Phase validated against roadmap
-- Vision gathered through collaborative thinking (not interrogation)
-- CONTEXT.md captures: how it works, what's essential
+- Phase validated and milestone artifacts loaded (graceful if missing)
+- Assumptions surfaced and validated before deep questioning
+- Product research offered for user-facing phases
+- Vision gathered through product-informed collaborative thinking (not interrogation)
+- CONTEXT.md captures: how it works, what's essential, decisions with inline reasoning
+- CONTEXT.md committed and STATE.md Last Command updated
 - User knows next steps (research or plan the phase)
 </success_criteria>