mindgraph-mcp 0.13.2 → 0.13.3

package/dist/cli.js

@@ -312,19 +312,12 @@ async function handlePlan(client2, args) {
       return ok(await client2.execution({ action: "complete", task_uid, agent_id }));
     case "fail_execution":
       return ok(await client2.execution({ action: "fail", task_uid, agent_id }));
-    // Governance
-    case "create_policy":
-      return ok(
-        await client2.governance({ action: "create_policy", label, summary, props, agent_id })
-      );
-    case "request_approval":
-      return ok(
-        await client2.governance({ action: "request_approval", label, summary, props, agent_id })
-      );
-    case "resolve_approval":
-      return ok(
-        await client2.governance({ action: "resolve_approval", task_uid, props, agent_id })
-      );
+    // Governance — read-only from MCP by design (C33). The write actions were
+    // removed rather than repaired: `resolve_approval` here also sent
+    // `task_uid` where the server requires `approval_uid`, and never sent
+    // `approved` at all, so the server's `unwrap_or(false)` would have silently
+    // DENIED every approval an agent tried to resolve. Wiring that correctly
+    // would have meant building a working self-approval path — the hole itself.
     case "get_pending":
       return ok(await client2.governance({ action: "get_pending", agent_id }));
     // Procedures (merged from mindgraph_action)
@@ -592,6 +585,15 @@ async function handleIngest(client2, args) {
     agent_id
   } = args;
   const src = source_uri ?? source;
+  const targetsOntology = Array.isArray(layers) && layers.includes("ontology");
+  const cognitiveLayers = targetsOntology ? layers.filter((layer) => layer !== "ontology") : layers;
+  if (targetsOntology && !ontology_schema_id) {
+    return err(
+      "layers included 'ontology' but no ontology_schema_id was supplied. Typed Layer-7 extraction is driven by ontology_schema_id, not by the layers list \u2014 pass the schema id, or drop 'ontology' from layers."
+    );
+  }
+  const forwardedLayers = Array.isArray(cognitiveLayers) && cognitiveLayers.length === 0 ? void 0 : cognitiveLayers;
+  const ontologyOnly = targetsOntology && forwardedLayers === void 0;
   switch (action) {
     case "chunk":
       if (!content) return err("content is required for chunk ingestion");
@@ -601,7 +603,9 @@ async function handleIngest(client2, args) {
           label: title,
           document_uid,
           chunk_index,
-          layers,
+          // `/ingest/chunk` runs its ontology pass inline from
+          // ontology_schema_id alone and has no ontology_only switch.
+          layers: forwardedLayers,
           agent_id,
           ontology_schema_id
         })
@@ -615,8 +619,9 @@ async function handleIngest(client2, args) {
           source_uri: src,
           content_type,
           document_type,
-          layers,
+          layers: forwardedLayers,
           ontology_schema_id,
+          ...ontologyOnly ? { ontology_only: true } : {},
           participants,
           occurred_at,
           context,
@@ -631,8 +636,9 @@ async function handleIngest(client2, args) {
         await client2.ingestSession({
           content,
           title,
-          layers,
+          layers: forwardedLayers,
           ontology_schema_id,
+          ...ontologyOnly ? { ontology_only: true } : {},
           participants,
           occurred_at,
           context,
@@ -1033,7 +1039,7 @@ var init_tools = __esm({
       },
       {
         name: "mindgraph_plan",
-        description: "Agent-level task management, governance, and procedural knowledge. Use 'create_plan'/'create_task'/'add_step' for task breakdowns, 'update_status' for progress, 'get_plan' to review. Use 'create_flow'/'add_procedure_step'/'add_affordance'/'add_control' for workflows and procedures. Use 'assess_risk'/'get_assessments' for risk analysis. Use 'create_policy'/'request_approval'/'resolve_approval'/'get_pending' for governance. Prefer mindgraph_commit for user goals/projects; use this for agent-managed execution.",
+        description: "Agent-level task management, governance, and procedural knowledge. Use 'create_plan'/'create_task'/'add_step' for task breakdowns, 'update_status' for progress, 'get_plan' to review. Use 'create_flow'/'add_procedure_step'/'add_affordance'/'add_control' for workflows and procedures. Use 'assess_risk'/'get_assessments' for risk analysis. Use 'get_pending' to read the governance approval queue \u2014 approvals are granted by a person in the MindGraph dashboard, never from here, so wait for one rather than trying to clear it. Prefer mindgraph_commit for user goals/projects; use this for agent-managed execution.",
         inputSchema: {
           type: "object",
           properties: {
@@ -1048,9 +1054,13 @@ var init_tools = __esm({
                 "start_execution",
                 "complete_execution",
                 "fail_execution",
-                "create_policy",
-                "request_approval",
-                "resolve_approval",
+                // C33: governance WRITES are deliberately not exposed here.
+                // `create_policy` let a model author the rules it is judged by;
+                // `request_approval` + `resolve_approval` let it raise and then
+                // clear its own gate, which defeats the human-in-the-loop control
+                // entirely. Authoring and resolving happen in the dashboard, by a
+                // person. `get_pending` stays — reading the queue is safe and is
+                // what an agent needs in order to wait correctly.
                 "get_pending",
                 "create_flow",
                 "add_procedure_step",
@@ -1075,7 +1085,7 @@ var init_tools = __esm({
             },
             task_uid: {
               type: "string",
-              description: "Task/step UID (for update_status, execution actions, resolve_approval)"
+              description: "Task/step UID (for update_status, execution actions)"
             },
             target_uid: {
               type: "string",
@@ -1266,11 +1276,11 @@ var init_tools = __esm({
                   "ontology"
                 ]
               },
-              description: "Cognitive layers to extract (defaults vary by action)"
+              description: "Cognitive layers to extract (defaults vary by action). 'ontology' is a targeting flag rather than a cognitive layer: include it only alongside ontology_schema_id, and list it alone to extract domain objects without any cognitive extraction."
             },
             ontology_schema_id: {
               type: "string",
-              description: "When set, run typed Layer-7 (domain-object) extraction against this schema in addition to the cognitive layers."
+              description: "When set, run typed Layer-7 (domain-object) extraction against this schema in addition to the cognitive layers. This field alone drives domain-object extraction \u2014 listing 'ontology' in layers without it extracts nothing."
             },
             participants: {
               type: "array",
@@ -1817,7 +1827,7 @@ Capture knowledge when the user shares something worth remembering:
     server = new import_server.Server(
       {
         name: "mindgraph",
-        version: "0.13.2"
+        version: "0.13.3"
       },
       {
         capabilities: {

package/dist/index.js

@@ -248,7 +248,7 @@ var TOOLS = [
   },
   {
     name: "mindgraph_plan",
-    description: "Agent-level task management, governance, and procedural knowledge. Use 'create_plan'/'create_task'/'add_step' for task breakdowns, 'update_status' for progress, 'get_plan' to review. Use 'create_flow'/'add_procedure_step'/'add_affordance'/'add_control' for workflows and procedures. Use 'assess_risk'/'get_assessments' for risk analysis. Use 'create_policy'/'request_approval'/'resolve_approval'/'get_pending' for governance. Prefer mindgraph_commit for user goals/projects; use this for agent-managed execution.",
+    description: "Agent-level task management, governance, and procedural knowledge. Use 'create_plan'/'create_task'/'add_step' for task breakdowns, 'update_status' for progress, 'get_plan' to review. Use 'create_flow'/'add_procedure_step'/'add_affordance'/'add_control' for workflows and procedures. Use 'assess_risk'/'get_assessments' for risk analysis. Use 'get_pending' to read the governance approval queue \u2014 approvals are granted by a person in the MindGraph dashboard, never from here, so wait for one rather than trying to clear it. Prefer mindgraph_commit for user goals/projects; use this for agent-managed execution.",
     inputSchema: {
       type: "object",
       properties: {
@@ -263,9 +263,13 @@ var TOOLS = [
             "start_execution",
             "complete_execution",
             "fail_execution",
-            "create_policy",
-            "request_approval",
-            "resolve_approval",
+            // C33: governance WRITES are deliberately not exposed here.
+            // `create_policy` let a model author the rules it is judged by;
+            // `request_approval` + `resolve_approval` let it raise and then
+            // clear its own gate, which defeats the human-in-the-loop control
+            // entirely. Authoring and resolving happen in the dashboard, by a
+            // person. `get_pending` stays — reading the queue is safe and is
+            // what an agent needs in order to wait correctly.
             "get_pending",
             "create_flow",
             "add_procedure_step",
@@ -290,7 +294,7 @@ var TOOLS = [
         },
         task_uid: {
           type: "string",
-          description: "Task/step UID (for update_status, execution actions, resolve_approval)"
+          description: "Task/step UID (for update_status, execution actions)"
         },
         target_uid: {
           type: "string",
@@ -481,11 +485,11 @@ var TOOLS = [
               "ontology"
             ]
           },
-          description: "Cognitive layers to extract (defaults vary by action)"
+          description: "Cognitive layers to extract (defaults vary by action). 'ontology' is a targeting flag rather than a cognitive layer: include it only alongside ontology_schema_id, and list it alone to extract domain objects without any cognitive extraction."
         },
         ontology_schema_id: {
           type: "string",
-          description: "When set, run typed Layer-7 (domain-object) extraction against this schema in addition to the cognitive layers."
+          description: "When set, run typed Layer-7 (domain-object) extraction against this schema in addition to the cognitive layers. This field alone drives domain-object extraction \u2014 listing 'ontology' in layers without it extracts nothing."
         },
         participants: {
           type: "array",
@@ -971,19 +975,12 @@ async function handlePlan(client2, args) {
       return ok(await client2.execution({ action: "complete", task_uid, agent_id }));
     case "fail_execution":
       return ok(await client2.execution({ action: "fail", task_uid, agent_id }));
-    // Governance
-    case "create_policy":
-      return ok(
-        await client2.governance({ action: "create_policy", label, summary, props, agent_id })
-      );
-    case "request_approval":
-      return ok(
-        await client2.governance({ action: "request_approval", label, summary, props, agent_id })
-      );
-    case "resolve_approval":
-      return ok(
-        await client2.governance({ action: "resolve_approval", task_uid, props, agent_id })
-      );
+    // Governance — read-only from MCP by design (C33). The write actions were
+    // removed rather than repaired: `resolve_approval` here also sent
+    // `task_uid` where the server requires `approval_uid`, and never sent
+    // `approved` at all, so the server's `unwrap_or(false)` would have silently
+    // DENIED every approval an agent tried to resolve. Wiring that correctly
+    // would have meant building a working self-approval path — the hole itself.
     case "get_pending":
       return ok(await client2.governance({ action: "get_pending", agent_id }));
     // Procedures (merged from mindgraph_action)
@@ -1251,6 +1248,15 @@ async function handleIngest(client2, args) {
     agent_id
   } = args;
   const src = source_uri ?? source;
+  const targetsOntology = Array.isArray(layers) && layers.includes("ontology");
+  const cognitiveLayers = targetsOntology ? layers.filter((layer) => layer !== "ontology") : layers;
+  if (targetsOntology && !ontology_schema_id) {
+    return err(
+      "layers included 'ontology' but no ontology_schema_id was supplied. Typed Layer-7 extraction is driven by ontology_schema_id, not by the layers list \u2014 pass the schema id, or drop 'ontology' from layers."
+    );
+  }
+  const forwardedLayers = Array.isArray(cognitiveLayers) && cognitiveLayers.length === 0 ? void 0 : cognitiveLayers;
+  const ontologyOnly = targetsOntology && forwardedLayers === void 0;
   switch (action) {
     case "chunk":
       if (!content) return err("content is required for chunk ingestion");
@@ -1260,7 +1266,9 @@ async function handleIngest(client2, args) {
           label: title,
           document_uid,
           chunk_index,
-          layers,
+          // `/ingest/chunk` runs its ontology pass inline from
+          // ontology_schema_id alone and has no ontology_only switch.
+          layers: forwardedLayers,
           agent_id,
           ontology_schema_id
         })
@@ -1274,8 +1282,9 @@ async function handleIngest(client2, args) {
           source_uri: src,
           content_type,
           document_type,
-          layers,
+          layers: forwardedLayers,
           ontology_schema_id,
+          ...ontologyOnly ? { ontology_only: true } : {},
           participants,
           occurred_at,
           context,
@@ -1290,8 +1299,9 @@ async function handleIngest(client2, args) {
         await client2.ingestSession({
           content,
           title,
-          layers,
+          layers: forwardedLayers,
           ontology_schema_id,
+          ...ontologyOnly ? { ontology_only: true } : {},
           participants,
           occurred_at,
           context,
@@ -1760,7 +1770,7 @@ Capture knowledge when the user shares something worth remembering:
 var server = new import_server.Server(
   {
     name: "mindgraph",
-    version: "0.13.2"
+    version: "0.13.3"
   },
   {
     capabilities: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mindgraph-mcp",
-  "version": "0.13.2",
+  "version": "0.13.3",
   "description": "MCP server for MindGraph — connect Claude Desktop, Claude Code, and any MCP client to your knowledge graph",
   "repository": {
     "type": "git",